shopify_api_extensions 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c941b2d40cd938d27a81562e21d5e1cc24254939
-  data.tar.gz: ebb922c0292452b14f44f997b49df06b24a1ae36
+  metadata.gz: f850d583cba2a480de94630b9edab556ef654d59
+  data.tar.gz: 497fd0c0c80f323232f258fb9a95575a2b7b417c
 SHA512:
-  metadata.gz: 44917662ae3ff68b7b25d3aa478099220a0125d784a13d239ddcebf9e36acead1915a1e507b4406a6e6b25a3d1378bb1d062f11c86e2b8b2201713ecfebec5f7
-  data.tar.gz: 69f0effd50de8174f283dc08ee0d16f991fb4ac3fae03ebe0dfaee1e6a992ea1574f71c713cc0992084d0c5cde4ffaab5299cb640a50b4892557ed6588e325e7
+  metadata.gz: a8bf0397813e478554d58aca4b8d8c0166cdd5ad3ce0d908109f7d4104f2857e8e4c6a65c22511719aae82596e48b3aed01ce2f9cc152fc8ecd4d83d0c4aaec3
+  data.tar.gz: 8fac87d951b43fb1fe03e86bcbd8371aa49f3cd6e83c636a77d5d6589d2d19198c1364fb0d16b708d1271cab0235880ba4f006e457c3ed7f1b9df6c396c13a5e

data/lib/shopify_api_extensions/backoff.rb

@@ -20,6 +20,7 @@ ShopifyAPI::Connection.class_eval do
         Zlib::BufError,
         SocketError,
         ActiveResource::SSLError,
+        ActiveResource::TimeoutError,
         # NOTE represents only 500x errors
         ActiveResource::ServerError
       ]

data/lib/shopify_api_extensions/pagination.rb

@@ -5,26 +5,18 @@ ShopifyAPI::Base.class_eval do
 
   def self.auto_paging_each(opts = {})
     opts[:limit] ||= 50
-    page_limit = opts[:limit]
-
-    total_count = self.count(opts)
-    pages = total_count/page_limit + 1
-    current_page = opts[:page] || 0
+    current_page = opts[:page] || 1
     records = []
-
-    while current_page != pages
+    record_found = true
+    while record_found
+      record_found = false
       self.list(opts.merge(page: current_page)).each do |record|
+        record_found = true
         records << record
-
         yield(record) if block_given?
       end
-
-      # TODO should keep incrementing until no results are returned instead of
-      #      relying on the page count when the requests were initiated
-
       current_page += 1
     end
-
     records
   end
 end

data/lib/shopify_api_extensions/version.rb

@@ -1,3 +1,3 @@
 module ShopifyAPIExtensions
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api_extensions
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-11 00:00:00.000000000 Z
+date: 2019-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shopify_api