shopify_api 9.0.4 → 9.5

data/test/product_test.rb

@@ -1,47 +1,54 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ProductTest < Test::Unit::TestCase
   def setup
     super
 
-    fake "products/632910392", :body => load_fixture('product')
-    @product = ShopifyAPI::Product.find(632910392)
+    refresh_product
   end
 
   def test_add_metafields_to_product
-    fake "products/632910392/metafields", :method => :post, :status => 201, :body => load_fixture('metafield')
-
-    field = @product.add_metafield(ShopifyAPI::Metafield.new(:namespace => "contact", :key => "email", :value => "123@example.com", :value_type => "string"))
-    assert_equal ActiveSupport::JSON.decode('{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body)
-    assert !field.new_record?
-    assert_equal "contact", field.namespace
-    assert_equal "email", field.key
-    assert_equal "123@example.com", field.value
+    fake("products/632910392/metafields", method: :post, status: 201, body: load_fixture('metafield'))
+
+    field = @product.add_metafield(
+      ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string")
+    )
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
+    assert(!field.new_record?)
+    assert_equal("contact", field.namespace)
+    assert_equal("email", field.key)
+    assert_equal("123@example.com", field.value)
   end
 
   def test_get_all_metafields_for_product
-    fake "products/632910392/metafields", :body => load_fixture('metafields')
+    fake("products/632910392/metafields", body: load_fixture('metafields'))
 
     metafields = @product.metafields
 
-    assert_equal 3, metafields.length
-    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+    assert_equal(3, metafields.length)
+    assert(metafields.all? { |m| m.is_a?(ShopifyAPI::Metafield) })
   end
 
   def test_get_2_metafields_for_product
-    body = ActiveSupport::JSON.decode load_fixture 'metafields'
-    body['metafields'].slice! 2, 1
+    body = ActiveSupport::JSON.decode(load_fixture('metafields'))
+    body['metafields'].slice!(2, 1)
 
-    fake 'products/632910392/metafields.json?limit=2', body: body.to_json, extension: false
+    fake('products/632910392/metafields.json?limit=2', body: body.to_json, extension: false)
 
-    metafields = @product.metafields limit: 2
+    metafields = @product.metafields(limit: 2)
 
-    assert_equal 2, metafields.length
-    assert metafields.all?{ |m| m.is_a? ShopifyAPI::Metafield }
+    assert_equal(2, metafields.length)
+    assert(metafields.all? { |m| m.is_a?(ShopifyAPI::Metafield) })
   end
 
   def test_update_loaded_variant
-    fake "products/632910392/variants/808950810", :method => :put, :status => 200, :body => load_fixture('variant')
+    fake("products/632910392/variants/808950810", method: :put, status: 200, body: load_fixture('variant'))
 
     variant = @product.variants.first
     variant.price = "0.50"
@@ -57,4 +64,48 @@ class ProductTest < Test::Unit::TestCase
 
     assert_equal('100.00 - 199.00', @product.price_range)
   end
+
+  def test_read_only_variant_inventory_fields_not_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+
+    variant = @product.variants.first
+    assert_equal(10, variant.inventory_quantity)
+  end
+
+  def test_deprecated_inventory_fields_are_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+
+    refute(@product.as_json.include?('total_inventory'))
+  end
+
+  def test_setting_product_total_inventory_passes_in_api_before_2019_10
+    ShopifyAPI::Base.api_version = '2019-07'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    @product.total_inventory = 8
+  end
+
+  def test_setting_product_total_inventory_fails_in_2019_10_api
+    ShopifyAPI::Base.api_version = '2019-10'
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    assert_raises(ShopifyAPI::ValidationException) do
+      @product.total_inventory = 8
+    end
+  end
+
+  def test_setting_product_total_inventory_fails_in_the_unstable_api
+    ShopifyAPI::Base.api_version = :unstable
+    refresh_product(api_version: ShopifyAPI::Base.api_version)
+    assert_raises(ShopifyAPI::ValidationException) do
+      @product.total_inventory = 8
+    end
+  end
+
+  private
+
+  def refresh_product(api_version: nil)
+    fake("products/632910392", body: load_fixture('product'), api_version: api_version)
+    @product = ShopifyAPI::Product.find(632910392)
+  end
 end

data/test/publication_test.rb

@@ -3,10 +3,10 @@ require 'test_helper'
 
 class PublicationTest < Test::Unit::TestCase
   def test_find_all_publications
-    fake 'publications'
+    fake('publications')
     publications = ShopifyAPI::Publication.find(:all)
 
-    assert_equal 55650051, publications.first.id
-    assert_equal "Buy Button", publications.first.name
+    assert_equal(55650051, publications.first.id)
+    assert_equal("Buy Button", publications.first.name)
   end
 end

data/test/recurring_application_charge_test.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class RecurringApplicationChargeTest < Test::Unit::TestCase
-
   def test_recurring_application_charges_create
-    fake "recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge')
+    fake(
+      "recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.create(
       name: "Default Plan",
@@ -11,132 +13,192 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
       return_url: "http://test.com/confirm"
     )
 
-    assert_equal 'http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164', charge.confirmation_url
+    assert_equal(
+      'http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?' \
+        'signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164',
+      charge.confirmation_url
+    )
   end
 
   def test_get_recurring_application_charges
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
-    assert_equal "Super Duper Plan", charge.name
+    assert_equal("Super Duper Plan", charge.name)
   end
 
   def test_list_recurring_application_charges
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all)
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_list_since_recurring_application_charges
-    fake "recurring_application_charges.json?since_id=64512345",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges.json?since_id=64512345",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { since_id: '64512345' })
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_list_fields_recurring_application_charges
-    fake "recurring_application_charges.json?fields=name",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges.json?fields=name",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { fields: 'name' })
 
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_pending_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.pending
 
-    assert_equal "Super Mega Plan2", charge.last.name
+    assert_equal("Super Mega Plan2", charge.last.name)
   end
 
   def test_cancelled_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.cancelled
 
-    assert_equal "Super Mega Plan3", charge.last.name
+    assert_equal("Super Mega Plan3", charge.last.name)
   end
 
   def test_accepted_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
 
-    assert_equal "Super Mega Plan4", charge.first.name
-    assert_equal "Super Mega Plan", charge.last.name
+    assert_equal("Super Mega Plan4", charge.first.name)
+    assert_equal("Super Mega Plan", charge.last.name)
   end
 
   def test_declined_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.declined
 
-    assert_equal "Super Mega Plan5", charge.last.name
+    assert_equal("Super Mega Plan5", charge.last.name)
   end
 
   def test_activate_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
-    fake "recurring_application_charges/455696199/activate", method: :post, status: 200, body: "{}"
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
+    fake("recurring_application_charges/455696199/activate", method: :post, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
 
-    assert charge.last.activate
+    assert(charge.last.activate)
   end
 
   def test_adjust_recurring_application_charge
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200", method: :put, body: load_fixture('recurring_application_charge_adjustment'), extension: false
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200",
+      method: :put,
+      body: load_fixture('recurring_application_charge_adjustment'),
+      extension: false
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
-    assert charge.customize(capped_amount: 200)
+    assert(charge.customize(capped_amount: 200))
   end
 
   def test_cancel_recurring_application_charge
-    fake "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
-    fake "recurring_application_charges/455696194", method: :delete, status: 200, body: "{}"
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
+    fake("recurring_application_charges/455696194", method: :delete, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.current
-    assert charge.cancel
+    assert(charge.cancel)
   end
 
   def test_usage_charges_recurring_application_charge_found
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: load_fixture('usage_charges')
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/usage_charges",
+      method: :get,
+      status: 201,
+      body: load_fixture('usage_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
     usage_charges = charge.usage_charges
 
-    assert_equal 2, usage_charges.length
+    assert_equal(2, usage_charges.length)
   end
 
   def test_usage_charges_recurring_application_charge_not_found
-    fake "recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge')
-    fake "recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: "[]"
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake("recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: "[]")
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
     usage_charges = charge.usage_charges
 
-    assert_equal 0, usage_charges.length
+    assert_equal(0, usage_charges.length)
   end
 
   def test_no_recurring_application_charge_found
-    fake "recurring_application_charges", body: {recurring_application_charges: []}.to_json
+    fake("recurring_application_charges", body: { recurring_application_charges: [] }.to_json)
 
-    assert_equal 0, ShopifyAPI::RecurringApplicationCharge.all.count
-    assert_nil ShopifyAPI::RecurringApplicationCharge.current
-    assert_equal [], ShopifyAPI::RecurringApplicationCharge.pending
+    assert_equal(0, ShopifyAPI::RecurringApplicationCharge.all.count)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.current)
+    assert_equal([], ShopifyAPI::RecurringApplicationCharge.pending)
   end
 
   def test_recurring_application_charge_not_found_error
-    fake "recurring_application_charges", body: '{"errors":"Not Found"}', status: 404
-    assert_nil ShopifyAPI::RecurringApplicationCharge.all
-    assert_nil ShopifyAPI::RecurringApplicationCharge.current
+    fake("recurring_application_charges", body: '{"errors":"Not Found"}', status: 404)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.all)
+    assert_nil(ShopifyAPI::RecurringApplicationCharge.current)
     assert_equal([], ShopifyAPI::RecurringApplicationCharge.pending)
   end
 end

data/test/redirect_test.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class RedirectTest < Test::Unit::TestCase
   test "#create should create a redirect" do
-    fake "redirects", :method => :post, :status => 201, :body => load_fixture('redirect')
-    redirect = ShopifyAPI::Redirect.create(:path => "/ipod", :target => "/pages/itunes")
-    assert_equal 979034150, redirect.id
+    fake("redirects", method: :post, status: 201, body: load_fixture('redirect'))
+    redirect = ShopifyAPI::Redirect.create(path: "/ipod", target: "/pages/itunes")
+    assert_equal(979034150, redirect.id)
   end
 end

data/test/refund_test.rb

@@ -1,32 +1,37 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class RefundTest < Test::Unit::TestCase
-
   test '#create should create a refund' do
-    fake "orders/450789469/refunds", :method => :post, :status => 201, :body => load_fixture('refund')
+    fake("orders/450789469/refunds", method: :post, status: 201, body: load_fixture('refund'))
     refund = ShopifyAPI::Refund.create(
-      :order_id => 450789469,
-      :restock => true,
-      :note => "wrong size",
-      :shipping => { :full_refund => true },
-      :refund_line_items => [{ :line_item_id => 518995019, :quantity => 1 }]
+      order_id: 450789469,
+      restock: true,
+      note: "wrong size",
+      shipping: { full_refund: true },
+      refund_line_items: [{ line_item_id: 518995019, quantity: 1 }]
     )
-    assert_equal 703073504, refund.refund_line_items.first.line_item_id
+    assert_equal(703073504, refund.refund_line_items.first.line_item_id)
   end
 
   test '#find should return a refund' do
-    fake "orders/450789469/refunds/509562969.json?order_id=450789469", :extension => false, :method => :get, :body => load_fixture('refund')
-    fake "orders/450789469/refunds/509562969", :method => :get, :body => load_fixture('refund')
-    refund = ShopifyAPI::Refund.find(509562969, :params => {:order_id => 450789469})
-    assert_equal 509562969, refund.id
+    fake(
+      "orders/450789469/refunds/509562969.json?order_id=450789469",
+      extension: false,
+      method: :get,
+      body: load_fixture('refund')
+    )
+    fake("orders/450789469/refunds/509562969", method: :get, body: load_fixture('refund'))
+    refund = ShopifyAPI::Refund.find(509562969, params: { order_id: 450789469 })
+    assert_equal(509562969, refund.id)
   end
 
   test '#calculate a refund' do
-    fake "orders/450789469/refunds/calculate", :method => :post, :body => load_fixture('refund')
-    data = { :shipping => { :amount => 0 } }
+    fake("orders/450789469/refunds/calculate", method: :post, body: load_fixture('refund'))
+    data = { shipping: { amount: 0 } }
 
-    refund = ShopifyAPI::Refund.calculate(data, :params => {:order_id => 450789469})
-    assert_equal 2, refund.refund_line_items.count
-    assert_equal 703073504, refund.refund_line_items.first.line_item_id
+    refund = ShopifyAPI::Refund.calculate(data, params: { order_id: 450789469 })
+    assert_equal(2, refund.refund_line_items.count)
+    assert_equal(703073504, refund.refund_line_items.first.line_item_id)
   end
 end

data/test/report_test.rb

@@ -1,35 +1,37 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ReportTest < Test::Unit::TestCase
   test 'get should get a report' do
-    fake 'reports/987', method: :get, status: 200, body: load_fixture('report')
+    fake('reports/987', method: :get, status: 200, body: load_fixture('report'))
 
     report = ShopifyAPI::Report.find(987)
-    assert_equal 987, report.id
+    assert_equal(987, report.id)
   end
 
   test 'get all should get all reports' do
-    fake 'reports', method: :get, status: 200, body: load_fixture('reports')
+    fake('reports', method: :get, status: 200, body: load_fixture('reports'))
 
     reports = ShopifyAPI::Report.all
-    assert_equal 'custom_app_reports', reports.first.category
+    assert_equal('custom_app_reports', reports.first.category)
   end
 
   test 'create should create a report' do
-    fake 'reports', method: :post, status: 201, body: load_fixture('report')
+    fake('reports', method: :post, status: 201, body: load_fixture('report'))
 
     report = ShopifyAPI::Report.create(
       name: 'Custom App Report',
-      shopify_ql: 'SHOW quantity_count, total_sales BY product_type, vendor, product_title FROM products SINCE -1m UNTIL -0m ORDER BY total_sales DESC'
+      shopify_ql: 'SHOW quantity_count, total_sales BY product_type, vendor, product_title ' \
+        'FROM products SINCE -1m UNTIL -0m ORDER BY total_sales DESC'
     )
-    assert_equal 'custom_app_reports', report.category
+    assert_equal('custom_app_reports', report.category)
   end
 
   test 'delete should delete report' do
-    fake 'reports/987', method: :get, status: 200, body: load_fixture('report')
-    fake 'reports/987', method: :delete, status: 200, body: '[]'
+    fake('reports/987', method: :get, status: 200, body: load_fixture('report'))
+    fake('reports/987', method: :delete, status: 200, body: '[]')
 
     report = ShopifyAPI::Report.find(987)
-    assert report.destroy
+    assert(report.destroy)
   end
 end

data/test/resource_feedback_test.rb

@@ -1,41 +1,42 @@
+# frozen_string_literal: true
 class ResourceFeedbackTest < Test::Unit::TestCase
   def test_get_resource_feedback
-    body = { resource_feedback: [ { resource_type: 'Shop' } ] }.to_json
-    fake 'resource_feedback', method: :get, body: body
+    body = { resource_feedback: [{ resource_type: 'Shop' }] }.to_json
+    fake('resource_feedback', method: :get, body: body)
     resource_feedback = ShopifyAPI::ResourceFeedback.find(:all)
-    assert_equal 'Shop', resource_feedback.first.resource_type
+    assert_equal('Shop', resource_feedback.first.resource_type)
   end
 
   def test_save_with_resource_feedback_endpoint
     body = { resource_feedback: {} }.to_json
-    fake 'resource_feedback', method: :post, body: body
+    fake('resource_feedback', method: :post, body: body)
     ShopifyAPI::ResourceFeedback.new.save
-    assert_request_body body
+    assert_request_body(body)
   end
 
   def test_get_resource_feedback_with_product_id
-    body = { resource_feedback: [ { resource_type: 'Product' } ] }.to_json
-    fake 'products/42/resource_feedback', method: :get, body: body
+    body = { resource_feedback: [{ resource_type: 'Product' }] }.to_json
+    fake('products/42/resource_feedback', method: :get, body: body)
     resource_feedback = ShopifyAPI::ResourceFeedback.find(:all, params: { product_id: 42 })
-    assert_equal 'Product', resource_feedback.first.resource_type
+    assert_equal('Product', resource_feedback.first.resource_type)
   end
 
   def test_save_with_product_id_resource_feedback_endpoint
     body = { resource_feedback: {} }.to_json
-    fake 'products/42/resource_feedback', method: :post, body: body
+    fake('products/42/resource_feedback', method: :post, body: body)
     ShopifyAPI::ResourceFeedback.new(product_id: 42).save
-    assert_request_body body
+    assert_request_body(body)
   end
 
   def test_save_raises_exception_when_already_persisted
     body = { resource_feedback: {} }.to_json
-    fake 'resource_feedback', method: :post, body: body
+    fake('resource_feedback', method: :post, body: body)
     resource_feedback = ShopifyAPI::ResourceFeedback.new
     resource_feedback.save
-    assert_request_body body
+    assert_request_body(body)
 
     ShopifyAPI::ResourceFeedback.any_instance.expects(:persisted?).returns(true)
-    assert_raises ShopifyAPI::ResourceFeedback::ExistingFeedbackSaved do
+    assert_raises(ShopifyAPI::ResourceFeedback::ExistingFeedbackSaved) do
       resource_feedback.save
     end
   end

data/test/script_tag_test.rb

@@ -1,30 +1,31 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 class ScriptTagTest < Test::Unit::TestCase
   test "get all should get all script tags" do
-    fake 'script_tags', :method => :get, :status => 200, :body => load_fixture('script_tags')
+    fake('script_tags', method: :get, status: 200, body: load_fixture('script_tags'))
     script_tags = ShopifyAPI::ScriptTag.all
-    assert_equal "http://js-aplenty.com/bar.js", script_tags.first.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tags.first.src)
   end
 
   test "get should get a script tag" do
-    fake 'script_tags/421379493', :method => :get, :status => 200, :body => load_fixture('script_tag')
+    fake('script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.find(421379493)
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 
   test "create should create a new script tag" do
-    fake 'script_tags', :method => :post, :status => 201, :body => load_fixture('script_tag')
+    fake('script_tags', method: :post, status: 201, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.create(event: "onload", src: "http://js-aplenty.com/bar.js")
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 
   test "editing script tag should update script tag" do
-    fake 'script_tags/421379493', :method => :get, :status => 200, :body => load_fixture('script_tag')
+    fake('script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.find(421379493)
     script_tag.src = "http://js-aplenty.com/bar.js"
-    fake 'script_tags/421379493', :method => :put, :status => 200, :body => load_fixture('script_tag')
+    fake('script_tags/421379493', method: :put, status: 200, body: load_fixture('script_tag'))
     script_tag.save
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 end