shopify_api 4.6.0 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa938b8a6b1e983a6b569571b2f0c8d191a374c6
-  data.tar.gz: e15f2478aeaac3834b047a007ee30847fb947896
+  metadata.gz: b372c851db7445d6687816c3d008810155b61504
+  data.tar.gz: 488e2b61967bed7464f0ebf24cec6554e0f961da
 SHA512:
-  metadata.gz: 3f3cbeba1953b0c4b65e8a0f62909e804cc59c3d8ea1d136c74604d64c98ed9cee9cd403fb350b885d2eab7cae71d1a625ec1c7cbc9f97b0fc2d7f9a5d1ce64f
-  data.tar.gz: f7deef5d9438c1b6a7e000aa59e9580c6194e47a2268e95c10dc6138201691acb73faac2c27140611688aa1857cbcf7e9b7fd0f4b94f6691a5246d425f658380
+  metadata.gz: 1b6e947edf820c32391fc11e8c4f4c4b2acb4899db0a174fa25b456ec0e23a221b27c5442ad98a33b2361ecd0d2db87615af59051c9412b837c4264ed99e329c
+  data.tar.gz: '099a49bff83d8115709f24b5a48afd90f3bef9e7fe35448a4ab5341785b1fc9bb64dbce1f7c31b3e8fb5d7eaeb6cb26fea44ae129bcbea8309666535012e3f8d'

data/CHANGELOG

@@ -1,3 +1,8 @@
+== Version 4.7.0
+
+* Removed the mandatory `application_id` parameter from `ShopifyAPI::ProductListing` and `ShopifyAPI::CollectionListing`
+* Fixed a bug related to the non-standard primary key for `ShopifyAPI::ProductListing` and `ShopifyAPI::CollectionListing`
+
 == Version 4.6.0
 
 * Added `ShopifyAPI::Report`

data/lib/shopify_api/resources/collection_listing.rb

@@ -1,9 +1,9 @@
 module ShopifyAPI
   class CollectionListing < Base
-    init_prefix :application
+    self.primary_key = :collection_id
 
-    def product_ids(options = {})
-      get("#{collection_id}/product_ids", options[:params])
+    def product_ids
+      get(:product_ids)
     end
   end
 end

data/lib/shopify_api/resources/product_listing.rb

@@ -1,9 +1,9 @@
 module ShopifyAPI
   class ProductListing < Base
-    init_prefix :application
+    self.primary_key = :product_id
 
-    def self.product_ids(options = {})
-      get(:product_ids, options[:params])
+    def self.product_ids
+      get(:product_ids)
     end
   end
 end

data/lib/shopify_api/version.rb

@@ -1,3 +1,3 @@
 module ShopifyAPI
-  VERSION = "4.6.0"
+  VERSION = "4.7.0"
 end

data/test/collection_listing_test.rb

@@ -3,23 +3,39 @@ require 'test_helper'
 class CollectionListingTest < Test::Unit::TestCase
 
   def test_get_collection_listings
-    fake "applications/999/collection_listings", method: :get, status: 201, body: load_fixture('collection_listings')
+    fake "collection_listings", method: :get, status: 201, body: load_fixture('collection_listings')
 
-    collection_listings = ShopifyAPI::CollectionListing.find(:all, params: { application_id: 999 })
+    collection_listings = ShopifyAPI::CollectionListing.find(:all)
 
     assert_equal 1, collection_listings.count
     assert_equal 1, collection_listings.first.collection_id
     assert_equal 'Home page', collection_listings.first.title
   end
 
-  def test_get_collection_listing_for_collection_id
-    fake "applications/999/collection_listings/1", method: :get, status: 201, body: load_fixture('collection_listing')
-    fake "applications/999/collection_listings//1/product_ids", method: :get, status: 201, body: load_fixture('collection_listing_product_ids')
+  def test_get_collection_listing
+    fake "collection_listings/1", method: :get, status: 201, body: load_fixture('collection_listing')
 
-    collection_listing = ShopifyAPI::CollectionListing.find(1, params: { application_id: 999 })
+    collection_listing = ShopifyAPI::CollectionListing.find(1)
 
     assert_equal 1, collection_listing.collection_id
     assert_equal 'Home page', collection_listing.title
+  end
+
+  def test_get_collection_listing_reload
+    fake "collection_listings/1", method: :get, status: 201, body: load_fixture('collection_listing')
+
+    collection_listing = ShopifyAPI::CollectionListing.new(collection_id: 1)
+    collection_listing.reload
+
+    assert_equal 1, collection_listing.collection_id
+    assert_equal 'Home page', collection_listing.title
+  end
+
+  def test_get_collection_listing_product_ids
+    fake "collection_listings/1/product_ids", method: :get, status: 201, body: load_fixture('collection_listing_product_ids')
+
+    collection_listing = ShopifyAPI::CollectionListing.new(collection_id: 1)
+
     assert_equal [1, 2], collection_listing.product_ids
   end
 end

data/test/product_listing_test.rb

@@ -3,9 +3,9 @@ require 'test_helper'
 class ProductListingTest < Test::Unit::TestCase
 
   def test_get_product_listings
-    fake "applications/999/product_listings", method: :get, status: 201, body: load_fixture('product_listings')
+    fake "product_listings", method: :get, status: 201, body: load_fixture('product_listings')
 
-    product_listings = ShopifyAPI::ProductListing.find(:all, params: { application_id: 999 })
+    product_listings = ShopifyAPI::ProductListing.find(:all)
     assert_equal 2, product_listings.count
     assert_equal 2, product_listings.first.product_id
     assert_equal 1, product_listings.last.product_id
@@ -13,17 +13,26 @@ class ProductListingTest < Test::Unit::TestCase
     assert_equal 'Rustic Copper Bottle', product_listings.last.title
   end
 
-  def test_get_product_listing_for_product_id
-    fake "applications/999/product_listings/2", method: :get, status: 201, body: load_fixture('product_listing')
+  def test_get_product_listing
+    fake "product_listings/2", method: :get, status: 201, body: load_fixture('product_listing')
+
+    product_listing = ShopifyAPI::ProductListing.find(2)
+    assert_equal 'Synergistic Silk Chair', product_listing.title
+  end
+
+  def test_reload_product_listing
+    fake "product_listings/2", method: :get, status: 201, body: load_fixture('product_listing')
+
+    product_listing = ShopifyAPI::ProductListing.new(product_id: 2)
+    product_listing.reload
 
-    product_listing = ShopifyAPI::ProductListing.find(2, params: { application_id: 999 })
     assert_equal 'Synergistic Silk Chair', product_listing.title
   end
 
   def test_get_product_listing_product_ids
-    fake "applications/999/product_listings/product_ids", method: :get, status: 201, body: load_fixture('product_listing_product_ids')
+    fake "product_listings/product_ids", method: :get, status: 201, body: load_fixture('product_listing_product_ids')
 
-    product_ids = ShopifyAPI::ProductListing.product_ids(params: { application_id: 999 })
+    product_ids = ShopifyAPI::ProductListing.product_ids
     assert_equal 2, product_ids.count
     assert_equal 2, product_ids.first
     assert_equal 1, product_ids.last

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify_api
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 4.7.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-20 00:00:00.000000000 Z
+date: 2017-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource