shopify_api 12.2.1 → 12.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9061778f35348ae6c1013eed58d1d1d274e84ec63796d33296ac7205319aee40
-  data.tar.gz: 9e0ea6bd2543ad11963eab31617b2700383825471483ecef46793fc9e454fd34
+  metadata.gz: f87e892122968b0fc410c734d089ec03952c3b5bbf2793fcca078730ac280233
+  data.tar.gz: 928a01df0d1bc4312fee18e768d84c3585e1d72b39871e63b473080ee35943ed
 SHA512:
-  metadata.gz: 05a97d69417a4192bd8e83e5eded057931640d700041f6b6d15459d85b3a463de049e5789153dfee75a9df6af8f287956dca4e51c8a230a816596a3e85a2a3b2
-  data.tar.gz: a7a1d5e77c69b85566c2484ca64aebb05cd6bfd3701f90aa17b9d8ab5b1f1db6e28ecdbb34dc0dc76cefd8813ab14e98e1fcf2bb8d41797d8f235b757e90f274
+  metadata.gz: dd43ee271006e1ca390d151c002ad9a65439ad2cbe2a9350bd20e2756797dd38697eaf1c3437f243d3d478fd55d116eebb991be148913d2b0c48293fcd572496
+  data.tar.gz: 295e7ec37443a12589fe3bd2a8edd18fdba3cc76016d1fa829a6334378547a017f326f798f318eb833da33f75361921553843cb1207139edf33e426636ef2c6c

data/.github/ISSUE_TEMPLATE/BUG_REPORT.md

@@ -0,0 +1,40 @@
+---
+name: "🐛 Bug Report"
+about: Something isn't working
+labels: "Type: Bug 🐛"
+---
+
+# Issue summary
+
+<!--
+
+Write a short description of the issue here. Please provide any details or logs that
+can help us debug it.
+
+Increase the logs as described in the README by setting log_level to :debug, and paste the relevant portion here.
+
+Learn more: https://github.com/Shopify/shopify-api-ruby#setup-shopify-context
+
+-->
+
+- `shopify_api` version:
+- Ruby version:
+- Operating system:
+
+```
+// Paste any relevant logs here
+```
+
+## Expected behavior
+
+<!-- What do you think should happen? -->
+
+## Actual behavior
+
+<!-- What actually happens? -->
+
+## Steps to reproduce the problem
+
+1.
+1.
+1.

data/.github/ISSUE_TEMPLATE/ENHANCEMENT.md

@@ -0,0 +1,9 @@
+---
+name: '📈 Enhancement'
+about: Enhancement to our codebase that isn't a adding or changing a feature
+labels: 'Type: Enhancement 📈'
+---
+
+## Overview/summary
+
+<!-- Write a short description of the enhancement here ↓ -->

data/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md

@@ -0,0 +1,9 @@
+---
+name: "🙌 Feature Request"
+about: Suggest a new feature, or changes to an existing one
+labels: "Type: Feature Request :raised_hands:"
+---
+
+## Overview
+
+<!-- Write a short description of the request here ↓ -->

data/.github/workflows/build.yml

@@ -16,9 +16,6 @@ jobs:
           - 3.1
     steps:
       - uses: actions/checkout@v2
-      - name: Remove Gemfile.lock
-        run: |
-          rm -f ${GITHUB_WORKSPACE}/Gemfile.lock
       - name: Set up Ruby ${{ matrix.version }}
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/stale.yml

@@ -30,3 +30,4 @@ jobs:
           days-before-pr-close: -1
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           exempt-issue-labels: "feature request"
+          close-issue-reason: "not_planned"

data/CHANGELOG.md

@@ -4,7 +4,20 @@ Note: For changes to the API, see https://shopify.dev/changelog?filter=api
 
 ## Unreleased
 
+## Version 12.4.0
+
+- [#1092](https://github.com/Shopify/shopify-api-ruby/pull/1092) Add support for 2023-01 API version.
+- [#1081](https://github.com/Shopify/shopify-api-ruby/pull/1081) Fixed an error when parsing the JSON response body for the AssignedFulfillmentOrder resource.
+
+## Version 12.3.0
+
+- [#1040](https://github.com/Shopify/shopify-api-ruby/pull/1040) `ShopifyAPI::Clients::HttpResponse` as argument for `ShopifyAPI::Errors::HttpResponseError`
+- [#1055](https://github.com/Shopify/shopify-api-ruby/pull/1055) Makes session_storage optional. Configuring the API with session_storage is now deprecated. Session persistence is handled by the [shopify_app gem](https://github.com/Shopify/shopify_app) if using Rails.
+- [#1063](https://github.com/Shopify/shopify-api-ruby/pull/1063) Fix ActiveSupport inflector dependency
+- [#1069](https://github.com/Shopify/shopify-api-ruby/pull/1069) Adds a custom Logger to help write uniform logs across the api and the [shopify_app gem](https://github.com/Shopify/shopify_app)
+
 ## Version 12.2.1
+
 - [#1045](https://github.com/Shopify/shopify-api-ruby/pull/1045) Fixes bug with host/host_name requirement.
 
 ## Version 12.2.0

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    shopify_api (12.2.1)
+    shopify_api (12.4.0)
+      activesupport
       concurrent-ruby
       hash_diff
       httparty
@@ -10,12 +11,12 @@ PATH
       openssl
       securerandom
       sorbet-runtime
-      zeitwerk (~> 2.5)
+      zeitwerk (~> 2.5, < 2.6.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.1)
+    activesupport (7.0.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -25,31 +26,29 @@ GEM
     ast (2.4.2)
     byebug (11.1.3)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     crack (0.4.5)
       rexml
     diff-lcs (1.5.0)
     fakefs (1.4.1)
     hash_diff (1.1.1)
     hashdiff (1.0.1)
-    httparty (0.20.0)
-      mime-types (~> 3.0)
+    httparty (0.21.0)
+      mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
-    i18n (1.8.11)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
     json (2.6.2)
-    jwt (2.5.0)
+    jwt (2.6.0)
     language_server-protocol (3.17.0.1)
     method_source (1.0.0)
-    mime-types (3.4.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2022.0105)
+    mini_mime (1.1.2)
     minitest (5.15.0)
     mocha (1.13.0)
     multi_xml (0.6.0)
     netrc (0.11.0)
-    oj (3.13.21)
-    openssl (3.0.1)
+    oj (3.13.23)
+    openssl (3.1.0)
     parallel (1.22.1)
     parser (3.1.2.1)
       ast (~> 2.4.1)
@@ -91,11 +90,12 @@ GEM
       sorbet-runtime
       syntax_tree (>= 3.4)
     ruby-progressbar (1.11.0)
-    securerandom (0.2.0)
+    securerandom (0.2.2)
     sorbet (0.5.10438)
       sorbet-static (= 0.5.10438)
     sorbet-runtime (0.5.10438)
     sorbet-static (0.5.10438-universal-darwin-21)
+    sorbet-static (0.5.10438-universal-darwin-22)
     sorbet-static (0.5.10438-x86_64-linux)
     sorbet-static-and-runtime (0.5.10438)
       sorbet (= 0.5.10438)
@@ -117,7 +117,7 @@ GEM
       thor (>= 1.2.0)
       yard-sorbet
     thor (1.2.1)
-    tzinfo (2.0.4)
+    tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.3.0)
     unparser (0.6.5)
@@ -133,14 +133,14 @@ GEM
     yard-sorbet (0.7.0)
       sorbet-runtime (>= 0.5)
       yard (>= 0.9)
-    zeitwerk (2.6.1)
+    zeitwerk (2.6.4)
 
 PLATFORMS
   arm64-darwin-21
+  universal-darwin-22
   x86_64-linux
 
 DEPENDENCIES
-  activesupport
   fakefs
   minitest
   mocha

data/README.md

@@ -23,7 +23,6 @@ To follow these usage guides, you will need to:
 
 - have a working knowledge of ruby and a web framework such as Rails or Sinatra
 - have a Shopify Partner account and development store
-- _OR_ have a test store where you can create a private app
 - have an app already set up in your test store or partner account
 - add the URL and the appropriate redirect for your OAuth callback route to your app settings
 
@@ -55,8 +54,8 @@ ShopifyAPI::Context.setup(
   scope: "read_orders,read_products,etc",
   session_storage: ShopifyAPI::Auth::FileSessionStorage.new, # See more details below
   is_embedded: true, # Set to true if you are building an embedded app
-  is_private: false, # Set to true if you are building a private app
   api_version: "2022-01" # The version of the API you would like to use
+  is_private: false, # Set to true if you have an existing private app
 )
 ```
 
@@ -68,7 +67,7 @@ Session information would is typically stored in cookies on the browser. However
 
 ### Performing OAuth
 
-Next, unless you are making a private app, you need to go through OAuth as described [here](https://shopify.dev/apps/auth/oauth) to create sessions for shops using your app.
+You need to go through OAuth as described [here](https://shopify.dev/apps/auth/oauth) to create sessions for shops using your app.
 The Shopify API gem tries to make this easy by providing functions to begin and complete the OAuth process. See the [Oauth doc](docs/usage/oauth.md) for instructions on how to use these.
 
 ### Register Webhooks and a Webhook Handler
@@ -83,7 +82,7 @@ Once your app can perform OAuth, it can now make authenticated Shopify API calls
 
 ### Breaking change notice for version 10.0.0
 
-We've rewritten this library for v10, so that it provides all essential features for a Shopify app without requiring any other packages.
+We've rewritten this library for v10, so that it provides all essential features for a Shopify app without depending on the [Active Resource](https://github.com/rails/activeresource) or [graphql-client](https://github.com/github/graphql-client) libraries.
 
 Here are the main features it provides:
 
@@ -107,12 +106,12 @@ With this, a lot changed in how apps access the library. Here are the updates yo
 
     Please see below a (non-exhaustive) list of common replacements to guide you in your updates, using the `Order` resource as an example.
 
-    | Before | After |
-    | --- | --- |
-    | `Order.find(:all, params: {param1: value1})` | `Order.all(param1: value1, session:)` |
-    | `Order.find(<id>)` | `Order.find(id: <id>, session:)` |
-    | `order = Order.new(<id>)`<br/>`order.post(:close)` | `order = Order.new(session:)`<br/>`order.close()` |
-    | `order = Order.new(<id>)`<br/>`order.delete` | `Order.delete(id: <id>, session:)` |
+    | Before                                             | After |
+    | ---                                                | --- |
+    | `Order.find(:all, params: {param1: value1})`       | `Order.all(param1: value1)` |
+    | `Order.find(<id>)`                                 | `Order.find(id: <id>)` |
+    | `order = Order.new(<id>)`<br/>`order.post(:close)` | `order = Order.new`<br/>`order.close` |
+    | `order = Order.new(<id>)`<br/>`order.delete`       | `Order.delete(id: <id>)` |
 
 ## Breaking changes for older versions
 

data/docs/getting_started.md

@@ -5,7 +5,7 @@ This page will outline everything you need to know and the steps you need to fol
 ## Requirements
 
 - A working knowledge of ruby and a web framework such as Rails or Sinatra
-- A private or custom app already set up in your test store or partner account
+- A custom app already set up in your test store or partner account
 - We recommend `ngrok` to tunnel traffic to your localhost for testing
 
 ## Installation

data/docs/usage/oauth.md

@@ -3,8 +3,7 @@
 Once the library is set up for your project, you'll be able to use it to start adding functionality to your app. The first thing your app will need to do is to obtain an access token to the Admin API by performing the OAuth process.
 
 To do this, you can follow the steps below.
-
-**Note:** You do not need to go through the OAuth process if you are creating a private app. In this case you can simply set your `<key+password>` as the `api_secret_key` in `ShopifyAPI::Context.setup`. For more information on authenticating a Shopify app please see the [Types of Authentication](https://shopify.dev/apps/auth#types-of-authentication) page.
+For more information on authenticating a Shopify app please see the [Types of Authentication](https://shopify.dev/apps/auth#types-of-authentication) page.
 
 ## Add a route to start OAuth
 
@@ -53,7 +52,7 @@ def callback
       cookies: cookies.to_h,
       auth_query: ShopifyAPI::Auth::Oauth::AuthQuery.new(request.parameters.symbolize_keys.except(:controller, :action))
     )
-    
+
     cookies[auth_result[:cookie].name] = {
       expires: auth_result[:cookie].expires,
       secure: true,
@@ -66,7 +65,7 @@ def callback
     head 307
     response.set_header("Location", "<some-redirect-url>")
   rescue => e
-    puts(e.message)  
+    puts(e.message)
     head 500
   end
 end

data/lib/shopify_api/admin_versions.rb

@@ -5,13 +5,14 @@ module ShopifyAPI
   module AdminVersions
     SUPPORTED_ADMIN_VERSIONS = T.let([
       "unstable",
+      "2023-01",
       "2022-10",
       "2022-07",
       "2022-04",
       "2022-01",
     ], T::Array[String])
 
-    LATEST_SUPPORTED_ADMIN_VERSION = T.let("2022-10", String)
+    LATEST_SUPPORTED_ADMIN_VERSION = T.let("2023-01", String)
   end
 
   SUPPORTED_ADMIN_VERSIONS = ShopifyAPI::AdminVersions::SUPPORTED_ADMIN_VERSIONS

data/lib/shopify_api/auth/oauth.rb

@@ -93,10 +93,7 @@ module ShopifyAPI
             )
           end
 
-          unless Context.session_storage.store_session(session)
-            raise Errors::SessionStorageError,
-              "Session could not be saved. Please check your session storage implementation."
-          end
+          Context.session_storage&.store_session(session)
 
           { session: session, cookie: cookie }
         end

data/lib/shopify_api/clients/http_client.rb

@@ -69,13 +69,13 @@ module ShopifyAPI
           error_message = error_messages.join("\n")
 
           unless [429, 500].include?(response.code)
-            raise ShopifyAPI::Errors::HttpResponseError.new(code: response.code.to_i), error_message
+            raise ShopifyAPI::Errors::HttpResponseError.new(response: response), error_message
           end
 
           if tries == request.tries
-            raise ShopifyAPI::Errors::HttpResponseError.new(code: response.code), error_message if request.tries == 1
+            raise ShopifyAPI::Errors::HttpResponseError.new(response: response), error_message if request.tries == 1
 
-            raise ShopifyAPI::Errors::MaxHttpRetriesExceededError.new(code: response.code),
+            raise ShopifyAPI::Errors::MaxHttpRetriesExceededError.new(response: response),
               "Exceeded maximum retry count of #{request.tries}. Last message: #{error_message}"
           end
 

data/lib/shopify_api/context.rb

@@ -9,13 +9,14 @@ module ShopifyAPI
     @api_secret_key = T.let("", String)
     @api_version = T.let(LATEST_SUPPORTED_ADMIN_VERSION, String)
     @scope = T.let(Auth::AuthScopes.new, Auth::AuthScopes)
-    @session_storage = T.let(ShopifyAPI::Auth::FileSessionStorage.new, ShopifyAPI::Auth::SessionStorage)
     @is_private = T.let(false, T::Boolean)
     @private_shop = T.let(nil, T.nilable(String))
     @is_embedded = T.let(true, T::Boolean)
-    @logger = T.let(Logger.new($stdout), Logger)
+    @logger = T.let(::Logger.new($stdout), ::Logger)
+    @log_level = T.let(:info, Symbol)
     @notified_missing_resources_folder = T.let({}, T::Hash[String, T::Boolean])
     @active_session = T.let(Concurrent::ThreadLocalVar.new { nil }, Concurrent::ThreadLocalVar)
+    @session_storage = T.let(nil, T.nilable(ShopifyAPI::Auth::SessionStorage))
     @user_agent_prefix = T.let(nil, T.nilable(String))
     @old_api_secret_key = T.let(nil, T.nilable(String))
 
@@ -32,8 +33,9 @@ module ShopifyAPI
           scope: T.any(T::Array[String], String),
           is_private: T::Boolean,
           is_embedded: T::Boolean,
-          session_storage: ShopifyAPI::Auth::SessionStorage,
-          logger: Logger,
+          log_level: T.any(String, Symbol),
+          logger: ::Logger,
+          session_storage: T.nilable(ShopifyAPI::Auth::SessionStorage),
           host_name: T.nilable(String),
           host: T.nilable(String),
           private_shop: T.nilable(String),
@@ -48,8 +50,9 @@ module ShopifyAPI
         scope:,
         is_private:,
         is_embedded:,
-        session_storage:,
-        logger: Logger.new($stdout),
+        log_level: :info,
+        logger: ::Logger.new($stdout),
+        session_storage: nil,
         host_name: nil,
         host: ENV["HOST"] || "https://#{host_name}",
         private_shop: nil,
@@ -73,6 +76,18 @@ module ShopifyAPI
         @private_shop = private_shop
         @user_agent_prefix = user_agent_prefix
         @old_api_secret_key = old_api_secret_key
+        @log_level = if valid_log_level?(log_level)
+          log_level.to_sym
+        else
+          :info
+        end
+
+        if @session_storage
+          ::ShopifyAPI::Logger.deprecated("The use of SessionStorage in the API library has been deprecated. " \
+            "The ShopifyAPI will no longer have responsibility for session persistence. " \
+            "Upgrading to `shopify_app` 21.3 will allow you to remove session_storage" \
+            " from the API library Context configuration.", "13.0.0")
+        end
 
         load_rest_resources(api_version: api_version)
       end
@@ -111,12 +126,15 @@ module ShopifyAPI
       sig { returns(Auth::AuthScopes) }
       attr_reader :scope
 
-      sig { returns(ShopifyAPI::Auth::SessionStorage) }
+      sig { returns(T.nilable(ShopifyAPI::Auth::SessionStorage)) }
       attr_reader :session_storage
 
-      sig { returns(Logger) }
+      sig { returns(::Logger) }
       attr_reader :logger
 
+      sig { returns(Symbol) }
+      attr_reader :log_level
+
       sig { returns(T::Boolean) }
       def private?
         @is_private
@@ -161,6 +179,18 @@ module ShopifyAPI
       def host_name
         T.must(URI(T.must(host)).host)
       end
+
+      private
+
+      sig { params(log_level: T.any(Symbol, String)).returns(T::Boolean) }
+      def valid_log_level?(log_level)
+        return true if ::ShopifyAPI::Logger.levels.include?(log_level.to_sym)
+
+        ShopifyAPI::Logger.warn("#{log_level} is not a valid log_level. "\
+          "Valid options are #{::ShopifyAPI::Logger.levels.join(", ")}")
+
+        false
+      end
     end
   end
 end

data/lib/shopify_api/errors/feature_deprecated_error.rb

@@ -0,0 +1,9 @@
+# typed: strict
+# frozen_string_literal: true
+
+module ShopifyAPI
+  module Errors
+    class FeatureDeprecatedError < StandardError
+    end
+  end
+end

data/lib/shopify_api/errors/http_response_error.rb

@@ -9,10 +9,14 @@ module ShopifyAPI
       sig { returns(Integer) }
       attr_reader :code
 
-      sig { params(code: Integer).void }
-      def initialize(code:)
+      sig { returns(ShopifyAPI::Clients::HttpResponse) }
+      attr_reader :response
+
+      sig { params(response: ShopifyAPI::Clients::HttpResponse).void }
+      def initialize(response:)
         super
-        @code = code
+        @code = T.let(response.code, Integer)
+        @response = response
       end
     end
   end

data/lib/shopify_api/errors/log_level_not_found_error.rb

@@ -0,0 +1,9 @@
+# typed: strict
+# frozen_string_literal: true
+
+module ShopifyAPI
+  module Errors
+    class LogLevelNotFoundError < StandardError
+    end
+  end
+end

data/lib/shopify_api/logger.rb

@@ -0,0 +1,82 @@
+# typed: strict
+# frozen_string_literal: true
+
+module ShopifyAPI
+  class Logger
+    LOG_LEVELS = T.let({ debug: 0, info: 1, warn: 2, error: 3, off: 6 }, T::Hash[Symbol, Integer])
+    DEFAULT_LOG_LEVEL = :info
+
+    class << self
+      extend T::Sig
+
+      sig { params(message: String).void }
+      def debug(message)
+        send_to_logger(:debug, message)
+      end
+
+      sig { params(message: String).void }
+      def info(message)
+        send_to_logger(:info, message)
+      end
+
+      sig { params(message: String).void }
+      def warn(message)
+        send_to_logger(:warn, message)
+      end
+
+      sig { params(message: String).void }
+      def error(message)
+        send_to_logger(:error, message)
+      end
+
+      sig { params(message: String, version: String).void }
+      def deprecated(message, version)
+        return unless enabled_for_log_level?(:warn)
+
+        raise Errors::FeatureDeprecatedError unless valid_version(version)
+
+        send_to_logger(:warn, message)
+      end
+
+      sig { returns(T::Array[Symbol]) }
+      def levels
+        LOG_LEVELS.keys
+      end
+
+      private
+
+      sig { params(log_level: Symbol).returns(String) }
+      def context(log_level)
+        current_shop = ShopifyAPI::Context.active_session&.shop
+
+        if current_shop.nil?
+          "[ ShopifyAPI | #{log_level.to_s.upcase} ]"
+        else
+          "[ ShopifyAPI | #{log_level.to_s.upcase} | #{current_shop} ]"
+        end
+      end
+
+      sig { params(log_level: Symbol, message: String).void }
+      def send_to_logger(log_level, message)
+        return unless enabled_for_log_level?(log_level)
+
+        full_message = "#{context(log_level)} #{message}"
+
+        ShopifyAPI::Context.logger.public_send(log_level, full_message)
+      end
+
+      sig { params(log_level: Symbol).returns(T::Boolean) }
+      def enabled_for_log_level?(log_level)
+        T.must(LOG_LEVELS[log_level]) >= T.must(LOG_LEVELS[ShopifyAPI::Context.log_level] ||
+          LOG_LEVELS[DEFAULT_LOG_LEVEL])
+      end
+
+      sig { params(version: String).returns(T::Boolean) }
+      def valid_version(version)
+        current_version = Gem::Version.create(ShopifyAPI::VERSION)
+        deprecate_version = Gem::Version.create(version)
+        current_version < deprecate_version
+      end
+    end
+  end
+end

data/lib/shopify_api/rest/base.rb

@@ -97,6 +97,11 @@ module ShopifyAPI
           class_name.underscore
         end
 
+        sig { returns(String) }
+        def json_response_body_name
+          class_name
+        end
+
         sig { returns(T.nilable(String)) }
         def prev_page_info
           instance_variable_get(:"@prev_page_info").value
@@ -205,12 +210,14 @@ module ShopifyAPI
 
           body = T.cast(response.body, T::Hash[String, T.untyped])
 
-          if body.key?(class_name.pluralize) || (body.key?(class_name) && body[class_name].is_a?(Array))
-            (body[class_name.pluralize] || body[class_name]).each do |entry|
+          response_name = json_response_body_name
+
+          if body.key?(response_name.pluralize) || (body.key?(response_name) && body[response_name].is_a?(Array))
+            (body[response_name.pluralize] || body[response_name]).each do |entry|
               objects << create_instance(data: entry, session: session)
             end
-          elsif body.key?(class_name)
-            objects << create_instance(data: body[class_name], session: session)
+          elsif body.key?(response_name)
+            objects << create_instance(data: body[response_name], session: session)
           end
 
           objects

data/lib/shopify_api/rest/resources/2022_01/assigned_fulfillment_order.rb

@@ -50,6 +50,13 @@ module ShopifyAPI
     attr_reader :status
 
     class << self
+      sig do
+        returns(String)
+      end
+      def json_response_body_name()
+        "fulfillment_order"
+      end
+
       sig do
         params(
           assignment_status: T.untyped,

data/lib/shopify_api/rest/resources/2022_01/customer.rb

@@ -197,11 +197,19 @@ module ShopifyAPI
 
       sig do
         params(
+          created_at_min: T.untyped,
+          created_at_max: T.untyped,
+          updated_at_min: T.untyped,
+          updated_at_max: T.untyped,
           session: Auth::Session,
           kwargs: T.untyped
         ).returns(T.untyped)
       end
       def count(
+        created_at_min: nil,
+        created_at_max: nil,
+        updated_at_min: nil,
+        updated_at_max: nil,
         session: ShopifyAPI::Context.active_session,
         **kwargs
       )
@@ -210,7 +218,7 @@ module ShopifyAPI
           operation: :count,
           session: session,
           ids: {},
-          params: {}.merge(kwargs).compact,
+          params: {created_at_min: created_at_min, created_at_max: created_at_max, updated_at_min: updated_at_min, updated_at_max: updated_at_max}.merge(kwargs).compact,
           body: {},
           entity: nil,
         )