shopify-money 3.2.4 → 3.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22d6b7f34e2df9d08722a1b5a3c4297bb95d68557b7e82c448476478336cf339
-  data.tar.gz: c267cac812901641a799ddc08afd446051f808c632d75ef62c8c80ad4237bf72
+  metadata.gz: 418b16ca343e15afec56dbfade82d9b8995efc241d4b82d3173c77c81f7ea3fc
+  data.tar.gz: 11d4b57794ac31518398361f1fd2c11f39fa5ba6f75baea4c2ed798ddca753c5
 SHA512:
-  metadata.gz: 4da3c3318564210997ae4e3a56c99e46d4702de1c19d258f61948f7aee0b978c7ccaea8f9be13d270216af9ad23d52d25e48a44e514e154014bd179ca217403f
-  data.tar.gz: e1378b9689d6e7a22cf4d9892a4802e09ecdca0e67b4bb3bc5a5c7c924fa06c3fdf0bea6ab5b4f65db206cd06c4becd5f23b0f46381ad425350aa4925d4b9e8b
+  metadata.gz: 1f7417f5dde55d548afe45cccd10fe16118daf3af28dc83ed543b8ae52149bd88e069f519e63fb5c19aa0734397aef8f264d39ce4f8c4daab7ffcd8005e1b845
+  data.tar.gz: 6c3be9a047b8926991416d4b99a53602171d83457f6dac0d53e90ed4cf0e2ee0cb345c4282eae512d40ede474f0c4eaea3ccc02304ec1346211bdbd65e20e3ac

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify-money (3.2.4)
+    shopify-money (3.2.6)
       bigdecimal (>= 3.0)
 
 GEM
@@ -108,7 +108,7 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.12.2)
+    json (2.13.2)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
@@ -125,7 +125,7 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.8)
     minitest (5.25.5)
-    net-imap (0.5.6)
+    net-imap (0.5.7)
       date
       net-protocol
     net-pop (0.1.2)
@@ -135,22 +135,22 @@ GEM
     net-smtp (0.5.1)
       net-protocol
     nio4r (2.7.4)
-    nokogiri (1.18.7)
+    nokogiri (1.18.8)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.18.7-aarch64-linux-gnu)
+    nokogiri (1.18.8-aarch64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.7-arm-linux-gnu)
+    nokogiri (1.18.8-arm-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.7-arm64-darwin)
+    nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.7-x86_64-darwin)
+    nokogiri (1.18.8-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.7-x86_64-linux-gnu)
+    nokogiri (1.18.8-x86_64-linux-gnu)
       racc (~> 1.4)
     ostruct (0.6.1)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
     pp (0.6.2)
@@ -167,8 +167,8 @@ GEM
       date
       stringio
     racc (1.8.1)
-    rack (3.1.12)
-    rack-session (2.1.0)
+    rack (3.1.14)
+    rack-session (2.1.1)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
     rack-test (2.2.0)
@@ -208,7 +208,7 @@ GEM
     rake (13.2.1)
     rdoc (6.13.1)
       psych (>= 4.0.0)
-    regexp_parser (2.10.0)
+    regexp_parser (2.11.0)
     reline (0.6.1)
       io-console (~> 0.5)
     rspec (3.13.0)
@@ -224,7 +224,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.75.7)
+    rubocop (1.79.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -232,10 +232,10 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.1)
+    rubocop-ast (1.46.0)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-performance (1.25.0)

data/lib/money/money.rb

@@ -135,6 +135,10 @@ class Money
 
   def initialize(value, currency)
     raise ArgumentError if value.nan?
+    if value.infinite?
+      Money.deprecate("Initializing Money with infinity is deprecated and will raise an ArgumentError in v4")
+    end
+
     @currency = Helpers.value_to_currency(currency)
     @value = BigDecimal(value.round(@currency.minor_units))
     freeze
@@ -162,9 +166,14 @@ class Money
   end
 
   def <=>(other)
-    return unless other.respond_to?(:to_money)
-    arithmetic(other) do |money|
-      value <=> money.value
+    if other.is_a?(Numeric)
+      return value <=> other
+    end
+
+    if other.respond_to?(:to_money)
+      arithmetic(other) do |money|
+        value <=> money.value
+      end
     end
   end
 

data/lib/money/rails/job_argument_serializer.rb

@@ -11,8 +11,6 @@ class Money
         Money.new(hash["value"], hash["currency"])
       end
 
-      private
-
       def klass
         Money
       end

data/lib/money/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Money
-  VERSION = "3.2.4"
+  VERSION = "3.2.6"
 end

data/spec/money_spec.rb

@@ -493,6 +493,16 @@ RSpec.describe "Money" do
     expect { Money.new( 0.0 / 0) }.to raise_error(ArgumentError)
   end
 
+  it "raises when constructed with positive infinity" do
+    expect(Money).to receive(:deprecate).once
+    Money.new(Float::INFINITY)
+  end
+
+  it "raises when constructed with negative infinity" do
+    expect(Money).to receive(:deprecate).once
+    Money.new(-Float::INFINITY)
+  end
+
   it "is comparable with non-money objects" do
     expect(money).not_to eq(nil)
   end
@@ -585,6 +595,7 @@ RSpec.describe "Money" do
     let (:nil_10) { Money.new(10.00, Money::NULL_CURRENCY) }
     let (:nil_20) { Money.new(20.00, Money::NULL_CURRENCY) }
     let (:usd_10) { Money.new(10.00, 'USD') }
+    let (:jpy_10) { Money.new(10, 'JPY') }
 
     it "<=> can compare with and without currency" do
       expect(Money.new(1000, Money::NULL_CURRENCY) <=> Money.new(2000, 'JPY')).to eq(-1)
@@ -746,6 +757,32 @@ RSpec.describe "Money" do
       it { expect { cad_10 <= nil }.to(raise_error(ArgumentError)) }
       it { expect { cad_10 <  nil }.to(raise_error(ArgumentError)) }
     end
+
+    describe('infinity comparisons') do
+      it { expect(cad_10 <=> Float::INFINITY).to(eq(-1)) }
+      it { expect(cad_10 <  Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 <= Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 >  Float::INFINITY).to(eq(false)) }
+      it { expect(cad_10 >= Float::INFINITY).to(eq(false)) }
+
+      it { expect(cad_10 <=> -Float::INFINITY).to(eq(1)) }
+      it { expect(cad_10 >  -Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 >= -Float::INFINITY).to(eq(true)) }
+      it { expect(cad_10 <  -Float::INFINITY).to(eq(false)) }
+      it { expect(cad_10 <= -Float::INFINITY).to(eq(false)) }
+
+      it { expect(jpy_10 <=> Float::INFINITY).to(eq(-1)) }
+      it { expect(jpy_10 <  Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 <= Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 >  Float::INFINITY).to(eq(false)) }
+      it { expect(jpy_10 >= Float::INFINITY).to(eq(false)) }
+
+      it { expect(jpy_10 <=> -Float::INFINITY).to(eq(1)) }
+      it { expect(jpy_10 >  -Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 >= -Float::INFINITY).to(eq(true)) }
+      it { expect(jpy_10 <  -Float::INFINITY).to(eq(false)) }
+      it { expect(jpy_10 <= -Float::INFINITY).to(eq(false)) }
+    end
   end
 
   describe "#subunits" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 3.2.4
+  version: 3.2.6
 platform: ruby
 authors:
 - Shopify Inc
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.4
 specification_version: 4
 summary: Shopify's money gem
 test_files: []