shopify-money 1.3.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 968f61cd2788112e0310dad876e0100eef9bdc375b39d10b7a34e98cb23650fc
-  data.tar.gz: 279e00665cf1561add517a797afc0d732410813233da3dfe6c09225de9108445
+  metadata.gz: 591c60e355144246085ac254fe82b099c85ab4bf7f1e37672b8082331bd9d0aa
+  data.tar.gz: 493384ced59c9a37ebc798b4cb499bd0532ea30243c8248704bf0df6f776ca0f
 SHA512:
-  metadata.gz: 5abf64ebc32b62bbb31906b977a05e66362dc68453c454efedfe0c83ae5743454c526882fbec437f4874d36ae5d384947c64175a8d50fba0fb339c58d77500c5
-  data.tar.gz: 76a439a0dca761dc12b3fd44e90737aee88fe26f11ed20af1ab9eba45ce20d6fa55265c9130ee034548d5b799621eef4d328808ca12fcfdcca6b02e258a496b4
+  metadata.gz: 1867df0795206ccd5996b1d8471f23f60340ace3e5e685ddbb98f601402a7748aade38263dbc7f12971c1e4368919cb0122c53eacf0b96b96df44189be3ca32e
+  data.tar.gz: 9ed8869fce8e66c4e9aee275ac3a28c24db47fd2ae8537f2ff3ee100541f122cd9b8b87e7ca102567b976548eb04b53b06f6c560f2e6e12dc3ca506e0bb87f01

data/.github/workflows/tests.yml

@@ -1,7 +1,7 @@
 name: tests
 
 on: [push, pull_request]
-  
+
 jobs:
   build:
 
@@ -9,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
+        ruby: ['3.0', '3.1', '3.2', '3.3']
 
     name: Ruby ${{ matrix.ruby }}
     steps:

data/README.md

@@ -29,7 +29,7 @@ require 'money'
 # 10.00 USD
 money = Money.new(10.00, "USD")
 money.subunits     #=> 1000
-money.currency  #=> Currency.new("USD")
+money.currency     #=> Money::Currency.new("USD")
 
 # Comparisons
 Money.new(1000, "USD") == Money.new(1000, "USD")   #=> true
@@ -40,13 +40,30 @@ Money.new(1000, "USD") != Money.new(1000, "EUR")   #=> true
 # Arithmetic
 Money.new(1000, "USD") + Money.new(500, "USD") == Money.new(1500, "USD")
 Money.new(1000, "USD") - Money.new(200, "USD") == Money.new(800, "USD")
-Money.new(1000, "USD") / 5                     == Money.new(200, "USD")
 Money.new(1000, "USD") * 5                     == Money.new(5000, "USD")
 
+m = Money.new(1000, "USD")
+# Splitting money evenly
+m.split(2)              == [Money.new(500, "USD"), Money.new(500, "USD")]
+m.split(3).map(&:value) == [333.34, 333.33, 333.33]
+m.calculate_splits(2)   == { Money.new(500, "USD") => 2 }
+m.calculate_splits(3)   == { Money.new(333.34, "USD") => 1, Money.new(333.33, "USD") =>2 }
+
+# Allocating money proportionally
+m.allocate([0.50, 0.25, 0.25]).map(&:value)               == [500, 250, 250]
+m.allocate([Rational(2, 3), Rational(1, 3)]).map(&:value) == [666.67, 333.33]
+
+## Allocating up to a cutoff
+m.allocate_max_amounts([500, 300, 200]).map(&:value) == [500, 300, 200]
+m.allocate_max_amounts([500, 300, 300]).map(&:value) == [454.55, 272.73, 272.72]
+
+# Clamp
+Money.new(50, "USD").clamp(1, 100) == Money.new(50, "USD")
+
 # Unit to subunit conversions
-Money.from_subunits(500, "USD") == Money.new(5, "USD")  # 5 USD
-Money.from_subunits(5, "JPY") == Money.new(5, "JPY")    # 5 JPY
-Money.from_subunits(5000, "TND") == Money.new(5, "TND") # 5 TND
+Money.from_subunits(500, "USD")  == Money.new(5, "USD")   # 5 USD
+Money.from_subunits(5, "JPY")    == Money.new(5, "JPY")   # 5 JPY
+Money.from_subunits(5000, "TND") == Money.new(5, "TND")   # 5 TND
 ```
 
 ## Currency

data/dev.yml

@@ -3,7 +3,7 @@
 ---
 name: money
 up:
-- ruby: 3.2.0
+- ruby: 3.3.0
 - bundler
 commands:
   test: bundle exec rspec

data/lib/money/helpers.rb

@@ -16,8 +16,6 @@ class Money
     def value_to_decimal(num)
       value =
         case num
-        when Money
-          num.value
         when BigDecimal
           num
         when nil, 0, ''

data/lib/money/money.rb

@@ -137,13 +137,8 @@ class Money
   end
 
   def *(numeric)
-    unless numeric.is_a?(Numeric)
-      if Money.config.legacy_deprecations
-        Money.deprecate("Multiplying Money with #{numeric.class.name} is deprecated and will be removed in the next major release.")
-      else
-        raise ArgumentError, "Money objects can only be multiplied by a Numeric"
-      end
-    end
+    raise ArgumentError, "Money objects can only be multiplied by a Numeric" unless numeric.is_a?(Numeric)
+
     return self if numeric == 1
     Money.new(value.to_r * numeric, currency)
   end

data/lib/money/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 class Money
-  VERSION = "1.3.0"
+  VERSION = "2.0.0"
 end

data/money.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency("database_cleaner", "~> 1.6")
   s.add_development_dependency("sqlite3", "~> 1.4.2")
 
-  s.required_ruby_version = '>= 2.6'
+  s.required_ruby_version = '>= 3.0'
 
   s.files = `git ls-files`.split($/)
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }

data/spec/deprecations_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 
 RSpec.describe "deprecations" do
   it "has the deprecation_horizon as the next major release" do
-    allow(Money).to receive(:const_get).with('VERSION').and_return("1.2.3")
-    expect(Money.active_support_deprecator.deprecation_horizon).to eq("2.0.0")
+    allow(Money).to receive(:const_get).with('VERSION').and_return("2.0.0")
+    expect(Money.active_support_deprecator.deprecation_horizon).to eq("3.0.0")
   end
 end

data/spec/helpers_spec.rb

@@ -7,8 +7,8 @@ RSpec.describe Money::Helpers do
     let (:amount) { BigDecimal('1.23') }
     let (:money) { Money.new(amount) }
 
-    it 'returns the value of a money object' do
-      expect(subject.value_to_decimal(money)).to eq(amount)
+    it 'raises when provided with a money object' do
+      expect { subject.value_to_decimal(money) }.to raise_error(ArgumentError)
     end
 
     it 'returns itself if it is already a big decimal' do

data/spec/money_spec.rb

@@ -290,13 +290,6 @@ RSpec.describe "Money" do
     expect(((1.0 / 12) * Money.new(3.3))).to eq(Money.new(0.28))
   end
 
-  it "legacy_deprecations is multipliable by a money object" do
-    configure(legacy_deprecations: true) do
-      expect(Money).to receive(:deprecate).once
-      expect((Money.new(3.3, 'USD') * Money.new(1, 'USD'))).to eq(Money.new(3.3, 'USD'))
-    end
-  end
-
   it "raises when multiplied by a money object" do
     expect{ (Money.new(3.3) * Money.new(1)) }.to raise_error(ArgumentError)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-09 00:00:00.000000000 Z
+date: 2024-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -179,14 +179,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.17
+rubygems_version: 3.5.5
 signing_key: 
 specification_version: 4
 summary: Shopify's money gem