shopify-money 0.16.0 → 1.0.2.pre

data/spec/{accounting_money_parser_spec.rb → parser/accounting_spec.rb}

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 require 'spec_helper'
 
-RSpec.describe AccountingMoneyParser do
-  describe "parsing of amounts with period decimal separator" do
-    before(:each) do
-      @parser = AccountingMoneyParser.new
-    end
+RSpec.describe Money::Parser::Accounting do
+  before(:each) do
+    @parser = described_class
+  end
 
+  describe "parsing of amounts with period decimal separator" do
     it "parses parenthesis as a negative amount eg (99.00)" do
       expect(@parser.parse("(99.00)")).to eq(Money.new(-99.00))
     end
@@ -20,8 +20,10 @@ RSpec.describe AccountingMoneyParser do
     end
 
     it "parses an invalid string to $0" do
-      expect(Money).to receive(:deprecate).once
-      expect(@parser.parse("no money")).to eq(Money.new)
+      configure(legacy_deprecations: true) do
+        expect(Money).to receive(:deprecate).once
+        expect(@parser.parse("no money", 'USD')).to eq(Money.new(0, 'USD'))
+      end
     end
 
     it "parses a single digit integer string" do
@@ -102,10 +104,6 @@ RSpec.describe AccountingMoneyParser do
   end
 
   describe "parsing of amounts with comma decimal separator" do
-    before(:each) do
-      @parser = AccountingMoneyParser.new
-    end
-
     it "parses dollar amount $1,00 with leading $" do
       expect(@parser.parse("$1,00")).to eq(Money.new(1.00))
     end
@@ -154,10 +152,6 @@ RSpec.describe AccountingMoneyParser do
   end
 
   describe "parsing of decimal cents amounts from 0 to 10" do
-    before(:each) do
-      @parser = AccountingMoneyParser.new
-    end
-
     it "parses 50.0" do
       expect(@parser.parse("50.0")).to eq(Money.new(50.00))
     end

data/spec/{money_parser_spec.rb → parser/fuzzy_spec.rb}

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 require 'spec_helper'
 
-RSpec.describe MoneyParser do
+RSpec.describe Money::Parser::Fuzzy do
   before(:each) do
-    @parser = MoneyParser
+    @parser = described_class
   end
 
   describe "parsing of amounts with period decimal separator" do
@@ -12,14 +12,22 @@ RSpec.describe MoneyParser do
     end
 
     it "parses an invalid string when not strict" do
-      expect(Money).to receive(:deprecate).twice
-      expect(@parser.parse("no money")).to eq(Money.new(0, Money::NULL_CURRENCY))
-      expect(@parser.parse("1..")).to eq(Money.new(1))
+      configure(legacy_deprecations: true) do
+        expect(Money).to receive(:deprecate).twice
+        expect(@parser.parse("no money", 'USD')).to eq(Money.new(0, 'USD'))
+        expect(@parser.parse("1..", 'USD')).to eq(Money.new(1, 'USD'))
+      end
     end
 
     it "parses raise with an invalid string and strict option" do
-      expect { @parser.parse("no money", strict: true) }.to raise_error(MoneyParser::MoneyFormatError)
-      expect { @parser.parse("1..1", strict: true) }.to raise_error(MoneyParser::MoneyFormatError)
+      expect { @parser.parse("no money", strict: true) }.to raise_error(described_class::MoneyFormatError)
+      expect { @parser.parse("1..1", strict: true) }.to raise_error(described_class::MoneyFormatError)
+    end
+
+    it "parses raise with an invalid when a currency is missing" do
+      configure do
+        expect { @parser.parse("1") }.to raise_error(Money::Currency::UnknownCurrency)
+      end
     end
 
     it "parses a single digit integer string" do
@@ -144,12 +152,14 @@ RSpec.describe MoneyParser do
     end
 
     it "parses amount with multiple inconsistent thousands delimiters" do
-      expect(Money).to receive(:deprecate).once
-      expect(@parser.parse("1.1.11.111")).to eq(Money.new(1_111_111))
+      configure(legacy_deprecations: true) do
+        expect(Money).to receive(:deprecate).once
+        expect(@parser.parse("1.1.11.111", 'USD')).to eq(Money.new(1_111_111, 'USD'))
+      end
     end
 
     it "parses raises with multiple inconsistent thousands delimiters and strict option" do
-      expect { @parser.parse("1.1.11.111", strict: true) }.to raise_error(MoneyParser::MoneyFormatError)
+      expect { @parser.parse("1.1.11.111", strict: true) }.to raise_error(described_class::MoneyFormatError)
     end
   end
 
@@ -216,12 +226,14 @@ RSpec.describe MoneyParser do
     end
 
     it "parses amount with multiple inconsistent thousands delimiters" do
-      expect(Money).to receive(:deprecate).once
-      expect(@parser.parse("1,1,11,111")).to eq(Money.new(1_111_111))
+      configure(legacy_deprecations: true) do
+        expect(Money).to receive(:deprecate).once
+        expect(@parser.parse("1,1,11,111", 'USD')).to eq(Money.new(1_111_111, 'USD'))
+      end
     end
 
     it "parses raises with multiple inconsistent thousands delimiters and strict option" do
-      expect { @parser.parse("1,1,11,111", strict: true) }.to raise_error(MoneyParser::MoneyFormatError)
+      expect { @parser.parse("1,1,11,111", strict: true) }.to raise_error(described_class::MoneyFormatError)
     end
   end
 

data/spec/parser/locale_aware_spec.rb

@@ -0,0 +1,208 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Money::Parser::LocaleAware do
+  context "parsing amounts with period decimal separator" do
+    around(:example) do |example|
+      with_decimal_separator(".") { example.run }
+    end
+
+    it "parses an empty string to nil" do
+      expect(described_class.parse("", "CAD")).to be_nil
+    end
+
+    it "parses an invalid string when not strict" do
+      expect(described_class.parse("no money", "CAD")).to be_nil
+      expect(described_class.parse("1..", "CAD")).to be_nil
+    end
+
+    it "raises with an invalid string and strict option" do
+      expect { described_class.parse("no money", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("1..1", "CAD", strict: true) }.to raise_error(ArgumentError)
+    end
+
+    it "parses an integer string amount" do
+      expect(described_class.parse("1", "CAD")).to eq(Money.new(1.00, "CAD"))
+      expect(described_class.parse("-1", "CAD")).to eq(Money.new(-1.00, "CAD"))
+    end
+
+    it "parses a float string amount" do
+      expect(described_class.parse("1.37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("-1.37", "CAD")).to eq(Money.new(-1.37, "CAD"))
+    end
+
+    it "parses a float string with 3 decimals" do
+      expect(described_class.parse("1.378", "JOD")).to eq(Money.new(1.378, "JOD"))
+      expect(described_class.parse("-1.378", "JOD")).to eq(Money.new(-1.378, "JOD"))
+      expect(described_class.parse("123.456", "USD")).to eq(Money.new(123.46, "USD"))
+    end
+
+    it "parses a float string amount with a leading random character" do
+      expect(described_class.parse("$1.37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse(",1.37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("€1.37", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses a float string amount with a trailing random character" do
+      expect(described_class.parse("1.37$", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("1.37,", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("1.37€", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses an amount with one or more thousands separators" do
+      expect(described_class.parse("100,000", "CAD")).to eq(Money.new(100_000.00, "CAD"))
+      expect(described_class.parse("-100,000", "CAD")).to eq(Money.new(-100_000.00, "CAD"))
+      expect(described_class.parse("100,000.01", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("1,00,000.01", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("1,00,000.001", "JOD")).to eq(Money.new(100_000.001, "JOD"))
+    end
+  end
+
+  context "parsing amounts with comma decimal separator" do
+    around(:example) do |example|
+      with_decimal_separator(",") { example.run }
+    end
+
+    it "parses an empty string to nil" do
+      expect(described_class.parse("", "CAD")).to be_nil
+    end
+
+    it "parses an invalid string when not strict" do
+      expect(described_class.parse("no money", "CAD")).to be_nil
+      expect(described_class.parse("1,,", "CAD")).to be_nil
+    end
+
+    it "raises with an invalid string and strict option" do
+      expect { described_class.parse("no money", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("1,,1", "CAD", strict: true) }.to raise_error(ArgumentError)
+    end
+
+    it "parses an integer string amount" do
+      expect(described_class.parse("1", "CAD")).to eq(Money.new(1.00, "CAD"))
+      expect(described_class.parse("-1", "CAD")).to eq(Money.new(-1.00, "CAD"))
+    end
+
+    it "parses a float string amount" do
+      expect(described_class.parse("1,37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("-1,37", "CAD")).to eq(Money.new(-1.37, "CAD"))
+    end
+
+    it "parses a float string with 3 decimals" do
+      expect(described_class.parse("1,378", "JOD")).to eq(Money.new(1.378, "JOD"))
+      expect(described_class.parse("-1,378", "JOD")).to eq(Money.new(-1.378, "JOD"))
+    end
+
+    it "parses a float string amount with a leading random character" do
+      expect(described_class.parse("$1,37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse(".1,37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("€1,37", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses a float string amount with a trailing random character" do
+      expect(described_class.parse("1,37$", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("1,37.", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("1,37€", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses an amount with one or more thousands separators" do
+      expect(described_class.parse("100.000", "CAD")).to eq(Money.new(100_000.00, "CAD"))
+      expect(described_class.parse("-100.000", "CAD")).to eq(Money.new(-100_000.00, "CAD"))
+      expect(described_class.parse("100.000,01", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("1.00.000,01", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("1.00.000,001", "JOD")).to eq(Money.new(100_000.001, "JOD"))
+    end
+  end
+
+  context "parsing amounts with fullwidth characters" do
+    around(:example) do |example|
+      with_decimal_separator(".") { example.run }
+    end
+
+    it "parses an empty string to nil" do
+      expect(described_class.parse("", "CAD")).to be_nil
+    end
+
+    it "parses an invalid string when not strict" do
+      expect(described_class.parse("ｎｏ ｍｏｎｅｙ", "CAD")).to be_nil
+      expect(described_class.parse("１．．", "CAD")).to be_nil
+    end
+
+    it "raises with an invalid string and strict option" do
+      expect { described_class.parse("ｎｏ ｍｏｎｅｙ", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("１．．１", "CAD", strict: true) }.to raise_error(ArgumentError)
+    end
+
+    it "parses an integer string amount" do
+      expect(described_class.parse("１", "CAD")).to eq(Money.new(1.00, "CAD"))
+      expect(described_class.parse("-１", "CAD")).to eq(Money.new(-1.00, "CAD"))
+    end
+
+    it "parses a float string amount" do
+      expect(described_class.parse("１．３７", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("－１．３７", "CAD")).to eq(Money.new(-1.37, "CAD"))
+    end
+
+    it "parses a float string with 3 decimals" do
+      expect(described_class.parse("１．３７８", "JOD")).to eq(Money.new(1.378, "JOD"))
+      expect(described_class.parse("－１．３７８", "JOD")).to eq(Money.new(-1.378, "JOD"))
+    end
+
+    it "parses a float string amount with a leading random character" do
+      expect(described_class.parse("$１．３７", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("，１．３７", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("€１．３７", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses a float string amount with a trailing random character" do
+      expect(described_class.parse("１．３７$", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("１．３７，", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("１．３７€", "CAD")).to eq(Money.new(1.37, "CAD"))
+    end
+
+    it "parses an amount with one or more thousands separators" do
+      expect(described_class.parse("１００，０００", "CAD")).to eq(Money.new(100_000.00, "CAD"))
+      expect(described_class.parse("－１００，０００", "CAD")).to eq(Money.new(-100_000.00, "CAD"))
+      expect(described_class.parse("１００，０００．０１", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("１，００，０００．０１", "CAD")).to eq(Money.new(100_000.01, "CAD"))
+      expect(described_class.parse("１，００，０００．００１", "JOD")).to eq(Money.new(100_000.001, "JOD"))
+      expect(described_class.parse("１００,０００、０００", "JPY")).to eq(Money.new(100_000_000, "JPY"))
+    end
+  end
+
+  context "bad decimal_separator_proc" do
+    context "raises when called" do
+      around(:example) do |example|
+        with_decimal_separator_proc(->() { raise NoMethodError }) { example.run }
+      end
+
+      it "raises the original error" do
+        expect { described_class.parse("1", "CAD") }.to raise_error(NoMethodError)
+      end
+    end
+
+    context "returning nil" do
+      around(:example) do |example|
+        with_decimal_separator(nil) { example.run }
+      end
+
+      it "raises the original error" do
+        expect { described_class.parse("1", "CAD") }.to raise_error(ArgumentError)
+      end
+    end
+  end
+
+  private
+
+  def with_decimal_separator(character)
+    with_decimal_separator_proc(->() { character }) do
+      yield
+    end
+  end
+
+  def with_decimal_separator_proc(proc)
+    old = described_class.decimal_separator_resolver
+    described_class.decimal_separator_resolver = proc
+    yield
+    described_class.decimal_separator_resolver = old
+  end
+end

data/spec/parser/simple_spec.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Money::Parser::Simple do
+  context "parsing amounts with period decimal separator" do
+    it "parses an empty string to nil" do
+      expect(described_class.parse("", "CAD")).to be_nil
+    end
+
+    it "parses an invalid string when not strict" do
+      expect(described_class.parse("no money", "CAD")).to be_nil
+      expect(described_class.parse("1..", "CAD")).to be_nil
+      expect(described_class.parse("10.", "CAD")).to be_nil
+      expect(described_class.parse("10.1E2", "CAD")).to be_nil
+    end
+
+    it "raises with an invalid string and strict option" do
+      expect { described_class.parse("no money", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("1..1", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("10.", "CAD", strict: true) }.to raise_error(ArgumentError)
+      expect { described_class.parse("10.1E2", "CAD", strict: true) }.to raise_error(ArgumentError)
+    end
+
+    it "parses an integer string amount" do
+      expect(described_class.parse("1", "CAD")).to eq(Money.new(1.00, "CAD"))
+      expect(described_class.parse("-1", "CAD")).to eq(Money.new(-1.00, "CAD"))
+    end
+
+    it "parses a float string amount" do
+      expect(described_class.parse("1.37", "CAD")).to eq(Money.new(1.37, "CAD"))
+      expect(described_class.parse("-1.37", "CAD")).to eq(Money.new(-1.37, "CAD"))
+    end
+
+    it "parses a float string with 3 decimals" do
+      expect(described_class.parse("1.378", "JOD")).to eq(Money.new(1.378, "JOD"))
+      expect(described_class.parse("-1.378", "JOD")).to eq(Money.new(-1.378, "JOD"))
+      expect(described_class.parse("123.456", "USD")).to eq(Money.new(123.46, "USD"))
+    end
+
+    it "does not parse a float string amount with a leading random character" do
+      expect(described_class.parse("$1.37", "CAD")).to be_nil
+      expect(described_class.parse(",1.37", "CAD")).to be_nil
+      expect(described_class.parse("€1.37", "CAD")).to be_nil
+      expect(described_class.parse(" 1.37", "CAD")).to be_nil
+    end
+
+    it "does not parse a float string amount with a trailing random character" do
+      expect(described_class.parse("1.37$", "CAD")).to be_nil
+      expect(described_class.parse("1.37,", "CAD")).to be_nil
+      expect(described_class.parse("1.37€", "CAD")).to be_nil
+      expect(described_class.parse("1.37 ", "CAD")).to be_nil
+    end
+
+    it "does not parse an amount with one or more thousands separators" do
+      expect(described_class.parse("100,000", "CAD")).to be_nil
+      expect(described_class.parse("-100,000", "CAD")).to be_nil
+      expect(described_class.parse("100,000.01", "CAD")).to be_nil
+      expect(described_class.parse("1,00,000.01", "CAD")).to be_nil
+      expect(described_class.parse("1,00,000.001", "JOD")).to be_nil
+    end
+  end
+end

data/spec/rails/job_argument_serializer_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require "rails_spec_helper"
+
+RSpec.describe Money::Rails::JobArgumentSerializer do
+  it "roundtrip a Money argument returns the same object" do
+    job = MoneyTestJob.new(value: Money.new(10.21, "BRL"))
+
+    serialized_job = job.serialize
+    serialized_value = serialized_job["arguments"][0]["value"]
+    expect(serialized_value["_aj_serialized"]).to eq("Money::Rails::JobArgumentSerializer")
+    expect(serialized_value["value"]).to eq(BigDecimal("10.21"))
+    expect(serialized_value["currency"]).to eq("BRL")
+
+    job2 = MoneyTestJob.deserialize(serialized_job)
+    job2.send(:deserialize_arguments_if_needed)
+
+    expect(job2.arguments.first[:value]).to eq(Money.new(10.21, "BRL"))
+  end
+end

data/spec/rails_spec_helper.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require "active_job"
+require_relative "spec_helper"
+
+Money::Railtie.initializers.each(&:run)
+
+class MoneyTestJob < ActiveJob::Base
+  def perform(_params)
+  end
+end

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'simplecov'
 SimpleCov.minimum_coverage 100
 SimpleCov.start do
   add_filter "/spec/"
+  add_filter "/lib/money/railtie"
 end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -68,3 +69,17 @@ RSpec::Matchers.define :quack_like do
     expected.instance_methods - actual.instance_methods
   end
 end
+
+
+def configure(default_currency: nil, legacy_json_format: nil, legacy_deprecations: nil, legacy_default_currency: nil)
+  old_config = Money.config
+  Money.config = Money::Config.new.tap do |config|
+    config.default_currency = default_currency if default_currency
+    config.legacy_json_format! if legacy_json_format
+    config.legacy_deprecations! if legacy_deprecations
+    config.legacy_default_currency! if legacy_default_currency
+  end
+  yield
+ensure
+  Money.config = old_config
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 1.0.2.pre
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-03 00:00:00.000000000 Z
+date: 2022-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -110,14 +110,15 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- UPGRADING.md
 - bin/console
 - config/currency_historic.yml
 - config/currency_iso.yml
 - config/currency_non_iso.yml
 - dev.yml
 - lib/money.rb
-- lib/money/accounting_money_parser.rb
 - lib/money/allocator.rb
+- lib/money/config.rb
 - lib/money/core_extensions.rb
 - lib/money/currency.rb
 - lib/money/currency/loader.rb
@@ -125,8 +126,13 @@ files:
 - lib/money/errors.rb
 - lib/money/helpers.rb
 - lib/money/money.rb
-- lib/money/money_parser.rb
 - lib/money/null_currency.rb
+- lib/money/parser/accounting.rb
+- lib/money/parser/fuzzy.rb
+- lib/money/parser/locale_aware.rb
+- lib/money/parser/simple.rb
+- lib/money/rails/job_argument_serializer.rb
+- lib/money/railtie.rb
 - lib/money/version.rb
 - lib/money_column.rb
 - lib/money_column/active_record_hooks.rb
@@ -137,16 +143,21 @@ files:
 - lib/rubocop/cop/money/zero_money.rb
 - lib/shopify-money.rb
 - money.gemspec
-- spec/accounting_money_parser_spec.rb
 - spec/allocator_spec.rb
+- spec/config_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
 - spec/helpers_spec.rb
 - spec/money_column_spec.rb
-- spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
+- spec/parser/accounting_spec.rb
+- spec/parser/fuzzy_spec.rb
+- spec/parser/locale_aware_spec.rb
+- spec/parser/simple_spec.rb
+- spec/rails/job_argument_serializer_spec.rb
+- spec/rails_spec_helper.rb
 - spec/rubocop/cop/money/missing_currency_spec.rb
 - spec/rubocop/cop/money/zero_money_spec.rb
 - spec/rubocop_helper.rb
@@ -168,25 +179,30 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: Shopify's money gem
 test_files:
-- spec/accounting_money_parser_spec.rb
 - spec/allocator_spec.rb
+- spec/config_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
 - spec/helpers_spec.rb
 - spec/money_column_spec.rb
-- spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
+- spec/parser/accounting_spec.rb
+- spec/parser/fuzzy_spec.rb
+- spec/parser/locale_aware_spec.rb
+- spec/parser/simple_spec.rb
+- spec/rails/job_argument_serializer_spec.rb
+- spec/rails_spec_helper.rb
 - spec/rubocop/cop/money/missing_currency_spec.rb
 - spec/rubocop/cop/money/zero_money_spec.rb
 - spec/rubocop_helper.rb

data/lib/money/accounting_money_parser.rb

@@ -1,8 +0,0 @@
-# frozen_string_literal: true
-
-class AccountingMoneyParser < MoneyParser
-  def parse(input, currency = nil, **options)
-    # set () to mean negativity. ignore $
-    super(input.gsub(/\(\$?(.*?)\)/, '-\1'), currency, **options)
-  end
-end