shopify-money 0.14.6 → 1.0.0.pre

data/spec/rubocop/cop/money/zero_money_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require_relative '../../../rubocop_helper'
+require 'rubocop/cop/money/zero_money'
+
+RSpec.describe RuboCop::Cop::Money::ZeroMoney do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) { RuboCop::Config.new }
+
+  context 'with default configuration' do
+    it 'registers an offense and corrects Money.zero without currency' do
+      expect_offense(<<~RUBY)
+        Money.zero
+        ^^^^^^^^^^ Money.zero is removed, use `Money.new(0, Money::NULL_CURRENCY)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Money.new(0, Money::NULL_CURRENCY)
+      RUBY
+    end
+
+    it 'registers an offense and corrects Money.zero with currency' do
+      expect_offense(<<~RUBY)
+        Money.zero('CAD')
+        ^^^^^^^^^^^^^^^^^ Money.zero is removed, use `Money.new(0, 'CAD')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Money.new(0, 'CAD')
+      RUBY
+    end
+
+    it 'does not register an offense when using Money.new with a currency' do
+      expect_no_offenses(<<~RUBY)
+        Money.new(0, 'CAD')
+      RUBY
+    end
+  end
+
+  context 'with ReplacementCurrency configuration' do
+    let(:config) do
+      RuboCop::Config.new(
+        'Money/ZeroMoney' => {
+          'ReplacementCurrency' => 'CAD'
+        }
+      )
+    end
+
+    it 'registers an offense and corrects Money.zero without currency' do
+      expect_offense(<<~RUBY)
+        Money.zero
+        ^^^^^^^^^^ Money.zero is removed, use `Money.new(0, 'CAD')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Money.new(0, 'CAD')
+      RUBY
+    end
+
+    it 'registers an offense and corrects Money.zero with currency' do
+      expect_offense(<<~RUBY)
+        Money.zero('EUR')
+        ^^^^^^^^^^^^^^^^^ Money.zero is removed, use `Money.new(0, 'EUR')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Money.new(0, 'EUR')
+      RUBY
+    end
+
+    it 'does not register an offense when using Money.new with a currency' do
+      expect_no_offenses(<<~RUBY)
+        Money.new(0, 'EUR')
+      RUBY
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -68,3 +68,18 @@ RSpec::Matchers.define :quack_like do
     expected.instance_methods - actual.instance_methods
   end
 end
+
+
+def configure(default_currency: nil, legacy_json_format: nil, legacy_deprecations: nil, legacy_default_currency: nil, parser: nil)
+  old_config = Money.config
+  Money.config = Money::Config.new.tap do |config|
+    config.default_currency = default_currency if default_currency
+    config.parser = parser if parser
+    config.legacy_json_format! if legacy_json_format
+    config.legacy_deprecations! if legacy_deprecations
+    config.legacy_default_currency! if legacy_default_currency
+  end
+  yield
+ensure
+  Money.config = old_config
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.14.6
+  version: 1.0.0.pre
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-19 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -103,13 +103,14 @@ extra_rdoc_files: []
 files:
 - ".document"
 - ".github/probots.yml"
+- ".github/workflows/tests.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- UPGRADING.md
 - bin/console
 - config/currency_historic.yml
 - config/currency_iso.yml
@@ -118,6 +119,7 @@ files:
 - lib/money.rb
 - lib/money/accounting_money_parser.rb
 - lib/money/allocator.rb
+- lib/money/config.rb
 - lib/money/core_extensions.rb
 - lib/money/currency.rb
 - lib/money/currency/loader.rb
@@ -128,27 +130,28 @@ files:
 - lib/money/money_parser.rb
 - lib/money/null_currency.rb
 - lib/money/version.rb
-- lib/money_accessor.rb
 - lib/money_column.rb
 - lib/money_column/active_record_hooks.rb
 - lib/money_column/active_record_type.rb
 - lib/money_column/railtie.rb
 - lib/rubocop/cop/money.rb
 - lib/rubocop/cop/money/missing_currency.rb
+- lib/rubocop/cop/money/zero_money.rb
 - lib/shopify-money.rb
 - money.gemspec
 - spec/accounting_money_parser_spec.rb
 - spec/allocator_spec.rb
+- spec/config_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
 - spec/helpers_spec.rb
-- spec/money_accessor_spec.rb
 - spec/money_column_spec.rb
 - spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
 - spec/rubocop/cop/money/missing_currency_spec.rb
+- spec/rubocop/cop/money/zero_money_spec.rb
 - spec/rubocop_helper.rb
 - spec/schema.rb
 - spec/spec_helper.rb
@@ -168,9 +171,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
@@ -179,16 +182,17 @@ summary: Shopify's money gem
 test_files:
 - spec/accounting_money_parser_spec.rb
 - spec/allocator_spec.rb
+- spec/config_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
 - spec/helpers_spec.rb
-- spec/money_accessor_spec.rb
 - spec/money_column_spec.rb
 - spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
 - spec/rubocop/cop/money/missing_currency_spec.rb
+- spec/rubocop/cop/money/zero_money_spec.rb
 - spec/rubocop_helper.rb
 - spec/schema.rb
 - spec/spec_helper.rb

data/.travis.yml

@@ -1,13 +0,0 @@
-sudo: false
-language: ruby
-cache: bundler
-branches:
-  only:
-  - master
-rvm:
-  - 2.7
-  - 2.6
-before_install:
-  # https://github.com/travis-ci/travis-ci/issues/8978#issuecomment-354036443
-  - gem update --system
-  - gem install bundler

data/lib/money_accessor.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-module MoneyAccessor
-  def self.included(base)
-    base.extend(ClassMethods)
-  end
-
-  module ClassMethods
-    def money_accessor(*columns)
-      variable_get = self <= Struct ? :[]  : :instance_variable_get
-      variable_set = self <= Struct ? :[]= : :instance_variable_set
-
-      Array(columns).flatten.each do |name|
-        variable_name = self <= Struct ? name : "@#{name}"
-
-        define_method(name) do
-          value = public_send(variable_get, variable_name)
-          value.blank? ? nil : Money.new(value)
-        end
-
-        define_method("#{name}=") do |value|
-          if value.blank? || !value.respond_to?(:to_money)
-            public_send(variable_set, variable_name, nil)
-            nil
-          else
-            money = value.to_money
-            public_send(variable_set, variable_name, money.value)
-            money
-          end
-        end
-      end
-    end
-  end
-end

data/spec/money_accessor_spec.rb

@@ -1,87 +0,0 @@
-# frozen_string_literal: true
-require 'spec_helper'
-
-class NormalObject
-  include MoneyAccessor
-
-  money_accessor :price
-
-  def initialize(price)
-    @price = price
-  end
-end
-
-class StructObject < Struct.new(:price)
-  include MoneyAccessor
-
-  money_accessor :price
-end
-
-RSpec.shared_examples_for "an object with a money accessor" do
-  it "generates an attribute reader that returns a money object" do
-    object = described_class.new(100)
-
-    expect(object.price).to eq(Money.new(100))
-  end
-
-  it "generates an attribute reader that returns a nil object if the value was nil" do
-    object = described_class.new(nil)
-
-    expect(object.price).to eq(nil)
-  end
-
-  it "generates an attribute reader that returns a nil object if the value was blank" do
-    object = described_class.new('')
-
-    expect(object.price).to eq(nil)
-  end
-
-  it "generates an attribute writer that allow setting a money object" do
-    object = described_class.new(0)
-    object.price = Money.new(10)
-
-    expect(object.price).to eq(Money.new(10))
-  end
-
-  it "generates an attribute writer that allow setting a integer value" do
-    object = described_class.new(0)
-    object.price = 10
-
-    expect(object.price).to eq(Money.new(10))
-  end
-
-  it "generates an attribute writer that allow setting a float value" do
-    object = described_class.new(0)
-    object.price = 10.12
-
-    expect(object.price).to eq(Money.new(10.12))
-  end
-
-  it "generates an attribute writer that allow setting a nil value" do
-    object = described_class.new(0)
-    object.price = nil
-
-    expect(object.price).to eq(nil)
-  end
-
-  it "generates an attribute writer that allow setting a blank value" do
-    object = described_class.new(0)
-    object.price = ''
-
-    expect(object.price).to eq(nil)
-  end
-end
-
-RSpec.describe NormalObject do
-  it_behaves_like "an object with a money accessor"
-end
-
-RSpec.describe StructObject do
-  it_behaves_like "an object with a money accessor"
-
-  it 'does not generate an ivar to store the price value' do
-    object = described_class.new(10.00)
-
-    expect(object.instance_variable_get(:@price)).to eq(nil)
-  end
-end