shopify-money 0.12.0 → 0.14.2

data/spec/null_currency_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe "NullCurrency" do

data/spec/rubocop/cop/money/missing_currency_spec.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+require_relative '../../../rubocop_helper'
+require 'rubocop/cop/money/missing_currency'
+
+RSpec.describe RuboCop::Cop::Money::MissingCurrency do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) { RuboCop::Config.new }
+
+  describe '#on_send' do
+    it 'registers an offense for Money.new without a currency argument' do
+      expect_offense(<<~RUBY)
+        Money.new(1)
+        ^^^^^^^^^^^^ Money is missing currency argument
+      RUBY
+    end
+
+    it 'does not register an offense for Money.new with currency argument' do
+      expect_no_offenses(<<~RUBY)
+        Money.new(1, 'CAD')
+      RUBY
+    end
+
+    it 'registers an offense for Money.new without a currency argument' do
+      expect_offense(<<~RUBY)
+        Money.new
+        ^^^^^^^^^ Money is missing currency argument
+      RUBY
+    end
+
+    it 'registers an offense for Money.from_amount without a currency argument' do
+      expect_offense(<<~RUBY)
+        Money.from_amount(1)
+        ^^^^^^^^^^^^^^^^^^^^ Money is missing currency argument
+      RUBY
+    end
+
+    it 'does not register an offense for Money.from_amount with currency argument' do
+      expect_no_offenses(<<~RUBY)
+        Money.from_amount(1, 'CAD')
+      RUBY
+    end
+
+    it 'registers an offense for Money.from_cents without a currency argument' do
+      expect_offense(<<~RUBY)
+        Money.from_cents(1)
+        ^^^^^^^^^^^^^^^^^^^ Money is missing currency argument
+      RUBY
+    end
+
+    it 'does not register an offense for Money.from_cents with currency argument' do
+      expect_no_offenses(<<~RUBY)
+        Money.from_cents(1, 'CAD')
+      RUBY
+    end
+
+    it 'registers an offense for to_money without a currency argument' do
+      expect_offense(<<~RUBY)
+        '1'.to_money
+        ^^^^^^^^^^^^ to_money is missing currency argument
+      RUBY
+    end
+
+    it 'does not register an offense for to_money with currency argument' do
+      expect_no_offenses(<<~RUBY)
+        '1'.to_money('CAD')
+      RUBY
+    end
+
+    it 'registers an offense for to_money block pass form' do
+      expect_offense(<<~RUBY)
+        ['1'].map(&:to_money)
+        ^^^^^^^^^^^^^^^^^^^^^ to_money is missing currency argument
+      RUBY
+    end
+  end
+
+  describe '#autocorrect' do
+    let(:config) do
+      RuboCop::Config.new(
+        'Money/MissingCurrency' => {
+          'ReplacementCurrency' => 'CAD'
+        }
+      )
+    end
+
+    it 'corrects Money.new without currency' do
+      new_source = autocorrect_source('Money.new(1)')
+      expect(new_source).to eq("Money.new(1, 'CAD')")
+    end
+
+    it 'corrects Money.new without amount or currency' do
+      new_source = autocorrect_source('Money.new')
+      expect(new_source).to eq("Money.new(0, 'CAD')")
+    end
+
+    it 'corrects to_money without currency' do
+      new_source = autocorrect_source('1.to_money')
+      expect(new_source).to eq("1.to_money('CAD')")
+    end
+
+    it 'corrects to_money block pass form' do
+      new_source = autocorrect_source("['1'].map(&:to_money)")
+      expect(new_source).to eq("['1'].map { |x| x.to_money('CAD') }")
+    end
+  end
+end

data/spec/rubocop_helper.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+require 'rubocop'
+require 'rubocop/rspec/support'
+
+RSpec.configure do |config|
+  config.include RuboCop::RSpec::ExpectOffense
+end

data/spec/schema.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 ActiveRecord::Schema.define do
   create_table "money_records", :force => true do |t|
     t.decimal  "price", precision: 20, scale: 3, default: '0.000'

data/spec/spec_helper.rb

@@ -1,14 +1,10 @@
+# frozen_string_literal: true
 require 'simplecov'
 SimpleCov.minimum_coverage 100
 SimpleCov.start do
   add_filter "/spec/"
 end
 
-if ENV['CI'] == 'true'
-  require 'codecov'
-  SimpleCov.formatter = SimpleCov::Formatter::Codecov
-end
-
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-money
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.14.2
 platform: ruby
 authors:
 - Shopify Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-10 00:00:00.000000000 Z
+date: 2020-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,28 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: 1.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
-- !ruby/object:Gem::Dependency
-  name: bigdecimal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.3.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.3.2
+        version: 1.4.2
 description: Manage money in Shopify with a class that wont lose pennies during division!
 email: gems@shopify.com
 executables:
@@ -131,6 +117,7 @@ files:
 - dev.yml
 - lib/money.rb
 - lib/money/accounting_money_parser.rb
+- lib/money/allocator.rb
 - lib/money/core_extensions.rb
 - lib/money/currency.rb
 - lib/money/currency/loader.rb
@@ -146,8 +133,12 @@ files:
 - lib/money_column/active_record_hooks.rb
 - lib/money_column/active_record_type.rb
 - lib/money_column/railtie.rb
+- lib/rubocop/cop/money.rb
+- lib/rubocop/cop/money/missing_currency.rb
+- lib/shopify-money.rb
 - money.gemspec
 - spec/accounting_money_parser_spec.rb
+- spec/allocator_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
@@ -157,12 +148,15 @@ files:
 - spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
+- spec/rubocop/cop/money/missing_currency_spec.rb
+- spec/rubocop_helper.rb
 - spec/schema.rb
 - spec/spec_helper.rb
 homepage: https://github.com/Shopify/money
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -171,20 +165,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Shopify's money gem
 test_files:
 - spec/accounting_money_parser_spec.rb
+- spec/allocator_spec.rb
 - spec/core_extensions_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
@@ -194,5 +188,7 @@ test_files:
 - spec/money_parser_spec.rb
 - spec/money_spec.rb
 - spec/null_currency_spec.rb
+- spec/rubocop/cop/money/missing_currency_spec.rb
+- spec/rubocop_helper.rb
 - spec/schema.rb
 - spec/spec_helper.rb