shopify-junos-ez-stdlib 1.0.0

data/lib/junos-ez/l1_ports/classic.rb

@@ -0,0 +1,87 @@
+class Junos::Ez::L1ports::Provider::CLASSIC < Junos::Ez::L1ports::Provider
+
+  ### ---------------------------------------------------------------
+  ### XML top placement
+  ### ---------------------------------------------------------------
+  
+  def xml_at_top    
+    xml = Nokogiri::XML::Builder.new {|xml| xml.configuration {
+      xml.interfaces {
+        xml.interface { 
+          xml.name @name
+          return xml
+        }
+      }
+    }}
+  end
+      
+  ### ---------------------------------------------------------------
+  ### XML property readers
+  ### ---------------------------------------------------------------
+  
+  def xml_read_filter( xml )
+    xml.description
+    xml.disable
+    xml.mtu
+    xml.speed
+    xml.send(:'link-mode') 
+    xml.unit({:recurse => 'false'})    
+  end
+  
+  def xml_config_read!
+    xml = xml_at_top
+    xml_read_filter( xml )
+    @ndev.rpc.get_configuration( xml )      
+  end    
+
+  def xml_read_parser( as_xml, as_hash )    
+    set_has_status( as_xml, as_hash )
+
+    as_hash[:admin] = as_xml.xpath('disable').empty? ? :up : :down
+    
+    unless (desc = as_xml.xpath('description').text.chomp).empty?
+      as_hash[:description] = desc
+    end
+        
+    if mtu = as_xml.xpath('mtu')[0]; as_hash[:mtu] = mtu.text.to_i end
+            
+    as_hash[:duplex] = case as_xml.xpath('link-mode').text.chomp
+      when 'full-duplex' then :full
+      when 'half-duplex' then :half
+      else :auto
+    end
+      
+    as_hash[:speed] = ( speed = as_xml.xpath('speed')[0] ) ? speed.text : :auto         
+    as_hash[:unit_count] = as_xml.xpath('unit').count
+    
+    return true
+  end
+  
+  ### ---------------------------------------------------------------
+  ### XML property writers
+  ### ---------------------------------------------------------------
+  
+  def xml_change_speed( xml )
+    if @should[:speed] == :auto
+      if is_new?
+        xml.speed Netconf::JunosConfig::DELETE
+      end
+    else
+      xml.speed @should[:speed]
+    end
+  end  
+
+  def xml_change_duplex( xml )
+    if @should[:duplex] == :auto
+      unless is_new?
+        xml.send( :'link-mode', Netconf::JunosConfig::DELETE )
+      end
+    else
+      xml.send( :'link-mode', case @should[:duplex]
+        when :full then 'full-duplex'
+        when :half then 'half-duplex'
+        end )
+    end
+  end  
+    
+end

data/lib/junos-ez/l1_ports/switch.rb

@@ -0,0 +1,134 @@
+class Junos::Ez::L1ports::Provider::SWITCH < Junos::Ez::L1ports::Provider
+
+  ### ---------------------------------------------------------------
+  ### XML top placement
+  ### ---------------------------------------------------------------
+  
+  def xml_at_top
+    xml = Nokogiri::XML::Builder.new {|xml| xml.configuration {
+      xml.interfaces {
+        xml.interface { 
+          xml.name @name
+          return xml
+        }
+      }
+    }}
+  end
+      
+  ### ---------------------------------------------------------------
+  ### XML property readers
+  ### ---------------------------------------------------------------
+  
+  def xml_read_filter( xml )
+    xml.description
+    xml.disable
+    xml.mtu
+    xml.send(:'ether-options') 
+    xml.unit({:recurse => 'false'})    
+  end
+  
+  def xml_config_read!
+    xml = xml_at_top
+    xml_read_filter( xml )
+    @ndev.rpc.get_configuration( xml )      
+  end    
+
+  def xml_read_parser( as_xml, as_hash )    
+    set_has_status( as_xml, as_hash )
+
+    xml_when_item(as_xml.xpath('description')){|i| as_hash[:description] = i.text}        
+    as_hash[:admin] = as_xml.xpath('disable').empty? ? :up : :down
+    xml_when_item(as_xml.xpath('mtu')){|i| as_hash[:mtu] = i.text.to_i }
+        
+    phy_options = as_xml.xpath('ether-options')    
+    if phy_options.empty?
+      as_hash[:speed] = :auto
+      as_hash[:duplex] = :auto
+    else      
+      ## :duplex
+      as_hash[:duplex] = case phy_options.xpath('link-mode').text.chomp
+        when 'full-duplex' then :full
+        when 'half-duplex' then :half
+        else :auto
+      end
+      ## :speed
+      if speed = phy_options.xpath('speed')[0]
+        as_hash[:speed] = _speed_from_junos_( speed.first_element_child.name )
+      else
+        as_hash[:speed] = :auto
+      end
+    end                      
+    
+    as_hash[:unit_count] = as_xml.xpath('unit').count    
+    return true
+  end
+  
+  ### ---------------------------------------------------------------
+  ### XML property writers
+  ### ---------------------------------------------------------------
+  
+  def xml_change_speed( xml )
+    xml.send(:'ether-options') {
+      xml.speed {
+        if @should[:speed] == :auto
+          unless @has[:speed] == :auto
+            xml.send( _speed_to_junos_( @has[:speed] ), Netconf::JunosConfig::DELETE )
+          end
+        else
+          xml.send( _speed_to_junos_( @should[:speed] ))
+        end
+      }
+    }
+  end
+  
+  def xml_change_duplex( xml )
+    xml.send(:'ether-options') {
+      if @should[:duplex] == :auto
+        unless @has[:duplex] == :auto
+          xml.send( :'link-mode', Netconf::JunosConfig::DELETE )
+        end
+      else
+        xml.send( :'link-mode', case @should[:duplex]
+           when :full then 'full-duplex'
+           when :half then 'half-duplex'
+        end )
+      end
+    }
+  end  
+  
+    
+end
+
+### -----------------------------------------------------------------
+### PRIVATE METHODS
+### -----------------------------------------------------------------
+
+class Junos::Ez::L1ports::Provider::SWITCH
+  private
+  
+  def _speed_to_junos_( pval )
+    # @@@ TODO: could remove case-statement and to
+    # @@@ string processing ...    
+    case pval
+       when '10g' then :'ethernet-10g'
+       when '1g' then :'ethernet-1g'
+       when '100m' then :'ethernet-100m'
+       when '10m' then :'ethernet-10m'
+       else :auto
+    end
+  end
+  
+  def _speed_from_junos_( jval )
+    # @@@ TODO: could remove case-statement and to
+    # @@@ string processing ...
+    case jval
+      when 'ethernet-100m' then '100m'
+      when 'ethernet-10m' then '10m'
+      when 'ethernet-1g' then '1g'
+      when 'ethernet-10g' then '10g'
+      else :auto
+    end
+  end
+  
+end
+

data/lib/junos-ez/l2_ports.rb

@@ -0,0 +1,66 @@
+
+require "junos-ez/provider"
+
+module Junos::Ez::L2ports
+
+  PROPERTIES = [ 
+    :description,           # String | nil
+    :untagged_vlan,         # String | nil
+    :tagged_vlans,          # Set of String | nil
+    :vlan_tagging           # true | false
+  ]  
+
+  def self.Provider( ndev, varsym )        
+    
+    newbie = case ndev.fact( :switch_style )
+    when :VLAN
+      Junos::Ez::L2ports::Provider::VLAN.new( ndev )      
+    when :VLAN_L2NG
+      Junos::Ez::L2ports::Provider::VLAN_L2NG.new( ndev )            
+    when :BRIDGE_DOMAIN
+      Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN.new(ndev)
+      #raise ArgumentError, "under development"
+#      Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN.new( ndev )      
+    end      
+    
+    newbie.properties = Junos::Ez::Provider::PROPERTIES + PROPERTIES
+    Junos::Ez::Provider.attach_instance_variable( ndev, varsym, newbie )
+  end
+  
+  class Provider < Junos::Ez::Provider::Parent
+    # common parenting ...
+    
+    def is_trunk?
+      @has[:vlan_tagging] == true
+    end
+    
+    def should_trunk?
+      (@should[:vlan_tagging].nil?) ? @has[:vlan_tagging] : @should[:vlan_tagging]
+    end
+    
+    def mode_changed?
+      return true if is_new?
+      return false if @should[:vlan_tagging].nil?      
+      @should[:vlan_tagging] != @has[:vlan_tagging]      
+    end    
+    
+    ### ---------------------------------------------------------------
+    ### XML overload 'activate/deactivate' since we need to modify
+    ### this at the 'unit' level and not at the 'family' level
+    ### ---------------------------------------------------------------   
+    
+    def xml_change__active( xml )
+      par = xml.instance_variable_get(:@parent).at_xpath('ancestor::interface')
+      value = @should[:_active]  ? 'active' : 'inactive'
+      par[value] = value # attribute name is same as value
+    end       
+    
+  end
+  
+end
+
+require 'junos-ez/l2_ports/vlan'
+require 'junos-ez/l2_ports/vlan_l2ng'
+require 'junos-ez/l2_ports/bridge_domain'
+
+

data/lib/junos-ez/l2_ports/bridge_domain.rb

@@ -0,0 +1,499 @@
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN< Junos::Ez::L2ports::Provider  
+  
+  ### ---------------------------------------------------------------
+  ### XML top placement
+  ### ---------------------------------------------------------------
+  
+  def xml_at_top
+    Nokogiri::XML::Builder.new {|xml| xml.configuration {
+      xml.interfaces {
+        return xml_at_element_top( xml, @name )
+      }
+    }}
+  end
+  
+  # set the edit anchor inside bridge-domains stanza
+  # we will need to 'up-out' when making changes to the 
+  # unit information, like description
+  
+  def xml_at_element_top( xml, name )
+    xml.interface {
+      xml.name name
+      xml.send(:'native-vlan-id')
+      xml.unit { 
+        xml.name '0'
+        return xml
+      }
+    }  
+  end
+     
+  ### ---------------------------------------------------------------
+  ### XML property readers
+  ### ---------------------------------------------------------------  
+
+  def xml_get_has_xml( xml ) 
+    # second unit contains the family/bridge-domains stanza
+    got = xml.xpath('//unit')[0]
+    # if this resource doesn't exist we need to default some 
+    # values into has/should variables
+    unless got
+      @has[:vlan_tagging] = false
+      @should = @has.clone
+    end
+    got
+  end
+  
+  def xml_read_parser( as_xml, as_hash )
+    ## reading is anchored at the [... unit 0 ...] level
+    set_has_status( as_xml, as_hash )  
+    
+    xml_when_item(as_xml.xpath('description')){|i| as_hash[:description] = i.text}
+
+    f_eth = as_xml.xpath('family/bridge')        
+    as_hash[:vlan_tagging] = f_eth.xpath('interface-mode').text.chomp == 'trunk' 
+    
+    # obtain a copy of the running state, this is needed in case the config
+    # is located under the [edit vlans] stanza vs. [edit interfaces]
+    
+    ifs_name = @name || as_xml.xpath('ancestor::interface/name').text.strip
+    eth_port_vlans = _get_eth_port_vlans_h( ifs_name )
+    @under_vlans = []
+    
+    # --- access port        
+    
+    if as_hash[:vlan_tagging] == false
+      xml_when_item(f_eth.xpath('domain/vlan-id')){ |i| as_hash[:untagged_vlan] = i.text.chomp }
+      unless as_hash[:untagged_vlan]
+        as_hash[:untagged_vlan] = eth_port_vlans[:untagged]
+        @under_vlans << eth_port_vlans[:untagged]
+      end
+      return
+    end
+    
+    # --- trunk port    
+    as_hash[:untagged_vlan] ||= eth_port_vlans[:untagged]
+    as_hash[:tagged_vlans] = f_eth.xpath('//bridge/vlan-id-list').collect { |v| v.text.chomp }.to_set
+    (eth_port_vlans[:tagged] - as_hash[:tagged_vlans]).each do |vlan|
+      as_hash[:tagged_vlans] << vlan
+     @under_vlans << vlan
+    end
+    # native-vlan-id is set at the interface level, and is the VLAN-ID, not the vlan
+    # name.  So we need to do a bit of translating here.  The *ASSUMPTION* is that the
+    # native-vlan-id value is a given VLAN in the tagged_vlan list.  So we will use 
+    # that list to do the reverse lookup on the tag-id => name
+    as_hash[:tagged_vlans]= as_hash[:tagged_vlans].collect {|x| _vlan_tag_id_to_name(x)} 
+    xml_when_item(f_eth.xpath('ancestor::interface/native-vlan-id')){ |i|
+      as_hash[:untagged_vlan] = _vlan_tag_id_to_name( i.text.chomp) 
+    }
+    as_hash[:tagged_vlans].delete(as_hash[:untagged_vlan])
+  end
+    
+  ### ---------------------------------------------------------------
+  ### XML on_create, on_delete handlers
+  ### ---------------------------------------------------------------   
+  
+  ## overload the xml_on_delete method since we may need
+  ## to do some cleanup work in the [edit vlans] stanza
+  
+  def xml_on_delete( xml )
+    @ifd = xml.instance_variable_get(:@parent).at_xpath('ancestor::interface')
+    @ifd.xpath('//native-vlan-id').remove      ## remove the element from the get-config    
+    ## need to add check if any native-vlan-id is present or not (untagged vlan)#####
+   if is_trunk? and @ifd.xpath('//native-vlan-id')
+      _delete_native_vlan_id( xml )
+   end
+      
+    return unless @under_vlans
+    return if @under_vlans.empty?
+
+    _xml_rm_under_vlans( xml, @under_vlans )
+  end   
+
+  ### ---------------------------------------------------------------
+  ### XML property writers
+  ### ---------------------------------------------------------------    
+  
+  def xml_at_here( xml )
+    @ifd = xml.instance_variable_get(:@parent).at_xpath('ancestor::interface')
+    @ifd.xpath('//native-vlan-id').remove      ## remove the element from the get-config
+    xml.family {
+      xml.send(:'bridge') {
+        return xml
+      }
+    }
+  end
+  
+  def xml_build_change( nop = nil )
+    @under_vlans ||= []       # handles case for create'd port
+    if mode_changed?
+      @should[:untagged_vlan] ||= @has[:untagged_vlan]    
+    end
+    super xml_at_here( xml_at_top )
+  end  
+
+  ## ----------------------------------------------------------------
+  ## :description
+  ## ----------------------------------------------------------------
+  
+  ## overload default method since we need to "up-out" of the
+  
+  def xml_change_description( xml )
+    unit = xml.parent.xpath('ancestor::unit')[0]
+    Nokogiri::XML::Builder.with( unit ){ |x| 
+      xml_set_or_delete( x, 'description', @should[:description] )
+    }
+  end
+  
+  ## ----------------------------------------------------------------
+  ## :vlan_tagging
+  ## ----------------------------------------------------------------
+  
+  def xml_change_vlan_tagging( xml )
+    port_mode = should_trunk? ? 'trunk' : 'access'
+    xml.send(:'interface-mode', port_mode )
+  
+    # when the vlan_tagging value changes then this method
+    # will trigger updates to the untagged_vlan and tagged_vlans
+    # resource values as well.
+    # !!! DO NOT SWAP THIS ORDER untagged processing *MUST* BE FIRST!
+    
+    upd_untagged_vlan( xml )
+    upd_tagged_vlans( xml ) 
+        
+    return true
+  end  
+  
+  def set_ifd_trunking( xml, should_trunk )
+   par = xml.instance_variable_get(:@parent)     
+   Nokogiri::XML::Builder.with( par.at_xpath( 'ancestor::interface' )) do |dot|
+     if should_trunk
+       dot.send( :'flexible-vlan-tagging' )
+       dot.send( :'encapsulation', 'flexible-ethernet-services' )
+     else
+       dot.send( :'flexible-vlan-tagging', Netconf::JunosConfig::DELETE )
+       dot.send( :'encapsulation', Netconf::JunosConfig::DELETE )
+     end
+   end       
+end 
+  
+  ## ----------------------------------------------------------------
+  ## :tagged_vlans
+  ## ----------------------------------------------------------------
+  
+  def xml_change_tagged_vlans( xml )  
+    return false if mode_changed?  
+    upd_tagged_vlans( xml )
+  end
+  
+  def upd_tagged_vlans( xml )
+    return false unless should_trunk?
+    
+    @should[:tagged_vlans] = @should[:tagged_vlans].to_set if @should[:tagged_vlans].kind_of? Array
+    @has[:tagged_vlans] = @has[:tagged_vlans].to_set if @has[:tagged_vlans].kind_of? Array    
+    
+    v_should = @should[:tagged_vlans] || Set.new    
+    v_has = @has[:tagged_vlans] || Set.new  
+      
+    del = v_has - v_should
+    add = v_should - v_has 
+    
+    del_under_vlans = del & @under_vlans    
+    unless del_under_vlans.empty?
+      del = del ^ @under_vlans
+      _xml_rm_under_vlans( xml, del_under_vlans )
+      @under_vlans = []
+    end
+    
+    if add or del
+      del.each{|v| xml.send(:'vlan-id-list', _vlan_name_to_tag_id( v ), Netconf::JunosConfig::DELETE)}
+      add.each{|v| xml.send( :'vlan-id-list', _vlan_name_to_tag_id(v) )}
+    end
+    return true    
+  end    
+  
+  ## ----------------------------------------------------------------  
+  ## :untagged_vlan
+  ## ----------------------------------------------------------------  
+  
+  def xml_change_untagged_vlan( xml ) 
+    return false if mode_changed?         
+    upd_untagged_vlan( xml )
+  end  
+  
+  def upd_untagged_vlan( xml )
+    self.class.change_untagged_vlan( self, xml )
+  end    
+  
+end
+
+##### ---------------------------------------------------------------
+##### Class methods for handling state-transitions between
+##### configurations (tagged/untagged)
+##### ---------------------------------------------------------------
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+    
+  # creating some class definitions ...
+  # this is a bit complicated because we need to handle port-mode
+  # change transitions; basically dealing with the fact that
+  # trunk ports use 'native-vlan-id' and access ports have a
+  # vlan member definition; i.e. they don't use native-vlan-id, ugh.
+  # Rather than doing all this logic as if/then/else statements,
+  # I've opted to using a proc jump-table technique.  Lessons
+  # learned from lots of embedded systems programming :-)    
+    
+  def self.init_jump_table
+    
+    # auto-hash table, majik!
+    hash = Hash.new(&(p=lambda{|h,k| h[k] = Hash.new(&p)}))
+    
+    # ------------------------------------------------------------------
+    # -   jump table for handling various untagged vlan change use-cases      
+    # ------------------------------------------------------------------      
+    # There are three criteria for selection:  
+    # | is_trunk | will_trunk | no_untg |
+    # ------------------------------------------------------------------
+    
+    # - will not have untagged vlan 
+    hash[false][false][true] = self.method(:ac_ac_nountg)
+    hash[false][true][true] = self.method(:ac_tr_nountg)
+    hash[true][false][true] = self.method(:tr_ac_nountg)
+    hash[true][true][true] = self.method(:tr_tr_nountg)
+    
+    # - will have untagged vlan 
+    hash[false][false][false] = self.method(:ac_ac_untg)
+    hash[false][true][false] = self.method(:ac_tr_untg)
+    hash[true][false][false] = self.method(:tr_ac_untg)
+    hash[true][true][false] = self.method(:tr_tr_untg)
+    
+    hash
+  end
+    
+  ### invoke the correct method from the jump table
+  ### based on the three criteria to select the action
+  
+  def self.change_untagged_vlan( this, xml )
+    @@ez_l2_jmptbl ||= init_jump_table 
+    proc = @@ez_l2_jmptbl[this.is_trunk?][this.should_trunk?][this.should[:untagged_vlan].nil?]
+    proc.call( this, xml )
+  end
+
+  ### -------------------------------------------------------------
+  ### The following are all the change transition functions for
+  ### each of the use-cases
+  ### -------------------------------------------------------------
+  
+  def self.ac_ac_nountg( this, xml )
+     #NetdevJunos::Log.debug "ac_ac_nountg"
+     # @@@ a port *MUST* be assigned to a vlan in access mode on MX.
+     # @@@ generate an error!
+     raise Junos::Ez::NoProviderError, "a port *MUST* be assigned to a vlan in access mode on MX."
+  end
+
+  def self.ac_tr_nountg( this, xml ) 
+    #no action needed handled already
+  end
+  
+  def self.tr_ac_nountg( this, xml )
+     # @@@ a port *MUST* be assigned to a vlan in access mode on MX.
+     # @@@ generate an error!
+     raise Junos::Ez::NoProviderError, "a port *MUST* be assigned to vlan in access mode on MX"
+  end
+  
+  def self.tr_tr_nountg( this, xml )
+    this._delete_native_vlan_id( xml )  
+  end
+  
+  ## ----------------------------------------------------------------
+  ## transition where port WILL-HAVE untagged-vlan
+  ## ----------------------------------------------------------------
+  
+  def self.ac_ac_untg( this, xml )
+    vlan_id = this._vlan_name_to_tag_id( this.should[:untagged_vlan] )
+    xml.send :'vlan-id', vlan_id 
+  end
+      
+  def self.ac_tr_untg( this, xml )    
+    was_untg_vlan = this.has[:untagged_vlan]
+    this._set_native_vlan_id( xml, this.should[:untagged_vlan] )
+    this._xml_rm_ac_untagged_vlan( xml ) if was_untg_vlan   
+  end   
+   
+  def self.tr_ac_untg( this, xml ) 
+    this._delete_native_vlan_id( xml )
+    vlan_id = this._vlan_name_to_tag_id( this.should[:untagged_vlan] )
+    xml.send( :'vlan-id', vlan_id )
+  end
+  
+  def self.tr_tr_untg( this, xml )
+    this._set_native_vlan_id(xml, this.should[:untagged_vlan])
+  end
+ 
+end
+
+##### ---------------------------------------------------------------
+##### Provider collection methods
+##### ---------------------------------------------------------------
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+  
+  def build_list
+    begin
+      got = @ndev.rpc.get_bridge_instance_information( :brief => true)
+    rescue => e
+      # in this case, no ethernet-switching is enabled so return empty list
+      return []
+    end   
+    got.xpath('//l2iff-interface-name').collect{ |ifn| ifn.text.split('.')[0] }
+  end
+  
+  def build_catalog
+    @catalog = {}    
+    return @catalog if list!.empty?
+    list.each do |ifs_name|
+      @ndev.rpc.get_configuration{ |xml|
+        xml.interfaces {
+          xml_at_element_top( xml, ifs_name )
+        }
+      }.xpath('interfaces/interface').each do |ifs_xml|
+        @catalog[ifs_name] = {}
+        unit = xml_get_has_xml( ifs_xml )
+        xml_read_parser( unit, @catalog[ifs_name] )
+      end
+    end    
+    
+    @catalog
+  end
+  
+end
+
+##### ---------------------------------------------------------------
+#####               !!!!! PRIVATE METHODS !!!!
+##### ---------------------------------------------------------------
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+  private
+  
+  def _get_eth_port_vlans_h( ifs_name )
+    got = @ndev.rpc.get_bridge_instance_information(:interface => ifs_name)
+    ret_h = {:untagged => nil, :tagged => Set.new }
+    got.xpath('//l2ng-l2ald-iff-interface-entry').each do |vlan|
+      # one of the node-set elements (the first one?) contains the interface name.
+      # this doesn't have any VLAN information, so skip it.
+      next if vlan.xpath('l2iff-interface-name')
+      
+      vlan_name = vlan.xpath('//l2rtb-bridge-vlan').text.strip 
+      if vlan.xpath('//l2rtb-interface-vlan-member-tagness')
+        tgdy = vlan.xpath('//l2rtb-interface-vlan-member-tagness').text.strip
+        if tgdy == 'untagged'
+          ret_h[:untagged] = vlan_name
+        else
+          ret_h[:tagged] << vlan_name
+        end      
+      else
+        ret_h[:tagged]<<vlan_name       
+      end         
+    end
+    ret_h
+  end
+end
+
+### ---------------------------------------------------------------
+### [edit vlans] - for interfaces configured here ...
+### ---------------------------------------------------------------
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+  
+    def _xml_edit_under_vlans( xml ) 
+    Nokogiri::XML::Builder.with( xml.doc.root ) do |dot|
+      dot.send(:'vlan-id'){
+        return dot
+      }
+    end      
+  end
+  
+  def _xml_rm_under_vlans( xml, vlans )
+    if vlans.any?
+      at_vlans = _xml_edit_under_vlans( xml )
+      vlans.each do |vlan_id|
+        Nokogiri::XML::Builder.with( at_vlans.parent ) do |this|
+          this.domain {
+            this.vlan_id vlan_id
+            this.interface( Netconf::JunosConfig::DELETE ) { this.name @name }
+          }
+        end
+      end
+    end    
+  end
+  
+  def _xml_rm_ac_untagged_vlan( xml )
+    if @under_vlans.empty?
+      xml.send :'vlan-id', Netconf::JunosConfig::DELETE    
+    else
+      _xml_rm_under_vlans( xml, [ @has[:untagged_vlan ] ] )
+      @under_vlans = []    
+    end
+  end
+  
+  def _xml_rm_these_vlans( xml, vlans )
+    if @under_vlans.empty?
+      xml.send :'vlan-id', ( Netconf::JunosConfig::DELETE ) 
+    else
+      # could be a mix between [edit vlans] and [edit interfaces] ...
+      v_has = vlans.to_set
+      del_under_vlans = v_has & @under_vlans
+      _xml_rm_under_vlans( xml, del_under_vlans )
+      if v_has ^ @under_vlans
+        xml.send :'vlan-id', ( Netconf::JunosConfig::DELETE ) 
+      end
+      @under_vlans = []        
+    end
+  end
+  
+end
+
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+    
+  def _vlan_name_to_tag_id( vlan_name )
+    tag_id = @ndev.rpc.get_configuration { |xml|
+      xml.send(:'bridge-domains') { xml.domain { xml.name vlan_name }}
+    }.xpath('//vlan-id').text.chomp
+    raise ArgumentError, "VLAN '#{vlan_name}' not found" if tag_id.empty?
+    return tag_id
+  end
+  
+
+  def _vlan_tag_id_to_name( vlan_id )
+    tag_name = @ndev.rpc.get_configuration { |xml|
+      xml.send(:'bridge-domains') { xml.domain { xml.send(:'vlan-id', vlan_id)}}
+    }.xpath('//name').text.chomp
+    raise ArgumentError, "VLAN '#{vlan_id}' not found" if tag_name.empty?
+    return tag_name
+  end
+ 
+
+end
+
+class Junos::Ez::L2ports::Provider::BRIDGE_DOMAIN
+  def _at_native_vlan_id( xml )
+    ifd
+  end
+  
+  def _delete_native_vlan_id( xml )
+    Nokogiri::XML::Builder.with( @ifd ) do |dot|
+      dot.send :'native-vlan-id', Netconf::JunosConfig::DELETE
+    end
+    return true
+  end
+  
+  def _set_native_vlan_id( xml, vlan_name )
+    Nokogiri::XML::Builder.with( @ifd ) do |dot|
+      dot.send :'native-vlan-id', _vlan_name_to_tag_id( vlan_name )
+      xml.send( :'vlan-id-list', _vlan_name_to_tag_id( vlan_name) )
+    end    
+    return true
+  end
+  
+ 
+end