shopify-cli 2.7.0 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4cce33ea79f749e3dc6e18d724ac5e584f887971224119f6e8ea61ade325798d
-  data.tar.gz: 3ae9563de4ea7eb1eaf3e51a03e71fba509ca9249c35e9be8d1311e952ddf577
+  metadata.gz: '068a38773a84e132b2b1dd435d4e369a2100d2fca4cccb539699e6033f816fb7'
+  data.tar.gz: d4f356f9f4bf9f0e43733da4f223f7e02917d8c29e4193c90eb276ac80a73c5b
 SHA512:
-  metadata.gz: f5e46c8fa4c9eeb026d7e7b451a53886338a32ea084153f541eda085a6a3bb6cf5247831498b0dcc960c9079e7eaf3906662965c32e17f2dfd31a47113343674
-  data.tar.gz: 46df1b135b1d37618560a00fb8121291ddf9d63f0e35c2c33abfdcf3decb2b9d0fb3380c99726cedab37bd4b01627ac4a3df51869312f82bbfd5ebeb43d9b6a3
+  metadata.gz: a163a0878650fbf8c846fa9d510240c3b4f938a621e14558a63788ce56e63a8fe39e6254ef4cc83107cd6b241d2d66e2fe935cd207d47a88c20182ceb7d59d5c
+  data.tar.gz: db35b09603e3ccb0c7a526da096a76663b4ab5f952cb37e1bde4b71fba3509d87c3e8626929e8d20e316a4c04097d3430da98e252b9634d5a0e53586b06ec2a9

data/.github/CODEOWNERS

@@ -1,5 +1,5 @@
 *       @shopify/core-build-learn
 *       @shopify/development-lifecycle
 
-/lib/project_types/script/ @shopify/scripts-experience
-/test/project_types/script/ @shopify/scripts-experience
+/lib/project_types/script/ @shopify/scripts-platform
+/test/project_types/script/ @shopify/scripts-platform

data/.github/workflows/shopify.yml

@@ -19,7 +19,7 @@ jobs:
         version:
           - 3.0.2
           - 2.6.6
-          - 2.7.1
+          - 2.7.5
         os:
           - macos-10.15
           - macos-11

data/.gitignore

@@ -21,4 +21,6 @@ packaging/rpm/build
 packaging/rpm/shopify-cli.spec
 .byebug_history
 ext/shopify-extensions/shopify-extensions
+ext/javy/bin
 .console_history
+TODO.md

data/.ruby-version

@@ -1 +1 @@
-2.7.1
+2.7.5

data/CHANGELOG.md

@@ -1,6 +1,52 @@
 From version 2.6.0, the sections in this file adhere to the [keep a changelog](https://keepachangelog.com/en/1.0.0/) specification.
+
 ## [Unreleased]
 
+## Version 2.7.4
+### Added
+* [#1825](https://github.com/Shopify/shopify-cli/pull/1825): Support passing the connection information through arguments
+
+### Fixed
+* [#1852](https://github.com/Shopify/shopify-cli/pull/1852): Fix `shopify --help` to include `extension` commands
+* [#1853](https://github.com/Shopify/shopify-cli/pull/1853): Fix javy installation failures from MacOS universal ruby installations
+* [#1851](https://github.com/Shopify/shopify-cli/pull/1851): Improve `shopify theme push --live` confirmation message to show current live theme
+* [#1850](https://github.com/Shopify/shopify-cli/pull/1850): Fix `shopify extension` commands timeout when organization has too many apps
+* [#1860](https://github.com/Shopify/shopify-cli/pull/1860): Fix `theme serve` hot reload when there are many tabs active
+
+## Version 2.7.3
+### Added
+* [#1826](https://github.com/Shopify/shopify-cli/pull/1826): Support using `script.config.yml` file for script configuration
+* [#1843](https://github.com/Shopify/shopify-cli/pull/1826): Support using javy on Apple ARM processors
+* [#1847](https://github.com/Shopify/shopify-cli/pull/1847): `shopify script connect` command.
+
+### Fixed
+* [#1811](https://github.com/Shopify/shopify-cli/pull/1811): Update theme-check to 1.9.0
+* [#1831](https://github.com/Shopify/shopify-cli/pull/1831): Ensure correct `ngrok` version is downloaded for Apple M1
+* [#1823](https://github.com/Shopify/shopify-cli/pull/1823): Indicate git is unavailable; don't error out
+* [#1807](https://github.com/Shopify/shopify-cli/pull/1807): Fix `--live` parameter, it should not imply `--allow-live` in the `theme push` command
+* [#1812](https://github.com/Shopify/shopify-cli/pull/1812): App creation with Rails 7
+* [#1821](https://github.com/Shopify/shopify-cli/pull/1821): Fix Shopify hosted fonts to load via the local preview URL
+* [#1830](https://github.com/Shopify/shopify-cli/pull/1830): Fix hot reload when users update many files "simultaneously"
+* [#1837](https://github.com/Shopify/shopify-cli/pull/1837): Fix `ShopifyCLI::Theme::DevServer::CdnFonts` class to support any font
+
+## Version 2.7.2
+### Fixed
+* [#1763](https://github.com/Shopify/shopify-cli/pull/1763): Fix: Tunnel --PORT parameter not working in Node.js app.
+* [#1769](https://github.com/Shopify/shopify-cli/pull/1769): Fix `theme push --development --json` to output the proper exit code
+* [#1766](https://github.com/Shopify/shopify-cli/pull/1766): Fix `theme serve` failing with the `--host` property
+* [#1771](https://github.com/Shopify/shopify-cli/pull/1771): Fix `theme push --development --json` to output errors in the STDERR
+* [#1778](https://github.com/Shopify/shopify-cli/pull/1778): Fix ngrok installation check on Windows 
+* [#1798](https://github.com/Shopify/shopify-cli/pull/1798): Add `--live` option to the `theme pull` and the `theme push` commands
+* [#1788](https://github.com/Shopify/shopify-cli/pull/1788): Improve `theme serve` errors and add logs for successful operations
+* [#1794](https://github.com/Shopify/shopify-cli/pull/1794): Fix bug where hidden subcommands appear in the help menu.
+
+## Version 2.7.1
+### Fixed
+* [#1722](https://github.com/Shopify/shopify-cli/pull/1722): Fix `theme serve` failing when the port is already being used
+* [#1751](https://github.com/Shopify/shopify-cli/pull/1751): A bug in the app creation flow that caused the CLI to abort when the form validation failed.
+* [#1750](https://github.com/Shopify/shopify-cli/pull/1750): Runtime errors in Windows' environments when the `PATHEXT` environment variable is not defined. 
+* [#1758](https://github.com/Shopify/shopify-cli/pull/1758): Fix tunnel creation for expired anonymous tunnels
+
 ## Version 2.7.0
 ### Changed
 * [#1650](https://github.com/Shopify/shopify-cli/pull/1650): **Breaking** Move app commands under `shopify app`.

data/Codespace.dockerfile

@@ -1,7 +1,7 @@
 # This is a Docker image to test the CLI in UNIX environments other than macOS
 # Build the image: docker build . -t shopify-cli
 # Run tests: docker run -t --rm --volume "$(pwd):/usr/src/app" shopify-cli bundle exec rake test
-FROM cimg/ruby:2.7.1
+FROM cimg/ruby:2.7.5
 
 RUN git config --global user.email "development-lifecycle@shopify.com"
 RUN git config --global user.name "Development Lifecycle"
@@ -29,7 +29,7 @@ RUN sudo apt-get install -y nodejs
 RUN sudo npm install --global yarn
 
 # Python is necessary to compile NPM packages with native extensions through node-gyp
-RUN sudo apt install python-minimal -y
+RUN sudo apt install python2-minimal -y
 
 # Install sqlite3
 RUN sudo apt-get install libsqlite3-dev -y

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    shopify-cli (2.7.0)
+    shopify-cli (2.7.4)
       bugsnag (~> 6.22)
       listen (~> 3.7.0)
-      theme-check (~> 1.8.0)
+      theme-check (~> 1.9.0)
 
 GEM
   remote: https://rubygems.org/
@@ -81,7 +81,7 @@ GEM
       mini_portile2 (~> 2.6.1)
       racc (~> 1.4)
     parallel (1.21.0)
-    parser (3.0.2.0)
+    parser (3.0.3.1)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
@@ -119,7 +119,7 @@ GEM
     ruby-progressbar (1.11.0)
     sys-uname (1.2.2)
       ffi (~> 1.1)
-    theme-check (1.8.0)
+    theme-check (1.9.0)
       liquid (>= 5.1.0)
       nokogiri (>= 1.12)
       parser (~> 3)

data/Rakefile

@@ -146,6 +146,33 @@ namespace :extensions do
   end
 end
 
+namespace :scripts do
+  namespace :javy do
+    task :symlink do
+      source = Paths.root("..", "javy", "target", "release", "javy")
+      error("Unable to find javy executable: #{executable}") unless File.executable?(source)
+      target = Paths.javy("javy")
+      File.delete(target) if File.exist?(target)
+      File.symlink(source, target)
+    end
+
+    task :install do
+      require_relative Paths.javy("javy.rb")
+      Javy.install
+    end
+
+    module Paths
+      def self.javy(*args)
+        root("ext", "javy", *args)
+      end
+
+      def self.root(*args)
+        Pathname(File.dirname(__FILE__)).join(*args).to_s
+      end
+    end
+  end
+end
+
 def error(message, output: STDERR, code: 1)
   output.puts(message)
   exit(code)

data/Tests.dockerfile

@@ -1,7 +1,7 @@
 # This is a Docker image to test the CLI in UNIX environments other than macOS
 # Build the image: docker build . -t shopify-cli
 # Run tests: docker run -t --rm --volume "$(pwd):/usr/src/app" shopify-cli bundle exec rake test
-FROM cimg/ruby:2.7.1
+FROM cimg/ruby:2.7.5
 
 RUN git config --global user.email "development-lifecycle@shopify.com"
 RUN git config --global user.name "Development Lifecycle"
@@ -29,7 +29,7 @@ RUN sudo apt-get install -y nodejs
 RUN sudo npm install --global yarn
 
 # Python is necessary to compile NPM packages with native extensions through node-gyp
-RUN sudo apt install python-minimal -y
+RUN sudo apt install python2-minimal -y
 
 # Install sqlite3
 RUN sudo apt-get install libsqlite3-dev -y

data/dev.yml

@@ -6,12 +6,12 @@ env:
   SHOPIFY_CLI_DEVELOPMENT: "1"
 
 up:
-  - ruby: 2.7.1
+  - ruby: 2.7.5
   - homebrew:
       - dpkg:
-          version: 1.20.9
+          version: 1.21.1
       - rpm:
-          version: 4.16.1.3
+          version: 4.17.0
   - bundler
   - docker
 

data/ext/javy/hashes/javy-arm-macos-v0.1.0.gz.sha256

@@ -0,0 +1 @@
+16e1a74c06eff6e5be79253a8ee96a08a404e95be3479a6e384c8926bb736e43

data/ext/javy/hashes/javy-x86_64-linux-v0.1.0.gz.sha256

@@ -0,0 +1 @@
+53cb9d0e8a345d68f91512a28a7d2eab93463dc8650c7a044f03cbee1f7cac05

data/ext/javy/hashes/javy-x86_64-macos-v0.1.0.gz.sha256

@@ -0,0 +1 @@
+5e1ca88385206a653980139ab969efd80de11fd9b298dafe450d3ac27d6d0173

data/ext/javy/hashes/javy-x86_64-windows-v0.1.0.gz.sha256

@@ -0,0 +1 @@
+37f9b3f75b4ffca68b06656d6f90abfbac57597ee45fffb59b3a559b6b5de44e

data/ext/javy/javy.rb

@@ -0,0 +1,204 @@
+require "open-uri"
+require "zlib"
+require "open3"
+require "digest/sha2"
+
+module Javy
+  ROOT = __dir__
+  BIN_FOLDER = File.join(ROOT, "bin")
+  HASH_FOLDER = File.join(ROOT, "hashes")
+  VERSION = File.read(File.join(ROOT, "version")).strip
+  TARGET = File.join(BIN_FOLDER, "javy-#{VERSION}")
+
+  class << self
+    def install
+      ShopifyCLI::Result
+        .wrap { Installer.call(target: target, platform: platform, version: VERSION) }
+        .call
+    end
+
+    def build(source:, dest: nil)
+      optional_args = []
+      optional_args += ["-o", dest] unless dest.nil?
+
+      ShopifyCLI::Result
+        .wrap { ensure_installed }
+        .call
+        .then { exec(source, *optional_args) }
+    end
+
+    private
+
+    def exec(*args, **kwargs)
+      out_and_err, stat = CLI::Kit::System.capture2e(target, *args, **kwargs)
+      raise ExecutionError, out_and_err unless stat.success?
+      true
+    end
+
+    def platform
+      Platform.new
+    end
+
+    def target
+      platform.format_executable_path(TARGET)
+    end
+
+    def ensure_installed
+      delete_outdated_installations
+      install.unwrap { |e| raise e } unless Installer.installed?(target: target)
+      true
+    end
+
+    def delete_outdated_installations
+      installed_binaries
+        .reject { |v| v == target }
+        .each { |file| File.delete(file) }
+    end
+
+    def installed_binaries
+      Dir[File.join(BIN_FOLDER, "javy-*")]
+    end
+
+    module Installer
+      def self.call(target:, platform:, version:)
+        asset = Asset.new(
+          platform: platform,
+          version: version,
+          owner: "Shopify",
+          repository: "javy",
+          basename: "javy"
+        )
+
+        downloaded = asset.download(target: target)
+        raise InstallationError.asset_not_found(platform: platform, version: version, url: asset.url) unless downloaded
+
+        true
+      end
+
+      def self.installed?(target:)
+        File.executable?(target)
+      end
+    end
+  end
+
+  class Error < RuntimeError; end
+  class ExecutionError < Error; end
+
+  class InstallationError < Error
+    def self.cpu_unsupported
+      new("Javy is not supported on this CPU")
+    end
+
+    def self.asset_not_found(platform:, version:, url:)
+      new(format(
+        "Unable to download javy %{version} for %{os} (%{cpu}) at %{url}",
+        version: version,
+        os: platform.os,
+        cpu: platform.cpu,
+        url: url
+      ))
+    end
+
+    def self.invalid_binary
+      new("Invalid Javy binary downloaded.")
+    end
+  end
+
+  Asset = Struct.new(:platform, :version, :owner, :repository, :basename, keyword_init: true) do
+    def download(target:)
+      FileUtils.mkdir_p(BIN_FOLDER)
+
+      source_file = url.open
+      validate_sha!(source_file)
+      source_file.seek(0)
+
+      Dir.chdir(File.dirname(target)) do
+        File.open(File.basename(target), "wb") do |target_file|
+          decompress(source_file, target_file)
+        end
+
+        File.chmod(0755, target)
+      end
+
+      true
+    rescue OpenURI::HTTPError
+      false
+    end
+
+    def url
+      URI.parse(format(
+        "https://github.com/%{owner}/%{repository}/releases/download/%{version}/%{filename}",
+        owner: owner,
+        repository: repository,
+        version: version,
+        filename: filename
+      ))
+    end
+
+    def filename
+      format(
+        "%{basename}-%{cpu}-%{os}-%{version}.gz",
+        basename: basename,
+        cpu: platform.cpu,
+        os: platform.os,
+        version: version
+      )
+    end
+
+    private
+
+    def decompress(source, target)
+      zlib = Zlib::GzipReader.new(source)
+      target << zlib.read
+    ensure
+      zlib.close
+    end
+
+    def validate_sha!(source)
+      generated_hash = Digest::SHA256.hexdigest(source.read).strip
+      expected_hash = File.read(File.join(HASH_FOLDER, "#{filename}.sha256")).strip
+      raise InstallationError.invalid_binary unless generated_hash == expected_hash
+    end
+  end
+
+  Platform = Struct.new(:ruby_platform) do
+    def initialize(ruby_platform = RUBY_PLATFORM)
+      super(ruby_platform)
+    end
+
+    def to_s
+      format("%{cpu}-%{os}", cpu: cpu, os: os)
+    end
+
+    def os
+      case ruby_platform
+      when /linux/
+        "linux"
+      when /darwin/
+        "macos"
+      else
+        "windows"
+      end
+    end
+
+    def cpu
+      case ruby_platform
+      when /x64/, /x86_64/
+        "x86_64"
+      when /arm/
+        "arm"
+      else
+        raise InstallationError.cpu_unsupported
+      end
+    end
+
+    def format_executable_path(path)
+      case os
+      when "windows"
+        File.extname(path) != ".exe" ? path + ".exe" : path
+      else
+        path
+      end
+    end
+  end
+end

data/ext/javy/version

@@ -0,0 +1 @@
+v0.1.0

data/lib/graphql/get_extension_registrations.graphql

@@ -0,0 +1,27 @@
+query GetExtensionRegistrations($api_key: String!, $type: String) {
+  app(apiKey: $api_key) {
+    id
+    title
+    apiKey
+    apiSecretKeys{
+      secret
+    }
+    appType
+    extensionRegistrations(specificationIdentifier: $type) {
+      id
+      type
+      uuid
+      title
+      draftVersion {
+        registrationId
+        context
+        lastUserInteractionAt
+        location
+        validationErrors { field message }
+        id
+        uuid
+        versionTag
+      }
+    }
+  }
+}

data/lib/project_types/extension/cli.rb

@@ -13,7 +13,6 @@ module Extension
   end
 
   class Command < ShopifyCLI::Command::ProjectCommand
-    hidden_feature
     autoload :ExtensionCommand, Project.project_filepath("commands/extension_command")
 
     subcommand :Create, "create", Project.project_filepath("commands/create")
@@ -41,7 +40,6 @@ module Extension
     autoload :FindNpmPackages, Project.project_filepath("tasks/find_npm_packages")
     autoload :GetExtensions, Project.project_filepath("tasks/get_extensions")
     autoload :GetProduct, Project.project_filepath("tasks/get_product")
-    autoload :RunExtensionCommand, Project.project_filepath("tasks/run_extension_command")
     autoload :MergeServerConfig, Project.project_filepath("tasks/merge_server_config")
     autoload :FindPackageFromJson, Project.project_filepath("tasks/find_package_from_json.rb")
     autoload :EnsureResourceUrl, Project.project_filepath("tasks/ensure_resource_url.rb")
@@ -53,6 +51,28 @@ module Extension
       autoload :ValidationErrorConverter, Project.project_filepath("tasks/converters/validation_error_converter")
       autoload :AppConverter, Project.project_filepath("tasks/converters/app_converter")
       autoload :ProductConverter, Project.project_filepath("tasks/converters/product_converter")
+      autoload :ExecuteCommands, Project.project_filepath("cli/execute_commands")
+    end
+
+    module ExecuteCommands
+      autoload :Base, Project.project_filepath("tasks/execute_commands/base")
+      autoload :Build, Project.project_filepath("tasks/execute_commands/build")
+      autoload :Create, Project.project_filepath("tasks/execute_commands/create")
+      autoload :Serve, Project.project_filepath("tasks/execute_commands/serve")
+
+      class << self
+        def build(*args)
+          Build.new(*args).call
+        end
+
+        def create(*args)
+          Create.new(*args).call
+        end
+
+        def serve(*args)
+          Serve.new(*args).call
+        end
+      end
     end
   end
 
@@ -121,4 +141,9 @@ module Extension
   autoload :ExtensionProjectKeys, Project.project_filepath("extension_project_keys")
   autoload :ExtensionProject, Project.project_filepath("extension_project")
   autoload :Errors, Project.project_filepath("errors")
+
+  module Loaders
+    autoload :Project, Extension::Project.project_filepath("loaders/project")
+    autoload :SpecificationHandler, Extension::Project.project_filepath("loaders/specification_handler")
+  end
 end

data/lib/project_types/extension/commands/build.rb

@@ -24,20 +24,16 @@ module Extension
       private
 
       def run_new_flow(project)
-        Tasks::RunExtensionCommand.new(
-          type: project.specification_identifier.downcase,
-          command: "build",
-          config_file_name: specification_handler.server_config_file,
-        ).call
-
-        @ctx.puts(@ctx.message("build.build_success_message"))
-      rescue => error
-        if error.message.include?("no such file or directory")
-          @ctx.abort(@ctx.message("build.directory_not_found"))
-        else
-          @ctx.debug(error)
-          @ctx.abort(@ctx.message("build.build_failure_message"))
-        end
+        Tasks::ExecuteCommands
+          .build(
+            context: @ctx,
+            config_file_path: specification_handler.server_config_path,
+            type: project.specification_identifier.downcase
+          )
+          .then { |output| @ctx.puts(output) }
+          .unwrap do |error|
+            raise ShopifyCLI::Abort, error.message unless error.nil?
+          end
       end
 
       def run_legacy_flow

data/lib/project_types/extension/commands/create.rb

@@ -3,9 +3,7 @@
 module Extension
   class Command
     class Create < ShopifyCLI::Command::SubCommand
-      unless ShopifyCLI::Environment.acceptance_test?
-        prerequisite_task :ensure_authenticated
-      end
+      prerequisite_task :ensure_authenticated
 
       options do |parser, flags|
         parser.on("--name=NAME") { |name| flags[:name] = name }
@@ -55,12 +53,11 @@ module Extension
       end
 
       def use_new_create_flow(form)
-        Tasks::RunExtensionCommand.new(
+        Tasks::ExecuteCommands.create(
           root_dir: form.directory_name,
           template: form.template,
           type: form.type.identifier.downcase,
-          command: "create"
-        ).call
+        )
         @ctx.chdir(form.directory_name)
         write_env_file(form)
       rescue => error

data/lib/project_types/extension/commands/push.rb

@@ -3,17 +3,40 @@ require "shopify_cli"
 
 module Extension
   class Command
-    class Push < ExtensionCommand
+    class Push < ShopifyCLI::Command::SubCommand
       prerequisite_task ensure_project_type: :extension
 
+      options do |parser, flags|
+        parser.on("--api-key=API_KEY") { |api_key| flags[:api_key] = api_key.gsub('"', "") }
+        parser.on("--api-secret=API_SECRET") { |api_secret| flags[:api_secret] = api_secret.gsub('"', "") }
+        parser.on("--registration-id=REGISTRATION_ID") do |registration_id|
+          flags[:registration_id] = registration_id.gsub('"', "")
+        end
+      end
+
       TIME_DISPLAY_FORMAT = "%B %d, %Y %H:%M:%S %Z"
 
       def call(args, name)
-        Command::Register.new(@ctx).call(args, name) unless project.registered?
+        project = Extension::Loaders::Project.load(
+          context: @ctx,
+          directory: Dir.pwd,
+          api_key: options.flags[:api_key],
+          api_secret: options.flags[:api_secret],
+          registration_id: options.flags[:registration_id]
+        )
+        specification_handler = Extension::Loaders::SpecificationHandler.load(project: project, context: @ctx)
+        register_if_necessary(project: project, args: args, name: name)
+
         Command::Build.new(@ctx).call(args, name) unless specification_handler.specification.options[:skip_build]
         CLI::UI::Frame.open(@ctx.message("push.frame_title")) do
-          updated_draft_version = update_draft
-          show_message(updated_draft_version)
+          updated_draft_version = update_draft(project: project, specification_handler: specification_handler)
+          show_message(updated_draft_version, project: project)
+        end
+      end
+
+      def register_if_necessary(project:, args:, name:)
+        if @ctx.tty? && !project.registered?
+          Command::Register.new(@ctx).call(args, name)
         end
       end
 
@@ -23,11 +46,16 @@ module Extension
 
       private
 
-      def show_message(draft)
-        draft.validation_errors.empty? ? output_success_messages(draft) : output_validation_errors(draft)
+      def show_message(draft, project:)
+        if draft.validation_errors.empty?
+          output_success_messages(draft,
+            project: project)
+        else
+          output_validation_errors(draft)
+        end
       end
 
-      def output_success_messages(draft)
+      def output_success_messages(draft, project:)
         @ctx.puts(@ctx.message("push.success_confirmation", project.title, format_time(draft.last_user_interaction_at)))
         @ctx.puts(@ctx.message("push.success_info", draft.location))
       end
@@ -51,7 +79,7 @@ module Extension
         yield
       end
 
-      def update_draft
+      def update_draft(project:, specification_handler:)
         with_waiting_text do
           Tasks::UpdateDraft.call(
             context: @ctx,

data/lib/project_types/extension/extension_project.rb

@@ -74,7 +74,7 @@ module Extension
     end
 
     def registered?
-      property_present?("api_key") && property_present?("secret") && registration_id?
+      registration_id?
     end
 
     def title