shopify-cli 2.15.6 → 2.17.0

data/lib/shopify_cli/theme/dev_server/hot_reload/sections_index.rb

@@ -14,13 +14,12 @@ module ShopifyCLI
 
             files.each do |file|
               section_hash(file).each do |key, value|
-                name = key
-                type = value&.dig("type")
-
-                next if !name || !type
+                next unless key
+                next unless value.is_a?(Hash)
+                next unless (type = value&.dig("type"))
 
                 index[type] = [] unless index[type]
-                index[type] << name
+                index[type] << key
               end
             end
 
@@ -42,7 +41,7 @@ module ShopifyCLI
           end
 
           def files
-            @theme.json_files
+            @theme.json_files.filter(&:template?)
           end
         end
       end

data/lib/shopify_cli/theme/dev_server/local_assets.rb

@@ -44,7 +44,7 @@ module ShopifyCLI
 
         def serve_file(path_info)
           path = @theme.root.join(path_info[1..-1])
-          if path.file? && path.readable? && @theme.theme_file?(path)
+          if path.file? && path.readable? && @theme.static_asset_file?(path)
             [
               200,
               {

data/lib/shopify_cli/theme/dev_server/watcher.rb

@@ -14,7 +14,8 @@ module ShopifyCLI
           @theme = theme
           @syncer = syncer
           @ignore_filter = ignore_filter
-          @listener = Listen.to(@theme.root, force_polling: poll) do |modified, added, removed|
+          @listener = Listen.to(@theme.root, force_polling: poll,
+            ignore: @ignore_filter&.regexes) do |modified, added, removed|
             changed
             notify_observers(modified, added, removed)
           end

data/lib/shopify_cli/theme/dev_server.rb

@@ -32,7 +32,7 @@ module ShopifyCLI
           theme = DevelopmentTheme.find_or_create!(ctx, root: root)
           ignore_filter = IgnoreFilter.from_path(root)
           @syncer = Syncer.new(ctx, theme: theme, ignore_filter: ignore_filter, overwrite_json: !editor_sync)
-          watcher = Watcher.new(ctx, theme: theme, syncer: @syncer, poll: poll)
+          watcher = Watcher.new(ctx, theme: theme, ignore_filter: ignore_filter, syncer: @syncer, poll: poll)
           remote_watcher = RemoteWatcher.to(theme: theme, syncer: @syncer)
 
           # Setup the middleware stack. Mimics Rack::Builder / config.ru, but in reverse order

data/lib/shopify_cli/theme/development_theme.rb

@@ -79,13 +79,23 @@ module ShopifyCLI
 
         theme_name = "Development ()"
         hostname_character_limit = API_NAME_LIMIT - theme_name.length - hash.length - 1
-        identifier = "#{hash}-#{hostname[0, hostname_character_limit]}"
+        identifier = encode_identifier("#{hash}-#{hostname[0, hostname_character_limit]}")
         theme_name = "Development (#{identifier})"
 
         ShopifyCLI::DB.set(development_theme_name: theme_name)
 
         theme_name
       end
+
+      ##
+      # In some cases, the identifier string encoding may be obfuscated by the hostname,
+      # which may be an ASCII string.
+      #
+      # This method ensures the result identifier is a UTF-8 valid string.
+      #
+      def encode_identifier(identifier)
+        identifier.encode(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "-")
+      end
     end
   end
 end

data/lib/shopify_cli/theme/file.rb

@@ -30,6 +30,15 @@ module ShopifyCLI
         else
           path.write(content, 0, mode: "wb")
         end
+      rescue Encoding::UndefinedConversionError
+        ##
+        # The CLI tries to write the file and normalize EOL characters to avoid
+        # errors on Windows when files are shared across different operational systems.
+        #
+        # The CLI fallbacks any error during the conversion by writing the file
+        # in binary mode when the normalization fails (e.g., ASCII files), so no data is lost.
+        #
+        path.write(content, 0, mode: "wb")
       end
 
       def delete

data/lib/shopify_cli/theme/theme.rb

@@ -47,6 +47,10 @@ module ShopifyCLI
         theme_files.include?(self[file])
       end
 
+      def static_asset_file?(file)
+        static_asset_files.include?(self[file])
+      end
+
       def static_asset_paths
         static_asset_files.map(&:relative_path)
       end

data/lib/shopify_cli/theme/theme_admin_api.rb

@@ -53,8 +53,10 @@ module ShopifyCLI
         # * when an asset operation cannot be performed:
         #   - <APIRequestForbiddenError: 403 {"message":"templates/gift_card.liquid could not be deleted"}>
         #
-        if empty_response?(error) || unauthorized_response?(error)
+        if empty_response?(error)
           return permission_error
+        elsif unauthorized_response?(error)
+          raise ShopifyCLI::Abort, @ctx.message("theme.unauthorized_error", @shop)
         end
 
         raise error

data/lib/shopify_cli/version.rb

@@ -1,3 +1,3 @@
 module ShopifyCLI
-  VERSION = "2.15.6"
+  VERSION = "2.17.0"
 end

data/shopify-cli.gemspec

@@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib", "vendor"]
   spec.executables << "shopify"
 
-  spec.add_development_dependency("bundler", "~> 2.3.8")
+  spec.add_development_dependency("bundler", "~> 2.3.11")
   spec.add_development_dependency("rake", "~> 12.3", ">= 12.3.3")
   spec.add_development_dependency("minitest", "~> 5.0")
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shopify-cli
 version: !ruby/object:Gem::Version
-  version: 2.15.6
+  version: 2.17.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-12 00:00:00.000000000 Z
+date: 2022-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.8
+        version: 2.3.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.8
+        version: 2.3.11
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -192,6 +192,7 @@ files:
 - lib/graphql/extension_update_draft.graphql
 - lib/graphql/fetch_specifications.graphql
 - lib/graphql/find_organization.graphql
+- lib/graphql/find_organization_with_apps.graphql
 - lib/graphql/get_app_by_api_key.graphql
 - lib/graphql/get_app_urls.graphql
 - lib/graphql/get_extension_registrations.graphql
@@ -243,6 +244,7 @@ files:
 - lib/project_types/extension/models/registration.rb
 - lib/project_types/extension/models/server_config/app.rb
 - lib/project_types/extension/models/server_config/base.rb
+- lib/project_types/extension/models/server_config/capabilities.rb
 - lib/project_types/extension/models/server_config/development.rb
 - lib/project_types/extension/models/server_config/development_entries.rb
 - lib/project_types/extension/models/server_config/development_renderer.rb
@@ -275,6 +277,7 @@ files:
 - lib/project_types/extension/tasks/execute_commands/base.rb
 - lib/project_types/extension/tasks/execute_commands/build.rb
 - lib/project_types/extension/tasks/execute_commands/create.rb
+- lib/project_types/extension/tasks/execute_commands/outdated_extension_detection.rb
 - lib/project_types/extension/tasks/execute_commands/serve.rb
 - lib/project_types/extension/tasks/fetch_specifications.rb
 - lib/project_types/extension/tasks/find_npm_packages.rb
@@ -318,6 +321,7 @@ files:
 - lib/project_types/script/layers/application/extension_points.rb
 - lib/project_types/script/layers/application/project_dependencies.rb
 - lib/project_types/script/layers/application/push_script.rb
+- lib/project_types/script/layers/domain/app_bridge.rb
 - lib/project_types/script/layers/domain/errors.rb
 - lib/project_types/script/layers/domain/extension_point.rb
 - lib/project_types/script/layers/domain/metadata.rb
@@ -538,7 +542,7 @@ files:
 - lib/shopify_cli/tunnel.rb
 - lib/shopify_cli/utilities.rb
 - lib/shopify_cli/version.rb
-- shipit.yml
+- shipit.rubygems.yml
 - shopify-cli.gemspec
 - shopify-dev
 - utilities/constants.rb