shopify-cli 2.12.0 → 2.15.0

data/lib/project_types/theme/commands/common/root_helper.rb

@@ -15,15 +15,16 @@ module Theme
 
           while next_index < argv.size
             element = argv[next_index]
-            option = option_by_key[element]
+            key, value = key_value_tuple(element)
+            option = option_by_key[key]
 
             return element if option.nil?
 
             # Skip the option argument
-            next_index += 1 unless option.arg.nil?
+            next_index += 1 if !option.arg.nil? && !value
 
             # PATTERN arguments take precedence over the `root`
-            if option.arg =~ /PATTERN/
+            if option.arg =~ /PATTERN/ && !value
               next_index += 1 while option_argument?(argv, next_index, option_by_key)
               next
             end
@@ -37,7 +38,7 @@ module Theme
         private
 
         def default_argv(options)
-          options.parser.default_argv
+          options.parser.default_argv.compact
         end
 
         def options_map(options)
@@ -57,7 +58,12 @@ module Theme
           return false unless next_index < argv.size
 
           element = argv[next_index]
-          option_by_key[element].nil?
+          key, _value = key_value_tuple(element)
+          option_by_key[key].nil?
+        end
+
+        def key_value_tuple(element)
+          element.split("=")
         end
       end
     end

data/lib/project_types/theme/commands/list.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require "shopify_cli/theme/theme"
+require "project_types/theme/presenters/themes_presenter"
+
+module Theme
+  class Command
+    class List < ShopifyCLI::Command::SubCommand
+      recommend_default_ruby_range
+
+      def call(_args, _name)
+        @ctx.puts(@ctx.message("theme.list.title", shop))
+
+        themes_presenter.all.each do |theme|
+          @ctx.puts("  #{theme}")
+        end
+      end
+
+      def self.help
+        @ctx.message("theme.list.help", ShopifyCLI::TOOL_NAME, ShopifyCLI::TOOL_NAME)
+      end
+
+      private
+
+      def themes_presenter
+        Theme::Presenters::ThemesPresenter.new(@ctx, nil)
+      end
+
+      def shop
+        ShopifyCLI::AdminAPI.get_shop_or_abort(@ctx)
+      end
+    end
+  end
+end

data/lib/project_types/theme/commands/open.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require "shopify_cli/theme/theme"
+require "shopify_cli/theme/development_theme"
+
+module Theme
+  class Command
+    class Open < ShopifyCLI::Command::SubCommand
+      recommend_default_ruby_range
+
+      options do |parser, flags|
+        parser.on("-t", "--theme=NAME_OR_ID") { |theme| flags[:theme] = theme }
+        parser.on("-l", "--live") { flags[:live] = true }
+        parser.on("-d", "--development") { flags[:development] = true }
+      end
+
+      def call(_args, _name)
+        theme = find_theme(**options.flags)
+
+        @ctx.puts(@ctx.message("theme.open.details", theme.name, theme.editor_url))
+        @ctx.open_url!(theme.preview_url)
+      end
+
+      def self.help
+        ShopifyCLI::Context.message("theme.open.help", ShopifyCLI::TOOL_NAME, ShopifyCLI::TOOL_NAME)
+      end
+
+      def find_theme(theme: nil, live: nil, development: nil, **_args)
+        return theme_by_identifier(theme) if theme
+        return live_theme if live
+        return development_theme if development
+
+        select_theme
+      end
+
+      def theme_by_identifier(identifier)
+        theme = ShopifyCLI::Theme::Theme.find_by_identifier(@ctx, identifier: identifier)
+        theme || not_found_error(identifier)
+      end
+
+      def development_theme
+        theme = ShopifyCLI::Theme::DevelopmentTheme.find(@ctx)
+        theme || not_found_error("development")
+      end
+
+      def live_theme
+        ShopifyCLI::Theme::Theme.live(@ctx)
+      end
+
+      def not_found_error(identifier)
+        @ctx.abort(@ctx.message("theme.open.theme_not_found", identifier))
+      end
+
+      def select_theme
+        form = Forms::Select.ask(
+          @ctx,
+          [],
+          title: @ctx.message("theme.open.select"),
+          root: nil
+        )
+        form&.theme
+      end
+    end
+  end
+end

data/lib/project_types/theme/commands/package.rb

@@ -15,6 +15,7 @@ module Theme
         sections
         snippets
         templates
+        release-notes.md
       ]
 
       def call(args, _name)

data/lib/project_types/theme/commands/pull.rb

@@ -26,11 +26,11 @@ module Theme
         parser.on("-d", "--development") { flags[:development] = true }
         parser.on("-o", "--only=PATTERN", Conversions::IncludeGlob) do |pattern|
           flags[:includes] ||= []
-          flags[:includes] += pattern
+          flags[:includes] |= pattern
         end
         parser.on("-x", "--ignore=PATTERN", Conversions::IgnoreGlob) do |pattern|
           flags[:ignores] ||= []
-          flags[:ignores] += pattern
+          flags[:ignores] |= pattern
         end
       end
 
@@ -45,8 +45,8 @@ module Theme
         ignore_filter.add_patterns(options.flags[:ignores]) if options.flags[:ignores]
 
         syncer = ShopifyCLI::Theme::Syncer.new(@ctx, theme: theme,
-                                               include_filter: include_filter,
-                                               ignore_filter: ignore_filter)
+          include_filter: include_filter,
+          ignore_filter: ignore_filter)
         begin
           syncer.start_threads
           CLI::UI::Frame.open(@ctx.message("theme.pull.pulling", theme.name, theme.id, theme.shop)) do

data/lib/project_types/theme/commands/push.rb

@@ -30,11 +30,11 @@ module Theme
         parser.on("-p", "--publish") { flags[:publish] = true }
         parser.on("-o", "--only=PATTERN", Conversions::IncludeGlob) do |pattern|
           flags[:includes] ||= []
-          flags[:includes] += pattern
+          flags[:includes] |= pattern
         end
         parser.on("-x", "--ignore=PATTERN", Conversions::IgnoreGlob) do |pattern|
           flags[:ignores] ||= []
-          flags[:ignores] += pattern
+          flags[:ignores] |= pattern
         end
       end
 
@@ -55,8 +55,8 @@ module Theme
         ignore_filter.add_patterns(options.flags[:ignores]) if options.flags[:ignores]
 
         syncer = ShopifyCLI::Theme::Syncer.new(@ctx, theme: theme,
-                                               include_filter: include_filter,
-                                               ignore_filter: ignore_filter)
+          include_filter: include_filter,
+          ignore_filter: ignore_filter)
         begin
           syncer.start_threads
           if options.flags[:json]

data/lib/project_types/theme/conversions/base_glob.rb

@@ -10,8 +10,22 @@ module Theme
 
         def convert(parser)
           argv = parser.default_argv
-          option_index = argv.index { |v| options.include?(v) }
+          values = []
+
+          option_indexes(argv).each do |option_index|
+            values += option_values(argv, parser, option_index)
+          end
+
+          values
+        end
+
+        def options
+          raise "`#{self.class.name}#options` must be defined"
+        end
+
+        private
 
+        def option_values(argv, parser, option_index)
           return [] if option_index.nil?
 
           start_index = option_index + 1
@@ -26,12 +40,13 @@ module Theme
           values
         end
 
-        def options
-          raise "`#{self.class.name}#options` must be defined"
+        def option_indexes(argv)
+          argv
+            .each_with_index
+            .select { |item, _index| options.include?(item) }
+            .map(&:last)
         end
 
-        private
-
         def options_map(parser)
           map = {}
           parser.top.list.each do |option|

data/lib/project_types/theme/forms/select.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require "project_types/theme/presenters/themes_presenter"
+
 module Theme
   module Forms
     class Select < ShopifyCLI::Form
@@ -6,53 +10,21 @@ module Theme
 
       def ask
         self.theme = CLI::UI::Prompt.ask(title, allow_empty: false) do |handler|
-          themes.each do |theme|
+          theme_presenters.each do |presenter|
+            theme = presenter.theme
+
             next if exclude_roles&.include?(theme.role)
             next if !include_foreign_developments && theme.foreign_development?
-            handler.option("#{theme.name} #{theme_tags(theme)}") { theme }
+
+            handler.option(presenter.to_s(:short)) { theme }
           end
         end
       end
 
       private
 
-      def themes
-        @themes ||= ShopifyCLI::Theme::Theme.all(@ctx, root: root)
-          .sort_by { |theme| theme_sort_order(theme) }
-      end
-
-      def theme_sort_order(theme)
-        case theme.role
-        when "live"
-          0
-        when "unpublished"
-          1
-        when "development"
-          2
-        else
-          3
-        end
-      end
-
-      def theme_tags(theme)
-        color = case theme.role
-        when "live"
-          "green"
-        when "unpublished"
-          "yellow"
-        when "development"
-          "blue"
-        else
-          "italic"
-        end
-
-        tags = ["{{#{color}:[#{theme.role}]}}"]
-
-        if theme.current_development?
-          tags << "{{cyan:[yours]}}}}"
-        end
-
-        tags.join(" ")
+      def theme_presenters
+        Theme::Presenters::ThemesPresenter.new(ctx, root).all
       end
     end
   end

data/lib/project_types/theme/messages/messages.rb

@@ -7,6 +7,8 @@ module Theme
           Suite of commands for developing Shopify themes. See {{command:%1$s theme <command> --help}} for usage of each command.
             Usage: {{command:%1$s theme [ %2$s ]}}
         HELP
+        ensure_user_error: "You are not authorized to edit themes on %s.",
+        ensure_user_try_this: "Make sure you are a user of that store, and allowed to edit themes.",
 
         init: {
           help: <<~HELP,
@@ -87,7 +89,7 @@ module Theme
               {{info:View your theme:}}
               {{underline:%s}}
 
-              {{info:Customize this theme in the Online Store Editor:}}
+              {{info:Customize this theme in the Theme Editor:}}
               {{underline:%s}}
           DONE
           name: "Theme name",
@@ -130,7 +132,7 @@ module Theme
           SERVING
           customize_or_preview: <<~CUSTOMIZE_OR_PREVIEW,
 
-            Customize this theme in the Online Store Editor:
+            Customize this theme in the Theme Editor:
             {{green:%s}}
 
             Share this theme preview:
@@ -215,6 +217,35 @@ module Theme
           WARN
           theme_not_found: "Theme \"%s\" doesn't exist",
         },
+        open: {
+          select: "Select a theme to open",
+          theme_not_found: "Theme \"%s\" doesn't exist",
+          details: <<~DETAILS,
+            {{*}} {{bold:%s}}
+
+            Customize your theme in the Theme Editor:
+            {{green:%s}}
+
+          DETAILS
+          help: <<~HELP,
+            {{command:%s theme open}}: Opens the preview of your remote theme.
+
+            Usage: {{command:%s theme open}}
+
+            Options:
+              {{command:-t, --theme=NAME_OR_ID}} Theme ID or name of your theme.
+              {{command:-l, --live}}             Open your live theme.
+              {{command:-d, --development}}      Open your development theme.
+          HELP
+        },
+        list: {
+          title: "{{*}} List of {{bold:%s}} themes:",
+          help: <<~HELP,
+            {{command:%s theme list}}: Lists your remote themes.
+
+            Usage: {{command:%s theme list}}
+          HELP
+        },
       },
     }.freeze
   end

data/lib/project_types/theme/presenters/theme_presenter.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "forwardable"
+
+module Theme
+  module Presenters
+    class ThemePresenter
+      extend Forwardable
+
+      COLOR_BY_ROLE = {
+        "live" => "green",
+        "unpublished" => "yellow",
+        "development" => "blue",
+      }
+
+      attr_reader :theme
+
+      def_delegators :theme, :id, :name, :role
+
+      def initialize(theme)
+        @theme = theme
+      end
+
+      def to_s(mode = :long)
+        case mode
+        when :short
+          "{{bold:#{name} #{theme_tags}}}"
+        when :long
+          "{{green:##{id}}} {{bold:#{name} #{theme_tags}}}"
+        else
+          inspect
+        end
+      end
+
+      private
+
+      def theme_tags
+        tags = ["{{#{tag_color}:[#{role}]}}"]
+        tags << "{{cyan:[yours]}}}}" if theme.current_development?
+        tags.join(" ")
+      end
+
+      def tag_color
+        COLOR_BY_ROLE[role] || "italic"
+      end
+    end
+  end
+end

data/lib/project_types/theme/presenters/themes_presenter.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require_relative "theme_presenter"
+
+module Theme
+  module Presenters
+    class ThemesPresenter
+      ORDER_BY_ROLE = %w(live unpublished development)
+
+      def initialize(ctx, root)
+        @ctx = ctx
+        @root = root
+      end
+
+      def all
+        all_themes
+          .sort_by { |theme| order_by_role(theme) }
+          .map { |theme| ThemePresenter.new(theme) }
+      end
+
+      private
+
+      def order_by_role(theme)
+        ORDER_BY_ROLE.index(theme.role) || ORDER_BY_ROLE.size
+      end
+
+      def all_themes
+        ShopifyCLI::Theme::Theme.all(@ctx, root: @root)
+      end
+    end
+  end
+end

data/lib/shopify_cli/api.rb

@@ -85,7 +85,7 @@ module ShopifyCLI
         end
       rescue Errno::ETIMEDOUT, Timeout::Error
         ctx.debug("timeout in #{method} #{uri} with X-Request-Id: #{headers["X-Request-Id"]}")
-        raise APIRequestTimeoutError.new("Timeout")
+        raise APIRequestTimeoutError, "Timeout"
       end.retry_after(APIRequestRetriableError, retries: 3) do |e|
         sleep(1) if e.is_a?(APIRequestThrottledError)
       end

data/lib/shopify_cli/command.rb

@@ -102,16 +102,10 @@ module ShopifyCLI
       def check_node_version
         return unless @compatible_node_range
 
-        context = Context.new
-        if context.which("node").nil?
-          raise ShopifyCLI::Abort, context.message("core.errors.missing_node")
-        end
-
         check_version(
           Environment.node_version,
           range: @compatible_node_range,
-          runtime: "Node",
-          context: context
+          runtime: "Node"
         )
       end
 

data/lib/shopify_cli/commands/app/deploy.rb

@@ -2,7 +2,6 @@ module ShopifyCLI
   module Commands
     class App
       class Deploy < ShopifyCLI::Command::AppSubCommand
-        subcommand :Heroku, "heroku", "shopify_cli/commands/app/deploy/heroku"
         prerequisite_task :ensure_git_dependency
 
         recommend_default_ruby_range

data/lib/shopify_cli/constants.rb

@@ -61,12 +61,12 @@ module ShopifyCLI
     module SupportedVersions
       module Ruby
         FROM = "2.6.6"
-        TO = "3.1.0"
+        TO = "3.2.0"
       end
 
       module Node
         FROM = "14.5.0"
-        TO = "17.0.0"
+        TO = "18.0.0"
       end
     end
 

data/lib/shopify_cli/context.rb

@@ -103,7 +103,7 @@ module ShopifyCLI
     # any command run by the context.
     attr_accessor :env
 
-    def initialize(root: Dir.pwd, env: ($original_env || ENV).clone) # :nodoc:
+    def initialize(root: Dir.pwd, env: ($original_env || ENV).to_h) # :nodoc:
       self.root = root
       self.env = env
     end
@@ -164,7 +164,7 @@ module ShopifyCLI
 
     # will return true while tests are running, either locally or on CI
     def testing?
-      ci? || ENV["TEST"]
+      ci? || ENV["SHOPIFY_CLI_TEST"]
     end
 
     ##
@@ -570,21 +570,19 @@ module ShopifyCLI
       trap("INFO", "DEFAULT")
 
       fork do
-        begin
-          r, w = IO.pipe
+        r, w = IO.pipe
+        @signal = false
+        trap("SIGINFO") do
+          @signal = true
+          w.write(0)
+        end
+        while r.read(1)
+          next unless @signal
           @signal = false
-          trap("SIGINFO") do
-            @signal = true
-            w.write(0)
-          end
-          while r.read(1)
-            next unless @signal
-            @signal = false
-            yield
-          end
-        rescue Interrupt
-          exit(0)
+          yield
         end
+      rescue Interrupt
+        exit(0)
       end
     end
 

data/lib/shopify_cli/core/entry_point.rb

@@ -5,7 +5,7 @@ module ShopifyCLI
     module EntryPoint
       class << self
         def call(args, ctx = Context.new)
-          if ctx.development?
+          if ctx.development? && !ctx.testing?
             ctx.warn(
               ctx.message("core.warning.development_version", File.join(ShopifyCLI::ROOT, "bin", ShopifyCLI::TOOL_NAME))
             )

data/lib/shopify_cli/core/monorail.rb

@@ -17,11 +17,7 @@ module ShopifyCLI
 
         def log(name, args, &block) # rubocop:disable Lint/UnusedMethodArgument
           command, command_name = Commands::Registry.lookup_command(name)
-          final_command = [command_name]
-          if command
-            subcommand, subcommand_name = command.subcommand_registry.lookup_command(args.first)
-            final_command << subcommand_name if subcommand
-          end
+          full_command = self.full_command(command, args, resolved_command: [command_name])
 
           start_time = now_in_milliseconds
           err = nil
@@ -35,9 +31,21 @@ module ShopifyCLI
             # If there's an error, we don't prompt from here and we let the exception
             # reporter do that.
             if report?(prompt: err.nil?)
-              send_event(start_time, final_command, args - final_command, err&.message)
+              send_event(start_time, full_command, args - full_command, err&.message)
+            end
+          end
+        end
+
+        def full_command(command, args, resolved_command:)
+          resolved_command = resolved_command.dup
+          if command
+            subcommand, subcommand_name = command.subcommand_registry.lookup_command(args.first)
+            resolved_command << subcommand_name if subcommand
+            if subcommand&.subcommand_registry
+              resolved_command = full_command(subcommand, args.drop(1), resolved_command: resolved_command)
             end
           end
+          resolved_command
         end
 
         private

data/lib/shopify_cli/environment.rb

@@ -12,23 +12,31 @@ module ShopifyCLI
     ]
 
     def self.ruby_version(context: Context.new)
-      out, err, stat = context.capture3('ruby -e "puts RUBY_VERSION"')
-      raise ShopifyCLI::Abort, err unless stat.success?
-      out = out.gsub('"', "")
-      ::Semantic::Version.new(out.chomp)
+      output, status = context.capture2e("ruby", "--version")
+      raise ShopifyCLI::Abort, context.message("core.errors.missing_ruby") unless status.success?
+      version = output.match(/ruby (\d+\.\d+\.\d+)/)[1]
+      ::Semantic::Version.new(version)
     end
 
     def self.node_version(context: Context.new)
-      out, err, stat = context.capture3("node", "--version")
-      raise ShopifyCLI::Abort, err unless stat.success?
-      out = out.gsub("v", "")
-      ::Semantic::Version.new(out.chomp)
+      output, status = context.capture2e("node", "--version")
+      raise ShopifyCLI::Abort, context.message("core.errors.missing_node") unless status.success?
+      version = output.match(/v(\d+\.\d+\.\d+)/)[1]
+      ::Semantic::Version.new(version)
     end
 
     def self.npm_version(context: Context.new)
-      out, err, stat = context.capture3("npm", "--version")
-      raise ShopifyCLI::Abort, err unless stat.success?
-      ::Semantic::Version.new(out.chomp)
+      output, status = context.capture2e("npm", "--version")
+      raise ShopifyCLI::Abort, context.message("core.errors.missing_npm") unless status.success?
+      version = output.match(/(\d+\.\d+\.\d+)/)[1]
+      ::Semantic::Version.new(version)
+    end
+
+    def self.rails_version(context: Context.new)
+      output, status = context.capture2e("rails", "--version")
+      context.abort(context.message("core.app.create.rails.error.install_failure", "rails")) unless status.success?
+      version = output.match(/Rails (\d+\.\d+\.\d+)/)[1]
+      ::Semantic::Version.new(version)
     end
 
     def self.interactive=(interactive)

data/lib/shopify_cli/exception_reporter.rb

@@ -46,6 +46,8 @@ module ShopifyCLI
       Bugsnag.notify(error) do |event|
         event.add_metadata(:device, metadata)
       end
+    rescue
+      nil
     end
 
     def self.report?(context:)