shopify-cli 2.11.0 → 2.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9944385de970a522f54fcf4e8feffa5bcab8ad61498095a1794c5abcf5918063
-  data.tar.gz: 62b23eb1ab82cf0783ccab14d77b55c3e71595d87581795fff19227c4bcada57
+  metadata.gz: ee0786bedc79f0e7fb3646adc5161faeb0fb2f4f15c6147394782db33236f425
+  data.tar.gz: 13d805804c7764151bfdd80747e879bd480ffcf85ba91fa280b776b93f784855
 SHA512:
-  metadata.gz: 72ec8ee4a02bb2b7cd6f9d58c094625bba0e1971a1d2e81d86920e8b326ff8fb52bac73b2a7afec43f7e67991b239bd7ac11c43a2df70790ecd82cf6c4614db2
-  data.tar.gz: e456bb338bfa6102cf8643455b983a147a0fdef6fb820a5ee46dd210e6cbde788de6053727c48ab44057a7ad920a8b765651bfd09a26735b4db8525dc6f247b1
+  metadata.gz: 8347252541e765517a6bc485cc7bc1b811771a55610543549d676d5321944185e9a446bed4c8a3909f21f336fd56ae76b91ede2e3731f30ea66c0916d1a3e591
+  data.tar.gz: 930367d81adf351b66aa7365daaf9f4406067db80a4959409e68ddd5ab7041ed10db4f983f81d1af3d8f2457b8d79543cbf33c927e69bfbde027a31da4b166a8

data/CHANGELOG.md

@@ -2,8 +2,36 @@ From version 2.6.0, the sections in this file adhere to the [keep a changelog](h
 
 ## [Unreleased]
 
-## Version 2.11.0
+## Version 2.12.0
+### Added
+* [#1866](https://github.com/Shopify/shopify-cli/pull/1866): Enforce git dependency
+* [#2009](https://github.com/Shopify/shopify-cli/pull/2009): Add localization support for Checkout Extensions
+* [#2060](https://github.com/Shopify/shopify-cli/pull/2060): Improve CLI error messages for token-based auth (scripts)
+* [#2076](https://github.com/Shopify/shopify-cli/pull/2076): Release Wasm Script Projects
+* [#2051](https://github.com/Shopify/shopify-cli/pull/2051): Update `theme serve` to accept `root` argument
+* [#2025](https://github.com/Shopify/shopify-cli/pull/2025): Improve `theme pull`/`push` help messages to indicate multiple `--only`/`--ignore` flags are allowed.
 
+### Fixed
+* [#2030](https://github.com/Shopify/shopify-cli/pull/2030): Fix Theme::Syncer handling of file deletions in `download_file!`
+* [#2071](https://github.com/Shopify/shopify-cli/pull/2071): Fix `theme pull` error message when dev theme doesn't exist
+* [#2066](https://github.com/Shopify/shopify-cli/pull/2066): Improve `--only`/`--ignore` parameters on Theme `pull`/`push` commands to work without quotes
+* [#2078](https://github.com/Shopify/shopify-cli/pull/2078): Fix errors on section rendering caused by CORS issues
+
+## Version 2.11.2
+### Fixed
+* [#2047](https://github.com/Shopify/shopify-cli/pull/2047): Fix the Homebrew installation
+* [#2019](https://github.com/Shopify/shopify-cli/pull/2019): Provide helpful link when nokogiri fails to load
+* [#2055](https://github.com/Shopify/shopify-cli/pull/2055): Remove unneeded Node requirements
+* [#2020](https://github.com/Shopify/shopify-cli/pull/2020): Fix `theme pull` so that correct dev theme is used with `-d` option
+
+## Version 2.11.1
+### Fixed
+* [#1973](https://github.com/Shopify/shopify-cli/pull/1973): Fix `theme serve` to preview generated files (`*.css.liquid`)
+* [#2034](https://github.com/Shopify/shopify-cli/pull/2034): Fix `theme serve` to accept parameters with multiple values
+* [#2033](https://github.com/Shopify/shopify-cli/pull/2033): Pin Homebrew Ruby to 3.0
+* [#2032](https://github.com/Shopify/shopify-cli/pull/2032): Runtime error checking the Node version if Node is not present in the environment.
+
+## Version 2.11.0
 ### Fixed
 * [#2005](https://github.com/Shopify/shopify-cli/pull/2005): Fix PHP app serve on Windows environments
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shopify-cli (2.11.0)
+    shopify-cli (2.12.0)
       bugsnag (~> 6.22)
       listen (~> 3.7.0)
       theme-check (~> 1.9.0)

data/bin/shopify

@@ -14,6 +14,19 @@ module Kernel
     raise if name == "#{RUBY_VERSION[/\d+\.\d+/]}/psych.so"
     # Special case for ffi, which rescues this itself
     raise if name == "#{RUBY_VERSION.split(".")[0, 2].join(".")}/ffi_c"
+    # Special case for nokogiri, which might install the wrong architecture
+    if name == "nokogiri/nokogiri"
+      STDERR.puts(<<~MESSAGE)
+        The Nokogiri gem is failing to load, due to an installation or architecture issue.
+
+        To fix this, reinstall Nokogiri.
+
+        • Installation guide: https://nokogiri.org/tutorials/installing_nokogiri.html
+
+      MESSAGE
+      STDERR.puts e.full_message
+      exit(1)
+    end
     STDERR.puts "[Note] You cannot use gems with Shopify CLI."
     STDERR.puts "[LoadError] #{e.message}"
     if ENV["DEBUG"]

data/docs/users/installation.md

@@ -1,46 +1,3 @@
 # Installation
 
-## Installation through RubyGems
-
-The easiest method to install the Shopify CLI is through RubyGems:
-
-```shell
-$ gem install shopify-cli
-```
-
-## Installation for macOS Users
-
-- Make sure you have [Homebrew](https://brew.sh/) installed
-- Open your terminal app
-- Run `brew tap shopify/shopify`
-- Run `brew install shopify-cli`
-- After the installation is completed, run `shopify version`, if this outputs a version number you've successfully installed the CLI.
-
-### To upgrade Shopify CLI
-
-#### Homebrew (Mac OS)
-
-```shell
-$ brew update
-$ brew upgrade shopify-cli
-```
-
-## Installation for Debian and Ubuntu users through `apt`
-
-1.- Download the latest `.deb` binary for Shopify CLI from the releases page.
-
-2.- Install the downloaded file and make sure to replace /path/to/download/shopify-cli-x.y.z.deb with the path to your file's location:
-
-```shell
-$ sudo apt install /path/to/downloaded/shopify-cli-x.y.z.deb
-```
-
-## Installation for CentOS 8+, Fedora, Red Hat, and SUSE users through `yum`
-
-1.- Download the latest .rpm file for Shopify App CLI from the releases page.
-
-2.- Install the downloaded file and make sure to replace /path/to/downloaded/shopify-cli-x.y.x.rpm with the path to your file's location:
-
-```shell
- $ sudo yum install /path/to/downloaded/shopify-cli-x.y.x.rpm
-```
+The installation guide can be found here: https://shopify.dev/apps/tools/cli/installation

data/lib/project_types/extension/commands/build.rb

@@ -8,9 +8,6 @@ module Extension
 
       prerequisite_task ensure_project_type: :extension
 
-      recommend_default_node_range
-      recommend_default_ruby_range
-
       YARN_BUILD_COMMAND = %w(build)
       NPM_BUILD_COMMAND = %w(run-script build)
 

data/lib/project_types/extension/commands/check.rb

@@ -4,7 +4,6 @@ require "theme_check"
 module Extension
   class Command
     class Check < ExtensionCommand
-      recommend_default_node_range
       recommend_default_ruby_range
 
       class CheckOptions < ShopifyCLI::Options

data/lib/project_types/extension/commands/create.rb

@@ -5,7 +5,6 @@ module Extension
     class Create < ShopifyCLI::Command::SubCommand
       prerequisite_task :ensure_authenticated
 
-      recommend_default_node_range
       recommend_default_ruby_range
 
       options do |parser, flags|

data/lib/project_types/extension/commands/push.rb

@@ -6,7 +6,6 @@ module Extension
     class Push < ShopifyCLI::Command::SubCommand
       prerequisite_task ensure_project_type: :extension
 
-      recommend_default_node_range
       recommend_default_ruby_range
 
       options do |parser, flags|
@@ -27,6 +26,10 @@ module Extension
           api_secret: options.flags[:api_secret],
           registration_id: options.flags[:registration_id]
         )
+        # on ci, registration id must be present
+        registration_id = options.flags[:registration_id]
+        check_registration(registration_id: registration_id, context: @ctx)
+
         specification_handler = Extension::Loaders::SpecificationHandler.load(project: project, context: @ctx)
         register_if_necessary(project: project, args: args, name: name)
 
@@ -43,6 +46,15 @@ module Extension
         end
       end
 
+      def check_registration(registration_id:, context:)
+        if !ShopifyCLI::Environment.interactive? && (!registration_id || registration_id.empty?)
+          message = context.message("errors.missing_push_options_ci", "--registration-id")
+          message += context.message("errors.missing_push_options_ci_solution", ShopifyCLI::TOOL_NAME)
+          raise ShopifyCLI::Abort,
+            message
+        end
+      end
+
       def self.help
         ShopifyCLI::Context.new.message("push.help", ShopifyCLI::TOOL_NAME)
       end

data/lib/project_types/extension/commands/serve.rb

@@ -5,7 +5,6 @@ module Extension
     class Serve < ExtensionCommand
       prerequisite_task ensure_project_type: :extension
 
-      recommend_default_node_range
       recommend_default_ruby_range
 
       DEFAULT_PORT = 39351

data/lib/project_types/extension/loaders/project.rb

@@ -9,20 +9,40 @@ module Extension
           "SHOPIFY_API_SECRET" => api_secret,
           "EXTENSION_ID" => registration_id,
         }.compact
-        env =
-          begin
-            ShopifyCLI::Resources::EnvFile.read(directory, overrides: env_overrides)
-          rescue Errno::ENOENT
-            ShopifyCLI::Resources::EnvFile.from_hash(env_overrides)
-          end
+        env_file_present = env_file_exists?(directory)
+        env = if env_file_present
+          ShopifyCLI::Resources::EnvFile.read(directory, overrides: env_overrides)
+        else
+          ShopifyCLI::Resources::EnvFile.from_hash(env_overrides)
+        end
         # This is a somewhat uncomfortable hack we use because `Project::at` is
         # a global cache and we can't rely on this class loading the project
         # first. Long-term we should move away from that global cache.
         project = ExtensionProject.at(directory)
         project.env = env
         project
-      rescue SmartProperties::InitializationError, SmartProperties::MissingValueError
-        context.abort(context.message("errors.missing_api_key"))
+      rescue SmartProperties::InitializationError, SmartProperties::MissingValueError => error
+        handle_error(error, context: context)
+      end
+
+      def self.handle_error(error, context:)
+        if ShopifyCLI::Environment.interactive?
+          properties_hash = { api_key: "SHOPIFY_API_KEY", secret: "SHOPIFY_API_SECRET" }
+          missing_env_variables = error.properties.map { |p| properties_hash[p.name] }.compact.join(", ")
+          message = context.message("errors.missing_env_file_variables", missing_env_variables)
+          message += context.message("errors.missing_env_file_variables_solution", ShopifyCLI::TOOL_NAME)
+        else
+          properties_hash = { api_key: "--api-key", secret: "--api-secret" }
+          missing_options = error.properties.map { |p| properties_hash[p.name] }.compact.join(", ")
+          message = context.message("errors.missing_push_options_ci", missing_options)
+          message += context.message("errors.missing_push_options_ci_solution", ShopifyCLI::TOOL_NAME)
+        end
+        raise ShopifyCLI::Abort,
+          message
+      end
+
+      def self.env_file_exists?(directory)
+        File.exist?(ShopifyCLI::Resources::EnvFile.path(directory))
       end
     end
   end

data/lib/project_types/extension/messages/messages.rb

@@ -174,9 +174,17 @@ module Extension
         },
       },
       errors: {
-        unknown_type: "Unknown extension type %s",
+        unknown_type: "Unknown extension type %s. Valid extension types include: CHECKOUT_POST_PURCHASE, " \
+        "CHECKOUT_UI_EXTENSION, THEME_APP_EXTENSION, and PRODUCT_SUBSCRIPTION.",
         package_not_found: "`%s` package not found.",
-        missing_api_key: "Missing api_key.",
+        missing_push_options_ci: "The following are missing: %s. ",
+        missing_push_options_ci_solution: "To add them to a CI environment:\n\t1. Run a connect command " \
+        "({{command:%1$s extension connect}})\n\t2. Navigate to the .env file at the root of your project\n\t" \
+            "3. Copy the missing values and pass them through as arguments in {{command:%1$s extension push}}",
+        missing_env_file_variables: "The following are missing in the .env file: %s. ",
+        missing_env_file_variables_solution: "To add it, connect your extension with " \
+        "{{command:%1$s extension connect}} " \
+        "or run {{command:%1$s extension register}} to register a new extension.",
         module_not_found: "Unable to find module %s. Ensure your dependencies are up-to-date and try again.",
       },
       warnings: {

data/lib/project_types/extension/models/specification_handlers/checkout_ui_extension.rb

@@ -4,12 +4,24 @@ module Extension
   module Models
     module SpecificationHandlers
       class CheckoutUiExtension < Default
+        L10N_ERROR_PREFIX = "core.extension.push.checkout_ui_extension.localization.error"
+        L10N_FILE_SIZE_LIMIT = 16 * 1024 # 16kb
+        L10N_BUNDLE_SIZE_LIMIT = 256 * 1024 # 256kb
+        LOCALE_CODE_FORMAT = %r{
+          \A
+          (?<language>[a-zA-Z]{2,3}) # Language tag
+          (?:
+           -
+           (?<region>[a-zA-Z]{2}) # Optional region subtag
+          )?
+          \z}x
         PERMITTED_CONFIG_KEYS = [:extension_points, :metafields, :name]
 
         def config(context)
           {
             **Features::ArgoConfig.parse_yaml(context, PERMITTED_CONFIG_KEYS),
             **argo.config(context, include_renderer_version: false),
+            **localization(context),
           }
         end
 
@@ -22,6 +34,108 @@ module Extension
           return unless product
           format("/cart/%<variant_id>d:%<quantity>d", variant_id: product.variant_id, quantity: 1)
         end
+
+        private
+
+        def localization(context)
+          Dir.chdir(context.root) do
+            locale_filenames = Dir["locales/*"].select { |filename| valid_l10n_file?(filename) }
+            # Localization is optional
+            return {} if locale_filenames.empty?
+
+            validate_total_size(locale_filenames)
+            default_locale = single_default_locale(locale_filenames)
+
+            locale_filenames.map do |filename|
+              locale = basename_for_locale_filename(filename)
+              [locale.to_sym, Base64.strict_encode64(File.read(filename, mode: "rt", encoding: "UTF-8").strip)]
+            end
+              .yield_self do |encoded_files_by_locale|
+              {
+                localization: {
+                  default_locale: default_locale,
+                  translations: encoded_files_by_locale.to_h,
+                },
+              }
+            end
+          end
+        end
+
+        def validate_total_size(locale_filenames)
+          total_size = locale_filenames.sum { |filename| File.size(filename) }
+          if total_size > L10N_BUNDLE_SIZE_LIMIT
+            raise(
+              ShopifyCLI::Abort,
+              ShopifyCLI::Context.message(
+                "#{L10N_ERROR_PREFIX}.bundle_too_large",
+                CLI::Kit::Util.to_filesize(L10N_BUNDLE_SIZE_LIMIT)
+              )
+            )
+          end
+        end
+
+        def single_default_locale(locale_filenames)
+          default_locale_matches = locale_filenames.grep(/default/)
+          if default_locale_matches.size != 1
+            raise(ShopifyCLI::Abort, ShopifyCLI::Context.message("#{L10N_ERROR_PREFIX}.single_default_locale"))
+          end
+          basename_for_locale_filename(default_locale_matches.first)
+        end
+
+        def valid_l10n_file?(filename)
+          return false unless File.file?(filename)
+          return false unless File.dirname(filename) == "locales"
+
+          validate_file_extension(filename)
+          validate_file_locale_code(filename)
+          validate_file_size(filename)
+          validate_file_not_empty(filename)
+
+          true
+        end
+
+        def validate_file_extension(filename)
+          if File.extname(filename) != ".json"
+            raise(
+              ShopifyCLI::Abort, ShopifyCLI::Context.message("#{L10N_ERROR_PREFIX}.invalid_file_extension", filename)
+            )
+          end
+        end
+
+        def validate_file_locale_code(filename)
+          unless valid_locale_code?(basename_for_locale_filename(filename))
+            raise(
+              ShopifyCLI::Abort, ShopifyCLI::Context.message("#{L10N_ERROR_PREFIX}.invalid_locale_code", filename)
+            )
+          end
+        end
+
+        def validate_file_size(filename)
+          if File.size(filename) > L10N_FILE_SIZE_LIMIT
+            raise(
+              ShopifyCLI::Abort,
+              ShopifyCLI::Context.message(
+                "#{L10N_ERROR_PREFIX}.file_too_large",
+                filename,
+                CLI::Kit::Util.to_filesize(L10N_FILE_SIZE_LIMIT)
+              )
+            )
+          end
+        end
+
+        def validate_file_not_empty(filename)
+          if File.zero?(filename)
+            raise(ShopifyCLI::Abort, ShopifyCLI::Context.message("#{L10N_ERROR_PREFIX}.file_empty", filename))
+          end
+        end
+
+        def valid_locale_code?(locale_code)
+          LOCALE_CODE_FORMAT.match?(locale_code)
+        end
+
+        def basename_for_locale_filename(filename)
+          File.basename(File.basename(filename, ".json"), ".default")
+        end
       end
     end
   end

data/lib/project_types/extension/models/specification_handlers/theme_app_extension.rb

@@ -6,10 +6,11 @@ module Extension
   module Models
     module SpecificationHandlers
       class ThemeAppExtension < Default
-        SUPPORTED_BUCKETS = %w(assets blocks snippets)
+        SUPPORTED_BUCKETS = %w(assets blocks snippets locales)
         BUNDLE_SIZE_LIMIT = 10 * 1024 * 1024 # 10MB
         LIQUID_SIZE_LIMIT = 100 * 1024 # 100kb
         SUPPORTED_ASSET_EXTS = %w(.jpg .js .css .png .svg)
+        SUPPORTED_LOCALE_EXTS = %w(.json)
 
         def create(directory_name, context, getting_started: false)
           context.root = File.join(context.root, directory_name)
@@ -89,6 +90,11 @@ module Extension
               raise Extension::Errors::InvalidFilenameError,
                 "Invalid filename: #{filename}; #{ext} is not supported"
             end
+          elsif dirname == "locales"
+            unless SUPPORTED_LOCALE_EXTS.include?(ext)
+              raise Extension::Errors::InvalidFilenameError,
+                "Invalid filename: #{filename}; Only #{SUPPORTED_LOCALE_EXTS.join(", ")} allowed in #{dirname}"
+            end
           elsif ext != ".liquid"
             raise Extension::Errors::InvalidFilenameError,
               "Invalid filename: #{filename}; Only .liquid allowed in #{dirname}"

data/lib/project_types/script/cli.rb

@@ -78,6 +78,8 @@ module Script
           Project.project_filepath("layers/infrastructure/languages/wasm_project_creator.rb")
         autoload :WasmTaskRunner,
           Project.project_filepath("layers/infrastructure/languages/wasm_task_runner.rb")
+        autoload :ToolVersionChecker,
+          Project.project_filepath("layers/infrastructure/languages/tool_version_checker.rb")
       end
 
       module ApiClients

data/lib/project_types/script/commands/create.rb

@@ -18,13 +18,13 @@ module Script
         form = Forms::Create.ask(@ctx, args, options.flags)
         return @ctx.puts(self.class.help) if form.nil?
 
-        unless !form.name.empty? && form.extension_point && form.language
+        unless !form.name.empty? && form.extension_point
           return @ctx.puts(self.class.help)
         end
 
         project = Layers::Application::CreateScript.call(
           ctx: @ctx,
-          language: form.language,
+          language: options.flags[:language]&.downcase || "wasm",
           sparse_checkout_branch: options.flags[:branch] || "master",
           script_name: form.name,
           extension_point_type: form.extension_point,

data/lib/project_types/script/commands/push.rb

@@ -5,10 +5,6 @@ module Script
     class Push < ShopifyCLI::Command::SubCommand
       prerequisite_task ensure_project_type: :script
 
-      recommend_node(
-        from: ::Script::Layers::Infrastructure::Languages::TypeScriptProjectCreator::MIN_NODE_VERSION,
-        to: ShopifyCLI::Constants::SupportedVersions::Node::TO
-      )
       recommend_default_ruby_range
 
       options do |parser, flags|
@@ -26,7 +22,7 @@ module Script
         push(project: project)
       rescue StandardError => e
         UI::ErrorHandler.pretty_print_and_raise(e,
-          failed_op: @ctx.message("script.push.error.operation_failed_no_api_key"))
+          failed_op: @ctx.message("script.push.error.operation_failed"))
       end
 
       def push(project:)
@@ -38,7 +34,9 @@ module Script
           Layers::Application::PushScript.call(ctx: @ctx, force: force, project: project)
           @ctx.puts(@ctx.message("script.push.script_pushed", api_key: api_key))
         else
-          raise ShopifyCLI::Abort, @ctx.message("script.push.error.operation_failed_no_uuid")
+          message = @ctx.message("script.error.missing_push_options_ci", "--uuid")
+          message += @ctx.message("script.error.missing_push_options_ci_solution", ShopifyCLI::TOOL_NAME)
+          raise ShopifyCLI::Abort, message
         end
       end
 

data/lib/project_types/script/config/extension_points.yml

@@ -9,7 +9,6 @@ payment_methods:
       package: "@shopify/scripts-checkout-apis"
       repo: "https://github.com/Shopify/scripts-apis-examples"
     wasm:
-      beta: true
       repo: "https://github.com/Shopify/scripts-apis-examples"
 shipping_methods:
   domain: 'checkout'
@@ -22,7 +21,6 @@ shipping_methods:
       package: "@shopify/scripts-checkout-apis"
       repo: "https://github.com/Shopify/scripts-apis-examples"
     wasm:
-      beta: true
       repo: "https://github.com/Shopify/scripts-apis-examples"
 merchandise_discount_types:
   beta: true
@@ -33,7 +31,6 @@ merchandise_discount_types:
       package: "@shopify/scripts-discounts-apis"
       repo: "https://github.com/Shopify/scripts-apis-examples"
     wasm:
-      beta: true
       repo: "https://github.com/Shopify/scripts-apis-examples"
 delivery_discount_types:
   beta: true
@@ -44,5 +41,4 @@ delivery_discount_types:
       package: "@shopify/scripts-discounts-apis"
       repo: "https://github.com/Shopify/scripts-apis-examples"
     wasm:
-      beta: true
       repo: "https://github.com/Shopify/scripts-apis-examples"

data/lib/project_types/script/forms/create.rb

@@ -3,12 +3,11 @@
 module Script
   module Forms
     class Create < ShopifyCLI::Form
-      flag_arguments :extension_point, :name, :language
+      flag_arguments :extension_point, :name
 
       def ask
         self.name = valid_name
         self.extension_point ||= ask_extension_point
-        self.language = ask_language
       end
 
       private
@@ -29,18 +28,6 @@ module Script
         return n if n.match?(/^[0-9A-Za-z_-]*$/)
         raise Errors::InvalidScriptNameError
       end
-
-      def ask_language
-        return language.downcase if language
-
-        all_languages = Layers::Application::ExtensionPoints.languages(type: extension_point)
-        return all_languages.first if all_languages.count == 1
-
-        CLI::UI::Prompt.ask(
-          ctx.message("script.forms.create.select_language"),
-          options: all_languages
-        )
-      end
     end
   end
 end

data/lib/project_types/script/layers/application/connect_app.rb

@@ -55,9 +55,10 @@ module Script
           def handle_error(error, context:)
             properties_hash = { api_key: "SHOPIFY_API_KEY", secret: "SHOPIFY_API_SECRET" }
             missing_env_variables = error.properties.map { |p| properties_hash[p.name] }.compact.join(", ")
+            message = context.message("script.error.missing_env_file_variables", missing_env_variables)
+            message += context.message("script.error.missing_env_file_variables_solution", ShopifyCLI::TOOL_NAME)
             raise ShopifyCLI::Abort,
-              context.message("script.connect.error.missing_env_file_variables", missing_env_variables,
-                ShopifyCLI::TOOL_NAME)
+              message
           end
 
           private

data/lib/project_types/script/layers/application/create_script.rb

@@ -47,7 +47,7 @@ module Script
           private
 
           def install_dependencies(ctx, language, script_name, project_creator)
-            task_runner = Infrastructure::Languages::TaskRunner.for(ctx, language, script_name)
+            task_runner = Infrastructure::Languages::TaskRunner.for(ctx, language)
             CLI::UI::Frame.open(ctx.message(
               "core.git.pulling_from_to",
               project_creator.sparse_checkout_repo,

data/lib/project_types/script/layers/application/push_script.rb

@@ -10,7 +10,7 @@ module Script
             script_project = script_project_repo.get
             script_project.env = project.env
             task_runner = Infrastructure::Languages::TaskRunner
-              .for(ctx, script_project.language, script_project.script_name)
+              .for(ctx, script_project.language)
 
             extension_point = ExtensionPoints.get(type: script_project.extension_point_type)
 

data/lib/project_types/script/layers/infrastructure/errors.rb

@@ -105,6 +105,17 @@ module Script
 
         class DependencyInstallError < ScriptProjectError; end
         class EmptyResponseError < ScriptProjectError; end
+
+        class InvalidEnvironmentError < ScriptProjectError
+          attr_reader :tool, :env_version, :minimum_version
+          def initialize(tool, env_version, minimum_version)
+            super()
+            @tool = tool
+            @env_version = env_version
+            @minimum_version = minimum_version
+          end
+        end
+
         class InvalidResponseError < ScriptProjectError; end
         class ForbiddenError < ScriptProjectError; end
         class InvalidContextError < ScriptProjectError; end

data/lib/project_types/script/layers/infrastructure/languages/assemblyscript_project_creator.rb

@@ -5,18 +5,14 @@ module Script
     module Infrastructure
       module Languages
         class AssemblyScriptProjectCreator < ProjectCreator
-          MIN_NODE_VERSION = "14.5.0" # kept because task_runner uses this
-          NPM_SET_REGISTRY_COMMAND = "npm --userconfig ./.npmrc config set @shopify:registry https://registry.npmjs.com"
-          NPM_SET_ENGINE_STRICT_COMMAND = "npm --userconfig ./.npmrc config set engine-strict true"
-
           def self.config_file
             "package.json"
           end
 
           def setup_dependencies
+            task_runner = Infrastructure::Languages::AssemblyScriptTaskRunner.new(ctx)
+            task_runner.set_npm_config
             super
-            command_runner.call(NPM_SET_REGISTRY_COMMAND)
-            command_runner.call(NPM_SET_ENGINE_STRICT_COMMAND)
           end
         end
       end