shopify-cli 2.10.0 → 2.11.1

data/lib/shopify_cli/commands/app/create/node.rb

@@ -5,6 +5,9 @@ module ShopifyCLI
         class Node < ShopifyCLI::Command::AppSubCommand
           prerequisite_task :ensure_authenticated
 
+          recommend_default_node_range
+          recommend_default_ruby_range
+
           options do |parser, flags|
             parser.on("--name=NAME") { |t| flags[:name] = t }
             parser.on("--organization-id=ID") { |id| flags[:organization_id] = id }

data/lib/shopify_cli/commands/app/create/rails.rb

@@ -5,6 +5,9 @@ module ShopifyCLI
         class Rails < ShopifyCLI::Command::AppSubCommand
           prerequisite_task :ensure_authenticated
 
+          recommend_default_ruby_range
+          recommend_default_node_range
+
           options do |parser, flags|
             parser.on("--name=NAME") { |t| flags[:name] = t }
             parser.on("--organization-id=ID") { |id| flags[:organization_id] = id }

data/lib/shopify_cli/commands/app/deploy.rb

@@ -4,6 +4,8 @@ module ShopifyCLI
       class Deploy < ShopifyCLI::Command::AppSubCommand
         subcommand :Heroku, "heroku", "shopify_cli/commands/app/deploy/heroku"
 
+        recommend_default_ruby_range
+
         def call(args, _name)
           platform = args.shift
           case platform

data/lib/shopify_cli/commands/app/serve.rb

@@ -6,6 +6,8 @@ module ShopifyCLI
 
         prerequisite_task :ensure_env, :ensure_dev_store
 
+        recommend_default_ruby_range
+
         options do |parser, flags|
           parser.on("--host=HOST") do |h|
             flags[:host] = h.gsub('"', "")

data/lib/shopify_cli/constants.rb

@@ -38,7 +38,7 @@ module ShopifyCLI
 
       # When true the CLI points to spin instances of services
       SPIN = "SPIN"
-      INFER_SPIN = "INFER_SPIN"
+      SPIN_INSTANCE = "SPIN_INSTANCE"
       SPIN_WORKSPACE = "SPIN_WORKSPACE"
       SPIN_NAMESPACE = "SPIN_NAMESPACE"
       SPIN_HOST = "SPIN_HOST"
@@ -58,6 +58,18 @@ module ShopifyCLI
       MONORAIL_REAL_EVENTS = "MONORAIL_REAL_EVENTS"
     end
 
+    module SupportedVersions
+      module Ruby
+        FROM = "2.6.6"
+        TO = "3.1.0"
+      end
+
+      module Node
+        FROM = "12.0.0"
+        TO = "17.0.0"
+      end
+    end
+
     module Identity
       CLIENT_ID_DEV = "e5380e02-312a-7408-5718-e07017e9cf52"
       CLIENT_ID = "fbdb2649-e327-4907-8f67-908d24cfd7e3"

data/lib/shopify_cli/environment.rb

@@ -1,8 +1,29 @@
+require "semantic/semantic"
+
 module ShopifyCLI
   # The environment module provides an interface to get information from
   # the environment in which the CLI runs
   module Environment
     TRUTHY_ENV_VARIABLE_VALUES = ["1", "true", "TRUE", "yes", "YES"]
+    SPIN_OVERRIDE_ENV_NAMES = [
+      Constants::EnvironmentVariables::SPIN_WORKSPACE,
+      Constants::EnvironmentVariables::SPIN_NAMESPACE,
+      Constants::EnvironmentVariables::SPIN_HOST,
+    ]
+
+    def self.ruby_version(context: Context.new)
+      out, err, stat = context.capture3('ruby -e "puts RUBY_VERSION"')
+      raise ShopifyCLI::Abort, err unless stat.success?
+      out = out.gsub('"', "")
+      ::Semantic::Version.new(out.chomp)
+    end
+
+    def self.node_version(context: Context.new)
+      out, err, stat = context.capture3("node", "--version")
+      raise ShopifyCLI::Abort, err unless stat.success?
+      out = out.gsub("v", "")
+      ::Semantic::Version.new(out.chomp)
+    end
 
     def self.interactive=(interactive)
       @interactive = interactive
@@ -71,6 +92,20 @@ module ShopifyCLI
       end
     end
 
+    def self.spin_url_override(env_variables: ENV)
+      tokens = SPIN_OVERRIDE_ENV_NAMES.map do |name|
+        env_variables[name]
+      end
+
+      return if tokens.all?(&:nil?)
+
+      if tokens.any?(&:nil?)
+        raise "To manually target a spin instance, you must set #{SPIN_OVERRIDE_ENV_NAMES}"
+      else
+        tokens.join(".")
+      end
+    end
+
     def self.use_spin?(env_variables: ENV)
       env_variable_truthy?(
         Constants::EnvironmentVariables::SPIN,
@@ -81,24 +116,31 @@ module ShopifyCLI
       )
     end
 
-    def self.infer_spin?(env_variables: ENV)
-      env_variable_truthy?(
-        Constants::EnvironmentVariables::INFER_SPIN,
-        env_variables: env_variables
-      )
-    end
-
     def self.spin_url(env_variables: ENV)
-      if infer_spin?(env_variables: env_variables)
-        %x(spin info fqdn 2> /dev/null).strip
+      override = spin_url_override(env_variables: env_variables)
+      return override unless override.nil?
+
+      spin_response = if env_variables.key?(
+        Constants::EnvironmentVariables::SPIN_INSTANCE
+      )
+        spin_show
       else
-        spin_workspace = spin_workspace(env_variables: env_variables)
-        spin_namespace = spin_namespace(env_variables: env_variables)
-        spin_host = spin_host(env_variables: env_variables)
-        "#{spin_workspace}.#{spin_namespace}.#{spin_host}"
+        spin_show(latest: true)
+      end
+
+      begin
+        instance = JSON.parse(spin_response)
+        raise "Missing key 'fqdn' from spin show. Actual response: #{instance}" unless instance.include?("fqdn")
+        instance["fqdn"]
+      rescue => e
+        raise "Failed to infer spin environment from spin show response #{spin_response}: #{e}"
       end
     end
 
+    def self.spin_show(latest: false)
+      latest ? %x(spin show --latest --json) : %x(spin show --json)
+    end
+
     def self.send_monorail_events?(env_variables: ENV)
       env_variable_truthy?(
         Constants::EnvironmentVariables::MONORAIL_REAL_EVENTS,
@@ -113,27 +155,5 @@ module ShopifyCLI
     def self.env_variable_truthy?(variable_name, env_variables: ENV)
       TRUTHY_ENV_VARIABLE_VALUES.include?(env_variables[variable_name.to_s])
     end
-
-    def self.spin_workspace(env_variables: ENV)
-      env_value = env_variables[Constants::EnvironmentVariables::SPIN_WORKSPACE]
-      return env_value unless env_value.nil?
-
-      if env_value.nil?
-        raise "No value set for #{Constants::EnvironmentVariables::SPIN_WORKSPACE}"
-      end
-    end
-
-    def self.spin_namespace(env_variables: ENV)
-      env_value = env_variables[Constants::EnvironmentVariables::SPIN_NAMESPACE]
-      return env_value unless env_value.nil?
-
-      if env_value.nil?
-        raise "No value set for #{Constants::EnvironmentVariables::SPIN_NAMESPACE}"
-      end
-    end
-
-    def self.spin_host(env_variables: ENV)
-      env_variables[Constants::EnvironmentVariables::SPIN_HOST] || "us.spin.dev"
-    end
   end
 end

data/lib/shopify_cli/exception_reporter.rb

@@ -1,5 +1,10 @@
 module ShopifyCLI
   module ExceptionReporter
+    def self.report_error_silently(error)
+      return unless ReportingConfigurationController.reporting_enabled?
+      report_to_bugsnag(error: error)
+    end
+
     def self.report(error, _logs = nil, _api_key = nil, custom_metadata = {})
       context = ShopifyCLI::Context.new
       unless ShopifyCLI::Environment.development?
@@ -19,6 +24,10 @@ module ShopifyCLI
       return unless reportable_error?(error)
 
       return unless report?(context: context)
+      report_to_bugsnag(error: error, custom_metadata: custom_metadata)
+    end
+
+    def self.report_to_bugsnag(error:, custom_metadata: {})
       ENV["BUGSNAG_DISABLE_AUTOCONFIGURE"] = "1"
       require "bugsnag"
 

data/lib/shopify_cli/github/issue_url_generator.rb

@@ -2,17 +2,28 @@ module ShopifyCLI
   module GitHub
     module IssueURLGenerator
       def self.error_url(error)
-        title = "#{error.class}: #{error.message}"
+        title = "[Bug]: #{error.class}: #{error.message}"
         labels = "type:bug"
-        content = File.read(File.join(ShopifyCLI::ROOT, ".github/ISSUE_TEMPLATE.md"))
 
         # take at most 5 lines from backtrace
-        stacktrace = error.backtrace.length < 5 ? error.backtrace : error.backtrace[0..4]
-        body = stacktrace.join("\n").to_s
-        output = content.gsub(/<!--Stacktrace(.|\n)*-->/, body)
-        query = URI.encode_www_form({ title: title, body: output, labels: labels })
-        url = "#{ShopifyCLI::Constants::Links::NEW_ISSUE}?#{query}"
-        url
+        stacktrace_text =
+          if error.backtrace # Sometimes errors seem to appear without backtrace, see https://github.com/Shopify/shopify-cli/issues/1972#issuecomment-1028013630
+            stacktrace = error.backtrace.length < 5 ? error.backtrace : error.backtrace[0..4]
+            stacktrace.join("\n").to_s
+          else
+            ""
+          end
+        query = URI.encode_www_form({
+          title: title,
+          labels: labels,
+          template: "bug_report.yaml",
+          stack_trace: stacktrace_text,
+          os: RUBY_PLATFORM,
+          cli_version: ShopifyCLI::VERSION,
+          ruby_version: "#{RUBY_VERSION}p#{RUBY_PATCHLEVEL}",
+          shell: ENV["SHELL"],
+        })
+        "#{ShopifyCLI::Constants::Links::NEW_ISSUE}?#{query}"
       end
     end
   end

data/lib/shopify_cli/identity_auth/env_auth_token.rb

@@ -0,0 +1,34 @@
+module ShopifyCLI
+  class IdentityAuth
+    class EnvAuthToken
+      Token = Struct.new(:token, :expires_at, keyword_init: true)
+
+      class << self
+        attr_accessor :exchanged_partners_token
+
+        def partners_token_present?
+          Environment.auth_token
+        end
+
+        def fetch_exchanged_partners_token
+          current_time = Time.now.to_i
+
+          # If we have an in-memory token that hasn't expired yet, we reuse it.
+          if exchanged_partners_token && current_time < exchanged_partners_token.expires_at.to_i
+            return exchanged_partners_token.token
+          end
+
+          new_exchanged_token = yield(Environment.auth_token)
+          token = new_exchanged_token["access_token"]
+          expires_in = new_exchanged_token["expires_in"].to_i
+          expires_at = Time.at(current_time + expires_in)
+
+          token = Token.new(token: token, expires_at: expires_at)
+
+          self.exchanged_partners_token = token
+          token.token
+        end
+      end
+    end
+  end
+end

data/lib/shopify_cli/identity_auth.rb

@@ -13,6 +13,7 @@ module ShopifyCLI
     include SmartProperties
 
     autoload :Servlet, "shopify_cli/identity_auth/servlet"
+    autoload :EnvAuthToken, "shopify_cli/identity_auth/env_auth_token"
 
     class Error < StandardError; end
     class Timeout < StandardError; end
@@ -68,9 +69,12 @@ module ShopifyCLI
       request_exchange_tokens
     end
 
-    def self.fetch_or_auth_partners_token(ctx:)
-      env_var_auth_token = Environment.auth_token
-      return env_var_auth_token if env_var_auth_token
+    def fetch_or_auth_partners_token
+      if EnvAuthToken.partners_token_present?
+        return EnvAuthToken.fetch_exchanged_partners_token do |env_token|
+          exchange_partners_auth_token(env_token)
+        end
+      end
 
       ShopifyCLI::DB.get(:partners_exchange_token) do
         IdentityAuth.new(ctx: ctx).authenticate
@@ -78,6 +82,15 @@ module ShopifyCLI
       end
     end
 
+    def exchange_partners_auth_token(subject_token)
+      application = "partners"
+      request_exchange_token(
+        audience: client_id_for_application(application),
+        scopes: APPLICATION_SCOPES[application],
+        subject_token: subject_token,
+      )
+    end
+
     def self.environment_auth_token?
       !!Environment.auth_token
     end
@@ -195,30 +208,35 @@ module ShopifyCLI
 
     def request_exchange_tokens
       APPLICATION_SCOPES.each do |key, scopes|
-        request_exchange_token(key, client_id_for_application(key), scopes)
+        request_and_save_exchange_token(key, client_id_for_application(key), scopes)
       end
     end
 
-    def request_exchange_token(name, audience, additional_scopes)
+    def request_and_save_exchange_token(name, audience, additional_scopes)
       return if name == "shopify" && !store.exists?(:shop)
+      access_token = request_exchange_token(
+        audience: audience,
+        scopes: scopes(additional_scopes),
+        subject_token: store.get(:identity_access_token),
+        destination: name == "shopify" ? "https://#{store.get(:shop)}/admin" : nil
+      )["access_token"]
+      store.set("#{name}_exchange_token".to_sym => access_token)
+      ctx.debug("#{name}_exchange_token: " + access_token)
+    end
 
+    def request_exchange_token(audience:, scopes:, subject_token:, destination: nil)
       params = {
         grant_type: "urn:ietf:params:oauth:grant-type:token-exchange",
         requested_token_type: "urn:ietf:params:oauth:token-type:access_token",
         subject_token_type: "urn:ietf:params:oauth:token-type:access_token",
         client_id: client_id,
         audience: audience,
-        scope: scopes(additional_scopes),
-        subject_token: store.get(:identity_access_token),
-      }.tap do |result|
-        if name == "shopify"
-          result[:destination] = "https://#{store.get(:shop)}/admin"
-        end
-      end
+        scope: scopes,
+        subject_token: subject_token,
+        destination: destination,
+      }.compact
       # ctx.debug(params)
-      resp = post_token_request(params)
-      store.set("#{name}_exchange_token".to_sym => resp["access_token"])
-      ctx.debug("#{name}_exchange_token: " + resp["access_token"])
+      post_token_request(params)
     end
 
     def post_token_request(params)

data/lib/shopify_cli/messages/messages.rb

@@ -15,6 +15,7 @@ module ShopifyCLI
       },
       core: {
         errors: {
+          missing_node: "Node is necessary for this command and was not found in the environment.",
           option_parser: {
             invalid_option: "The option {{command:%s}} is not supported.",
             missing_argument: "The required argument {{command:%s}} is missing.",
@@ -53,7 +54,7 @@ module ShopifyCLI
                     {{command:--organization-id=ID}} Partner organization ID. Must be an existing organization.
                     {{command:--store-domain=MYSHOPIFYDOMAIN }} Development store URL. Must be an existing development store.
                     {{command:--db=DB}} Database type. Must be one of: mysql, postgresql, sqlite3, oracle, frontbase, ibm_db, sqlserver, jdbcmysql, jdbcsqlite3, jdbcpostgresql, jdbc.
-                    {{command:--rails-opts=RAILSOPTS}} Additional options. Must be string containing one or more valid Rails options, separated by spaces.
+                    {{command:--rails-opts=RAILSOPTS}} Additional options. Must be a string containing one or more valid Rails options, separated by spaces.
               HELP
 
               error: {

data/lib/shopify_cli/partners_api.rb

@@ -38,7 +38,11 @@ module ShopifyCLI
       def query(ctx, query_name, **variables)
         CLI::Kit::Util.begin do
           api_client(ctx).query(query_name, variables: variables)
-        end.retry_after(API::APIRequestUnauthorizedError, retries: 1) do
+        end.retry_after(
+          API::APIRequestUnauthorizedError,
+          retries: 1,
+          only: -> { !IdentityAuth::EnvAuthToken.partners_token_present? }
+        ) do
           ShopifyCLI::IdentityAuth.new(ctx: ctx).reauthenticate
         end
       rescue API::APIRequestUnauthorizedError => e
@@ -60,9 +64,10 @@ module ShopifyCLI
       private
 
       def api_client(ctx)
+        identity_auth = ShopifyCLI::IdentityAuth.new(ctx: ctx)
         new(
           ctx: ctx,
-          token: IdentityAuth.fetch_or_auth_partners_token(ctx: ctx),
+          token: identity_auth.fetch_or_auth_partners_token,
           url: "https://#{Environment.partners_domain}/api/cli/graphql",
         )
       end

data/lib/shopify_cli/services/app/create/rails_service.rb

@@ -41,12 +41,7 @@ module ShopifyCLI
 
             raise ShopifyCLI::AbortSilent if form.nil?
 
-            ruby_version = Rails::Ruby.version(context)
-            context.abort(context.message("core.app.create.rails.error.invalid_ruby_version")) unless
-              ruby_version.satisfies?("~>2.5") || ruby_version.satisfies?("~>3.0.0")
-
-            check_node
-            check_yarn
+            check_dependencies
 
             build(form.name, form.db)
             set_custom_ua
@@ -106,6 +101,18 @@ module ShopifyCLI
             end
           end
 
+          def check_dependencies
+            check_ruby
+            check_node
+            check_yarn
+          end
+
+          def check_ruby
+            ruby_version = Rails::Ruby.version(context)
+            return if ruby_version.satisfies?("~>2.5") || ruby_version.satisfies?("~>3.0.0")
+            context.abort(context.message("core.app.create.rails.error.invalid_ruby_version"))
+          end
+
           def check_node
             cmd_path = context.which("node")
             if cmd_path.nil?
@@ -148,11 +155,13 @@ module ShopifyCLI
           end
 
           def build(name, db)
-            context.abort(context.message("core.app.create.rails.error.install_failure",
-              "rails")) unless install_gem("rails",
-                "<6.1")
-            context.abort(context.message("core.app.create.rails.error.install_failure", "bundler ~>2.0")) unless
-              install_gem("bundler", "~>2.0")
+            unless install_gem("rails")
+              context.abort(context.message("core.app.create.rails.error.install_failure", "rails"))
+            end
+
+            unless install_gem("bundler", "~>2.0")
+              context.abort(context.message("core.app.create.rails.error.install_failure", "bundler ~>2.0"))
+            end
 
             full_path = File.join(context.root, name)
             context.abort(context.message("core.app.create.rails.error.dir_exists", name)) if Dir.exist?(full_path)
@@ -173,7 +182,7 @@ module ShopifyCLI
 
             context.puts(context.message("core.app.create.rails.adding_shopify_gem"))
             File.open(File.join(context.root, "Gemfile"), "a") do |f|
-              f.puts "\ngem 'shopify_app', '>=17.0.3'"
+              f.puts "\ngem 'shopify_app', '>=18.1.0'"
             end
             CLI::UI::Frame.open(context.message("core.app.create.rails.running_bundle_install")) do
               syscall(%w(bundle install))
@@ -188,7 +197,7 @@ module ShopifyCLI
               syscall(%w(rails db:migrate RAILS_ENV=development))
             end
 
-            unless File.exist?(File.join(context.root, "config/webpacker.yml"))
+            if install_webpacker?
               CLI::UI::Frame.open(context.message("core.app.create.rails.running_webpacker_install")) do
                 syscall(%w(rails webpacker:install))
               end
@@ -208,6 +217,21 @@ module ShopifyCLI
           def install_gem(name, version = nil)
             Rails::Gem.install(context, name, version)
           end
+
+          def install_webpacker?
+            rails_version < ::Semantic::Version.new("7.0.0") &&
+              !File.exist?(File.join(context.root, "config/webpacker.yml"))
+          end
+
+          def rails_version
+            output, status = context.capture2e("rails", "--version")
+            unless status.success?
+              context.abort(context.message("core.app.create.rails.error.install_failure", "rails"))
+            end
+
+            version = output.scan(/Rails \d+\.\d+\.\d+/).first.split(" ").last
+            ::Semantic::Version.new(version)
+          end
         end
       end
     end

data/lib/shopify_cli/theme/dev_server/cdn_fonts.rb

@@ -1,13 +1,9 @@
 # frozen_string_literal: true
 
-require_relative "cdn/cdn_helper"
-
 module ShopifyCLI
   module Theme
     module DevServer
       class CdnFonts
-        include Cdn::CdnHelper
-
         FONTS_PATH = "/fonts"
         FONTS_CDN = "https://fonts.shopifycdn.com"
         FONTS_REGEX = %r{#{FONTS_CDN}}
@@ -21,7 +17,7 @@ module ShopifyCLI
           path = env["PATH_INFO"]
 
           # Serve from fonts CDN
-          return serve_font(env, path) if path.start_with?(FONTS_PATH)
+          return serve_font(env) if path.start_with?(FONTS_PATH)
 
           # Proxy the request, and replace the URLs in the response
           status, headers, body = @app.call(env)
@@ -31,11 +27,35 @@ module ShopifyCLI
 
         private
 
-        def serve_font(env, path)
-          query = env["QUERY_STRING"]
+        def serve_font(env)
+          parameters = %w(PATH_INFO QUERY_STRING REQUEST_METHOD rack.input)
+          path, query, method, body_stream = *env.slice(*parameters).values
+
           uri = fonts_cdn_uri(path, query)
 
-          proxy_request(env, uri, @theme)
+          response = Net::HTTP.start(uri.host, 443, use_ssl: true) do |http|
+            req_class = Net::HTTP.const_get(method.capitalize)
+            req = req_class.new(uri)
+            req.initialize_http_header(fonts_cdn_headers)
+            req.body_stream = body_stream
+            http.request(req)
+          end
+
+          [
+            response.code.to_s,
+            {
+              "Content-Type" => response.content_type,
+              "Content-Length" => response.content_length.to_s,
+            },
+            [response.body],
+          ]
+        end
+
+        def fonts_cdn_headers
+          {
+            "Referer" => "https://#{@theme.shop}",
+            "Transfer-Encoding" => "chunked",
+          }
         end
 
         def fonts_cdn_uri(path, query)

data/lib/shopify_cli/theme/dev_server/hot_reload/remote_file_reloader.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module ShopifyCLI
+  module Theme
+    module DevServer
+      class HotReload
+        class RemoteFileReloader
+          def initialize(ctx, theme:, streams:)
+            @ctx = ctx
+            @theme = theme
+            @streams = streams
+          end
+
+          def reload(file)
+            retries = 6
+
+            until retries.zero?
+              retries -= 1
+
+              _status, body = fetch_asset(file)
+              retries = 0 if updated_file?(body, file)
+
+              wait
+            end
+
+            notify(file)
+          end
+
+          private
+
+          def updated_file?(body, file)
+            remote_checksum = body.dig("asset", "checksum")
+            local_checksum = file.checksum
+
+            remote_checksum == local_checksum
+          end
+
+          def notify(file)
+            @streams.broadcast(JSON.generate(modified: [file]))
+            @ctx.debug("[RemoteFileReloader] Modified #{file}")
+          end
+
+          def wait
+            sleep(1)
+          end
+
+          def fetch_asset(file)
+            ShopifyCLI::AdminAPI.rest_request(
+              @ctx,
+              shop: @theme.shop,
+              path: "themes/#{@theme.id}/assets.json",
+              method: "GET",
+              api_version: "unstable",
+              query: URI.encode_www_form("asset[key]" => file.relative_path.to_s),
+            )
+          rescue ShopifyCLI::API::APIRequestNotFoundError
+            [404, {}]
+          end
+        end
+      end
+    end
+  end
+end