shopify-cli 1.2.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aac6d7ad80aa747af6b8334b1cf6f82b3dfc0c6db77e8e22eb9638365b11317b
-  data.tar.gz: f5a744abb193c02bad16f0978d93bac2825ce287f95e3143848be47c28c8bbfc
+  metadata.gz: 6d907a49558ca8dfb5998667698b5bf262d850a55951ac2af30c178f141d9063
+  data.tar.gz: 833124c900634e59426bef89dd7fbf35948d19b73e55ecb96becfb6307b3cc3a
 SHA512:
-  metadata.gz: b934e0c4c5321cdb01d733886e2eae5fc23c94c1ea7115e9b18af302244512d93617440d1a4274ca764305c6797a10ef79285c97cf03636d473deec63a6a0d23
-  data.tar.gz: fec928d425a1be8c543d45d495156857fcf848c12170eaf825fdf549f70536198fdf076d71b35b448b97769869ac85e2eddb8d6dd1321a2f93949160cd2929fa
+  metadata.gz: 4670c00c70ae907f1d5eea958ba512ac61e2579566dabf4bb09345925d6da2cd882e5c4d0e9bededd92fd779f85326d4b4cbc66d3c268ee816aa0d23330bc55c
+  data.tar.gz: 33a780da492b11846f89d84b74da119d707236846e4b9617ccb1541cde9be83b0f33fcf302d92b3aaa58c3634ed9004d3d2b7673f0a2a916b33ed2336b2835f9

data/.github/CODEOWNERS

@@ -1,4 +1,4 @@
 *       @shopify/platform-dev-tools-education
 
-/lib/project_types/script/ @shopify/scripts
-/test/project_types/script/ @shopify/scripts
+/lib/project_types/script/ @shopify/scripts-experience
+/test/project_types/script/ @shopify/scripts-experience

data/.github/CONTRIBUTING.md

@@ -19,6 +19,14 @@ When contributing to the Shopify App CLI, there are a set of [design guidelines]
 
 We track all of our issues in GitHub and [bugs](https://github.com/Shopify/shopify-app-cli/labels/Bug) are labeled accordingly. If you are planning to work on an issue, avoid ones which already have an assignee, where someone has commented within the last two weeks they are working on it, or the issue is labeled with [fix in progress](https://github.com/Shopify/shopify-app-cli/labels/fix%20in%20progress). We will do our best to communicate when an issue is being worked on internally.
 
+### Running against a local environment
+
+This section only applies to Shopify staff:
+
+To run against a local Partners or Identity instance, you can use:
+
+`SHOPIFY_APP_CLI_LOCAL_PARTNERS=1 shopify`
+
 ### Reporting new issues
 
 To reduce duplicates, look through open issues before filing one. When [opening an issue](https://github.com/Shopify/shopify-app-cli/issues/new?template=ISSUE.md), complete as much of the template as possible.
@@ -48,4 +56,4 @@ Each contributor is required to [sign a CLA](https://cla.shopify.com/). This pro
 
 If you are changing the CLI version, please make sure to update all the places that use it:
 * ShopifyCLI::VERSION
-* Debian package version under `packaging/debian`
+* Debian package version under `packaging/debian`

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,7 @@
   - Prefix it with [Feature] (if applicable)
   - Start with a verb, for example: Add, Delete, Improve, Fix…
   - Give as much context as necessary and as little as possible
-  - Prefix it with [WIP] while it’s a work in progress
+  - Use a draft PR while it’s a work in progress
 -->
 
 ### WHY are these changes introduced?
@@ -20,3 +20,11 @@ Fixes #0000 <!-- link to issue if one exists -->
   Summary of the changes committed.
   Before / after screenshots appreciated for UI changes.
 -->
+
+### Update checklist
+<!--
+  Ideally, CHANGELOG entries should be in the format
+  `* [#PR](PR URL): Message`. You should consider adding your PR
+  and then making the CHANGELOG update once you know the PR number.
+-->
+- [ ] I've added a CHANGELOG entry for this PR (if the change is public-facing)

data/.github/workflows/release.yml

@@ -0,0 +1,61 @@
+name: Create Release
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+  create-release:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Extract tag name
+      id: tag
+      run: echo "::set-output name=value::${GITHUB_REF##*/}"
+    - uses: actions/checkout@v2
+    
+    - name: Set up Ruby
+      uses: actions/setup-ruby@v1.1.2
+      with:
+        ruby-version: 2.6
+    
+    - name: Install dependencies
+      run: bundle install
+
+    - name: Create package
+      run: bundle exec rake package
+
+    - name: Get Directory
+      id: folder
+      run: |
+        cd packaging/builds
+        echo ::set-output name=name::$(ls)
+    
+    - name: Get Packages
+      id: binaries
+      run: |
+        cd packaging/builds/${{ steps.folder.outputs.name }}
+        deb=$(find . -type f -name '*.deb')
+        rpm=$(find . -type f -name "*.rpm")
+        echo ::set-output name=deb_file::"${deb:2}"
+        echo ::set-output name=rpm_file::"${rpm:2}"
+
+    - uses: dawidd6/action-homebrew-bump-formula@v3
+      with:
+        token: ${{secrets.BREW_TOKEN}}
+        tap: shopify/shopify
+        formula: shopify-cli
+        tag: ${{ steps.folder.outputs.name }}
+
+    - name: Create Release # https://hub.github.com/hub-release.1.html
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
+        cd packaging/builds/${{ steps.folder.outputs.name }}
+        hub release create ${{ steps.tag.outputs.value }} \
+        -a ${{ steps.binaries.outputs.deb_file }} \
+        -a ${{ steps.binaries.outputs.rpm_file }} \
+        -m "Version ${{ steps.folder.outputs.name }}
+
+        Release of version ${{ steps.folder.outputs.name }} of the Shopify App CLI
+        Please refer to [CHANGELOG](https://github.com/Shopify/shopify-app-cli/blob/master/CHANGELOG.md) for details."

data/.github/workflows/triage.yml

@@ -0,0 +1,22 @@
+name: Triage new issues to DTE oncall project board ("Needs triage" column)
+
+on:
+  issues:
+    types: [opened, reopened]
+
+jobs:
+  triage-issue:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Extract issue id
+      id: issue
+      run: echo "::set-output name=id::$(jq -r '.issue.id' < "$GITHUB_EVENT_PATH")"
+
+    - name: Create card
+      env:
+        TOKEN: ${{ secrets.ACTIONS_TOKEN }}
+      run: |
+        curl -s -X POST -u "$GITHUB_ACTOR:$TOKEN" --retry 3 \
+          -H 'Accept: application/vnd.github.inertia-preview+json' \
+          -d "{\"content_type\": \"Issue\", \"content_id\": ${{ steps.issue.outputs.id }}}" \
+          "https://api.github.com/projects/columns/10507989/cards"

data/.gitignore

@@ -1,4 +1,3 @@
-.rubocop-*
 .tmp/*
 .bundle/*
 .DS_Store

data/.rubocop.yml

@@ -1,5 +1,43 @@
-inherit_from:
-  - https://shopify.github.io/ruby-style-guide/rubocop-cli.yml
+inherit_from: .rubocop_todo.yml
+
+require: rubocop-minitest
+
+inherit_gem:
+  rubocop-shopify:
+    - rubocop-cli.yml
+
+Minitest:
+  Enabled: true
+  Include:
+    - '**/test/**/*'
+    - '**/*_test.rb'
+
+Minitest/AssertInDelta: # (new in 0.10)
+  Enabled: true
+Minitest/AssertionInLifecycleHook: # (new in 0.10)
+  Enabled: true
+Minitest/AssertKindOf: # (new in 0.10)
+  Enabled: true
+Minitest/AssertOutput: # (new in 0.10)
+  Enabled: true
+Minitest/AssertPathExists: # (new in 0.10)
+  Enabled: false # only available from minitest 5.13.0
+Minitest/AssertSilent: # (new in 0.10)
+  Enabled: true
+Minitest/LiteralAsActualArgument: # (new in 0.10)
+  Enabled: true
+Minitest/MultipleAssertions: # (new in 0.10)
+  Enabled: true
+Minitest/RefuteInDelta: # (new in 0.10)
+  Enabled: true
+Minitest/RefuteKindOf: # (new in 0.10)
+  Enabled: true
+Minitest/RefutePathExists: # (new in 0.10)
+  Enabled: false # only available from minitest 5.13.0
+Minitest/TestMethodName: # (new in 0.10)
+  Enabled: true
+Minitest/UnspecifiedException: # (new in 0.10)
+  Enabled: true
 
 AllCops:
   Exclude:
@@ -13,6 +51,9 @@ Layout/EmptyLines:
     # Need extra line so comment at top isnt registered to the Dev namespace
     - 'lib/dev/helpers/chruby_reset.rb'
 
+Layout/EmptyLineBetweenDefs:
+  AllowAdjacentOneLineDefs: true
+
 # Changing this could effect the way the content is rendered.
 Layout/HeredocIndentation:
   Exclude:
@@ -36,12 +77,24 @@ Style/RegexpLiteral:
 
 Style/MethodCallWithArgsParentheses:
   IgnoredMethods:
+    - assert
+    - assert_equal
+    - assert_includes
+    - assert_nil
+    - assert_raises
+    - assert_requested # from Webmock
+    - puts
+    - raise
+    - refute
+    - refute_empty
+    - refute_nil
     - require
-    - require_relative
     - require_dependency
+    - require_relative
     - yield
-    - raise
-    - puts
-    - assert_equal
-    - assert
-    - refute
+
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'ext/shopify-cli/extconf.rb' # unsure if safe to remove
+    - 'lib/project_types/extension/messages/messages.rb' # unsure if safe to remove
+    - 'test/project_types/extension/extension_test_helpers/stubs/argo_script.rb' # unsure if save to remove

data/.rubocop_todo.yml

@@ -0,0 +1,11 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-12-01 16:33:09 UTC using RuboCop version 1.4.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 30
+Minitest/MultipleAssertions:
+  Max: 9

data/CHANGELOG.md

@@ -1,3 +1,28 @@
+Unreleased
+------
+
+Version 1.5.0
+-----
+* [#965](https://github.com/Shopify/shopify-app-cli/pull/965): Remove --no-optional when using npm to create new project
+* [#958](https://github.com/Shopify/shopify-app-cli/pull/958): Split `connect` command into project-specific functionality
+
+Version 1.4.1
+------
+* [#917](https://github.com/Shopify/shopify-app-cli/pull/917): Ensure analytics for create action includes the same fields as other commands
+
+Version 1.4.0
+------
+* Updates to tests, dependencies and internal tooling
+* [#924](https://github.com/Shopify/shopify-app-cli/pull/924): Improve debugging messages on Partner API errors
+
+Version 1.3.1
+------
+* Allow any characters in ngrok account names
+
+Version 1.3.0
+------
+* Support for new `shopify config analytics` command to enable/disable anonymous usage reporting
+
 Version 1.2.0
 ------
 * Improvements and new functionality to various internal components

data/Gemfile

@@ -8,14 +8,15 @@ group :development, :test do
   gem 'rake'
   gem 'pry-byebug'
   gem 'byebug'
-  gem 'rubocop'
+  gem 'rubocop-shopify', require: false
+  gem 'rubocop-minitest', require: false
 end
 
 group :test do
-  gem 'session'
   gem 'mocha', require: false
   gem 'minitest', '>= 5.0.0', require: false
   gem 'minitest-reporters', require: false
+  gem 'minitest-fail-fast', require: false
   gem 'fakefs', '>= 1.0', require: false
   gem 'webmock', require: false
   gem 'timecop', require: false

data/Gemfile.lock

@@ -1,61 +1,62 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     ansi (1.5.0)
     ast (2.4.1)
-    builder (3.2.3)
-    byebug (8.2.5)
-    coderay (1.1.2)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
+    builder (3.2.4)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    crack (0.4.4)
     fakefs (1.2.2)
-    hashdiff (0.3.2)
-    metaclass (0.0.4)
-    method_source (0.9.2)
-    minitest (5.11.3)
-    minitest-reporters (1.3.5)
+    hashdiff (1.0.1)
+    method_source (1.0.0)
+    minitest (5.14.2)
+    minitest-fail-fast (0.1.0)
+      minitest (~> 5)
+    minitest-reporters (1.4.2)
       ansi
       builder
       minitest (>= 5.0)
       ruby-progressbar
-    mocha (1.7.0)
-      metaclass (~> 0.0.1)
-    parallel (1.19.2)
-    parser (2.7.1.4)
+    mocha (1.11.2)
+    parallel (1.20.1)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.3.0)
-      byebug (~> 8.0)
-      pry (~> 0.10)
-    public_suffix (3.0.3)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
-    rubocop (0.89.1)
+    rubocop (1.4.1)
       parallel (~> 1.10)
-      parser (>= 2.7.1.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.3.0, < 1.0)
+      rubocop-ast (>= 1.1.1)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.3.0)
-      parser (>= 2.7.1.4)
+    rubocop-ast (1.1.1)
+      parser (>= 2.7.1.5)
+    rubocop-minitest (0.10.1)
+      rubocop (>= 0.87)
+    rubocop-shopify (1.0.7)
+      rubocop (~> 1.4)
     ruby-progressbar (1.10.1)
-    safe_yaml (1.0.4)
-    session (3.2.0)
-    timecop (0.9.1)
+    timecop (0.9.2)
     unicode-display_width (1.7.0)
-    webmock (2.3.2)
+    webmock (3.9.3)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
-      hashdiff
+      hashdiff (>= 0.4.0, < 2.0.0)
 
 PLATFORMS
   ruby
@@ -64,12 +65,13 @@ DEPENDENCIES
   byebug
   fakefs (>= 1.0)
   minitest (>= 5.0.0)
+  minitest-fail-fast
   minitest-reporters
   mocha
   pry-byebug
   rake
-  rubocop
-  session
+  rubocop-minitest
+  rubocop-shopify
   timecop
   webmock
 

data/RELEASING.md

@@ -2,50 +2,40 @@
 
 1. Check the Semantic Versioning page for info on how to version the new release: http://semver.org
 
-2. Create a branch named `release_X_Y_Z` (replacing `X_Y_Z` with the intended release version)
+1. Make sure you're on the most recent `master`
+   ```
+   $ git checkout master
+   $ git pull
+   ```
+
+1. Create a branch named `release_X_Y_Z` (replacing `X_Y_Z` with the intended release version)
    ```
    $ git checkout -b release_X_Y_Z
    ```
 
-3. Update the version of Shopify CLI in `lib/shopify-cli/version.rb`
+1. Update the version of Shopify CLI in `lib/shopify-cli/version.rb`
 
-4. Add an entry for the new release to `CHANGELOG.md`
+1. Add an entry for the new release to `CHANGELOG.md`
 
-5. Commit the changes with a commit message like "Packaging for release X.Y.Z"
+1. Commit the changes with a commit message like "Packaging for release X.Y.Z"
    ```
    $ git commit -am "Packaging for release vX.Y.Z"
    ```
 
-6. Push out the changes
+1. Push out the changes
    ```
    $ git push -u origin release_X_Y_Z
    ```
 
-7. Open a PR for the branch, get necessary approvals from code owners and merge into main branch. Note that the PR title will be the release note in Shipit, so make sure it mentions the release
+1. Open a PR for the branch, get necessary approvals from code owners and merge into main branch. Note that the PR title will be the release note in Shipit, so make sure it mentions the release
 
-8. Deploy using Shipit
+1. Deploy using Shipit
 
-9. On local machine and _AFTER_ gem has been published to https://rubygems.org, run
-   ```
-   $ rake package
-   ```
-   This will generate the `.deb`, `.rpm` and brew formula files, which will be located in `packaging/builds/X.Y.Z/`.
+1. Check the "Actions" tab to see if the _Create Release_ workflow is successful. 
+   The workflow will automatically create a [release](https://github.com/Shopify/shopify-app-cli/releases) with the latest tag and `.deb`, `.rpm` assets attached.
+
+2. Check the `Shopify/homebrew-shopify` repository for new PR `shopify-cli {version}`
+   * rename PR to `Packaging for release of v{version} of shopify-cli`
+   * when PR is approved, merge into main branch
 
-10. Clone the `Shopify/homebrew-shopify` repository (if not already cloned), and then
-    * create a branch named `release_X_Y_Z_of_shopify-cli`
-    * update the brew formula in `shopify-cli.rb` with the generated formula in `packaging/builds/X.Y.Z/` in the `Shopify/shopify-app-cli` repo (from step 9)
-    * commit the change and create a PR on the [Shopify Homebrew repository](https://github.com/Shopify/homebrew-shopify)
-    * when PR is approved, merge into main branch
 
-11. Go to [releases](https://github.com/Shopify/shopify-app-cli/releases) page of `Shopify/shopify-app-cli` repo and create a new release:
-    * use the tag created in step 8 by Shipit (should be "vX.Y.Z")
-    * release title = "Version X.Y.Z"
-    * description should be 
-      ```
-      Release of version X.Y.Z of Shopify App CLI
-    
-      Please refer to [CHANGELOG](https://github.com/Shopify/shopify-app-cli/blob/master/CHANGELOG.md) for details.
-      ```
-    * upload the `.deb` and `.rpm` files from `packaging/builds/X.Y.Z/` (generated in step 9)
-    * if it's a pre-release version, select the "This is a pre-release" checkbox
-    * and click "Publish release".