shoes-core 4.0.0.pre6 → 4.0.0.pre7

data/spec/shoes/shared_examples/style.rb

@@ -70,7 +70,7 @@ shared_examples_for "object with style" do
 
     it 'has a style getter for all styles' do
       subject.supported_styles.each do |style|
-        expect(subject).to respond_to("#{style}".to_sym)
+        expect(subject).to respond_to(style.to_s.to_sym)
       end
     end
   end

data/spec/shoes/slot_spec.rb

@@ -2,13 +2,14 @@ require 'spec_helper'
 
 describe Shoes::Slot do
   include_context "dsl app"
-  let(:parent) { app }
+  let(:parent) { Shoes::Stack.new(app, app, {}) }
 
   let(:left) { 44 }
   let(:top) { 66 }
   let(:width) { 111 }
   let(:height) { 333 }
   let(:input_opts) { {left: left, top: top, width: width, height: height} }
+
   subject(:slot) { Shoes::Slot.new(app, parent, input_opts) }
 
   before do
@@ -62,7 +63,7 @@ describe Shoes::Slot do
 
     describe 'with a block' do
       before :each do
-        subject.clear {add_text_block}
+        subject.clear { add_text_block }
       end
 
       it 'has one element afterwards' do
@@ -71,8 +72,24 @@ describe Shoes::Slot do
     end
   end
 
+  describe '#remove' do
+    before :each do
+      Shoes::Para.new app, slot, ['text']
+    end
+
+    it 'removes the child element' do
+      subject.remove
+      expect(subject.contents).to be_empty
+    end
+
+    it 'notifies the gui' do
+      expect(subject.gui).to receive(:remove)
+      subject.remove
+    end
+  end
+
   describe '#remove_child' do
-    let(:element) {Shoes::FakeElement.new subject}
+    let(:element) { Shoes::FakeElement.new subject }
 
     before :each do
       subject.add_child element
@@ -84,7 +101,7 @@ describe Shoes::Slot do
     end
 
     describe '2 elements' do
-      let(:element2) {Shoes::FakeElement.new subject}
+      let(:element2) { Shoes::FakeElement.new subject }
 
       before :each do
         subject.add_child element2
@@ -103,7 +120,7 @@ describe Shoes::Slot do
 
   describe "create_bound_block" do
     let(:callable) { double("block", call: nil) }
-    let(:block)    { Proc.new { callable.call(self) } }
+    let(:block)    { proc { callable.call(self) } }
 
     it "calls within the slot's context" do
       expect(subject).to receive(:eval_block).with(block)
@@ -121,12 +138,12 @@ describe Shoes::Slot do
     end
 
     describe "with children" do
-      let(:child) {
+      let(:child) do
         child_element = Shoes::FakeElement.new(subject, height: 100)
         child_element.absolute_top = 0
         child_element.gui = double('child gui').as_null_object
         child_element
-      }
+      end
 
       before do
         subject.add_child(child)

data/spec/shoes/span_spec.rb

@@ -29,12 +29,12 @@ describe Shoes::Span do
   end
 
   describe 'Looking up styles of the parent text' do
-    let(:white) {Shoes::COLORS[:white]}
-    let(:red) {Shoes::COLORS[:red]}
+    let(:white) { Shoes::COLORS[:white] }
+    let(:red) { Shoes::COLORS[:red] }
     it 'does not try to merge with parent style when there are none' do
       parent = double 'parent'
       span.parent = parent
-      expect {span.style}.to_not raise_error
+      expect { span.style }.to_not raise_error
     end
 
     it 'merges with the styles of the parent text' do
@@ -44,7 +44,7 @@ describe Shoes::Span do
     end
 
     describe 'with own style' do
-      let(:style) {{stroke: red}}
+      let(:style) { {stroke: red} }
       it 'prefers own values over parent text values' do
         parent = double 'parent', style: {stroke: white}
         span.parent = parent
@@ -64,7 +64,7 @@ describe Shoes::Span do
   describe 'code' do
     it 'sets font to Lucida Console' do
       result = app.code 'test'
-      expect(result.style[:font]).to eq(('Lucida Console'))
+      expect(result.style[:font]).to eq('Lucida Console')
     end
   end
 

data/spec/shoes/spec_helper.rb

@@ -9,7 +9,7 @@ def unpack_styles(styles)
   supported_styles = []
   styles.each do |style|
     if Shoes::Common::Style::STYLE_GROUPS[style]
-      Shoes::Common::Style::STYLE_GROUPS[style].each {|s| supported_styles << s}
+      Shoes::Common::Style::STYLE_GROUPS[style].each { |s| supported_styles << s }
     else
       supported_styles << style
     end

data/spec/shoes/stack_spec.rb

@@ -17,13 +17,13 @@ describe Shoes::Stack do
 
       def check_self_inside_stack
         inside_stack = nil
-        @app.stack do inside_stack = self end
+        @app.stack { inside_stack = self }
         inside_stack
       end
     end
 
     it 'does not change the context' do
-      app = Shoes.app do; end
+      app = Shoes.app { ; }
       context_object = ContextObject.new app
       inside_stack = context_object.check_self_inside_stack
       expect(inside_stack).to be context_object
@@ -36,17 +36,17 @@ describe Shoes::Stack do
     it_behaves_like 'arranges elements underneath each other'
 
     describe 'small stack height' do
-      let(:input_opts) {{height: element.height + 10}}
+      let(:input_opts) { {height: element.height + 10} }
       it_behaves_like 'set height and contents alignment'
     end
 
     describe 'big stack height' do
-      let(:input_opts) {{height: 1000}}
+      let(:input_opts) { {height: 1000} }
       it_behaves_like 'set height and contents alignment'
     end
 
     describe 'with margin' do
-      let(:input_opts) {{margin: 27}}
+      let(:input_opts) { {margin: 27} }
       it_behaves_like 'taking care of margin'
     end
   end

data/spec/shoes/text_block_dimensions_spec.rb

@@ -61,9 +61,12 @@ describe Shoes::TextBlockDimensions do
     end
 
     describe "with parent" do
-      let(:parent) { double('parent', element_width: 100,
-                                      x_dimension: double("x"),
-                                      y_dimension: double("y")) }
+      let(:parent) do
+        double('parent', element_width: 100,
+                         x_dimension: double("x"),
+                         y_dimension: double("y"))
+      end
+
       subject { Shoes::TextBlockDimensions.new(parent, left, top, nil, height) }
 
       it "delegates to parent if no width of its own" do

data/spec/shoes/text_block_spec.rb

@@ -275,7 +275,7 @@ describe Shoes::TextBlock do
   #   end
   #
   context "with nested text fragments" do
-    let(:helper) {Sample17Helper.new(app)}
+    let(:helper) { Sample17Helper.new(app) }
     let!(:para) { helper.create_para }
 
     it "has full text of fragments" do
@@ -284,12 +284,12 @@ describe Shoes::TextBlock do
 
     it "has fragment styles" do
       text_styles = {
-                     21..33 => [helper.strong_breadsticks],
-                     34..46 => [helper.em],
-                     47..59 => [helper.code],
-                     60..71 => [helper.bg, helper.fg, helper.strong, helper.ins],
-                     72..76 => [helper.sub]
-                    }
+        21..33 => [helper.strong_breadsticks],
+        34..46 => [helper.em],
+        47..59 => [helper.code],
+        60..71 => [helper.bg, helper.fg, helper.strong, helper.ins],
+        72..76 => [helper.sub]
+      }
       expect(para.text_styles).to eq(text_styles)
     end
 
@@ -305,4 +305,10 @@ describe Shoes::TextBlock do
       expect(helper.ins.text_block).to eq para
     end
   end
+
+  describe "links" do
+    it "finds em" do
+      expect(text_block.links).to eq([text_link])
+    end
+  end
 end

data/spec/shoes/text_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Shoes::Text do
+  include_context "dsl app"
+
+  let(:link) { Shoes::Link.new(app, ['link']) }
+
+  it "finds no links" do
+    text = Shoes::Text.new(['text'])
+    expect(text.links).to be_empty
+  end
+
+  it "finds a link" do
+    text = Shoes::Text.new(['text', link])
+    expect(text.links).to eq([link])
+  end
+
+  it "finds multiple" do
+    text = Shoes::Text.new([Shoes::Text.new(['yo', link]), link])
+    expect(text.links).to eq([link, link])
+  end
+end

data/spec/shoes/ui/picker_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 require 'shoes/ui/picker'
 
 describe Shoes::UI::Picker do
-  let(:swt_backend)  { "/gems/lib/shoes/swt/generate-backend.rb" }
-  let(:faux_backend) { "/gems/lib/shoes/faux/generate-backend.rb" }
+  let(:swt_backend)  { "/gems/lib/shoes/swt/generate_backend.rb" }
+  let(:faux_backend) { "/gems/lib/shoes/faux/generate_backend.rb" }
 
   let(:output) { StringIO.new }
   let(:input)  { StringIO.new }
 
-  subject  { Shoes::UI::Picker.new(input, output) }
+  subject { Shoes::UI::Picker.new(input, output) }
 
   it "selects single backend generator" do
     allow(Gem).to receive(:find_files) { [swt_backend] }

data/spec/shoes/url_spec.rb

@@ -44,21 +44,21 @@ describe 'Shoes.url' do
 
   it 'should receive path when visitting path' do
     expect_any_instance_of(klazz).to receive(:path)
-    Shoes.app do visit '/path' end
+    Shoes.app { visit '/path' }
   end
 
   it 'handles the arguments given in the regexes' do
     expect_any_instance_of(klazz).to receive(:number).with('7')
-    Shoes.app do visit '/number/7' end
+    Shoes.app { visit '/number/7' }
   end
 
   it 'can call methods defined in the URL class when visitting a URL' do
     expect_any_instance_of(klazz).to receive(:some_method)
-    Shoes.app do visit '/foo' end
+    Shoes.app { visit '/foo' }
   end
 
   it 'has a location method that returns the current URL' do
-    Shoes.app do visit('/visit_me') end
+    Shoes.app { visit('/visit_me') }
   end
 
   it 'instances report class as klazz (regression, do not ask...)' do

data/spec/shoes/widget_spec.rb

@@ -72,7 +72,7 @@ describe Shoes::Widget do
 
     it 'really smiles' do
       expect_any_instance_of(Smile).to receive(:smile_magic)
-      Shoes.app do visit '/smile' end
+      Shoes.app { visit '/smile' }
     end
   end
 end

data/spec/shoes_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Shoes, 'load_backend' do
-  it "raises ArgumentError on bad input" do
-    expect { Shoes.load_backend :bogus }.to raise_error(ArgumentError)
+  it "raises on bad input" do
+    expect { Shoes.load_backend :bogus }.to raise_error(LoadError)
   end
 end
 
@@ -21,7 +21,7 @@ describe Shoes, 'setup' do
     end
 
     it 'puts a warning message to $stderr' do
-      Shoes.setup do end
+      Shoes.setup {}
     end
 
     it 'warns for individual gems' do

data/spec/spec_helper.rb

@@ -2,7 +2,14 @@ SHOESSPEC_ROOT = File.expand_path('..', __FILE__)
 $LOAD_PATH << File.join(SHOESSPEC_ROOT)
 $LOAD_PATH << File.join(SHOESSPEC_ROOT, "../lib")
 
-require_relative '../../spec/code_coverage'
+# loaded again when executing DSL specs with the SWT backend, therefore
+# we souldn't start the test coverage again or override the command as it'd
+# mess up merging
+unless defined?(SimpleCov)
+  require_relative '../../spec/code_coverage'
+  SimpleCov.command_name 'spec:shoes'
+end
+
 require 'rspec'
 require 'rspec/its'
 require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shoes-core
 version: !ruby/object:Gem::Version
-  version: 4.0.0.pre6
+  version: 4.0.0.pre7
 platform: ruby
 authors:
 - Team Shoes
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-11-07 00:00:00.000000000 Z
+date: 2016-12-11 00:00:00.000000000 Z
 dependencies: []
 description: Shoes is the best little GUI toolkit for Ruby. Shoes makes building for Mac, Windows, and Linux super simple. This is the DSL for writing your app. You'll need a backend to run it.
 email:
@@ -24,7 +24,6 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- bin/shoes
 - bin/shoes-picker
 - bin/shoes-stub
 - ext/install/Rakefile
@@ -36,6 +35,7 @@ files:
 - lib/shoes/animation.rb
 - lib/shoes/app.rb
 - lib/shoes/arc.rb
+- lib/shoes/arrow.rb
 - lib/shoes/background.rb
 - lib/shoes/border.rb
 - lib/shoes/builtin_methods.rb
@@ -45,6 +45,7 @@ files:
 - lib/shoes/color/dsl.rb
 - lib/shoes/color/dsl_helpers.rb
 - lib/shoes/color/hex_converter.rb
+- lib/shoes/common/attachable.rb
 - lib/shoes/common/background_element.rb
 - lib/shoes/common/changeable.rb
 - lib/shoes/common/clickable.rb
@@ -52,6 +53,7 @@ files:
 - lib/shoes/common/hover.rb
 - lib/shoes/common/initialization.rb
 - lib/shoes/common/inspect.rb
+- lib/shoes/common/link_finder.rb
 - lib/shoes/common/positioning.rb
 - lib/shoes/common/registration.rb
 - lib/shoes/common/remove.rb
@@ -60,6 +62,7 @@ files:
 - lib/shoes/common/stroke.rb
 - lib/shoes/common/style.rb
 - lib/shoes/common/style_normalizer.rb
+- lib/shoes/common/translate.rb
 - lib/shoes/common/ui_element.rb
 - lib/shoes/common/visibility.rb
 - lib/shoes/configuration.rb
@@ -87,6 +90,7 @@ files:
 - lib/shoes/mock/animation.rb
 - lib/shoes/mock/app.rb
 - lib/shoes/mock/arc.rb
+- lib/shoes/mock/arrow.rb
 - lib/shoes/mock/background.rb
 - lib/shoes/mock/border.rb
 - lib/shoes/mock/button.rb
@@ -138,21 +142,25 @@ files:
 - lib/shoes/url.rb
 - lib/shoes/version.rb
 - lib/shoes/widget.rb
+- lib/shoes/window.rb
 - shoes-core.gemspec
 - spec/shoes/animation_spec.rb
 - spec/shoes/app_spec.rb
 - spec/shoes/arc_spec.rb
+- spec/shoes/arrow_spec.rb
 - spec/shoes/background_spec.rb
 - spec/shoes/border_spec.rb
 - spec/shoes/builtin_methods_spec.rb
 - spec/shoes/button_spec.rb
 - spec/shoes/check_spec.rb
 - spec/shoes/color_spec.rb
+- spec/shoes/common/attachable_spec.rb
 - spec/shoes/common/inspect_spec.rb
 - spec/shoes/common/remove_spec.rb
 - spec/shoes/common/rotate_spec.rb
 - spec/shoes/common/style_normalizer_spec.rb
 - spec/shoes/common/style_spec.rb
+- spec/shoes/common/translate_spec.rb
 - spec/shoes/configuration_spec.rb
 - spec/shoes/constants_spec.rb
 - spec/shoes/dialog_spec.rb
@@ -238,6 +246,7 @@ files:
 - spec/shoes/star_spec.rb
 - spec/shoes/text_block_dimensions_spec.rb
 - spec/shoes/text_block_spec.rb
+- spec/shoes/text_spec.rb
 - spec/shoes/ui/picker_spec.rb
 - spec/shoes/url_spec.rb
 - spec/shoes/widget_spec.rb
@@ -267,7 +276,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.6
+rubygems_version: 2.6.8
 signing_key:
 specification_version: 4
 summary: The best little DSL for the best little GUI toolkit for Ruby.
@@ -275,17 +284,20 @@ test_files:
 - spec/shoes/animation_spec.rb
 - spec/shoes/app_spec.rb
 - spec/shoes/arc_spec.rb
+- spec/shoes/arrow_spec.rb
 - spec/shoes/background_spec.rb
 - spec/shoes/border_spec.rb
 - spec/shoes/builtin_methods_spec.rb
 - spec/shoes/button_spec.rb
 - spec/shoes/check_spec.rb
 - spec/shoes/color_spec.rb
+- spec/shoes/common/attachable_spec.rb
 - spec/shoes/common/inspect_spec.rb
 - spec/shoes/common/remove_spec.rb
 - spec/shoes/common/rotate_spec.rb
 - spec/shoes/common/style_normalizer_spec.rb
 - spec/shoes/common/style_spec.rb
+- spec/shoes/common/translate_spec.rb
 - spec/shoes/configuration_spec.rb
 - spec/shoes/constants_spec.rb
 - spec/shoes/dialog_spec.rb
@@ -371,6 +383,7 @@ test_files:
 - spec/shoes/star_spec.rb
 - spec/shoes/text_block_dimensions_spec.rb
 - spec/shoes/text_block_spec.rb
+- spec/shoes/text_spec.rb
 - spec/shoes/ui/picker_spec.rb
 - spec/shoes/url_spec.rb
 - spec/shoes/widget_spec.rb