shoelace-rails 0.6.0 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 206ca8361dedd910c96e3c13469e9bad996af7d2a91a0ca0af2cb8e1a7430808
-  data.tar.gz: 64df314d89557bd02dbf791bddcc49185017f5cb1d22c5046a23f1767df5bf18
+  metadata.gz: 9ead8cbfce57323de6e03b0b4dc638eac355b3a9e7495747a17aaf79682e81ed
+  data.tar.gz: 9c84316ec90e6a29fb270b3d0c56d9dbc93b947c51aab3fa3c07bac5620f4399
 SHA512:
-  metadata.gz: 284ca5c08643f593de6554d02bb8e4857d141c8a4ddc02def92e573a273a3b45694e2ce14783779fbafe83eea1b9cbc85fd80ba52f36dc235e11d5cec6e9f6b1
-  data.tar.gz: 22ca68a850b08eebb0ad6d8fd48a8a7b65a3a4647acd34171f04cac20eca635475147804194957efe75fb4aeef68741b4b65fc3f10edc214165b3eb51addefcb
+  metadata.gz: 511f5b435164a36c9fe094ebdc905d05c3759cf469ec9559b9fd437171291b3b0b07361ecc674d120ed5b59b0683044582f1d5726c50f05df0e57ff972a185fc
+  data.tar.gz: 74f6c3f146f2aea79e9cce672c36840c4f416adf6ea14748dbfdf63ca0c92bbb1ad9041407df6ca91c93fd0334e6cb12e2e038fcb18d3eb13cdd970413459262

data/CHANGELOG.md

@@ -1,8 +1,24 @@
-## v0.6.0
+## v0.6.2
+
+#### 🐞Bug Fixes
+
+- Fixes a bug where form builders fail to render when it falls back to humanize the given method name
+
+## [v0.6.1](https://github.com/yuki24/shoelace-rails/tree/v0.6.1)
+
+_<sup>released at 2024-03-13 03:05:20 UTC</sup>_
+
+#### 🐞Bug Fixes
+
+- Fixes a bug where form builders fail to render with a string `:as` option
+
+## [v0.6.0](https://github.com/yuki24/shoelace-rails/tree/v0.6.0)
+
+_<sup>released at 2024-03-13 02:54:02 UTC</sup>_
 
 #### ⭐️ Features
 
-- Add the ability to use translations with form helpers
+- Add the ability to use translations with form helpers ([<tt>626f271</tt>](https://github.com/yuki24/shoelace-rails/commit/626f271ca710dd48040907ff6a99e3bba6c5d57c))
 
 ## [v0.5.0](https://github.com/yuki24/shoelace-rails/tree/v0.5.0)
 

data/app/helpers/shoelace/form_helper.rb

@@ -57,7 +57,7 @@ module Shoelace
         options = @options.stringify_keys
         options["value"] = options.fetch("value") { value_before_type_cast }
         add_default_name_and_id(options)
-        label = options.delete('label').presence || @method_name.humanize
+        label = options.delete('label').presence || @method_name.to_s.humanize
 
         @template_object.content_tag('sl-switch', label, options, &block)
       end
@@ -124,7 +124,7 @@ module Shoelace
         options = @options.stringify_keys
         options["value"]   = @checked_value
         options["checked"] = true if input_checked?(options)
-        label = options.delete("label") || @method_name.humanize
+        label = options.delete("label") || @method_name.to_s.humanize
 
         if options["multiple"]
           add_default_name_and_id_for_value(@checked_value, options)
@@ -183,7 +183,7 @@ module Shoelace
         html_options = @html_options.stringify_keys
         html_options["value"] = value
         add_default_name_and_id(html_options)
-        html_options["label"] = @options[:label].presence || @method_name.humanize
+        html_options["label"] = @options[:label].presence || @method_name.to_s.humanize
 
         @template_object.content_tag('sl-radio-group', html_options) { super(&block) }
       end
@@ -270,7 +270,7 @@ module Shoelace
       private
 
       def label_text(method, tag_value = nil)
-        ::ActionView::Helpers::Tags::Label::LabelBuilder.new(@template, object_name, method, object, tag_value).translation
+        ::ActionView::Helpers::Tags::Label::LabelBuilder.new(@template, object_name.to_s, method.to_s, object, tag_value).translation
       end
     end
 

data/lib/shoelace/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Shoelace
   module Rails
-    VERSION = "0.6.0"
+    VERSION = "0.6.2"
   end
 end

data/test/helpers/translation_test.rb

@@ -34,6 +34,24 @@ class TranslationTest < ActionView::TestCase
     end
   end
 
+  test "Form helpers should cast symbol object names to String" do
+    sl_form_for(User.new, as: :user, url: "/") do |form|
+      assert_dom_equal <<~HTML, form.text_field(:name)
+        <sl-input label="Full Name" type="text" name="user[name]" id="user_name"></sl-input>
+      HTML
+    end
+  end
+
+  test "Form helpers should fall back to the humanize method when there is no matching translation" do
+    I18n.backend.reload!
+
+    sl_form_for(OpenStruct.new, as: :user, url: "/") do |form|
+      assert_dom_equal <<~HTML, form.text_field(:name_eq)
+        <sl-input label="Name eq" type="text" name="user[name_eq]" id="user_name_eq"></sl-input>
+      HTML
+    end
+  end
+
   test "#color_field should respect label translations" do
     sl_form_for(User.new, url: "/") do |form|
       assert_dom_equal <<~HTML, form.color_field(:name)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shoelace-rails
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.2
 platform: ruby
 authors:
 - Yuki Nishijima