shipit-engine 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1dc1f1894044cb766ca0ba066ca7a064ce832721
-  data.tar.gz: abd419734fa453bf807439d93a1e26bf8403bcd7
+  metadata.gz: 74cc484927228d18c31d24f110e2341307e984ef
+  data.tar.gz: 808334ec6a06615b548eb0e20e47571fb943599d
 SHA512:
-  metadata.gz: d665cb11cb34a3c350e13130162647d3b787987e92a9673607bd771539c1edb5448a6a59a3211dd3a2c2fe4e9666b27d00944efbf9880463216c6ae03e01bcd1
-  data.tar.gz: 33219abcdc9acaccddd18bc765ce4e8fc2bbb392aaeab90b7dc0ab1c5a4364d764bf790db948e2601f9a353dfff3f3641704ae2f99f229b9a7138f4a64a6e55f
+  metadata.gz: 10ea80eaae7515e6850a8c3e690b1b16da2f99e72760c361ea066186039090df31ec9beac04243421026b61f46c72346402dce98481291aee43f9dd286b51e52
+  data.tar.gz: 818be40a841487e4d453cfc44ebb9cce0d6b1ba262ebcc1b84a1882af8eccbf50bb65a03c56f25ff68acf214e771e1ff3f2ccb3093ce6790e179b06d6d3de5da

data/app/models/shipit/user.rb

@@ -62,7 +62,11 @@ module Shipit
 
     def github_user=(github_user)
       return unless github_user
-      github_user = github_user.rels[:self].get.data unless github_user.name
+
+      if github_user.name.nil? && github_user.rels && github_user.rels[:self]
+        github_user = github_user.rels[:self].get.data
+      end
+
       assign_attributes(
         github_id: github_user.id,
         name: github_user.name || github_user.login, # Name is not mandatory on GitHub

data/lib/shipit/version.rb

@@ -1,3 +1,3 @@
 module Shipit
-  VERSION = '0.8.6'
+  VERSION = '0.8.7'
 end

data/test/models/users_test.rb

@@ -12,6 +12,15 @@ module Shipit
         avatar_url: 'https://avatars.githubusercontent.com/u/42?v=3',
         url: 'https://api.github.com/user/george',
       )
+      @minimal_github_user = stub(
+        id: 43,
+        name: nil,
+        login: 'peter',
+        email: nil,
+        avatar_url: 'https://avatars.githubusercontent.com/u/43?v=3',
+        url: 'https://api.github.com/user/peter',
+        rels: nil,
+      )
     end
 
     test "find_or_create_from_github persist a new user if he is unknown" do
@@ -48,6 +57,11 @@ module Shipit
       assert_equal @github_user.login, user.login
     end
 
+    test "find_or_create_from_github accepts minimal users without name nor email" do
+      user = User.find_or_create_from_github(@minimal_github_user)
+      assert_equal @minimal_github_user.login, user.login
+    end
+
     test "#identifiers_for_ping returns a hash with the user's github_id, name, email and github_login" do
       user = shipit_users(:bob)
       expected_ouput = {github_id: user.github_id, name: user.name, email: user.email, github_login: user.login}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shipit-engine
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-14 00:00:00.000000000 Z
+date: 2016-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake