shipit-engine 0.38.0 → 0.40.0

data/test/models/shipit/webhooks/handlers/pull_request/unlabeled_handler_test.rb

@@ -18,13 +18,15 @@ module Shipit
           end
 
           test "ignores Github PullRequest webhooks by default" do
-            UnlabeledHandler.new(payload_parsed(:pull_request_with_no_repo).merge(action: "closed")).process
+            assert_no_difference -> { Shipit::PullRequest.count } do
+              UnlabeledHandler.new(payload_parsed(:pull_request_with_no_repo).merge(action: "closed")).process
+            end
           end
 
           test "ignores Github PullRequest webhooks when the Repository has disabled the Review Stacks feature" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               provisioning_enabled: false,
               behavior: :allow_with_label,
               label: "pull-requests-label"
@@ -45,7 +47,7 @@ module Shipit
             stack = create_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -59,7 +61,7 @@ module Shipit
             stack = create_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -72,7 +74,7 @@ module Shipit
           test "ignores Github PullRequest webhooks when the repository allow_with_label to create ReviewStacks and the label is absent" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -86,7 +88,7 @@ module Shipit
             stack = create_archived_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -102,7 +104,7 @@ module Shipit
           test "creates and provisions a new review stack when the repository creates ReviewStacks with allow_with_label and the label is present" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -124,7 +126,7 @@ module Shipit
             stack = create_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -140,7 +142,7 @@ module Shipit
             stack = create_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -155,7 +157,7 @@ module Shipit
           test "ignores Github PullRequest webhooks when the repository prevent_with_label to create ReviewStacks and the label is present" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -171,7 +173,7 @@ module Shipit
             stack = create_archived_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -187,7 +189,7 @@ module Shipit
           test "creates and provisions a new review stack when the repository creates ReviewStacks with prevent_with_label and the label is absent" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -208,7 +210,7 @@ module Shipit
           test "assigns the PullRequest to newly created stacks" do
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :prevent_with_label,
               label: "pull-requests-label"
             )
@@ -224,7 +226,7 @@ module Shipit
             create_archived_stack
             repository = shipit_repositories(:shipit)
             configure_provisioning_behavior(
-              repository: repository,
+              repository:,
               behavior: :allow_with_label,
               label: "pull-requests-label"
             )
@@ -273,8 +275,8 @@ module Shipit
 
           def complete_active_tasks(stack)
             active_tasks = stack
-              .tasks
-              .active
+                           .tasks
+                           .active
 
             active_tasks.map(&:run)
             active_tasks.reload
@@ -290,32 +292,32 @@ module Shipit
 
           setup do
             Shipit.github.api.stubs(:commit)
-              .with("shopify/shipit-engine", "ec26c3e57ca3a959ca5aad62de7213c562f8c821")
-              .returns(
-                resource(
-                  {
-                    sha: "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
-                    commit: {
-                      author: {
-                        name: "Codertocat",
-                        email: "21031067+Codertocat@users.noreply.github.com",
-                        date: "2019-05-15 15:20:30",
-                      },
-                      committer: {
-                        name: "Codertocat",
-                        email: "21031067+Codertocat@users.noreply.github.com",
-                        date: "2019-05-15 15:20:30",
-                      },
-                      message: "Update README.md",
-                    },
-                    stats: {
-                      total: 2,
-                      additions: 1,
-                      deletions: 1,
-                    },
-                  }
-                )
-              )
+                  .with("shopify/shipit-engine", "ec26c3e57ca3a959ca5aad62de7213c562f8c821")
+                  .returns(
+                    resource(
+                      {
+                        sha: "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
+                        commit: {
+                          author: {
+                            name: "Codertocat",
+                            email: "21031067+Codertocat@users.noreply.github.com",
+                            date: "2019-05-15 15:20:30"
+                          },
+                          committer: {
+                            name: "Codertocat",
+                            email: "21031067+Codertocat@users.noreply.github.com",
+                            date: "2019-05-15 15:20:30"
+                          },
+                          message: "Update README.md"
+                        },
+                        stats: {
+                          total: 2,
+                          additions: 1,
+                          deletions: 1
+                        }
+                      }
+                    )
+                  )
           end
         end
       end

data/test/models/shipit/webhooks/handlers_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/models/status/group_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -21,7 +22,7 @@ module Shipit
     end
 
     test "#state is significant's status state" do
-      assert_equal %w(success success failure), @group.statuses.map(&:state)
+      assert_equal %w[success success failure], @group.statuses.map(&:state)
       assert_equal 'failure', @group.state
     end
 
@@ -42,7 +43,7 @@ module Shipit
     end
 
     test "missing required status will have MissingRequiredStatus as placeholder" do
-      @commit.stubs(:required_statuses).returns(%w(ci/very-important))
+      @commit.stubs(:required_statuses).returns(%w[ci/very-important])
       status = Status::Group.compact(@commit, [])
       assert_instance_of Status::Missing, status
       assert_predicate status, :pending?

data/test/models/status/missing_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/models/status_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -50,7 +51,7 @@ module Shipit
         description: 'This is a description',
         context: 'default',
         target_url: 'http://example.com',
-        created_at: 1.day.ago.to_time,
+        created_at: 1.day.ago.to_time
       )
     end
 

data/test/models/task_definitions_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -7,7 +8,7 @@ module Shipit
       @definition = TaskDefinition.new(
         'restart',
         'action' => 'Restart application',
-        'title' => 'Restart application %{FOO}',
+        'title' => 'Restart application %<FOO>s',
         'description' => 'Restart app and job servers',
         'steps' => ['touch tmp/restart'],
         'allow_concurrency' => true,
@@ -15,8 +16,8 @@ module Shipit
           { 'name' => 'FOO', 'title' => 'Set to 0 to foo', 'default' => '1' },
           { 'name' => 'BAR', 'title' => 'Set to 1 to bar', 'default' => '0' },
           { 'name' => 'WALRUS', 'title' => 'Use with caution', 'default' => ' ' },
-          { 'name' => 'NODEFAULT', 'title' => 'Variable without default' },
-        ],
+          { 'name' => 'NODEFAULT', 'title' => 'Variable without default' }
+        ]
       )
     end
 
@@ -38,7 +39,7 @@ module Shipit
       as_json = {
         id: 'restart',
         action: 'Restart application',
-        title: "Restart application %{FOO}",
+        title: "Restart application %<FOO>s",
         description: 'Restart app and job servers',
         steps: ['touch tmp/restart'],
         checklist: [],
@@ -47,8 +48,8 @@ module Shipit
           { 'name' => 'FOO', 'title' => 'Set to 0 to foo', 'default' => '1', 'select' => nil },
           { 'name' => 'BAR', 'title' => 'Set to 1 to bar', 'default' => '0', 'select' => nil },
           { 'name' => 'WALRUS', 'title' => 'Use with caution', 'default' => ' ', 'select' => nil },
-          { 'name' => 'NODEFAULT', 'title' => 'Variable without default', 'default' => '', 'select' => nil },
-        ],
+          { 'name' => 'NODEFAULT', 'title' => 'Variable without default', 'default' => '', 'select' => nil }
+        ]
       }
       assert_equal as_json, TaskDefinition.load(TaskDefinition.dump(@definition)).as_json
     end

data/test/models/tasks_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -16,7 +17,7 @@ module Shipit
 
     test '#title returns an error message when the title raises an error' do
       task = shipit_tasks(:shipit_with_title_parsing_issue)
-      assert_equal 'This task (title: Using the %{WRONG_VARIABLE_NAME}) cannot be shown due to an incorrect variable name. Check your shipit.yml file', task.title
+      assert_equal 'This task (title: Using the %<WRONG_VARIABLE_NAME>) cannot be shown due to an incorrect variable name. Check your shipit.yml file', task.title
     end
 
     test "#write sends line-buffered output to task logger" do
@@ -44,7 +45,7 @@ module Shipit
       # We don't use assert_includes because it will print the whole message
       assert(
         output.include?(Task::OUTPUT_TRUNCATED_MESSAGE),
-        "'#{Task::OUTPUT_TRUNCATED_MESSAGE.chomp}' was not present in the output",
+        "'#{Task::OUTPUT_TRUNCATED_MESSAGE.chomp}' was not present in the output"
       )
     end
 
@@ -94,7 +95,7 @@ module Shipit
       task.update(
         rolled_up: false,
         created_at: (60 + 1).minutes.ago.to_formatted_s(:db),
-        status: "success",
+        status: "success"
       )
 
       assert_includes Shipit::Task.due_for_rollup, task
@@ -105,7 +106,7 @@ module Shipit
       task.update(
         rolled_up: false,
         created_at: (60 + 1).minutes.ago.to_formatted_s(:db),
-        status: "error",
+        status: "error"
       )
 
       assert_includes Shipit::Task.due_for_rollup, task

data/test/models/team_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -34,7 +35,7 @@ module Shipit
       skip unless limit
 
       slug = 'a' * 255
-      team = new_team(slug: slug)
+      team = new_team(slug:)
 
       response = stub(rels: {}, data: [team])
       Shipit.github.api.expects(:org_teams).with('shopify', per_page: 100).returns(response.data)
@@ -61,7 +62,7 @@ module Shipit
         login: 'george',
         email: 'george@cyclim.se',
         avatar_url: 'https://avatars.githubusercontent.com/u/42?v=3',
-        url: 'https://api.github.com/user/george',
+        url: 'https://api.github.com/user/george'
       )
     end
 
@@ -69,10 +70,10 @@ module Shipit
       stub(
         id: 24,
         name: 'New Team',
-        slug: slug,
+        slug:,
         url: 'https://example.com',
         description: 'The Best one',
-        organization: 'shopify',
+        organization: 'shopify'
       )
     end
   end

data/test/models/undeployed_commits_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -41,9 +42,9 @@ module Shipit
     end
 
     test "#expected_to_be_deployed? returns true if the stack has continuous deployment enabled, next expected commit to deploy id is greater or equals to the commit id and commit is not active" do
-      commit = shipit_commits(:undeployed_4)
+      commit = shipit_commits(:undeployed4)
       next_expected_commit_to_deploy = commit.stack.next_expected_commit_to_deploy
-      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: next_expected_commit_to_deploy)
+      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy:)
 
       refute_predicate next_expected_commit_to_deploy, :nil?
       assert_predicate undeployed_commit.stack, :continuous_deployment
@@ -56,7 +57,7 @@ module Shipit
     test "#expected_to_be_deployed? returns true if the active task has no commit range" do
       commit = shipit_commits(:task_no_commits)
       next_expected_commit_to_deploy = commit.stack.next_expected_commit_to_deploy
-      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: next_expected_commit_to_deploy)
+      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy:)
 
       refute_predicate next_expected_commit_to_deploy, :nil?
       assert_predicate undeployed_commit.stack, :continuous_deployment
@@ -69,7 +70,7 @@ module Shipit
     test "#expected_to_be_deployed? returns false if the stack has continuous deployment disabled" do
       commit = shipit_commits(:cyclimse_first)
       next_expected_commit_to_deploy = commit.stack.next_expected_commit_to_deploy
-      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: next_expected_commit_to_deploy)
+      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy:)
 
       refute_predicate next_expected_commit_to_deploy, :nil?
       refute_predicate undeployed_commit.stack, :continuous_deployment
@@ -80,9 +81,9 @@ module Shipit
     end
 
     test "#expected_to_be_deployed? returns false if the commit is part of the active task" do
-      commit = shipit_commits(:undeployed_3)
+      commit = shipit_commits(:undeployed3)
       next_expected_commit_to_deploy = commit.stack.next_expected_commit_to_deploy
-      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: next_expected_commit_to_deploy)
+      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy:)
 
       refute_predicate next_expected_commit_to_deploy, :nil?
       assert_predicate undeployed_commit.stack, :continuous_deployment
@@ -93,16 +94,16 @@ module Shipit
     end
 
     test "#expected_to_be_deployed? returns false if there is no commit to deploy" do
-      commit = shipit_commits(:undeployed_3)
+      commit = shipit_commits(:undeployed3)
       undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: nil)
 
       refute_predicate undeployed_commit, :expected_to_be_deployed?
     end
 
     test "#expected_to_be_deployed? returns false if the commit has an id greater than next commit to deploy" do
-      commit = shipit_commits(:undeployed_7)
+      commit = shipit_commits(:undeployed7)
       next_expected_commit_to_deploy = commit.stack.next_expected_commit_to_deploy
-      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy: next_expected_commit_to_deploy)
+      undeployed_commit = UndeployedCommit.new(commit, index: 1, next_expected_commit_to_deploy:)
 
       refute_predicate next_expected_commit_to_deploy, :nil?
       assert_predicate undeployed_commit.stack, :continuous_deployment

data/test/models/users_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -12,7 +13,7 @@ module Shipit
         login: 'george',
         email: 'george@cyclim.se',
         avatar_url: 'https://avatars.githubusercontent.com/u/42?v=3',
-        url: 'https://api.github.com/user/george',
+        url: 'https://api.github.com/user/george'
       )
       @org_domain = "shopify.com"
       @emails_url = "https://api.github.com/user/emails"
@@ -23,7 +24,7 @@ module Shipit
         email: nil,
         avatar_url: 'https://avatars.githubusercontent.com/u/43?v=3',
         url: 'https://api.github.com/user/peter',
-        rels: nil,
+        rels: nil
       )
     end
 
@@ -78,7 +79,7 @@ module Shipit
         login: 'jim',
         email: "jim@#{@org_domain}",
         avatar_url: 'https://avatars.githubusercontent.com/u/42?v=3',
-        url: 'https://api.github.com/user/jim',
+        url: 'https://api.github.com/user/jim'
       )
 
       Shipit.preferred_org_emails = [].freeze
@@ -91,9 +92,9 @@ module Shipit
       expected_email = "myuser@#{@org_domain}"
 
       stub_request(:get, @emails_url).to_return(
-        status: %w(200 OK),
+        status: %w[200 OK],
         body: [{ email: expected_email }].to_json,
-        headers: { "Content-Type" => "application/json" },
+        headers: { "Content-Type" => "application/json" }
       )
 
       user = User.find_or_create_from_github(@github_user)
@@ -106,21 +107,21 @@ module Shipit
       result_email_records = [
         {
           email: "notmyuser1@#{@org_domain}",
-          primary: false,
+          primary: false
         },
         {
-          email: "notmyuser2@#{@org_domain}",
+          email: "notmyuser2@#{@org_domain}"
         },
         {
           email: expected_email,
-          primary: true,
-        },
+          primary: true
+        }
       ]
 
       stub_request(:get, @emails_url).to_return(
-        status: %w(200 OK),
+        status: %w[200 OK],
         body: result_email_records.to_json,
-        headers: { "Content-Type" => "application/json" },
+        headers: { "Content-Type" => "application/json" }
       )
 
       user = User.find_or_create_from_github(@github_user)
@@ -132,17 +133,17 @@ module Shipit
       result_email_records = [
         {
           email: "notmyuser1@not#{@org_domain}",
-          primary: false,
+          primary: false
         },
         {
-          email: "notmyuser2@not#{@org_domain}",
-        },
+          email: "notmyuser2@not#{@org_domain}"
+        }
       ]
 
       stub_request(:get, @emails_url).to_return(
-        status: %w(200 OK),
+        status: %w[200 OK],
         body: result_email_records.to_json,
-        headers: { "Content-Type" => "application/json" },
+        headers: { "Content-Type" => "application/json" }
       )
 
       user = User.find_or_create_from_github(@github_user)
@@ -203,6 +204,14 @@ module Shipit
       assert_equal 'george@cyclim.se', user.email
     end
 
+    test "#refresh_from_github! logs deleted users" do
+      Shipit.github.api.expects(:user).with(@user.github_id).raises(Octokit::Forbidden)
+
+      Rails.logger.expects(:info).with("User #{@user.name}, github_id #{@user.github_id} has forbidden access to their GitHub, likely deleted.")
+
+      @user.refresh_from_github!
+    end
+
     test "#github_api uses the user's access token" do
       assert_equal @user.github_access_token, @user.github_api.access_token
     end
@@ -265,15 +274,15 @@ module Shipit
             id: user.github_id,
             name: user.name,
             email: user.email,
-            date: Time.now.utc,
+            date: Time.now.utc
           },
           committer: {
             name: user.name,
             email: user.email,
-            date: Time.now.utc,
+            date: Time.now.utc
           },
-          message: "commit to trigger staging build\n\nMerge-Requested-By: missinguser\n",
-        },
+          message: "commit to trigger staging build\n\nMerge-Requested-By: missinguser\n"
+        }
       )
       found_user = Shipit::User.find_or_create_author_from_github_commit(github_commit)
       assert_equal user, found_user

data/test/test_command_integration.rb

@@ -16,7 +16,7 @@ expected_output = [
   "Sleeping for 10 seconds\r\n",
   "\e[1;31mNo output received in the last 2 seconds.\e[0m\n",
   "\e[1;31mSending SIGINT to PID #{command.pid}\n\e[0m",
-  "Recieved SIGINT, aborting.\r\n",
+  "Recieved SIGINT, aborting.\r\n"
 ]
 
 unless buffer.join == expected_output.join

data/test/test_helper.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
+
 ENV["RAILS_ENV"] ||= "test"
 
-if Warning.respond_to?(:[]=)
-  Warning[:deprecated] = true
-end
+Warning[:deprecated] = true if Warning.respond_to?(:[]=)
 
 require 'simplecov'
 SimpleCov.start('rails') do
@@ -12,10 +11,10 @@ end
 
 require 'webmock/minitest'
 
-require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+require File.expand_path('../test/dummy/config/environment.rb', __dir__)
 ActiveRecord::Migrator.migrations_paths = [
-  File.expand_path('../../test/dummy/db/migrate', __FILE__),
-  File.expand_path('../../db/migrate', __FILE__),
+  File.expand_path('../test/dummy/db/migrate', __dir__),
+  File.expand_path('../db/migrate', __dir__)
 ]
 require 'rails/test_help'
 require 'mocha/minitest'
@@ -23,11 +22,11 @@ require 'spy/integration'
 
 # Load fixtures from the engine
 if ActiveSupport::TestCase.respond_to?(:fixture_path=)
-  ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
+  ActiveSupport::TestCase.fixture_paths << File.expand_path('fixtures', __dir__)
   ActiveSupport::TestCase.fixtures(:all)
 end
 
-Dir[File.expand_path('../helpers/**/*.rb', __FILE__)].each do |helper|
+Dir[File.expand_path('helpers/**/*.rb', __dir__)].each do |helper|
   require helper
 end
 
@@ -66,12 +65,15 @@ module ActiveSupport
     teardown do
       Shipit.redis.flushdb
       Shipit.instance_variable_names.each do |name|
-        next if %w(@mocha @redis).include?(name)
+        next if %w[@mocha @redis].include?(name)
+
         Shipit.remove_instance_variable(name)
       end
     end
 
-    ActiveRecord::Migration.check_pending!
+    ActiveRecord::Migration.check_all_pending!
+
+    fixture_paths << File.expand_path('fixtures', __dir__)
 
     # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order.
     #

data/test/unit/anonymous_user_serializer_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit

data/test/unit/command_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Shipit
@@ -54,12 +55,20 @@ module Shipit
       assert_equal 10, command.timeout
     end
 
+    test "#timeout in duration string form" do
+      command = Command.new({ 'cap $LANG deploy' => { 'timeout' => '10m' } }, default_timeout: 5, env: {}, chdir: '.')
+      assert_equal 600, command.timeout
+
+      command = Command.new({ 'cap $LANG deploy' => { 'timeout' => '10B' } }, default_timeout: 5, env: {}, chdir: '.')
+      assert_equal 5, command.timeout # default
+    end
+
     test "the process is properly terminated if it times out" do
       # Minitest being run in an at_exit callback, signal handling etc is unreliable
       assert system(
         Engine.root.join('test/dummy/bin/rails').to_s,
         'runner',
-        Engine.root.join('test/test_command_integration.rb').to_s,
+        Engine.root.join('test/test_command_integration.rb').to_s
       )
     end