shipit-engine 0.36.0 → 0.36.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3336765264c2c554f5dd879ac8ed409b08e4f5b281bbd9127132b688d23184ee
-  data.tar.gz: ac55d9a82c007326c9a231b784d887be1a826ba11cc71c581888a0018ffaed7b
+  metadata.gz: 17cf66ed4359907e35e37a0ac00bcb05884c24148386bf8712d8b73c3cc33708
+  data.tar.gz: b21d35454c554c7faccad5236333cefc3270434617e4bd192372c0a8baa66ac1
 SHA512:
-  metadata.gz: a770a63ffadea62d25d8244265d5ea9552930fee64951d6c4b1e5be4a518271d54d34161b83a8760c9331c6f2758995e61114000bfcf5675b0353a955cc41bad
-  data.tar.gz: 7e7d3629476bab8aa1ab7655e099e6218b511fe728ef9161a2591835ae2c369cd22724e7c193243fd29779574ea1148b2adb97119ce8a04def1a46df0168d62c
+  metadata.gz: 1f8e6ba6aaaa5eaa4630cfb52a1445e416e4cb6566550c4a5e2ec447065b2d342c52a728b370552a8b7a2a7df8061c30b0d4987d637729d533fd1bfd907a074a
+  data.tar.gz: 94abc1c12513349c85d4d54c4668865f21a42bf055d630fca667fd636dd7119b42f31c11f5c2182f2412ed76601adecce38b096a1add9e978dd83279b600d7fb

data/README.md

@@ -134,6 +134,19 @@ Lastly, if you override the `app_name` configuration in your Shipit deployment,
 
 * * *
 
+<h3 id="respecting-bare-files">Respecting bare <code>shipit.yml</code> files</h3>
+
+Shipit will, by default, respect the "bare" <code>shipit.yml</code> file as a fallback option if no more specifically-named file exists (such as <code>shipit.staging.yml</code>).
+
+You can configure this behavior via the attribute <code>Shipit.respect_bare_shipit_file</code>.
+
+- The value <code>false</code> will disable this behavior and instead cause Shipit to emit an error upon deploy if Shipit cannot find a more specifically-named file.
+- Setting this attribute to any other value (**including <code>nil</code>**), or not setting this attribute, will cause Shipit to use the default behavior of respecting bare <code>shipit.yml</code> files.
+
+You can determine if Shipit is configured to respect bare files using <code>Shipit.respect_bare_shipit_file?</code>.
+
+* * *
+
 <h3 id="installing-dependencies">Installing dependencies</h3>
 
 The **<code>dependencies</code>** step allows you to install all the packages your deploy script needs.

data/app/controllers/shipit/api/stacks_controller.rb

@@ -62,7 +62,7 @@ module Shipit
       end
 
       def refresh
-        GithubSyncJob.perform_later(id: stack.id)
+        GithubSyncJob.perform_later(stack_id: stack.id)
         render_resource(stack, status: :accepted)
       end
 

data/app/controllers/shipit/rollbacks_controller.rb

@@ -5,7 +5,11 @@ module Shipit
     before_action :load_deploy
 
     def create
-      @rollback = @deploy.trigger_rollback(current_user, env: rollback_params[:env], force: params[:force].present?)
+      @rollback = @deploy.trigger_rollback(
+        current_user,
+        env: rollback_params[:env]&.to_unsafe_hash,
+        force: params[:force].present?,
+      )
       redirect_to(stack_deploy_path(@stack, @rollback))
     rescue Task::ConcurrentTaskRunning
       redirect_to(rollback_stack_deploy_path(@stack, @deploy))

data/app/models/shipit/api_client.rb

@@ -8,7 +8,7 @@ module Shipit
 
     validates :creator, :name, presence: true
 
-    serialize :permissions, Array
+    serialize :permissions, Shipit.serialized_column(:permissions, type: Array)
     PERMISSIONS = %w(
       read:stack
       write:stack

data/app/models/shipit/delivery.rb

@@ -9,7 +9,7 @@ module Shipit
     validates :url, presence: true, url: { no_local: true, allow_blank: true }
     validates :content_type, presence: true
 
-    serialize :response_headers, JSON
+    serialize :response_headers, SafeJSON
 
     after_commit :purge_old_deliveries, on: :create
 

data/app/models/shipit/deploy.rb

@@ -128,6 +128,7 @@ module Shipit
       lock_reason = "A rollback for #{until_commit.sha} has been triggered. " \
         "Please make sure the reason for the rollback has been addressed before deploying again."
       stack.update!(lock_reason: lock_reason, lock_author_id: user_id)
+      stack.emit_lock_hooks
       rollback
     end
 

data/app/models/shipit/deploy_spec/file_system.rb

@@ -91,10 +91,30 @@ module Shipit
       end
 
       def load_config
-        read_config(file("#{app_name}.#{@env}.yml", root: true)) ||
-          read_config(file("#{app_name}.yml", root: true)) ||
-          read_config(file("shipit.#{@env}.yml", root: true)) ||
-          read_config(file('shipit.yml', root: true))
+        return if config_file_path.nil?
+
+        if !Shipit.respect_bare_shipit_file? && config_file_path.to_s.end_with?(*bare_shipit_filenames)
+          return { 'deploy' => { 'pre' => [shipit_not_obeying_bare_file_echo_command, 'exit 1'] } }
+        end
+
+        read_config(config_file_path)
+      end
+
+      def shipit_file_names_in_priority_order
+        ["#{app_name}.#{@env}.yml", "#{app_name}.yml", "shipit.#{@env}.yml", "shipit.yml"].uniq
+      end
+
+      def bare_shipit_filenames
+        ["#{app_name}.yml", "shipit.yml"].uniq
+      end
+
+      def config_file_path
+        shipit_file_names_in_priority_order.each do |filename|
+          path = file(filename, root: true)
+          return path if path.exist?
+        end
+
+        nil
       end
 
       def app_name
@@ -104,6 +124,14 @@ module Shipit
       def read_config(path)
         SafeYAML.load(path.read) if path.exist?
       end
+
+      def shipit_not_obeying_bare_file_echo_command
+        <<~EOM
+          echo \"\e[1;31mShipit is configured to ignore the bare '#{app_name}.yml' file.
+          Please rename this file to more specifically include the environment name.
+          Deployments will fail until a valid '#{app_name}.#{@env}.yml' file is found.\e[0m\"
+        EOM
+      end
     end
   end
 end

data/app/models/shipit/pull_request.rb

@@ -11,7 +11,7 @@ module Shipit
     has_many :pull_request_assignments
     has_many :assignees, class_name: :User, through: :pull_request_assignments, source: :user
 
-    serialize :labels, Array
+    serialize :labels, Shipit.serialized_column(:labels, type: Array)
 
     after_create_commit :emit_create_hooks
     after_update_commit :emit_update_hooks

data/app/models/shipit/stack.rb

@@ -608,6 +608,16 @@ module Shipit
       Shipit.deployment_checks.call(self)
     end
 
+    def emit_lock_hooks
+      return unless previous_changes.include?('lock_reason')
+
+      lock_details = if previous_changes['lock_reason'].last.blank?
+        { from: previous_changes['locked_since'].first, until: Time.zone.now }
+      end
+
+      Hook.emit(:lock, self, locked: locked?, lock_details: lock_details, stack: self)
+    end
+
     private
 
     def clear_cache
@@ -641,16 +651,6 @@ module Shipit
       end
     end
 
-    def emit_lock_hooks
-      return unless previous_changes.include?('lock_reason')
-
-      lock_details = if previous_changes['lock_reason'].last.blank?
-        { from: previous_changes['locked_since'].first, until: Time.zone.now }
-      end
-
-      Hook.emit(:lock, self, locked: locked?, lock_details: lock_details, stack: self)
-    end
-
     def emit_added_hooks
       Hook.emit(:stack, self, action: :added, stack: self)
     end

data/app/models/shipit/task.rb

@@ -27,8 +27,35 @@ module Shipit
 
     deferred_touch stack: :updated_at
 
+    module EnvHash
+      class << self
+        def dump(hash)
+          raise TypeError, "Task#env should be a Hash[String => String]" unless hash.is_a?(Hash)
+          hash = hash.to_h.stringify_keys
+          hash.transform_values! do |value|
+            case value
+            when String, Symbol, Numeric
+              value.to_s
+            else
+              raise TypeError, "Task#env should be a Hash[String => String]" unless hash.is_a?(Hash)
+            end
+          end
+
+          hash unless hash.empty?
+        end
+
+        def load(hash)
+          hash&.to_h || {} # cast back to a real hash
+        end
+
+        def new
+          nil
+        end
+      end
+    end
+
     serialize :definition, TaskDefinition
-    serialize :env, Hash
+    serialize :env, Shipit.serialized_column(:env, coder: EnvHash)
 
     scope :success, -> { where(status: 'success') }
     scope :completed, -> { where(status: COMPLETED_STATUSES) }

data/lib/shipit/engine.rb

@@ -5,7 +5,18 @@ module Shipit
 
     paths['app/models'] << 'app/serializers' << 'app/serializers/concerns'
 
-    initializer 'shipit.config', before: 'active_record_encryption.configuration' do |app|
+    initializer 'shipit.encryption_config', before: 'active_record_encryption.configuration' do |app|
+      if app.credentials.active_record_encryption.blank? && Shipit.user_access_tokens_key.present?
+        # For ease of upgrade, we derive an Active Record encryption config automatically.
+        # But if AR Encryption is already configured, we just use that
+        app.credentials[:active_record_encryption] = {
+          primary_key: Shipit.user_access_tokens_key,
+          key_derivation_salt: Digest::SHA256.digest("salt:".b + Shipit.user_access_tokens_key),
+        }
+      end
+    end
+
+    initializer 'shipit.config' do |app|
       Rails.application.routes.default_url_options[:host] = Shipit.host
       Shipit::Engine.routes.default_url_options[:host] = Shipit.host
       Pubsubstub.redis_url = Shipit.redis_url.to_s
@@ -42,15 +53,6 @@ module Shipit
       if Shipit.enable_samesite_middleware?
         app.config.middleware.insert_after(::Rack::Runtime, Shipit::SameSiteCookieMiddleware)
       end
-
-      if app.credentials.active_record_encryption.blank? && Shipit.user_access_tokens_key.present?
-        # For ease of upgrade, we derive an Active Record encryption config automatically.
-        # But if AR Encryption is already configured, we just use that
-        app.credentials[:active_record_encryption] = {
-          primary_key: Shipit.user_access_tokens_key,
-          key_derivation_salt: Digest::SHA256.digest("salt:".b + Shipit.user_access_tokens_key),
-        }
-      end
     end
 
     config.after_initialize do

data/lib/shipit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Shipit
-  VERSION = '0.36.0'
+  VERSION = '0.36.1'
 end

data/lib/shipit.rb

@@ -5,6 +5,7 @@ require 'state_machines-activerecord'
 require 'validate_url'
 require 'responders'
 require 'explicit-parameters'
+require 'paquito'
 
 require 'sass-rails'
 require 'coffee-rails'
@@ -63,7 +64,8 @@ module Shipit
 
   delegate :table_name_prefix, to: :secrets
 
-  attr_accessor :disable_api_authentication, :timeout_exit_codes, :deployment_checks
+  attr_accessor :disable_api_authentication, :timeout_exit_codes, :deployment_checks, :respect_bare_shipit_file,
+    :database_serializer
   attr_writer(
     :internal_hook_receivers,
     :preferred_org_emails,
@@ -76,6 +78,9 @@ module Shipit
   end
 
   self.timeout_exit_codes = [].freeze
+  self.respect_bare_shipit_file = true
+
+  alias_method :respect_bare_shipit_file?, :respect_bare_shipit_file
 
   def authentication_disabled?
     ENV['SHIPIT_DISABLE_AUTH'].present?
@@ -103,6 +108,50 @@ module Shipit
     )
   end
 
+  module SafeJSON
+    class << self
+      def load(serial)
+        return nil if serial.nil?
+        # JSON.load is unsafe, we should use parse instead
+        JSON.parse(serial)
+      end
+
+      def dump(object)
+        JSON.dump(object)
+      end
+    end
+  end
+
+  module TransitionalSerializer
+    SafeYAML = Paquito::SafeYAML.new(deprecated_classes: ["ActiveSupport::HashWithIndifferentAccess"])
+
+    class << self
+      def load(serial)
+        return if serial.nil?
+
+        JSON.parse(serial)
+      rescue JSON::ParserError
+        SafeYAML.load(serial)
+      end
+
+      def dump(object)
+        return if object.nil?
+        JSON.dump(object)
+      end
+    end
+  end
+
+  self.database_serializer = TransitionalSerializer
+
+  def serialized_column(attribute_name, type: nil, coder: nil)
+    column = Paquito::SerializedColumn.new(database_serializer, type, attribute_name: attribute_name)
+    if coder
+      Paquito.chain(coder, column)
+    else
+      column
+    end
+  end
+
   def github(organization: github_default_organization)
     # Backward compatibility
     # nil signifies the single github app config schema is being used

data/lib/snippets/fetch-gem-version

@@ -10,7 +10,7 @@ github_repository = ARGV[1]
 def get_json(url)
   uri = URI.parse(url)
   response = Net::HTTP.get_response(uri)
-  versions = JSON.load(response.body)
+  versions = JSON.parse(response.body)
 end
 
 versions = get_json("https://rubygems.org/api/v1/versions/#{gem_name}.json")

data/test/controllers/api/stacks_controller_test.rb

@@ -209,7 +209,7 @@ module Shipit
       end
 
       test "#refresh queues a GithubSyncJob" do
-        assert_enqueued_with(job: GithubSyncJob, args: [id: @stack.id]) do
+        assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
           post :refresh, params: { id: @stack.to_param }
         end
         assert_response :accepted

data/test/fixtures/shipit/tasks.yml

@@ -344,3 +344,15 @@ shipit_nocommit_task:
   status: pending
   created_at: <%= (60 - 2).minutes.ago.to_formatted_s(:db) %>
   started_at: <%= (60 - 2).minutes.ago.to_formatted_s(:db) %>
+
+shipit_legacy_yaml_task:
+  id: 502
+  user: walrus
+  type: Shipit::Task
+  stack: shipit_task_no_commits
+  status: pending
+  created_at: <%= (60 - 1).minutes.ago.to_formatted_s(:db) %>
+  started_at: <%= (60 - 1).minutes.ago.to_formatted_s(:db) %>
+  env: |
+    --- !ruby/hash:ActiveSupport::HashWithIndifferentAccess
+    POD_ID: '12'

data/test/models/deploy_spec_test.rb

@@ -286,29 +286,6 @@ module Shipit
       assert_equal({ 'GLOBAL' => '1' }, @spec.machine_env)
     end
 
-    test '#load_config can grab the env-specific shipit.yml file' do
-      config = {}
-      config.expects(:exist?).returns(true)
-      config.expects(:read).returns({ 'dependencies' => { 'override' => %w(foo bar baz) } }.to_yaml)
-      spec = DeploySpec::FileSystem.new('.', 'staging')
-      spec.expects(:file).with('shipit.staging.yml', root: true).returns(config)
-      assert_equal %w(foo bar baz), spec.dependencies_steps
-    end
-
-    test '#load_config grabs the global shipit.yml file if there is no env-specific file' do
-      not_config = {}
-      not_config.expects(:exist?).returns(false)
-
-      config = {}
-      config.expects(:exist?).returns(true)
-      config.expects(:read).returns({ 'dependencies' => { 'override' => %w(foo bar baz) } }.to_yaml)
-
-      spec = DeploySpec::FileSystem.new('.', 'staging')
-      spec.expects(:file).with('shipit.staging.yml', root: true).returns(not_config)
-      spec.expects(:file).with('shipit.yml', root: true).returns(config)
-      assert_equal %w(foo bar baz), spec.dependencies_steps
-    end
-
     test '#gemspec gives the path of the repo gemspec if present' do
       spec = DeploySpec::FileSystem.new('foobar/', 'production')
       Dir.expects(:[]).with('foobar/*.gemspec').returns(['foobar/foobar.gemspec'])

data/test/models/deploys_test.rb

@@ -459,6 +459,32 @@ module Shipit
       end
     end
 
+    test "transitioning to aborted locks the stack if a rollback is scheduled" do
+      refute @stack.locked?
+
+      @deploy = shipit_deploys(:shipit_running)
+      @deploy.ping
+      @deploy.pid = 42
+      @deploy.abort!(rollback_once_aborted: true, aborted_by: @user)
+      @deploy.aborted!
+
+      assert_predicate @stack.reload, :locked?
+      assert_equal @user, @stack.lock_author
+    end
+
+    test "transitioning to aborted emits a lock hook if a rollback is scheduled" do
+      refute_predicate @stack, :locked?
+
+      @deploy = shipit_deploys(:shipit_running)
+      @deploy.ping
+      @deploy.pid = 42
+      @deploy.abort!(rollback_once_aborted: true, aborted_by: @user)
+
+      expect_hook(:lock, @stack, locked: true, lock_details: nil, stack: @stack) do
+        @deploy.aborted!
+      end
+    end
+
     test "#build_rollback returns an unsaved record" do
       assert @deploy.build_rollback.new_record?
     end

data/test/models/shipit/deploy_spec/file_system_test.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+require 'test_helper'
+require 'tmpdir'
+
+module Shipit
+  class DeploySpec
+    class FileSystemTest < ActiveSupport::TestCase
+      test 'deploy.pre calls "exit 1" if there is a bare shipit file and Shipit is configured to ignore' do
+        Shipit.expects(:respect_bare_shipit_file?).returns(false).at_least_once
+        deploy_spec = Shipit::DeploySpec::FileSystem.new(Dir.tmpdir, 'env')
+        deploy_spec.expects(:config_file_path).returns(Pathname.new(Dir.tmpdir) + '/shipit.yml').at_least_once
+        deploy_spec.expects(:read_config).never
+        pre_commands = deploy_spec.send(:config, 'deploy', 'pre')
+        assert pre_commands.include?('exit 1')
+        assert pre_commands.first.include?('configured to ignore')
+        refute pre_commands.include?('test 2')
+      end
+
+      test 'deploy.pre does not call "exit 1" if Shipit is not configured to do so' do
+        Shipit.expects(:respect_bare_shipit_file?).returns(true).at_least_once
+        deploy_spec = Shipit::DeploySpec::FileSystem.new(Dir.tmpdir, 'env')
+        deploy_spec.expects(:config_file_path).returns(Pathname.new(Dir.tmpdir) + '/shipit.yml').at_least_once
+        deploy_spec.expects(:read_config).returns(SafeYAML.load(deploy_spec_yaml))
+        pre_commands = deploy_spec.send(:config, 'deploy', 'pre')
+        refute pre_commands.include?('exit 1')
+        assert pre_commands.include?('test 2')
+      end
+
+      test 'Shipit.respect_bare_shipit_file? has no effect if the file is not a bare file' do
+        [true, false].each do |obey_val|
+          Shipit.expects(:respect_bare_shipit_file?).returns(obey_val).at_least_once
+          deploy_spec = Shipit::DeploySpec::FileSystem.new(Dir.tmpdir, 'env')
+          deploy_spec.expects(:config_file_path).returns(Pathname.new(Dir.tmpdir) + '/shipit.env.yml').at_least_once
+          deploy_spec.expects(:read_config).returns(SafeYAML.load(deploy_spec_yaml))
+          pre_commands = deploy_spec.send(:config, 'deploy', 'pre')
+          refute pre_commands.include?('exit 1')
+          assert pre_commands.include?('test 2')
+        end
+      end
+
+      test '#load_config does not error if the file is empty' do
+        Shipit.expects(:respect_bare_shipit_file?).returns(true).at_least_once
+        deploy_spec = Shipit::DeploySpec::FileSystem.new(Dir.tmpdir, 'env')
+        deploy_spec.expects(:config_file_path).returns(Pathname.new(Dir.tmpdir) + '/shipit.env.yml').at_least_once
+        deploy_spec.expects(:read_config).at_least_once.returns(false)
+        loaded_config = deploy_spec.send(:cacheable_config)
+        refute loaded_config == false
+      end
+
+      test '#load_config does not error if there is no "deploy" key' do
+        Shipit.expects(:respect_bare_shipit_file?).returns(false).at_least_once
+        deploy_spec = Shipit::DeploySpec::FileSystem.new(Dir.tmpdir, 'env')
+        deploy_spec.expects(:config_file_path).returns(Pathname.new(Dir.tmpdir) + '/shipit.yml').at_least_once
+        deploy_spec.expects(:read_config).never
+        loaded_config = deploy_spec.send(:load_config)
+        assert loaded_config.key?("deploy")
+        assert loaded_config["deploy"].key?("pre")
+        assert loaded_config["deploy"]["pre"].include?('exit 1')
+      end
+
+      def deploy_spec_yaml
+        <<~EOYAML
+          deploy:
+            pre:
+              - test 2
+            override:
+              - test 1
+        EOYAML
+      end
+
+      def deploy_spec_missing_deploy_yaml
+        <<~EOYAML
+          production_platform:
+            application: test-application
+            runtime_ids:
+              - production-unrestricted-1234
+        EOYAML
+      end
+    end
+  end
+end

data/test/models/tasks_test.rb

@@ -110,5 +110,17 @@ module Shipit
 
       assert_includes Shipit::Task.due_for_rollup, task
     end
+
+    test "load legacy YAML records" do
+      task = Shipit::Task.find(shipit_tasks(:shipit_legacy_yaml_task).id)
+      assert_equal({ "POD_ID" => "12" }, task.env)
+      assert_equal Hash, task.env.class
+
+      task.save
+      task.reload
+
+      assert_equal({ "POD_ID" => "12" }, task.env)
+      assert_equal Hash, task.env.class
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shipit-engine
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.36.1
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-15 00:00:00.000000000 Z
+date: 2022-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -388,6 +388,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: paquito
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - jean.boussier@shopify.com
@@ -963,6 +977,7 @@ files:
 - test/models/release_statuses_test.rb
 - test/models/rollbacks_test.rb
 - test/models/shipit/check_run_test.rb
+- test/models/shipit/deploy_spec/file_system_test.rb
 - test/models/shipit/provisioning_handler/base_test.rb
 - test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb
 - test/models/shipit/provisioning_handler_test.rb
@@ -1038,203 +1053,204 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Application deployment software
 test_files:
-- test/unit/github_url_helper_test.rb
-- test/unit/shipit_deployment_checks_test.rb
-- test/unit/user_serializer_test.rb
-- test/unit/github_app_test.rb
-- test/unit/deploy_serializer_test.rb
-- test/unit/csv_serializer_test.rb
-- test/unit/environment_variables_test.rb
-- test/unit/commands_test.rb
-- test/unit/anonymous_user_serializer_test.rb
-- test/unit/command_test.rb
-- test/unit/shipit_task_execution_strategy_test.rb
-- test/unit/shipit_test.rb
-- test/unit/github_apps_test.rb
-- test/unit/variable_definition_test.rb
-- test/unit/deploy_commands_test.rb
-- test/unit/commit_serializer_test.rb
-- test/unit/line_buffer_test.rb
-- test/unit/shipit_helper_test.rb
-- test/unit/rollback_commands_test.rb
-- test/middleware/same_site_cookie_middleware_test.rb
-- test/test_helper.rb
-- test/serializers/shipit/pull_request_serializer_test.rb
-- test/lib/shipit/task_commands_test.rb
-- test/lib/shipit/deploy_commands_test.rb
-- test/helpers/json_helper.rb
-- test/helpers/api_helper.rb
-- test/helpers/hooks_helper.rb
-- test/helpers/links_helper.rb
-- test/helpers/fixture_aliases_helper.rb
-- test/helpers/payloads_helper.rb
-- test/helpers/queries_helper.rb
-- test/dummy/db/schema.rb
-- test/dummy/db/seeds.rb
-- test/dummy/app/assets/javascripts/application.js
+- test/controllers/api/base_controller_test.rb
+- test/controllers/api/ccmenu_controller_test.rb
+- test/controllers/api/commits_controller_test.rb
+- test/controllers/api/deploys_controller_test.rb
+- test/controllers/api/hooks_controller_test.rb
+- test/controllers/api/locks_controller_test.rb
+- test/controllers/api/merge_requests_controller_test.rb
+- test/controllers/api/outputs_controller_test.rb
+- test/controllers/api/release_statuses_controller_test.rb
+- test/controllers/api/rollback_controller_test.rb
+- test/controllers/api/stacks_controller_test.rb
+- test/controllers/api/tasks_controller_test.rb
+- test/controllers/api_clients_controller_test.rb
+- test/controllers/ccmenu_controller_test.rb
+- test/controllers/commit_checks_controller_test.rb
+- test/controllers/commits_controller_test.rb
+- test/controllers/deploys_controller_test.rb
+- test/controllers/github_authentication_controller_test.rb
+- test/controllers/merge_requests_controller_test.rb
+- test/controllers/merge_status_controller_test.rb
+- test/controllers/release_statuses_controller_test.rb
+- test/controllers/repositories_controller_test.rb
+- test/controllers/rollbacks_controller_test.rb
+- test/controllers/stacks_controller_test.rb
+- test/controllers/status_controller_test.rb
+- test/controllers/tasks_controller_test.rb
+- test/controllers/webhooks_controller_test.rb
+- test/dummy/Rakefile
 - test/dummy/app/assets/config/manifest.js
+- test/dummy/app/assets/javascripts/application.js
 - test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/views/layouts/application.html.erb
-- test/dummy/config.ru
-- test/dummy/public/favicon.ico
-- test/dummy/public/422.html
-- test/dummy/public/404.html
-- test/dummy/public/500.html
-- test/dummy/bin/rake
-- test/dummy/bin/setup
 - test/dummy/bin/bundle
 - test/dummy/bin/rails
+- test/dummy/bin/rake
+- test/dummy/bin/setup
+- test/dummy/config/application.rb
 - test/dummy/config/boot.rb
-- test/dummy/config/database.postgresql.yml
 - test/dummy/config/database.mysql.yml
-- test/dummy/config/secrets_double_github_app.yml
-- test/dummy/config/routes.rb
+- test/dummy/config/database.postgresql.yml
 - test/dummy/config/database.yml
-- test/dummy/config/application.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/environments/production.rb
+- test/dummy/config/environment.rb
 - test/dummy/config/environments/development.rb
-- test/dummy/config/locales/en.yml
+- test/dummy/config/environments/production.rb
+- test/dummy/config/environments/test.rb
+- test/dummy/config/initializers/0_load_development_secrets.rb
+- test/dummy/config/initializers/assets.rb
+- test/dummy/config/initializers/backtrace_silencers.rb
 - test/dummy/config/initializers/cookies_serializer.rb
+- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/inflections.rb
 - test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/0_load_development_secrets.rb
 - test/dummy/config/initializers/session_store.rb
 - test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/assets.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
+- test/dummy/config/locales/en.yml
+- test/dummy/config/routes.rb
 - test/dummy/config/secrets.yml
-- test/dummy/config/environment.rb
-- test/dummy/Rakefile
-- test/controllers/tasks_controller_test.rb
-- test/controllers/deploys_controller_test.rb
-- test/controllers/ccmenu_controller_test.rb
-- test/controllers/api/tasks_controller_test.rb
-- test/controllers/api/deploys_controller_test.rb
-- test/controllers/api/locks_controller_test.rb
-- test/controllers/api/rollback_controller_test.rb
-- test/controllers/api/ccmenu_controller_test.rb
-- test/controllers/api/base_controller_test.rb
-- test/controllers/api/outputs_controller_test.rb
-- test/controllers/api/hooks_controller_test.rb
-- test/controllers/api/commits_controller_test.rb
-- test/controllers/api/release_statuses_controller_test.rb
-- test/controllers/api/merge_requests_controller_test.rb
-- test/controllers/api/stacks_controller_test.rb
-- test/controllers/status_controller_test.rb
-- test/controllers/webhooks_controller_test.rb
-- test/controllers/commits_controller_test.rb
-- test/controllers/api_clients_controller_test.rb
-- test/controllers/release_statuses_controller_test.rb
-- test/controllers/commit_checks_controller_test.rb
-- test/controllers/merge_requests_controller_test.rb
-- test/controllers/repositories_controller_test.rb
-- test/controllers/merge_status_controller_test.rb
-- test/controllers/stacks_controller_test.rb
-- test/controllers/rollbacks_controller_test.rb
-- test/controllers/github_authentication_controller_test.rb
-- test/fixtures/timeout
+- test/dummy/config/secrets_double_github_app.yml
+- test/dummy/config.ru
+- test/dummy/db/schema.rb
+- test/dummy/db/seeds.rb
+- test/dummy/public/404.html
+- test/dummy/public/422.html
+- test/dummy/public/500.html
+- test/dummy/public/favicon.ico
 - test/fixtures/payloads/check_suite_master.json
-- test/fixtures/payloads/pull_request_reopened.json
-- test/fixtures/payloads/push_not_master.json
-- test/fixtures/payloads/pull_request_with_no_repo.json
-- test/fixtures/payloads/status_master.json
+- test/fixtures/payloads/invalid_pull_request.json
+- test/fixtures/payloads/provision_disabled_pull_request.json
+- test/fixtures/payloads/pull_request_assigned.json
 - test/fixtures/payloads/pull_request_closed.json
+- test/fixtures/payloads/pull_request_labeled.json
+- test/fixtures/payloads/pull_request_opened.json
+- test/fixtures/payloads/pull_request_reopened.json
 - test/fixtures/payloads/pull_request_unlabeled.json
-- test/fixtures/payloads/pull_request_assigned.json
+- test/fixtures/payloads/pull_request_with_no_repo.json
 - test/fixtures/payloads/push_master.json
-- test/fixtures/payloads/pull_request_opened.json
-- test/fixtures/payloads/pull_request_labeled.json
-- test/fixtures/payloads/provision_disabled_pull_request.json
-- test/fixtures/payloads/invalid_pull_request.json
-- test/fixtures/shipit/pull_request_assignments.yml
-- test/fixtures/shipit/commit_deployments.yml
+- test/fixtures/payloads/push_not_master.json
+- test/fixtures/payloads/status_master.json
+- test/fixtures/shipit/api_clients.yml
 - test/fixtures/shipit/check_runs.yml
-- test/fixtures/shipit/hooks.yml
-- test/fixtures/shipit/release_statuses.yml
-- test/fixtures/shipit/teams.yml
-- test/fixtures/shipit/users.yml
-- test/fixtures/shipit/repositories.yml
 - test/fixtures/shipit/commit_deployment_statuses.yml
-- test/fixtures/shipit/stacks.yml
+- test/fixtures/shipit/commit_deployments.yml
 - test/fixtures/shipit/commits.yml
-- test/fixtures/shipit/pull_requests.yml
-- test/fixtures/shipit/tasks.yml
+- test/fixtures/shipit/deliveries.yml
 - test/fixtures/shipit/github_hooks.yml
+- test/fixtures/shipit/hooks.yml
 - test/fixtures/shipit/memberships.yml
 - test/fixtures/shipit/merge_requests.yml
+- test/fixtures/shipit/pull_request_assignments.yml
+- test/fixtures/shipit/pull_requests.yml
+- test/fixtures/shipit/release_statuses.yml
+- test/fixtures/shipit/repositories.yml
+- test/fixtures/shipit/stacks.yml
 - test/fixtures/shipit/statuses.yml
-- test/fixtures/shipit/api_clients.yml
-- test/fixtures/shipit/deliveries.yml
-- test/models/pull_request_assignment_test.rb
-- test/models/status_test.rb
-- test/models/github_hook_test.rb
+- test/fixtures/shipit/tasks.yml
+- test/fixtures/shipit/teams.yml
+- test/fixtures/shipit/users.yml
+- test/fixtures/timeout
+- test/helpers/api_helper.rb
+- test/helpers/fixture_aliases_helper.rb
+- test/helpers/hooks_helper.rb
+- test/helpers/json_helper.rb
+- test/helpers/links_helper.rb
+- test/helpers/payloads_helper.rb
+- test/helpers/queries_helper.rb
+- test/jobs/cache_deploy_spec_job_test.rb
+- test/jobs/chunk_rollup_job_test.rb
+- test/jobs/deliver_hook_job_test.rb
+- test/jobs/destroy_repository_job_test.rb
+- test/jobs/destroy_stack_job_test.rb
+- test/jobs/emit_event_job_test.rb
+- test/jobs/fetch_commit_stats_job_test.rb
+- test/jobs/fetch_deployed_revision_job_test.rb
+- test/jobs/github_sync_job_test.rb
+- test/jobs/mark_deploy_healthy_job_test.rb
+- test/jobs/perform_task_job_test.rb
+- test/jobs/process_merge_requests_job_test.rb
+- test/jobs/purge_old_deliveries_job_test.rb
+- test/jobs/reap_dead_tasks_job_test.rb
+- test/jobs/refresh_github_user_job_test.rb
+- test/jobs/refresh_status_job_test.rb
+- test/jobs/unique_job_test.rb
+- test/jobs/update_github_last_deployed_ref_job_test.rb
+- test/lib/shipit/deploy_commands_test.rb
+- test/lib/shipit/task_commands_test.rb
+- test/middleware/same_site_cookie_middleware_test.rb
+- test/models/api_client_test.rb
+- test/models/commit_checks_test.rb
+- test/models/commit_deployment_status_test.rb
 - test/models/commit_deployment_test.rb
-- test/models/delivery_test.rb
-- test/models/hook_test.rb
-- test/models/task_definitions_test.rb
 - test/models/commits_test.rb
-- test/models/merge_request_test.rb
-- test/models/tasks_test.rb
-- test/models/commit_deployment_status_test.rb
+- test/models/delivery_test.rb
+- test/models/deploy_spec_test.rb
 - test/models/deploy_stats_test.rb
 - test/models/deploys_test.rb
-- test/models/team_test.rb
-- test/models/deploy_spec_test.rb
+- test/models/duration_test.rb
+- test/models/github_hook_test.rb
+- test/models/hook_test.rb
 - test/models/membership_test.rb
-- test/models/users_test.rb
-- test/models/rollbacks_test.rb
+- test/models/merge_request_test.rb
+- test/models/pull_request_assignment_test.rb
 - test/models/release_statuses_test.rb
-- test/models/commit_checks_test.rb
-- test/models/status/missing_test.rb
-- test/models/status/group_test.rb
+- test/models/rollbacks_test.rb
+- test/models/shipit/check_run_test.rb
+- test/models/shipit/deploy_spec/file_system_test.rb
+- test/models/shipit/provisioning_handler/base_test.rb
+- test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb
+- test/models/shipit/provisioning_handler_test.rb
+- test/models/shipit/pull_request_test.rb
 - test/models/shipit/repository_test.rb
+- test/models/shipit/review_stack_provision_status_test.rb
+- test/models/shipit/review_stack_provisioning_queue_test.rb
+- test/models/shipit/review_stack_test.rb
 - test/models/shipit/stacks_test.rb
+- test/models/shipit/webhooks/handlers/pull_request/assigned_handler_test.rb
+- test/models/shipit/webhooks/handlers/pull_request/closed_handler_test.rb
+- test/models/shipit/webhooks/handlers/pull_request/edited_handler_test.rb
 - test/models/shipit/webhooks/handlers/pull_request/label_capturing_handler_test.rb
 - test/models/shipit/webhooks/handlers/pull_request/labeled_handler_test.rb
 - test/models/shipit/webhooks/handlers/pull_request/opened_handler_test.rb
-- test/models/shipit/webhooks/handlers/pull_request/edited_handler_test.rb
-- test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb
 - test/models/shipit/webhooks/handlers/pull_request/reopened_handler_test.rb
-- test/models/shipit/webhooks/handlers/pull_request/assigned_handler_test.rb
-- test/models/shipit/webhooks/handlers/pull_request/closed_handler_test.rb
+- test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb
 - test/models/shipit/webhooks/handlers/pull_request/unlabeled_handler_test.rb
 - test/models/shipit/webhooks/handlers_test.rb
-- test/models/shipit/check_run_test.rb
-- test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb
-- test/models/shipit/provisioning_handler/base_test.rb
-- test/models/shipit/review_stack_test.rb
-- test/models/shipit/provisioning_handler_test.rb
-- test/models/shipit/review_stack_provisioning_queue_test.rb
-- test/models/shipit/pull_request_test.rb
-- test/models/shipit/review_stack_provision_status_test.rb
-- test/models/api_client_test.rb
+- test/models/status/group_test.rb
+- test/models/status/missing_test.rb
+- test/models/status_test.rb
+- test/models/task_definitions_test.rb
+- test/models/tasks_test.rb
+- test/models/team_test.rb
 - test/models/undeployed_commits_test.rb
-- test/models/duration_test.rb
-- test/jobs/process_merge_requests_job_test.rb
-- test/jobs/unique_job_test.rb
-- test/jobs/reap_dead_tasks_job_test.rb
-- test/jobs/github_sync_job_test.rb
-- test/jobs/refresh_github_user_job_test.rb
-- test/jobs/chunk_rollup_job_test.rb
-- test/jobs/fetch_commit_stats_job_test.rb
-- test/jobs/fetch_deployed_revision_job_test.rb
-- test/jobs/destroy_repository_job_test.rb
-- test/jobs/update_github_last_deployed_ref_job_test.rb
-- test/jobs/deliver_hook_job_test.rb
-- test/jobs/refresh_status_job_test.rb
-- test/jobs/perform_task_job_test.rb
-- test/jobs/emit_event_job_test.rb
-- test/jobs/mark_deploy_healthy_job_test.rb
-- test/jobs/purge_old_deliveries_job_test.rb
-- test/jobs/cache_deploy_spec_job_test.rb
-- test/jobs/destroy_stack_job_test.rb
+- test/models/users_test.rb
+- test/serializers/shipit/pull_request_serializer_test.rb
 - test/test_command_integration.rb
+- test/test_helper.rb
+- test/unit/anonymous_user_serializer_test.rb
+- test/unit/command_test.rb
+- test/unit/commands_test.rb
+- test/unit/commit_serializer_test.rb
+- test/unit/csv_serializer_test.rb
+- test/unit/deploy_commands_test.rb
+- test/unit/deploy_serializer_test.rb
+- test/unit/environment_variables_test.rb
+- test/unit/github_app_test.rb
+- test/unit/github_apps_test.rb
+- test/unit/github_url_helper_test.rb
+- test/unit/line_buffer_test.rb
+- test/unit/rollback_commands_test.rb
+- test/unit/shipit_deployment_checks_test.rb
+- test/unit/shipit_helper_test.rb
+- test/unit/shipit_task_execution_strategy_test.rb
+- test/unit/shipit_test.rb
+- test/unit/user_serializer_test.rb
+- test/unit/variable_definition_test.rb