shipit-engine 0.32.0 → 0.35.1

data/test/fixtures/shipit/statuses.yml

@@ -134,3 +134,12 @@ canaries_fifth_success:
   created_at: <%= 7.days.ago.to_s(:db) %>
   state: success
   target_url: "http://www.example.com"
+
+review_stack_commit_success:
+  stack: review_stack
+  commit_id: 801
+  description: lets go
+  context: ci/travis
+  created_at: <%= 10.days.ago.to_s(:db) %>
+  state: success
+  target_url: "http://www.example.com"

data/test/fixtures/shipit/tasks.yml

@@ -11,6 +11,7 @@ shipit:
   created_at: <%= (60 - 1).minutes.ago.to_s(:db) %>
   started_at: <%= (60 - 1).minutes.ago.to_s(:db) %>
   ended_at: <%= (60 - 6).minutes.ago.to_s(:db) %>
+  max_retries: 3
 
 shipit2:
   id: 2
@@ -28,7 +29,7 @@ shipit2:
 
 shipit_restart:
   id: 3
-  user: walrus
+  user: ~
   type: Shipit::Task
   stack: shipit
   status: success
@@ -60,6 +61,8 @@ shipit_pending:
   deletions: 406
   created_at: <%= (60 - 4).minutes.ago.to_s(:db) %>
   allow_concurrency: true
+  max_retries: 1
+  retry_attempt: 0
 
 shipit_running:
   id: 5

data/test/fixtures/shipit/users.yml

@@ -5,6 +5,13 @@ walrus:
   encrypted_github_access_token: "ffHk4diyVKppJGfwfJefMizxF45H\n" # t0k3n
   encrypted_github_access_token_iv: "gRSldoTZ+fmrIDoY\n"
 
+codertocat:
+  name: Coding Cat
+  email: coding@cat.com
+  login: Codertocat
+  encrypted_github_access_token: "ffHk4diyVKppJGfwfJefMizxF45H\n" # t0k3n
+  encrypted_github_access_token_iv: "gRSldoTZ+fmrIDoY\n"
+
 bob:
   name:  Bob the Builder
   email: bob@bob.com

data/test/helpers/json_helper.rb

@@ -3,7 +3,11 @@ module JSONHelper
   UNDEFINED = Object.new.freeze
   private_constant :UNDEFINED
 
-  def assert_json(path = nil, expected_value = UNDEFINED, document: response.body)
+  def assert_json(path = nil, expected_value = UNDEFINED, &block)
+    assert_json_document(response.body, path, expected_value, &block)
+  end
+
+  def assert_json_document(document, path, expected_value = UNDEFINED)
     value = follow_path(path.to_s.split('.'), document: document)
     if block_given?
       yield value

data/test/helpers/payloads_helper.rb

@@ -3,4 +3,8 @@ module PayloadsHelper
   def payload(name)
     Shipit::Engine.root.join('test/fixtures/payloads', "#{name}.json").read
   end
+
+  def payload_parsed(name)
+    JSON.parse(payload(name))
+  end
 end

data/test/jobs/chunk_rollup_job_test.rb

@@ -5,6 +5,7 @@ module Shipit
   class ChunkRollupJobTest < ActiveSupport::TestCase
     setup do
       @task = shipit_tasks(:shipit)
+      @task.write("dummy output")
       @job = ChunkRollupJob.new
     end
 
@@ -15,10 +16,10 @@ module Shipit
       @job.perform(@task)
 
       @task.reload
-      assert_equal 0, @task.chunks.count
       assert @task.output.present?
       assert_equal expected_output, @task.chunk_output
       assert @task.rolled_up
+      assert_nil Shipit.redis.get(@task.send(:output_key))
     end
 
     test "#peform ignores non-finished jobs" do
@@ -40,5 +41,18 @@ module Shipit
 
       @job.perform(@task)
     end
+
+    test "#perform takes into account data still in the DB" do
+      output_chunks = Shipit::OutputChunk.create(text: "DB output", task: @task)
+      expected_output = [output_chunks.text, @task.chunk_output].join("\n")
+
+      @job.perform(@task)
+
+      @task.reload
+      assert_equal expected_output, @task.chunk_output
+      assert @task.rolled_up
+      assert_empty Shipit::OutputChunk.where(task: @task)
+      assert_nil Shipit.redis.get(@task.send(:output_key))
+    end
   end
 end

data/test/jobs/destroy_repository_job_test.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class DestroyRepositoryJobTest < ActiveSupport::TestCase
+    setup do
+      @job = DestroyRepositoryJob.new
+      @repository = Repository.first
+    end
+
+    test "perform destroys the repository" do
+      assert_difference -> { Repository.count }, -1 do
+        @job.perform(@repository)
+      end
+    end
+
+    test "perform destroys the repository's stacks" do
+      stack = Stack.first
+      Shipit.github.api.expects(:remove_hook).times(stack.github_hooks.count)
+      @repository.stacks << stack
+
+      assert_difference -> { Stack.count }, -@repository.stacks.size do
+        @job.perform(@repository)
+      end
+    end
+  end
+end

data/test/jobs/github_sync_job_test.rb

@@ -91,7 +91,7 @@ module Shipit
       last = stub(sha: 123)
       first = stub(sha: 345)
       Shipit::FirstParentCommitsIterator.any_instance.stubs(:each).multiple_yields(last, first)
-      @job.stubs(lookup_commit: nil)
+      @job.stubs(lookup_commit: nil, stack: @stack)
 
       commits, parent = @job.fetch_missing_commits { stub }
       assert_nil parent
@@ -104,6 +104,7 @@ module Shipit
       Shipit::FirstParentCommitsIterator.any_instance.stubs(:each).multiple_yields(last, first)
       @job.stubs(:lookup_commit).with(123).returns(nil)
       @job.stubs(:lookup_commit).with(345).returns(first)
+      @job.stubs(stack: @stack)
 
       commits, parent = @job.fetch_missing_commits { stub }
       assert_equal first, parent

data/test/jobs/perform_task_job_test.rb

@@ -19,8 +19,8 @@ module Shipit
     end
 
     test "#perform fetch commits from the API" do
-      @job.stubs(:capture!)
-      @job.stubs(:capture)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture)
       @commands = stub
       Commands.expects(:for).with(@deploy).returns(@commands)
 
@@ -39,7 +39,7 @@ module Shipit
       @deploy.stack.expects(:release_status?).at_least_once.returns(false)
       Dir.stubs(:chdir).yields
       DeployCommands.any_instance.expects(:perform).returns([])
-      @job.stubs(:capture!)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
 
       assert_enqueued_with(job: FetchDeployedRevisionJob, args: [@deploy.stack]) do
         @job.perform(@deploy)
@@ -50,7 +50,7 @@ module Shipit
       @deploy.stack.expects(:release_status?).at_least_once.returns(false)
       Dir.stubs(:chdir).yields
       DeployCommands.any_instance.expects(:perform).returns([])
-      @job.stubs(:capture!)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
 
       assert_equal 'pending', @deploy.status
       @job.perform(@deploy)
@@ -63,7 +63,7 @@ module Shipit
 
       Dir.stubs(:chdir).yields
       DeployCommands.any_instance.expects(:perform).returns([])
-      @job.stubs(:capture!)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
 
       assert_equal 'pending', @deploy.status
       @job.perform(@deploy)
@@ -77,7 +77,7 @@ module Shipit
 
       Dir.stubs(:chdir).yields
       DeployCommands.any_instance.expects(:perform).returns([])
-      @job.stubs(:capture!)
+      Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
 
       assert_equal 'pending', @deploy.status
       @job.perform(@deploy)
@@ -85,7 +85,7 @@ module Shipit
     end
 
     test "marks deploy as `error` if any application error is raised" do
-      @job.expects(:capture!).raises("some error")
+      Shipit::TaskExecutionStrategy::Default.any_instance.expects(:capture!).raises("some error")
       assert_nothing_raised do
         @job.perform(@deploy)
       end
@@ -94,7 +94,7 @@ module Shipit
     end
 
     test "marks deploy as `failed` if a command exit with an error code" do
-      @job.expects(:capture!).at_least_once.raises(Command::Error.new('something'))
+      Shipit::TaskExecutionStrategy::Default.any_instance.expects(:capture!).at_least_once.raises(Command::Error.new('something'))
       @job.perform(@deploy)
       assert_equal 'failed', @deploy.reload.status
     end

data/test/jobs/{merge_pull_requests_job_test.rb → process_merge_requests_job_test.rb}

@@ -2,22 +2,22 @@
 require 'test_helper'
 
 module Shipit
-  class MergePullRequestsJobTest < ActiveSupport::TestCase
+  class ProcessMergeRequestsJobTest < ActiveSupport::TestCase
     setup do
       @stack = shipit_stacks(:shipit)
-      @job = MergePullRequestsJob.new
+      @job = ProcessMergeRequestsJob.new
 
-      @pending_pr = shipit_pull_requests(:shipit_pending)
-      @unmergeable_pr = shipit_pull_requests(:shipit_pending_unmergeable)
-      @not_ready_pr = shipit_pull_requests(:shipit_pending_not_mergeable_yet)
-      @closed_pr = shipit_pull_requests(:shipit_pending_closed)
-      @merged_pr = shipit_pull_requests(:shipit_pending_merged)
-      @expired_pr = shipit_pull_requests(:shipit_pending_expired)
-      @mergable_pending_ci = shipit_pull_requests(:shipit_mergeable_pending_ci)
+      @pending_pr = shipit_merge_requests(:shipit_pending)
+      @unmergeable_pr = shipit_merge_requests(:shipit_pending_unmergeable)
+      @not_ready_pr = shipit_merge_requests(:shipit_pending_not_mergeable_yet)
+      @closed_pr = shipit_merge_requests(:shipit_pending_closed)
+      @merged_pr = shipit_merge_requests(:shipit_pending_merged)
+      @expired_pr = shipit_merge_requests(:shipit_pending_expired)
+      @mergable_pending_ci = shipit_merge_requests(:shipit_mergeable_pending_ci)
     end
 
     test "#perform rejects unmergeable PRs and merge the others" do
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w(200 OK), body: {
         sha: "6dcb09b5b57875f334f61aebed695e2e4193db5e",
         merged: true,
@@ -35,7 +35,7 @@ module Shipit
     end
 
     test "#perform rejects PRs if the merge attempt fails" do
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       stub_request(:put, "#{@pending_pr.api_url}/merge").to_return(status: %w(405 Method not allowed), body: {
         message: "Pull Request is not mergeable",
         documentation_url: "https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button",
@@ -47,24 +47,24 @@ module Shipit
     end
 
     test "#perform rejects PRs but do not attempt to merge any if the stack doesn't allow merges" do
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       @stack.update!(lock_reason: 'Maintenance')
       @job.perform(@stack)
       assert_predicate @pending_pr.reload, :pending?
     end
 
     test "#perform revalidate PRs but do not attempt to merge any if the stack doesn't allow merges" do
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       @stack.update!(lock_reason: 'Maintenance')
       @job.perform(@stack)
       assert_predicate @expired_pr.reload, :revalidating?
     end
 
     test "#perform schedules a new job if the first PR in the queue is not mergeable yet" do
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
 
       @pending_pr.update!(mergeable: nil)
-      assert_enqueued_with(job: MergePullRequestsJob) do
+      assert_enqueued_with(job: ProcessMergeRequestsJob) do
         @job.perform(@stack)
       end
       assert_predicate @pending_pr.reload, :pending?
@@ -72,21 +72,21 @@ module Shipit
 
     test "#perform cancels merge requests for closed PRs" do
       @pending_pr.cancel!
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       @job.perform(@stack)
       assert_predicate @closed_pr.reload, :canceled?
     end
 
     test "#perform cancels merge requests for manually merged PRs" do
       @pending_pr.cancel!
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       @job.perform(@stack)
       assert_predicate @merged_pr.reload, :canceled?
     end
 
     test "#perform does not reject pull requests with pending statuses" do
       @pending_pr.cancel!
-      PullRequest.any_instance.stubs(:refresh!)
+      MergeRequest.any_instance.stubs(:refresh!)
       @job.perform(@stack)
       refute_predicate @mergable_pending_ci.reload, :rejected?
       refute_predicate @mergable_pending_ci.reload, :merged?

data/test/lib/shipit/deploy_commands_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DeployCommandsTest < ActiveSupport::TestCase
+  test "#env includes the stack's pull request labels" do
+    stack = shipit_stacks(:review_stack)
+    deploy = stack.trigger_continuous_delivery
+    stack.pull_request.labels = ["wip", "bug"]
+
+    env = Shipit::DeployCommands.new(deploy).env
+
+    assert_equal env["WIP"], "true"
+    assert_equal env["BUG"], "true"
+  end
+end

data/test/lib/shipit/task_commands_test.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class TaskCommandsTest < ActiveSupport::TestCase
+  test "#env includes a ReviewStack's pull request labels" do
+    stack = shipit_stacks(:review_stack)
+    stack.pull_request.labels = ["wip", "bug"]
+    task = shipit_tasks(:shipit_restart)
+    task.stack = stack
+
+    env = Shipit::TaskCommands.new(task).env
+
+    assert_equal env["WIP"], "true"
+    assert_equal env["BUG"], "true"
+  end
+end

data/test/models/commit_deployment_status_test.rb

@@ -12,7 +12,7 @@ module Shipit
 
     test 'creation on GitHub' do
       response = stub(id: 44, url: 'https://example.com')
-      @author.github_api.expects(:create_deployment_status).with(
+      @author.github_api.class.any_instance.expects(:create_deployment_status).with(
         @deployment.api_url,
         'in_progress',
         accept: "application/vnd.github.flash-preview+json",
@@ -33,7 +33,7 @@ module Shipit
       status = deployment.statuses.create!(status: 'success')
       status.stubs(:description).returns('desc' * limit)
       create_status_response = stub(id: 'abcd', url: 'https://github.com/status/abcd')
-      status.author.github_api.expects(:create_deployment_status).with do |*_args, **kwargs|
+      status.author.github_api.class.any_instance.expects(:create_deployment_status).with do |_url, _status, kwargs|
         kwargs[:description].size <= limit
       end.returns(create_status_response)
 
@@ -47,7 +47,7 @@ module Shipit
       stack = status.stack
       stack.deploy_url = "stack-deploy-url"
       create_status_response = stub(id: 'abcd', url: 'https://github.com/status/abcd')
-      status.author.github_api.expects(:create_deployment_status).with do |*_args, **kwargs|
+      status.author.github_api.class.any_instance.expects(:create_deployment_status).with do |_url, _status, kwargs|
         kwargs[:environment_url] == 'stack-deploy-url'
       end.returns(create_status_response)
 

data/test/models/commits_test.rb

@@ -170,6 +170,15 @@ module Shipit
       assert_equal limit, @commit.message.bytesize
     end
 
+    test "#message= truncates multibyte messages" do
+      skip unless Shipit::Commit.columns_hash['message'].limit
+      limit = Shipit::Commit.columns_hash['message'].limit
+
+      @commit.update!(message: '国' * limit)
+      assert_operator @commit.message.length, :<=, limit
+      assert_operator @commit.message.bytesize, :<=, limit
+    end
+
     test "#pull_request? detect pull request based on message format" do
       assert @pr.pull_request?
       refute @commit.pull_request?
@@ -341,6 +350,8 @@ module Shipit
         output: mock(
           title: 'Tests build ran successfully',
         ),
+        completed_at: Time.now,
+        started_at: Time.now - 1.minute,
       )
       response = mock(
         check_runs: [check_run],
@@ -678,7 +689,7 @@ module Shipit
       end
     end
 
-    test "#add_status schedule a MergePullRequests job if the commit transition to `pending` or `success`" do
+    test "#add_status schedule a MergeMergeRequests job if the commit transition to `pending` or `success`" do
       commit = shipit_commits(:second)
       github_status = OpenStruct.new(
         state: 'success',
@@ -688,7 +699,7 @@ module Shipit
       )
 
       assert_equal 'failure', commit.state
-      assert_enqueued_with(job: MergePullRequestsJob, args: [@commit.stack]) do
+      assert_enqueued_with(job: ProcessMergeRequestsJob, args: [@commit.stack]) do
         commit.create_status_from_github!(github_status)
         assert_equal 'success', commit.state
       end
@@ -729,12 +740,12 @@ module Shipit
         sha: '5590fd8b5f2be05d1fedb763a3605ee461c39074',
         message: "Merge pull request #62 from shipit-engine/yoloshipit\n\nyoloshipit!",
       )
-      pull_request = shipit_pull_requests(:shipit_pending)
+      merge_request = shipit_merge_requests(:shipit_pending)
 
       assert_predicate commit, :pull_request?
       assert_equal 62, commit.pull_request_number
-      assert_equal pull_request.title, commit.pull_request_title
-      assert_equal pull_request, commit.pull_request
+      assert_equal merge_request.title, commit.pull_request_title
+      assert_equal merge_request, commit.merge_request
     end
 
     test "merge commits infer pull request number and title from the message if it's not a known pull request" do
@@ -750,7 +761,7 @@ module Shipit
       assert_predicate commit, :pull_request?
       assert_equal 99, commit.pull_request_number
       assert_equal 'yoloshipit!', commit.pull_request_title
-      assert_nil commit.pull_request
+      assert_nil commit.merge_request
     end
 
     test "the merge requester if known overrides the commit author" do
@@ -779,7 +790,7 @@ module Shipit
       refute_predicate commit, :pull_request?
       assert_nil commit.pull_request_number
       assert_nil commit.pull_request_title
-      assert_nil commit.pull_request
+      assert_nil commit.merge_request
     end
 
     test "#revert? returns false if the message doesn't follow the revert convention" do
@@ -838,12 +849,12 @@ module Shipit
     test "when merged via the queue, deploy_requested_at is merge_requested_at" do
       commit = shipit_commits(:cyclimse_merged)
       assert_predicate commit, :pull_request?
-      assert_equal commit.pull_request, shipit_pull_requests(:cyclimse_pending_merged)
-      assert_equal commit.deploy_requested_at, commit.pull_request.merge_requested_at
+      assert_equal commit.merge_request, shipit_merge_requests(:cyclimse_pending_merged)
+      assert_equal commit.deploy_requested_at, commit.merge_request.merge_requested_at
     end
 
     test "when merged manually after being queued, deploy_requested_at is created_at" do
-      pr = shipit_pull_requests(:cyclimse_pending_merged)
+      pr = shipit_merge_requests(:cyclimse_pending_merged)
       pr.cancel!
       commit = shipit_commits(:cyclimse_merged)
       assert_equal commit.deploy_requested_at, commit.created_at
@@ -870,9 +881,9 @@ module Shipit
 
     def expect_hook_emit(commit, event, status_attributes, &block)
       matches = lambda do |payload|
-        assert_equal commit, payload[:commit]
-        assert_equal commit.stack, payload[:stack]
-        assert_equal status_attributes[:state], payload[:status]
+        assert_equal(commit, payload[:commit])
+        assert_equal(commit.stack, payload[:stack])
+        assert_equal(status_attributes[:state], payload[:status])
       end
       expect_hook(event, commit.stack, matches, &block)
     end