shipit-engine 0.32.0 → 0.33.0

data/test/controllers/{pull_requests_controller_test.rb → merge_requests_controller_test.rb}

@@ -2,30 +2,30 @@
 require 'test_helper'
 
 module Shipit
-  class PullRequestsControllerTest < ActionController::TestCase
+  class MergeRequestsControllerTest < ActionController::TestCase
     setup do
       @stack = shipit_stacks(:shipit)
-      @pr = shipit_pull_requests(:shipit_pending)
+      @pr = shipit_merge_requests(:shipit_pending)
       session[:user_id] = shipit_users(:walrus).id
     end
 
     test "#index shows pending pull requests" do
       get :index, params: { stack_id: @stack.to_param }
       assert_response :success
-      assert_select '.pr-list .pr', @stack.pull_requests.pending.count
+      assert_select '.pr-list .pr', @stack.merge_requests.pending.count
     end
 
     test "#add can enqueue a pull request" do
-      assert_difference -> { PullRequest.count }, +1 do
+      assert_difference -> { MergeRequest.count }, +1 do
         post :create, params: { stack_id: @stack.to_param, number_or_url: '#5' }
       end
-      assert_redirected_to stack_pull_requests_path(@stack)
+      assert_redirected_to stack_merge_requests_path(@stack)
     end
 
     test "#destroy can cancel a pending pull request" do
       assert_predicate @pr, :pending?
       delete :destroy, params: { stack_id: @stack.to_param, id: @pr.id }
-      assert_redirected_to stack_pull_requests_path(@stack)
+      assert_redirected_to stack_merge_requests_path(@stack)
       assert_predicate @pr.reload, :canceled?
     end
   end

data/test/controllers/repositories_controller_test.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class RepositoriesControllerTest < ActionController::TestCase
+    setup do
+      @routes = Shipit::Engine.routes
+      @repository = shipit_repositories(:shipit)
+      session[:user_id] = shipit_users(:walrus).id
+    end
+
+    test "GitHub authentication is mandatory" do
+      session[:user_id] = nil
+      get :index
+      assert_redirected_to '/github/auth/github?origin=http%3A%2F%2Ftest.host%2Frepositories'
+    end
+
+    test "current_user must be a member of at least a Shipit.github_teams" do
+      session[:user_id] = shipit_users(:bob).id
+      Shipit.stubs(:github_teams).returns([shipit_teams(:cyclimse_cooks), shipit_teams(:shopify_developers)])
+      get :index
+      assert_response :forbidden
+      assert_equal(
+        'You must be a member of cyclimse/cooks or shopify/developers to access this application.',
+        response.body,
+      )
+    end
+
+    test "#show is success" do
+      get :show, params: { id: @repository.to_param }
+      assert_response :ok
+    end
+
+    test "#create creates a repository and redirects to it" do
+      assert_difference "Repository.count" do
+        post :create, params: {
+          repository: {
+            name: 'valid',
+            owner: 'repository',
+          },
+        }
+      end
+      assert_redirected_to repository_path(Repository.last)
+    end
+
+    test "#create when not valid renders new" do
+      assert_no_difference "Repository.count" do
+        post :create, params: {
+          repository: {
+            owner: 'some',
+            name: 'owner/path',
+          },
+        }
+      end
+      assert_response :success
+    end
+
+    test "#destroy enqueues a DestroyRepositoryJob" do
+      assert_enqueued_with(job: DestroyRepositoryJob, args: [@repository]) do
+        delete :destroy, params: { id: @repository.to_param }
+      end
+
+      assert_redirected_to repositories_path
+    end
+
+    test "#settings is success" do
+      get :settings, params: { id: @repository.to_param }
+      assert_response :success
+    end
+  end
+end

data/test/controllers/stacks_controller_test.rb

@@ -48,11 +48,17 @@ module Shipit
     end
 
     test "#index list all stacks" do
-      get :index
+      get :index, params: { show_archived: true }
       assert_response :ok
       assert_select ".stack", count: Stack.count
     end
 
+    test "#index list all not archived stacks" do
+      get :index
+      assert_response :ok
+      assert_select ".stack", count: Stack.not_archived.count
+    end
+
     test "#index list a repo stacks if the :repo params is passed" do
       repo = shipit_repositories(:shipit)
       get :index, params: { repo: repo.full_name }
@@ -175,6 +181,8 @@ module Shipit
       @stack.reload
       refute @stack.archived?
       refute @stack.locked?
+      assert_nil @stack.locked_since
+      assert_nil @stack.lock_reason
       assert_instance_of AnonymousUser, @stack.lock_author
     end
 

data/test/controllers/tasks_controller_test.rb

@@ -101,12 +101,24 @@ module Shipit
 
     test ":tail returns the task status, output, and next url" do
       @task = shipit_deploys(:shipit_running)
-      last_chunk = @task.chunks.last
+      @task.write("dummy output")
+      last_chunk = @task.chunk_output.bytesize
 
-      get :tail, params: { stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id }, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_json_keys %w(url status output)
       assert_json 'status', @task.status
+      assert_json 'output', @task.chunk_output
+      assert_json 'url', "/shopify/shipit-engine/production/tasks/#{@task.id}/tail?last_byte=#{last_chunk}"
+    end
+
+    test ":tail can handle last_byte as string" do
+      @task = shipit_deploys(:shipit_running)
+      @task.write("dummy output")
+
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id, last_byte: "50" }, format: :json
+      assert_response :success
+      assert_json_keys %w(url status output)
     end
 
     test ":tail doesn't returns the next url if the task is finished" do

data/test/controllers/webhooks_controller_test.rb

@@ -158,7 +158,7 @@ module Shipit
       event = 'pull_request'
       mock_handler = mock
       mock_handler.expects(:call).with(pull_request_params.stringify_keys).once
-      Shipit::Webhooks.register_handler(event, mock_handler)
+      Shipit::Webhooks.handlers["pull_request"] = [mock_handler]
 
       @request.headers['X-Github-Event'] = event
       post :create, body: pull_request_params.to_json, as: :json

data/test/dummy/config/application.rb

@@ -1,6 +1,11 @@
 require File.expand_path('../boot', __FILE__)
 
-require 'rails/all'
+require 'active_record/railtie'
+require 'action_controller/railtie'
+require 'action_view/railtie'
+require 'active_job/railtie'
+require 'rails/test_unit/railtie'
+require 'sprockets/railtie'
 
 Bundler.require(*Rails.groups)
 require "shipit"

data/test/dummy/config/environments/development.rb

@@ -28,9 +28,6 @@ Rails.application.configure do
     config.cache_store = :null_store
   end
 
-  # Don't care if the mailer can't send.
-  config.action_mailer.raise_delivery_errors = false
-
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 

data/test/dummy/config/environments/test.rb

@@ -26,11 +26,6 @@ Rails.application.configure do
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
 
-  # Tell Action Mailer not to deliver emails to the real world.
-  # The :test delivery method accumulates sent emails in the
-  # ActionMailer::Base.deliveries array.
-  config.action_mailer.delivery_method = :test
-
   # Randomize the order test cases are executed.
   config.active_support.test_order = :random
 

data/test/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_06_15_181558) do
+ActiveRecord::Schema.define(version: 2020_10_08_152744) do
 
   create_table "api_clients", force: :cascade do |t|
     t.text "permissions", limit: 65535
@@ -75,7 +75,7 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.integer "deletions", limit: 4
     t.integer "pull_request_number"
     t.string "pull_request_title", limit: 1024
-    t.integer "pull_request_id"
+    t.integer "merge_request_id"
     t.boolean "locked", default: false, null: false
     t.integer "lock_author_id", limit: 4
     t.string "pull_request_head_sha", limit: 40
@@ -138,15 +138,7 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.index ["user_id"], name: "index_memberships_on_user_id"
   end
 
-  create_table "output_chunks", force: :cascade do |t|
-    t.integer "task_id", limit: 4
-    t.text "text", limit: 16777215
-    t.datetime "created_at"
-    t.datetime "updated_at"
-    t.index ["task_id"], name: "index_output_chunks_on_task_id"
-  end
-
-  create_table "pull_requests", force: :cascade do |t|
+  create_table "merge_requests", force: :cascade do |t|
     t.integer "stack_id", null: false
     t.integer "number", null: false
     t.string "title", limit: 256
@@ -168,11 +160,46 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.datetime "merged_at"
     t.string "base_ref", limit: 1024
     t.integer "base_commit_id"
+    t.index ["head_id"], name: "index_merge_requests_on_head_id"
+    t.index ["merge_requested_by_id"], name: "index_merge_requests_on_merge_requested_by_id"
+    t.index ["merge_status"], name: "index_merge_requests_on_merge_status"
+    t.index ["stack_id", "github_id"], name: "index_merge_requests_on_stack_id_and_github_id", unique: true
+    t.index ["stack_id", "merge_status"], name: "index_merge_requests_on_stack_id_and_merge_status"
+    t.index ["stack_id", "number"], name: "index_merge_requests_on_stack_id_and_number", unique: true
+    t.index ["stack_id"], name: "index_merge_requests_on_stack_id"
+  end
+
+  create_table "output_chunks", force: :cascade do |t|
+    t.integer "task_id", limit: 4
+    t.text "text", limit: 16777215
+    t.datetime "created_at"
+    t.datetime "updated_at"
+    t.index ["task_id"], name: "index_output_chunks_on_task_id"
+  end
+
+  create_table "pull_request_assignments", force: :cascade do |t|
+    t.integer "pull_request_id"
+    t.integer "user_id"
+    t.index ["pull_request_id"], name: "index_pull_request_assignments_on_pull_request_id"
+    t.index ["user_id"], name: "index_pull_request_assignments_on_user_id"
+  end
+
+  create_table "pull_requests", force: :cascade do |t|
+    t.integer "stack_id", null: false
+    t.integer "number", null: false
+    t.string "title", limit: 256
+    t.integer "github_id", limit: 8
+    t.string "api_url", limit: 1024
+    t.string "state"
+    t.integer "additions", default: 0, null: false
+    t.integer "deletions", default: 0, null: false
+    t.integer "user_id"
+    t.text "labels"
+    t.integer "head_id"
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
     t.index ["head_id"], name: "index_pull_requests_on_head_id"
-    t.index ["merge_requested_by_id"], name: "index_pull_requests_on_merge_requested_by_id"
-    t.index ["merge_status"], name: "index_pull_requests_on_merge_status"
     t.index ["stack_id", "github_id"], name: "index_pull_requests_on_stack_id_and_github_id", unique: true
-    t.index ["stack_id", "merge_status"], name: "index_pull_requests_on_stack_id_and_merge_status"
     t.index ["stack_id", "number"], name: "index_pull_requests_on_stack_id_and_number", unique: true
     t.index ["stack_id"], name: "index_pull_requests_on_stack_id"
   end
@@ -197,6 +224,9 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.string "name", limit: 100, null: false
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.boolean "review_stacks_enabled", default: false
+    t.string "provisioning_behavior", default: "allow_all"
+    t.string "provisioning_label_name"
     t.index ["owner", "name"], name: "repository_unicity", unique: true
   end
 
@@ -221,9 +251,15 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.datetime "last_deployed_at"
     t.integer "repository_id", null: false
     t.datetime "archived_since"
+    t.string "provision_status", default: "deprovisioned", null: false
+    t.string "type", default: "Shipit::Stack"
+    t.boolean "awaiting_provision", default: false, null: false
     t.index ["archived_since"], name: "index_stacks_on_archived_since"
+    t.index ["awaiting_provision"], name: "index_stacks_on_awaiting_provision"
+    t.index ["provision_status"], name: "index_stacks_on_provision_status"
     t.index ["repository_id", "environment"], name: "stack_unicity", unique: true
     t.index ["repository_id"], name: "index_stacks_on_repository_id"
+    t.index ["type"], name: "index_stacks_on_type"
   end
 
   create_table "statuses", force: :cascade do |t|
@@ -262,6 +298,8 @@ ActiveRecord::Schema.define(version: 2020_06_15_181558) do
     t.boolean "ignored_safeties", default: false, null: false
     t.integer "aborted_by_id"
     t.integer "rollback_once_aborted_to_id"
+    t.integer "retry_attempt", default: 0, null: false
+    t.integer "max_retries"
     t.index ["rolled_up", "created_at", "status"], name: "index_tasks_on_rolled_up_and_created_at_and_status"
     t.index ["since_commit_id"], name: "index_tasks_on_since_commit_id"
     t.index ["stack_id", "allow_concurrency", "status"], name: "index_active_tasks"

data/test/dummy/db/seeds.rb

@@ -147,7 +147,7 @@ module Shipit
       end
     end
 
-    stack.pull_requests.create!(
+    stack.merge_requests.create!(
       number: Faker::Number.number(digits: 3),
       title: Faker::Company.catch_phrase,
       merge_status: 'pending',

data/test/fixtures/payloads/check_suite_master.json

@@ -9,7 +9,7 @@
     "url": "https://api.github.com/repos/Shopify/shipit-engine/check-suites/5",
     "before": "146e867f55c26428e5f9fade55a9bbf5e95a7912",
     "after": "d6fde92930d4715a2b49857d24b940956b26d2d3",
-    "pull_requests": [
+    "merge_requests": [
 
     ],
     "app": {
@@ -191,4 +191,4 @@
   "installation": {
     "id": 1
   }
-}
+}

data/test/fixtures/payloads/invalid_pull_request.json

@@ -0,0 +1,117 @@
+{
+  "action": "opened",
+  "repository": {
+    "id": 186853002,
+    "node_id": "MDEwOlJlcG9zaXRvcnkxODY4NTMwMDI=",
+    "name": "Hello-World",
+    "full_name": "Codertocat/Hello-World",
+    "private": false,
+    "owner": {
+      "login": "Codertocat",
+      "id": 21031067,
+      "node_id": "MDQ6VXNlcjIxMDMxMDY3",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/21031067?v=4",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/Codertocat",
+      "html_url": "https://github.com/Codertocat",
+      "followers_url": "https://api.github.com/users/Codertocat/followers",
+      "following_url": "https://api.github.com/users/Codertocat/following{/other_user}",
+      "gists_url": "https://api.github.com/users/Codertocat/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/Codertocat/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/Codertocat/subscriptions",
+      "organizations_url": "https://api.github.com/users/Codertocat/orgs",
+      "repos_url": "https://api.github.com/users/Codertocat/repos",
+      "events_url": "https://api.github.com/users/Codertocat/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/Codertocat/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "html_url": "https://github.com/Codertocat/Hello-World",
+    "description": null,
+    "fork": false,
+    "url": "https://api.github.com/repos/Codertocat/Hello-World",
+    "forks_url": "https://api.github.com/repos/Codertocat/Hello-World/forks",
+    "keys_url": "https://api.github.com/repos/Codertocat/Hello-World/keys{/key_id}",
+    "collaborators_url": "https://api.github.com/repos/Codertocat/Hello-World/collaborators{/collaborator}",
+    "teams_url": "https://api.github.com/repos/Codertocat/Hello-World/teams",
+    "hooks_url": "https://api.github.com/repos/Codertocat/Hello-World/hooks",
+    "issue_events_url": "https://api.github.com/repos/Codertocat/Hello-World/issues/events{/number}",
+    "events_url": "https://api.github.com/repos/Codertocat/Hello-World/events",
+    "assignees_url": "https://api.github.com/repos/Codertocat/Hello-World/assignees{/user}",
+    "branches_url": "https://api.github.com/repos/Codertocat/Hello-World/branches{/branch}",
+    "tags_url": "https://api.github.com/repos/Codertocat/Hello-World/tags",
+    "blobs_url": "https://api.github.com/repos/Codertocat/Hello-World/git/blobs{/sha}",
+    "git_tags_url": "https://api.github.com/repos/Codertocat/Hello-World/git/tags{/sha}",
+    "git_refs_url": "https://api.github.com/repos/Codertocat/Hello-World/git/refs{/sha}",
+    "trees_url": "https://api.github.com/repos/Codertocat/Hello-World/git/trees{/sha}",
+    "statuses_url": "https://api.github.com/repos/Codertocat/Hello-World/statuses/{sha}",
+    "languages_url": "https://api.github.com/repos/Codertocat/Hello-World/languages",
+    "stargazers_url": "https://api.github.com/repos/Codertocat/Hello-World/stargazers",
+    "contributors_url": "https://api.github.com/repos/Codertocat/Hello-World/contributors",
+    "subscribers_url": "https://api.github.com/repos/Codertocat/Hello-World/subscribers",
+    "subscription_url": "https://api.github.com/repos/Codertocat/Hello-World/subscription",
+    "commits_url": "https://api.github.com/repos/Codertocat/Hello-World/commits{/sha}",
+    "git_commits_url": "https://api.github.com/repos/Codertocat/Hello-World/git/commits{/sha}",
+    "comments_url": "https://api.github.com/repos/Codertocat/Hello-World/comments{/number}",
+    "issue_comment_url": "https://api.github.com/repos/Codertocat/Hello-World/issues/comments{/number}",
+    "contents_url": "https://api.github.com/repos/Codertocat/Hello-World/contents/{+path}",
+    "compare_url": "https://api.github.com/repos/Codertocat/Hello-World/compare/{base}...{head}",
+    "merges_url": "https://api.github.com/repos/Codertocat/Hello-World/merges",
+    "archive_url": "https://api.github.com/repos/Codertocat/Hello-World/{archive_format}{/ref}",
+    "downloads_url": "https://api.github.com/repos/Codertocat/Hello-World/downloads",
+    "issues_url": "https://api.github.com/repos/Codertocat/Hello-World/issues{/number}",
+    "pulls_url": "https://api.github.com/repos/Codertocat/Hello-World/pulls{/number}",
+    "milestones_url": "https://api.github.com/repos/Codertocat/Hello-World/milestones{/number}",
+    "notifications_url": "https://api.github.com/repos/Codertocat/Hello-World/notifications{?since,all,participating}",
+    "labels_url": "https://api.github.com/repos/Codertocat/Hello-World/labels{/name}",
+    "releases_url": "https://api.github.com/repos/Codertocat/Hello-World/releases{/id}",
+    "deployments_url": "https://api.github.com/repos/Codertocat/Hello-World/deployments",
+    "created_at": "2019-05-15T15:19:25Z",
+    "updated_at": "2019-05-15T15:19:27Z",
+    "pushed_at": "2019-05-15T15:20:32Z",
+    "git_url": "git://github.com/Codertocat/Hello-World.git",
+    "ssh_url": "git@github.com:Codertocat/Hello-World.git",
+    "clone_url": "https://github.com/Codertocat/Hello-World.git",
+    "svn_url": "https://github.com/Codertocat/Hello-World",
+    "homepage": null,
+    "size": 0,
+    "stargazers_count": 0,
+    "watchers_count": 0,
+    "language": null,
+    "has_issues": true,
+    "has_projects": true,
+    "has_downloads": true,
+    "has_wiki": true,
+    "has_pages": true,
+    "forks_count": 0,
+    "mirror_url": null,
+    "archived": false,
+    "disabled": false,
+    "open_issues_count": 2,
+    "license": null,
+    "forks": 0,
+    "open_issues": 2,
+    "watchers": 0,
+    "default_branch": "master"
+  },
+  "sender": {
+    "login": "Codertocat",
+    "id": 21031067,
+    "node_id": "MDQ6VXNlcjIxMDMxMDY3",
+    "avatar_url": "https://avatars1.githubusercontent.com/u/21031067?v=4",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/Codertocat",
+    "html_url": "https://github.com/Codertocat",
+    "followers_url": "https://api.github.com/users/Codertocat/followers",
+    "following_url": "https://api.github.com/users/Codertocat/following{/other_user}",
+    "gists_url": "https://api.github.com/users/Codertocat/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/Codertocat/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/Codertocat/subscriptions",
+    "organizations_url": "https://api.github.com/users/Codertocat/orgs",
+    "repos_url": "https://api.github.com/users/Codertocat/repos",
+    "events_url": "https://api.github.com/users/Codertocat/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/Codertocat/received_events",
+    "type": "User",
+    "site_admin": false
+  }
+}