shipit-engine 0.31.0 → 0.35.0

data/test/fixtures/payloads/push_master.json

@@ -64,7 +64,7 @@
     "fork": false,
     "size": 0,
     "owner": {
-      "name": "Shopify",
+      "login": "Shopify",
       "email": "jean.boussier@gmail.com"
     },
     "private": false,

data/test/fixtures/payloads/push_not_master.json

@@ -64,7 +64,7 @@
     "fork": false,
     "size": 0,
     "owner": {
-      "name": "Shopify",
+      "login": "Shopify",
       "email": "jean.boussier@gmail.com"
     },
     "private": false,

data/test/fixtures/shipit/commits.yml

@@ -45,14 +45,15 @@ fourth:
   sha: 467578b362bf2b4df5903e1c7960929361c3435a
   message: "Merge pull request #7 from shipit-engine/yoloshipit\n\nyoloshipit!"
   stack: shipit
-  author: walrus
-  committer: walrus
+  author: ~
+  committer: ~
   authored_at: <%= 4.days.ago.to_s(:db) %>
   committed_at: <%= 3.days.ago.to_s(:db) %>
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
   created_at: <%= 1.day.ago.to_s(:db) %>
+  pull_request_head_sha: '6dcb09b5b57875f334f61aebed695e2e4193db5e'
 
 fifth:
   id: 5
@@ -120,7 +121,7 @@ cyclimse_merged:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
-  pull_request_id: 99
+  merge_request_id: 99
 
 anonymous:
   id: 10
@@ -373,3 +374,30 @@ task_no_commits:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
+
+check_deploy_spec_first:
+  id: 701
+  sha: 547578b362bf2b4df5903e1c7960929361c3435a
+  message: "Removing deploy spec"
+  stack: check_deploy_spec
+  author: walrus
+  committer: walrus
+  authored_at: <%= 4.days.ago.to_s(:db) %>
+  committed_at: <%= 3.days.ago.to_s(:db) %>
+  additions: 420
+  deletions: 342
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+
+deployable_review_stack_commit:
+  id: 801
+  sha: ec26c3e57ca3a959ca5aad62de7213c562f8c821
+  message: "lets go"
+  stack: review_stack
+  author: walrus
+  committer: walrus
+  authored_at: <%= 10.days.ago.to_s(:db) %>
+  committed_at: <%= 9.days.ago.to_s(:db) %>
+  additions: 42
+  deletions: 24
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>

data/test/fixtures/shipit/hooks.yml

@@ -3,6 +3,7 @@ shipit_deploys:
   events: 'deploy,rollback'
   delivery_url: https://example.com/events/deploy
   content_type: json
+  secret: 'example-secret-key'
 
 all_deploys:
   events: 'deploy,rollback'

data/test/fixtures/shipit/merge_requests.yml

@@ -0,0 +1,141 @@
+shipit_fetching:
+  stack: shipit
+  number: 63
+  merge_status: fetching
+  merge_requested_at: <%= 1.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+
+shipit_pending:
+  stack: shipit
+  number: 62
+  title: Super duper nice feature
+  merge_status: pending
+  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 42424424242424
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/62
+  state: open
+  branch: feature-62
+  head_id: 8
+  mergeable: true
+  additions: 23
+  deletions: 43
+
+shipit_pending_unmergeable:
+  stack: shipit
+  number: 61
+  title: Other cool feature
+  merge_status: pending
+  merge_requested_at: <%= 4.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 4.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 43434434343434
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/61
+  state: open
+  branch: feature-61
+  head_id: 8
+  mergeable: false
+  additions: 23
+  deletions: 43
+
+shipit_pending_not_mergeable_yet:
+  stack: shipit
+  number: 64
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 45454454545454
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/64
+  state: open
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+
+shipit_pending_closed:
+  stack: shipit
+  number: 65
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243243
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/65
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+
+shipit_pending_merged:
+  stack: shipit
+  number: 66
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  merged_at: <%= 2.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243232
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/66
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+
+shipit_mergeable_pending_ci:
+  stack: shipit
+  number: 67
+  title: Super duper nice feature
+  merge_status: pending
+  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 424244242424241
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/67
+  state: open
+  branch: feature-67
+  head_id: 4
+  mergeable: true
+  additions: 23
+  deletions: 43
+
+shipit_pending_expired:
+  stack: shipit
+  number: 68
+  title: Noice !
+  merge_status: pending
+  merge_requested_at: <%= 50.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 25.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 48484848484848
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/68
+  state: open
+  branch: feature-68
+  head_id: 8
+  mergeable: true
+  additions: 23
+  deletions: 43
+
+cyclimse_pending_merged:
+  id: 99
+  stack: cyclimse
+  number: 66
+  merge_status: merged
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  merged_at: <%= 2.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243232
+  api_url: https://api.github.com/repos/shopify/cyclimse/pulls/66
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43

data/test/fixtures/shipit/pull_request_assignments.yml

@@ -0,0 +1,3 @@
+walrus_shopify_developers:
+  pull_request: shipit_pending
+  user: walrus

data/test/fixtures/shipit/pull_requests.yml

@@ -1,141 +1,20 @@
-shipit_fetching:
-  stack: shipit
-  number: 63
-  merge_status: fetching
-  merge_requested_at: <%= 1.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-
-shipit_pending:
+shipit_review:
   stack: shipit
   number: 62
   title: Super duper nice feature
-  merge_status: pending
-  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
   github_id: 42424424242424
   api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/62
   state: open
-  branch: feature-62
-  head_id: 8
-  mergeable: true
-  additions: 23
-  deletions: 43
-
-shipit_pending_unmergeable:
-  stack: shipit
-  number: 61
-  title: Other cool feature
-  merge_status: pending
-  merge_requested_at: <%= 4.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 4.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 43434434343434
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/61
-  state: open
-  branch: feature-61
-  head_id: 8
-  mergeable: false
-  additions: 23
-  deletions: 43
-
-shipit_pending_not_mergeable_yet:
-  stack: shipit
-  number: 64
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 45454454545454
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/64
-  state: open
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-
-shipit_pending_closed:
-  stack: shipit
-  number: 65
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243243
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/65
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-
-shipit_pending_merged:
-  stack: shipit
-  number: 66
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  merged_at: <%= 2.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243232
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/66
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-
-shipit_mergeable_pending_ci:
-  stack: shipit
-  number: 67
-  title: Super duper nice feature
-  merge_status: pending
-  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 424244242424241
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/67
-  state: open
-  branch: feature-67
-  head_id: 4
-  mergeable: true
   additions: 23
   deletions: 43
 
-shipit_pending_expired:
-  stack: shipit
-  number: 68
-  title: Noice !
-  merge_status: pending
-  merge_requested_at: <%= 50.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 25.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 48484848484848
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/68
+review_stack_review:
+  stack: review_stack
+  number: 100
+  head_id: 801
+  title: Review Stack Pull Request
+  github_id: 100110001
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/100
   state: open
-  branch: feature-68
-  head_id: 8
-  mergeable: true
-  additions: 23
-  deletions: 43
-
-cyclimse_pending_merged:
-  id: 99
-  stack: cyclimse
-  number: 66
-  merge_status: merged
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  merged_at: <%= 2.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243232
-  api_url: https://api.github.com/repos/shopify/cyclimse/pulls/66
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
+  additions: 1
+  deletions: 70

data/test/fixtures/shipit/repositories.yml

@@ -1,6 +1,7 @@
 shipit:
   owner: shopify
   name: shipit-engine
+  review_stacks_enabled: true
 
 cyclimse:
   owner: george
@@ -18,6 +19,10 @@ check_runs:
   owner: shopify
   name: check_runs
 
+check_deploy_spec:
+  owner: shopify
+  name: check_deploy_spec
+
 rails:
   owner: rails
   name: rails

data/test/fixtures/shipit/stacks.yml

@@ -7,27 +7,70 @@ shipit:
   merge_queue_enabled: true
   tasks_count: 8
   undeployed_commits_count: 2
-  cached_deploy_spec: >
+  cached_deploy_spec: |-
     {
-      "machine": {"environment": {}},
+      "machine": {
+        "environment": {
+        }
+      },
       "review": {
-        "checklist": ["foo", "bar", "baz"],
+        "checklist": [
+          "foo",
+          "bar",
+          "baz"
+        ],
         "monitoring": [
-          {"image": "https://example.com/monitor.png", "width": 200, "height": 300}
+          {
+            "image": "https://example.com/monitor.png",
+            "width": 200,
+            "height": 300
+          }
         ]
       },
-      "dependencies": {"override": []},
-      "deploy": {"override": null, "interval": 60, "max_commits": 3, "variables": [{"name": "SAFETY_DISABLED", "title": "Set to 1 to do dangerous things", "default": 0}]},
-      "rollback": {"override": ["echo 'Rollback!'"]},
-      "fetch": ["echo '42'"],
+      "dependencies": {
+        "override": [
+
+        ]
+      },
+      "deploy": {
+        "override": null,
+        "interval": 60,
+        "max_commits": 3,
+        "variables": [
+          {
+            "name": "SAFETY_DISABLED",
+            "title": "Set to 1 to do dangerous things",
+            "default": 0
+          }
+        ]
+      },
+      "rollback": {
+        "override": [
+          "echo 'Rollback!'"
+        ]
+      },
+      "fetch": [
+        "echo '42'"
+      ],
       "tasks": {
         "restart": {
           "action": "Restart application",
           "description": "Restart app and job servers",
           "variables": [
-            {"name": "FOO", "title": "Set to 0 to foo", "default": 1},
-            {"name": "BAR", "title": "Set to 1 to bar", "default": 0},
-            {"name": "WALRUS", "title": "Walrus without a default value"}
+            {
+              "name": "FOO",
+              "title": "Set to 0 to foo",
+              "default": 1
+            },
+            {
+              "name": "BAR",
+              "title": "Set to 1 to bar",
+              "default": 0
+            },
+            {
+              "name": "WALRUS",
+              "title": "Walrus without a default value"
+            }
           ],
           "steps": [
             "cap $ENVIRONMENT deploy:restart"
@@ -46,8 +89,12 @@ shipit:
         "revalidate_after": 900
       },
       "ci": {
-        "hide": ["ci/hidden"],
-        "allow_failures": ["ci/ok_to_fail"]
+        "hide": [
+          "ci/hidden"
+        ],
+        "allow_failures": [
+          "ci/ok_to_fail"
+        ]
       }
     }
   last_deployed_at: <%= 8.days.ago.to_s(:db) %>
@@ -241,7 +288,23 @@ shipit_undeployed:
         ]
       },
       "dependencies": {"override": []},
-      "deploy": {"override": null, "interval": 60, "max_commits": 3, "variables": [{"name": "SAFETY_DISABLED", "title": "Set to 1 to do dangerous things", "default": 0}]},
+      "deploy": {
+        "override": null,
+        "interval": 60,
+        "max_commits": 3,
+        "variables": [
+          {"name": "SAFETY_DISABLED", "title": "Set to 1 to do dangerous things", "default": 0},
+          {
+            "name": "DEPLOY_REGION",
+            "title": "Region to deploy to",
+            "default": "us-central",
+            "select": [
+              "us-central",
+              "us-east"
+            ]
+          }
+        ]
+      },
       "rollback": {"override": ["echo 'Rollback!'"]},
       "fetch": ["echo '42'"],
       "tasks": {
@@ -404,3 +467,161 @@ shipit_task_no_commits:
       }
     }
   updated_at: <%= 8.days.ago.to_s(:db) %>
+
+check_deploy_spec:
+  repository: check_deploy_spec
+  environment: production
+  branch: master
+  ignore_ci: true
+  merge_queue_enabled: true
+  tasks_count: 0
+  undeployed_commits_count: 1
+  continuous_deployment: true
+  cached_deploy_spec: "{}"
+  last_deployed_at: <%= 8.days.ago.to_s(:db) %>
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+
+review_stack:
+  type: Shipit::ReviewStack
+  repository: shipit
+  environment: "123"
+  branch: master
+  deploy_url: https://shipit.shopify.com
+  ignore_ci: false
+  merge_queue_enabled: true
+  tasks_count: 8
+  undeployed_commits_count: 2
+  cached_deploy_spec: |-
+    {
+      "machine": {
+        "environment": {
+        }
+      },
+      "review": {
+        "checklist": [
+          "foo",
+          "bar",
+          "baz"
+        ],
+        "monitoring": [
+          {
+            "image": "https://example.com/monitor.png",
+            "width": 200,
+            "height": 300
+          }
+        ]
+      },
+      "dependencies": {
+        "override": [
+
+        ]
+      },
+      "deploy": {
+        "override": null,
+        "interval": 60,
+        "max_commits": 3,
+        "variables": [
+          {
+            "name": "SAFETY_DISABLED",
+            "title": "Set to 1 to do dangerous things",
+            "default": 0
+          }
+        ]
+      },
+      "rollback": {
+        "override": [
+          "echo 'Rollback!'"
+        ]
+      },
+      "fetch": [
+        "echo '42'"
+      ],
+      "tasks": {
+        "restart": {
+          "action": "Restart application",
+          "description": "Restart app and job servers",
+          "variables": [
+            {
+              "name": "FOO",
+              "title": "Set to 0 to foo",
+              "default": 1
+            },
+            {
+              "name": "BAR",
+              "title": "Set to 1 to bar",
+              "default": 0
+            },
+            {
+              "name": "WALRUS",
+              "title": "Walrus without a default value"
+            }
+          ],
+          "steps": [
+            "cap $ENVIRONMENT deploy:restart"
+          ]
+        },
+        "flush_cache": {
+          "action": "Flush cache",
+          "description": "Flush the application cache",
+          "steps": [
+            "cap $ENVIRONMENT cache:flush"
+          ],
+          "allow_concurrency": true
+        }
+      },
+      "merge": {
+        "revalidate_after": 900
+      },
+      "ci": {
+        "hide": [
+          "ci/hidden"
+        ],
+        "allow_failures": [
+          "ci/ok_to_fail"
+        ]
+      }
+    }
+  last_deployed_at: <%= 8.days.ago.to_s(:db) %>
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+
+archived_25hours_ago:
+  type: Shipit::ReviewStack
+  repository: cyclimse
+  environment: archived_25hours_ago
+  branch: master
+  ignore_ci: true
+  merge_queue_enabled: true
+  tasks_count: 8
+  undeployed_commits_count: 2
+  cached_deploy_spec: "{}"
+  last_deployed_at: <%= 8.days.ago.to_s(:db) %>
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+  archived_since: <%= 25.hours.ago.to_s(:db) %>
+
+archived_6hours_ago:
+  type: Shipit::ReviewStack
+  repository: cyclimse
+  environment: archived_6hours_ago
+  branch: master
+  ignore_ci: true
+  merge_queue_enabled: true
+  tasks_count: 8
+  undeployed_commits_count: 2
+  cached_deploy_spec: "{}"
+  last_deployed_at: <%= 8.days.ago.to_s(:db) %>
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+  archived_since: <%= 6.hours.ago.to_s(:db) %>
+
+archived_30minutes_ago:
+  type: Shipit::ReviewStack
+  repository: cyclimse
+  environment: archived_30minutes_ago
+  branch: master
+  ignore_ci: true
+  merge_queue_enabled: true
+  tasks_count: 8
+  undeployed_commits_count: 2
+  cached_deploy_spec: "{}"
+  last_deployed_at: <%= 8.days.ago.to_s(:db) %>
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+  archived_since: <%= 30.minutes.ago.to_s(:db) %>