shipit-engine 0.3.1 → 0.4.0

data/test/fixtures/stacks.yml

@@ -27,6 +27,10 @@ shipit:
             "cap $ENVIRONMENT deploy:restart"
           ]
         }
+      },
+      "ci": {
+        "hide": ["ci/hidden"],
+        "allow_failures": ["ci/ok_to_fail"]
       }
     }
   updated_at: <%= 8.days.ago.to_s(:db) %>

data/test/models/commits_test.rb

@@ -269,6 +269,52 @@ class CommitsTest < ActiveSupport::TestCase
     assert commits(:first).deployable?
   end
 
+  expected_webhook_transitions = { # we expect deployable_status to fire on these transitions, and not on any others
+    'pending' => %w(success failure error),
+    'success' => %w(failure error),
+    'failure' => %w(success),
+    'error' => %w(success),
+  }
+  expected_webhook_transitions.each do |initial_state, firing_states|
+    initial_status_attributes = {state: initial_state, description: 'abc', context: 'ci/travis'}
+    expected_webhook_transitions.keys.each do |new_state|
+      should_fire = firing_states.include?(new_state)
+      test "#add_status #{should_fire ? 'fires' : 'does not fire'} for status from #{initial_state} to #{new_state}" do
+        commit = commits(:cyclimse_first)
+        assert commit.stack.hooks.where(events: ['deploy_status']).size >= 1
+        refute commit.stack.ignore_ci
+        commit.statuses.destroy_all
+        commit.reload
+        commit.statuses.create!(initial_status_attributes.merge(created_at: 10.days.ago.to_s(:db)))
+        assert_equal initial_state, commit.state
+
+        expected_status_attributes = {state: new_state, description: initial_state, context: 'ci/travis'}
+        if should_fire
+          expect_hook_emit(commit, :deployable_status, expected_status_attributes)
+        else
+          Hook.expects(:emit).never
+        end
+        expect_hook_emit(commit, :commit_status, expected_status_attributes)
+
+        commit.add_status(expected_status_attributes.merge(created_at: 1.day.ago.to_s(:db)))
+      end
+    end
+  end
+
+  test "#add_status does not fire webhooks for invisible statuses" do
+    commit = commits(:second)
+    assert commit.stack.hooks.where(events: ['commit_status']).size >= 1
+    Hook.expects(:emit).never
+    commit.add_status(state: 'failure', description: 'Sad', context: 'ci/hidden', created_at: 1.day.ago.to_s(:db))
+  end
+
+  test "#add_status does not fire webhooks for non-meaningful statuses" do
+    commit = commits(:second)
+    assert commit.stack.hooks.where(events: ['commit_status']).size >= 1
+    Hook.expects(:emit).never
+    commit.add_status(state: 'failure', description: 'Sad', context: 'ci/ok_to_fail', created_at: 1.day.ago.to_s(:db))
+  end
+
   test "#visible_statuses forward the last_statuses to the stack" do
     commit = commits(:second)
     stack = commit.stack
@@ -330,4 +376,11 @@ class CommitsTest < ActiveSupport::TestCase
       channel == "stack.#{stack.id}" && data['url'] == "/#{stack.to_param}"
     end
   end
+
+  def expect_hook_emit(commit, event, status_attributes)
+    matchers = status_attributes.to_a.map { |pair| responds_with(pair.first, pair.second) }
+    Hook.expects(:emit).with(event, commit.stack, has_entries(commit: commit, stack: commit.stack,
+                                                              event => all_of(*matchers),
+                                                              status: status_attributes[:state]))
+  end
 end

data/test/models/deploys_test.rb

@@ -325,6 +325,57 @@ class DeploysTest < ActiveSupport::TestCase
     end
   end
 
+  test "#accept! bails out if the deploy is successful already" do
+    assert_predicate @deploy, :success?
+
+    Deploy::CONFIRMATIONS_REQUIRED.times do
+      @deploy.accept!
+      assert_predicate @deploy, :success?
+    end
+  end
+
+  test "#accept! first transition to flapping then ultimately to success if the deploy was failed" do
+    @deploy = deploys(:shipit2)
+    assert_predicate @deploy, :failed?
+
+    (Deploy::CONFIRMATIONS_REQUIRED - 1).times do
+      @deploy.accept!
+      assert_predicate @deploy, :flapping?
+    end
+
+    @deploy.accept!
+    assert_predicate @deploy, :success?
+  end
+
+  test "#reject! bails out if the deploy is failed already" do
+    @deploy = deploys(:shipit2)
+    assert_predicate @deploy, :failed?
+
+    Deploy::CONFIRMATIONS_REQUIRED.times do
+      @deploy.reject!
+      assert_predicate @deploy, :failed?
+    end
+  end
+
+  test "#reject! first transition to flapping then ultimately to failed if the deploy was successful" do
+    assert_predicate @deploy, :success?
+
+    (Deploy::CONFIRMATIONS_REQUIRED - 1).times do
+      @deploy.reject!
+      assert_predicate @deploy, :flapping?
+    end
+
+    @deploy.reject!
+    assert_predicate @deploy, :failed?
+  end
+
+  test "entering flapping state triggers webhooks" do
+    assert_enqueued_with job: EmitEventJob do
+      @deploy.reject!
+    end
+    assert_predicate @deploy, :flapping?
+  end
+
   private
 
   def expect_event(deploy)

data/test/models/hook_test.rb

@@ -7,6 +7,12 @@ class HookTest < ActiveSupport::TestCase
   end
 
   test "#url must be valid" do
+    @hook.url = 'file:/ad"fa/adfa'
+    refute @hook.valid?
+    assert_equal ['Url is not a valid URL'], @hook.errors.full_messages
+  end
+
+  test "#url must not be localhost" do
     @hook.url = 'file:///etc/passwd'
     refute @hook.valid?
     assert_equal ['Url is not a valid URL'], @hook.errors.full_messages
@@ -28,7 +34,7 @@ class HookTest < ActiveSupport::TestCase
     end
   end
 
-  test ".deliver schedule a delivery for each matching hook" do
+  test ".deliver schedules a delivery for each matching hook" do
     assert_difference -> { Delivery.count }, 2 do
       Hook.deliver(:deploy, @stack, 'foo' => 42)
     end
@@ -41,7 +47,7 @@ class HookTest < ActiveSupport::TestCase
     assert_equal 'scheduled', delivery.status
   end
 
-  test ".scoped? returns true if the hook have a stack_id" do
+  test ".scoped? returns true if the hook has a stack_id" do
     @hook.stack_id = nil
     refute @hook.scoped?
 

data/test/models/stacks_test.rb

@@ -148,6 +148,22 @@ class StacksTest < ActiveSupport::TestCase
     assert_equal commits(:fifth), @stack.last_deployed_commit
   end
 
+  test "#update_deployed_revision accepts the deploy if the reported revision is consistent" do
+    Deploy.active.update_all(status: 'error')
+
+    Deploy.any_instance.expects(:accept!).once
+    last_deploy = @stack.deploys_and_rollbacks.completed.last
+    @stack.update_deployed_revision(last_deploy.until_commit.sha)
+  end
+
+  test "#update_deployed_revision reject the deploy if the reported revision is inconsistent" do
+    Deploy.active.update_all(status: 'error')
+
+    Deploy.any_instance.expects(:reject!).once
+    last_deploy = @stack.deploys_and_rollbacks.completed.last
+    @stack.update_deployed_revision(last_deploy.since_commit.sha)
+  end
+
   test "#create queues 2 GithubSetupWebhooksJob" do
     assert_enqueued_with(job: SetupGithubHookJob) do
       Stack.create!(repo_name: 'rails', repo_owner: 'rails')