shipit-engine 0.25.1 → 0.26.0

data/test/fixtures/payloads/check_suite_master.json

@@ -0,0 +1,194 @@
+{
+  "action": "requested",
+  "check_suite": {
+    "id": 5,
+    "head_branch": "master",
+    "head_sha": "6d9278037b872fd9a6690523e411ecb3aa181355",
+    "status": "completed",
+    "conclusion": "neutral",
+    "url": "https://api.github.com/repos/Shopify/shipit-engine/check-suites/5",
+    "before": "146e867f55c26428e5f9fade55a9bbf5e95a7912",
+    "after": "d6fde92930d4715a2b49857d24b940956b26d2d3",
+    "pull_requests": [
+
+    ],
+    "app": {
+      "id": 2,
+      "node_id": "MDExOkludGVncmF0aW9uMQ==",
+      "owner": {
+        "login": "github",
+        "id": 340,
+        "node_id": "MDEyOk9yZ2FuaXphdGlvbjE=",
+        "avatar_url": "http://alambic.github.com/avatars/u/340?",
+        "gravatar_id": "",
+        "url": "https://api.github.com/users/github",
+        "html_url": "http://github.com/github",
+        "followers_url": "https://api.github.com/users/github/followers",
+        "following_url": "https://api.github.com/users/github/following{/other_user}",
+        "gists_url": "https://api.github.com/users/github/gists{/gist_id}",
+        "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
+        "subscriptions_url": "https://api.github.com/users/github/subscriptions",
+        "organizations_url": "https://api.github.com/users/github/orgs",
+        "repos_url": "https://api.github.com/users/github/repos",
+        "events_url": "https://api.github.com/users/github/events{/privacy}",
+        "received_events_url": "https://api.github.com/users/github/received_events",
+        "type": "Organization",
+        "site_admin": false
+      },
+      "name": "Super Duper",
+      "description": null,
+      "external_url": "http://super-duper.example.com",
+      "html_url": "http://github.com/apps/super-duper",
+      "created_at": "2018-04-25 20:42:10",
+      "updated_at": "2018-04-25 20:42:10"
+    },
+    "created_at": "2018-05-04T01:14:52Z",
+    "updated_at": "2018-05-04T01:14:52Z",
+    "latest_check_runs_count": 1,
+    "check_runs_url": "https://api.github.com/repos/Shopify/shipit-engine/check-suites/5/check-runs",
+    "head_commit": {
+      "id": "d6fde92930d4715a2b49857d24b940956b26d2d3",
+      "tree_id": "41a846c7d878d279f11355e23b348e1bb63b89a8",
+      "message": "Say hello (again) to everybody",
+      "timestamp": "2018-05-04T01:14:46Z",
+      "author": {
+        "name": "octocat",
+        "email": "octocat@github.com"
+      },
+      "committer": {
+        "name": "octocat",
+        "email": "octocat@github.com"
+      }
+    }
+  },
+  "repository": {
+    "id": 526,
+    "node_id": "MDEwOlJlcG9zaXRvcnkxMzU0OTMyMzM=",
+    "name": "shipit-engine",
+    "full_name": "Shopify/shipit-engine",
+    "owner": {
+      "login": "github",
+      "id": 340,
+      "node_id": "MDQ6VXNlcjIxMDMxMDY3",
+      "avatar_url": "http://alambic.github.com/avatars/u/340?",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/github",
+      "html_url": "http://github.com/github",
+      "followers_url": "https://api.github.com/users/github/followers",
+      "following_url": "https://api.github.com/users/github/following{/other_user}",
+      "gists_url": "https://api.github.com/users/github/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/github/subscriptions",
+      "organizations_url": "https://api.github.com/users/github/orgs",
+      "repos_url": "https://api.github.com/users/github/repos",
+      "events_url": "https://api.github.com/users/github/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/github/received_events",
+      "type": "Organization",
+      "site_admin": false
+    },
+    "private": false,
+    "html_url": "http://github.com/Shopify/shipit-engine",
+    "description": null,
+    "fork": false,
+    "url": "https://api.github.com/repos/Shopify/shipit-engine",
+    "forks_url": "https://api.github.com/repos/Shopify/shipit-engine/forks",
+    "keys_url": "https://api.github.com/repos/Shopify/shipit-engine/keys{/key_id}",
+    "collaborators_url": "https://api.github.com/repos/Shopify/shipit-engine/collaborators{/collaborator}",
+    "teams_url": "https://api.github.com/repos/Shopify/shipit-engine/teams",
+    "hooks_url": "https://api.github.com/repos/Shopify/shipit-engine/hooks",
+    "issue_events_url": "https://api.github.com/repos/Shopify/shipit-engine/issues/events{/number}",
+    "events_url": "https://api.github.com/repos/Shopify/shipit-engine/events",
+    "assignees_url": "https://api.github.com/repos/Shopify/shipit-engine/assignees{/user}",
+    "branches_url": "https://api.github.com/repos/Shopify/shipit-engine/branches{/branch}",
+    "tags_url": "https://api.github.com/repos/Shopify/shipit-engine/tags",
+    "blobs_url": "https://api.github.com/repos/Shopify/shipit-engine/git/blobs{/sha}",
+    "git_tags_url": "https://api.github.com/repos/Shopify/shipit-engine/git/tags{/sha}",
+    "git_refs_url": "https://api.github.com/repos/Shopify/shipit-engine/git/refs{/sha}",
+    "trees_url": "https://api.github.com/repos/Shopify/shipit-engine/git/trees{/sha}",
+    "statuses_url": "https://api.github.com/repos/Shopify/shipit-engine/statuses/{sha}",
+    "languages_url": "https://api.github.com/repos/Shopify/shipit-engine/languages",
+    "stargazers_url": "https://api.github.com/repos/Shopify/shipit-engine/stargazers",
+    "contributors_url": "https://api.github.com/repos/Shopify/shipit-engine/contributors",
+    "subscribers_url": "https://api.github.com/repos/Shopify/shipit-engine/subscribers",
+    "subscription_url": "https://api.github.com/repos/Shopify/shipit-engine/subscription",
+    "commits_url": "https://api.github.com/repos/Shopify/shipit-engine/commits{/sha}",
+    "git_commits_url": "https://api.github.com/repos/Shopify/shipit-engine/git/commits{/sha}",
+    "comments_url": "https://api.github.com/repos/Shopify/shipit-engine/comments{/number}",
+    "issue_comment_url": "https://api.github.com/repos/Shopify/shipit-engine/issues/comments{/number}",
+    "contents_url": "https://api.github.com/repos/Shopify/shipit-engine/contents/{+path}",
+    "compare_url": "https://api.github.com/repos/Shopify/shipit-engine/compare/{base}...{head}",
+    "merges_url": "https://api.github.com/repos/Shopify/shipit-engine/merges",
+    "archive_url": "https://api.github.com/repos/Shopify/shipit-engine/{archive_format}{/ref}",
+    "downloads_url": "https://api.github.com/repos/Shopify/shipit-engine/downloads",
+    "issues_url": "https://api.github.com/repos/Shopify/shipit-engine/issues{/number}",
+    "pulls_url": "https://api.github.com/repos/Shopify/shipit-engine/pulls{/number}",
+    "milestones_url": "https://api.github.com/repos/Shopify/shipit-engine/milestones{/number}",
+    "notifications_url": "https://api.github.com/repos/Shopify/shipit-engine/notifications{?since,all,participating}",
+    "labels_url": "https://api.github.com/repos/Shopify/shipit-engine/labels{/name}",
+    "releases_url": "https://api.github.com/repos/Shopify/shipit-engine/releases{/id}",
+    "deployments_url": "https://api.github.com/repos/Shopify/shipit-engine/deployments",
+    "created_at": "2018-04-25T20:42:10Z",
+    "updated_at": "2018-04-25T20:43:34Z",
+    "pushed_at": "2018-05-04T01:14:47Z",
+    "git_url": "git://github.com/Shopify/shipit-engine.git",
+    "ssh_url": "ssh://git@localhost:3035/Shopify/shipit-engine.git",
+    "clone_url": "http://github.com/Shopify/shipit-engine.git",
+    "svn_url": "http://github.com/Shopify/shipit-engine",
+    "homepage": null,
+    "size": 0,
+    "stargazers_count": 0,
+    "watchers_count": 0,
+    "language": null,
+    "has_issues": true,
+    "has_projects": true,
+    "has_downloads": true,
+    "has_wiki": true,
+    "has_pages": false,
+    "forks_count": 0,
+    "mirror_url": null,
+    "archived": false,
+    "open_issues_count": 3,
+    "license": null,
+    "forks": 0,
+    "open_issues": 3,
+    "watchers": 0,
+    "default_branch": "master"
+  },
+  "organization": {
+    "login": "github",
+    "id": 340,
+    "node_id": "MDEyOk9yZ2FuaXphdGlvbjM4MzAyODk5",
+    "url": "https://api.github.com/orgs/github",
+    "repos_url": "https://api.github.com/orgs/github/repos",
+    "events_url": "https://api.github.com/orgs/github/events",
+    "hooks_url": "https://api.github.com/orgs/github/hooks",
+    "issues_url": "https://api.github.com/orgs/github/issues",
+    "members_url": "https://api.github.com/orgs/github/members{/member}",
+    "public_members_url": "https://api.github.com/orgs/github/public_members{/member}",
+    "avatar_url": "http://alambic.github.com/avatars/u/340?",
+    "description": "How people build software."
+  },
+  "sender": {
+    "login": "octocat",
+    "id": 5346,
+    "node_id": "MDQ6VXNlcjIxMDMxMDY3",
+    "avatar_url": "http://alambic.github.com/avatars/u/5346?",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/octocat",
+    "html_url": "http://github.com/octocat",
+    "followers_url": "https://api.github.com/users/octocat/followers",
+    "following_url": "https://api.github.com/users/octocat/following{/other_user}",
+    "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
+    "organizations_url": "https://api.github.com/users/octocat/orgs",
+    "repos_url": "https://api.github.com/users/octocat/repos",
+    "events_url": "https://api.github.com/users/octocat/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/octocat/received_events",
+    "type": "User",
+    "site_admin": false
+  },
+  "installation": {
+    "id": 1
+  }
+}

data/test/fixtures/shipit/check_runs.yml

@@ -0,0 +1,21 @@
+second_pending_travis:
+  stack: shipit
+  commit_id: 2 # second
+  github_id: 424242
+  name: Travis CI
+  title: Tests ran successfully
+  conclusion: success
+  html_url: "http://www.example.com/run/424242"
+  details_url: "http://www.example.com/build/424242"
+  created_at: <%= 10.days.ago.to_s(:db) %>
+
+check_runs_first_success_coveralls:
+  stack: check_runs
+  commit_id: 201 # check_runs_first
+  github_id: 434343
+  title: lets go
+  name: Coverage metrics
+  created_at: <%= 9.days.ago.to_s(:db) %>
+  conclusion: success
+  html_url: "http://www.example.com/run/434343"
+  details_url: "http://www.example.com/build/434343"

data/test/fixtures/shipit/commits.yml

@@ -168,3 +168,16 @@ soc_third:
   additions: 12
   deletions: 64
   updated_at: <%= 8.days.ago.to_s(:db) %>
+
+check_runs_first:
+  id: 201
+  sha: 234328037b872fd9a6690523e411ecb3aa181355
+  message: "lets go"
+  stack: check_runs
+  author: walrus
+  committer: walrus
+  authored_at: <%= 10.days.ago.to_s(:db) %>
+  committed_at: <%= 9.days.ago.to_s(:db) %>
+  additions: 42
+  deletions: 24
+  updated_at: <%= 8.days.ago.to_s(:db) %>

data/test/fixtures/shipit/stacks.yml

@@ -162,3 +162,11 @@ soc:
       }
     }
   updated_at: <%= 8.days.ago.to_s(:db) %>
+
+check_runs:
+  repo_owner: shopify
+  repo_name: check_runs
+  environment: production
+  branch: master
+  tasks_count: 0
+  undeployed_commits_count: 1

data/test/jobs/perform_task_job_test.rb

@@ -2,6 +2,15 @@ require 'test_helper'
 
 module Shipit
   class PerformTaskJobTest < ActiveSupport::TestCase
+    class FakeSuccessfulCommand
+      def run
+      end
+
+      def success?
+        true
+      end
+    end
+
     setup do
       @job = PerformTaskJob.new
       @deploy = shipit_deploys(:shipit_pending)
@@ -14,7 +23,7 @@ module Shipit
       @commands = stub(:commands)
       Commands.expects(:for).with(@deploy).returns(@commands)
 
-      @commands.expects(:fetch).once
+      @commands.expects(:fetched?).once.returns(FakeSuccessfulCommand.new)
       @commands.expects(:clone).returns([]).once
       @commands.expects(:checkout).with(@deploy.until_commit).once
       @commands.expects(:install_dependencies).returns([]).once

data/test/models/commits_test.rb

@@ -222,6 +222,29 @@ module Shipit
       assert_equal 'success', @commit.statuses.first.state
     end
 
+    test "refresh_check_runs! pull state from github" do
+      check_run = mock(
+        id: 34_234_234_234_432,
+        name: 'Test suite',
+        conclusion: 'neutral',
+        details_url: 'https://example.com/details',
+        html_url: 'https://example.com/run',
+        output: mock(
+          title: 'Tests build ran successfully',
+        ),
+      )
+      response = mock(
+        check_runs: [check_run],
+      )
+      Shipit.github.api.expects(:check_runs).with(@stack.github_repo_name, @commit.sha).returns(response)
+
+      assert_difference -> { @commit.check_runs.count }, 1 do
+        @commit.refresh_check_runs!
+      end
+
+      assert_equal 'success', @commit.check_runs.first.state
+    end
+
     test "#creating a commit update the undeployed_commits_count" do
       walrus = shipit_users(:walrus)
       assert_equal 1, @stack.undeployed_commits_count
@@ -321,14 +344,18 @@ module Shipit
     test "#status returns an unknown if the commit has no statuses" do
       commit = shipit_commits(:second)
       commit.statuses = []
+      commit.check_runs = []
       assert_predicate commit.status, :unknown?
     end
 
     test "#status rejects the statuses that are specified in the deploy spec's `ci.hide`" do
       commit = shipit_commits(:second)
       assert_predicate commit.status, :group?
-      assert_equal 2, commit.status.size
-      commit.stack.update!(cached_deploy_spec: DeploySpec.new('ci' => {'hide' => 'metrics/coveralls'}))
+      assert_equal 3, commit.status.size
+      commit.stack.update!(cached_deploy_spec: DeploySpec.new('ci' => {'hide' => [
+        'Travis CI',
+        'metrics/coveralls',
+      ]}))
       commit.reload
       refute_predicate commit.status, :group?
     end

data/test/models/deploy_spec_test.rb

@@ -214,6 +214,46 @@ module Shipit
       assert_equal ["kubernetes-deploy --max-watch-seconds 900 foo bar"], @spec.rollback_steps
     end
 
+    test "#discover_task_definitions include a kubernetes restart command if `kubernetes` is present" do
+      @spec.stubs(:load_config).returns(
+        'kubernetes' => {
+          'namespace' => 'foo',
+          'context' => 'bar',
+        },
+      )
+      tasks = {
+        'restart' => {
+          'action' => 'Restart application',
+          'description' => 'Simulates a rollout of Kubernetes deployments by using kubernetes-restart utility',
+          'steps' => ['kubernetes-restart foo bar --max-watch-seconds 900'],
+        },
+      }
+      assert_equal tasks, @spec.discover_task_definitions
+    end
+
+    test "#discover_task_definitions include the user defined restart command even if `kubernetes` is present" do
+      tasks = {
+        'restart' => {
+          'action' => 'Restart application',
+          'description' => 'Simulates a rollout of Kubernetes deployments by using kubernetes-restart utility',
+          'steps' => ['kubernetes-restart something custom'],
+        },
+        'some-other-tasj' => {
+          'action' => 'Do something else',
+          'description' => 'Eat some chips!',
+          'steps' => ['echo chips'],
+        },
+      }
+      @spec.stubs(:load_config).returns(
+        'kubernetes' => {
+          'namespace' => 'foo',
+          'context' => 'bar',
+        },
+        'tasks' => tasks,
+      )
+      assert_equal tasks, @spec.discover_task_definitions
+    end
+
     test '#machine_env returns an environment hash' do
       @spec.stubs(:load_config).returns('machine' => {'environment' => {'GLOBAL' => '1'}})
       assert_equal({'GLOBAL' => '1'}, @spec.machine_env)

data/test/models/shipit/check_run_test.rb

@@ -0,0 +1,51 @@
+require 'test_helper'
+
+module Shipit
+  class CheckRunTest < ActiveSupport::TestCase
+    setup do
+      @commit = shipit_commits(:first)
+      @stack = @commit.stack
+      @check_run = shipit_check_runs(:second_pending_travis)
+    end
+
+    test ".create_or_update_from_github! is idempotent" do
+      assert_difference -> { @commit.check_runs.count }, +1 do
+        @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run)
+      end
+
+      assert_no_difference -> { @commit.check_runs.count } do
+        @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run)
+      end
+    end
+
+    {
+      nil => 'pending',
+      'success' => 'success',
+      'failure' => 'failure',
+      'neutral' => 'success',
+      'cancelled' => 'failure',
+      'timed_out' => 'error',
+      'action_required' => 'pending',
+    }.each do |conclusion, expected_status|
+      test "#state is #{expected_status.inspect} when conclusion is #{conclusion.inspect}" do
+        @check_run.update!(conclusion: conclusion)
+        assert_equal expected_status, @check_run.state
+      end
+    end
+
+    private
+
+    def github_check_run
+      @github_check_run ||= OpenStruct.new(
+        id: 424_242,
+        conclusion: 'success',
+        output: OpenStruct.new(
+          description: 'This is a description',
+        ),
+        name: 'Test Suite',
+        html_url: 'http://example.com/run',
+        details_url: 'http://example.com/details',
+      )
+    end
+  end
+end

data/test/models/status/group_test.rb

@@ -4,11 +4,11 @@ module Shipit
   class StatusGroupTest < ActiveSupport::TestCase
     setup do
       @commit = shipit_commits(:second)
-      @group = Status::Group.new(@commit, @commit.statuses)
+      @group = Status::Group.new(@commit, @commit.statuses_and_check_runs)
     end
 
     test "#description is a summary of the statuses" do
-      assert_equal '1 / 2 checks OK', @group.description
+      assert_equal '2 / 3 checks OK', @group.description
     end
 
     test "#group? returns true" do
@@ -20,7 +20,7 @@ module Shipit
     end
 
     test "#state is significant's status state" do
-      assert_equal %w(success failure), @group.statuses.map(&:state)
+      assert_equal %w(success success failure), @group.statuses.map(&:state)
       assert_equal 'failure', @group.state
     end
 

data/test/unit/deploy_commands_test.rb

@@ -61,7 +61,11 @@ module Shipit
     test "#clone clones the repository cache into the working directory" do
       commands = @commands.clone
       assert_equal 2, commands.size
-      clone_args = ['git', 'clone', '--local', '--origin', 'cache', @stack.git_path, @deploy.working_directory]
+      clone_args = [
+        'git', 'clone', '--local',
+        '--origin', 'cache',
+        @stack.git_path, @deploy.working_directory
+      ]
       assert_equal clone_args, commands.first.args
       assert_equal ['git', 'remote', 'add', 'origin', @stack.repo_git_url], commands.second.args
     end