shipit-engine 0.2.3 → 0.3.0

data/test/dummy/tmp/cache/48D/660/task%3A73%3Apid

@@ -0,0 +1,2 @@
+o: ActiveSupport::Cache::Entry:@valueio�:@created_atf1440538336.8985999:@expires_inf
+3.6e3

data/test/dummy/tmp/cache/5F5/7B0/task%3A644540443%3Apid

@@ -1,2 +1,2 @@
-o: ActiveSupport::Cache::Entry:@valuei/:@created_atf1440287501.490551:@expires_inf
+o: ActiveSupport::Cache::Entry:@valuei/:@created_atf1441985184.249957:@expires_inf
 3.6e3

data/test/dummy/tmp/cache/5F7/AA0/task%3A496901070%3Apid

@@ -1,2 +1,2 @@
-o: ActiveSupport::Cache::Entry:@valueix�:@created_atf1440287496.052917:@expires_inf
+o: ActiveSupport::Cache::Entry:@valueiD:@created_atf1441985492.542173:@expires_inf
 3.6e3

data/test/dummy/tmp/cache/5FD/BF0/task%3A616453971%3Apid

@@ -1,2 +1,2 @@
-o: ActiveSupport::Cache::Entry:@valuei/:@created_atf1440287497.7865229:@expires_inf
+o: ActiveSupport::Cache::Entry:@valuei/:@created_atf1441985184.291611:@expires_inf
 3.6e3

data/test/dummy/tmp/cache/98C/C60/stacks%3A616453971%3Aci_enabled

@@ -1 +1 @@
-o: ActiveSupport::Cache::Entry:@valueT:@created_atf1440287498.936449:@expires_in0
+o: ActiveSupport::Cache::Entry:@valueT:@created_atf1441985186.357144:@expires_in0

data/test/helpers/queries_helper.rb

@@ -41,7 +41,7 @@ module QueriesHelper
     attr_reader :log
 
     def initialize(ignore = nil)
-      @ignore =  ignore || self.class.ignored_sql
+      @ignore = ignore || self.class.ignored_sql
       @log = []
     end
 

data/test/jobs/emit_event_job_test.rb

@@ -7,7 +7,7 @@ class EmitEventJobTest < ActiveSupport::TestCase
   end
 
   test "#perform schedule deliveries" do
-    assert_difference -> { Delivery.scheduled.count }, +2 do
+    assert_difference -> { Delivery.scheduled.count }, 2 do
       @job.perform(event: :deploy, stack_id: @stack.id, payload: {foo: 42}.to_json)
     end
   end

data/test/jobs/unique_job_test.rb

@@ -14,4 +14,10 @@ class UniqueJobTest < ActiveSupport::TestCase
     end
     assert called
   end
+
+  test "the lock key is serialized" do
+    task = tasks(:shipit_restart)
+    job = ChunkRollupJob.new(task)
+    assert_equal %(ChunkRollupJob-{"_aj_globalid"=>"gid://shipit/Task/#{task.id}"}), job.lock_key(*job.arguments)
+  end
 end

data/test/models/commits_test.rb

@@ -156,7 +156,7 @@ class CommitsTest < ActiveSupport::TestCase
     rels = {target: mock(href: 'http://example.com')}
     status = mock(state: 'success', description: nil, context: 'default', rels: rels, created_at: 1.day.ago)
     Shipit.github_api.expects(:statuses).with(@stack.github_repo_name, @commit.sha).returns([status])
-    assert_difference '@commit.statuses.count', +1 do
+    assert_difference '@commit.statuses.count', 1 do
       @commit.refresh_statuses!
     end
     assert_equal 'success', @commit.statuses.first.state

data/test/models/deploys_test.rb

@@ -37,9 +37,9 @@ class DeploysTest < ActiveSupport::TestCase
   end
 
   test "#since_commit_id returns a default value if stack_id is set" do
-    stack  = stacks(:shipit)
+    stack = stacks(:shipit)
     deploy = stack.deploys.new
-    last   = stack.deploys.success.last.until_commit_id
+    last = stack.deploys.success.last.until_commit_id
     assert_equal last, deploy.since_commit_id
   end
 
@@ -51,7 +51,7 @@ class DeploysTest < ActiveSupport::TestCase
   test "additions and deletions are denormalized on before create" do
     stack = stacks(:shipit)
     first = commits(:first)
-    third  = commits(:third)
+    third = commits(:third)
 
     deploy = stack.deploys.create!(
       since_commit: first,
@@ -65,7 +65,7 @@ class DeploysTest < ActiveSupport::TestCase
   test "#commits returns the commits in the id range" do
     stack = stacks(:shipit)
     first = commits(:first)
-    last  = commits(:third)
+    last = commits(:third)
 
     deploy = stack.deploys.new(
       since_commit: first,
@@ -82,7 +82,7 @@ class DeploysTest < ActiveSupport::TestCase
   test "#commits returns commits from newer to older" do
     stack = stacks(:shipit)
     first = commits(:first)
-    last  = commits(:fourth)
+    last = commits(:fourth)
 
     deploy = stack.deploys.new(
       since_commit: first,
@@ -195,7 +195,7 @@ class DeploysTest < ActiveSupport::TestCase
     @deploy.pid = 42
     @deploy.abort!(rollback_once_aborted: true)
 
-    assert_difference -> { @stack.rollbacks.count }, +1 do
+    assert_difference -> { @stack.rollbacks.count }, 1 do
       assert_enqueued_with(job: PerformTaskJob) do
         @deploy.aborted!
       end
@@ -237,7 +237,7 @@ class DeploysTest < ActiveSupport::TestCase
   end
 
   test "#trigger_rollback creates a new Rollback" do
-    assert_difference -> { Rollback.count }, +1 do
+    assert_difference -> { Rollback.count }, 1 do
       @deploy.trigger_rollback(@user)
     end
   end

data/test/models/hook_test.rb

@@ -29,7 +29,7 @@ class HookTest < ActiveSupport::TestCase
   end
 
   test ".deliver schedule a delivery for each matching hook" do
-    assert_difference -> { Delivery.count }, +2 do
+    assert_difference -> { Delivery.count }, 2 do
       Hook.deliver(:deploy, @stack, 'foo' => 42)
     end
 

data/test/models/output_chunk_test.rb

@@ -8,7 +8,7 @@ class OutputChunkTest < ActiveSupport::TestCase
 
   test "tail" do
     start = @chunks.first
-    rest  = @chunks - [start]
+    rest = @chunks - [start]
     assert_equal rest, @deploy.chunks.tail(start.id)
   end
 

data/test/models/stacks_test.rb

@@ -126,7 +126,7 @@ class StacksTest < ActiveSupport::TestCase
     Deploy.active.update_all(status: 'error')
 
     assert_equal commits(:fourth), @stack.last_deployed_commit
-    assert_difference 'Deploy.count', +1 do
+    assert_difference 'Deploy.count', 1 do
       deploy = @stack.update_deployed_revision(commits(:fifth).sha)
       assert_not_nil deploy
       assert_equal commits(:fourth), deploy.since_commit
@@ -139,7 +139,7 @@ class StacksTest < ActiveSupport::TestCase
     Deploy.active.update_all(status: 'error')
 
     assert_equal commits(:fourth), @stack.last_deployed_commit
-    assert_difference 'Deploy.count', +1 do
+    assert_difference 'Deploy.count', 1 do
       deploy = @stack.update_deployed_revision(commits(:fifth).sha[0..5])
       assert_not_nil deploy
       assert_equal commits(:fourth), deploy.since_commit

data/test/models/status_test.rb

@@ -7,7 +7,7 @@ class StatusTest < ActiveSupport::TestCase
   end
 
   test ".replicate_from_github! is idempotent" do
-    assert_difference '@commit.statuses.count', +1 do
+    assert_difference '@commit.statuses.count', 1 do
       @commit.statuses.replicate_from_github!(github_status)
     end
 

data/test/models/team_test.rb

@@ -13,7 +13,7 @@ class TeamTest < ActiveSupport::TestCase
     Shipit.github_api.expects(:org_teams).with('shopify', per_page: 100)
     response = stub(rels: {}, data: [new_team])
     Shipit.github_api.expects(:last_response).returns(response)
-    assert_difference -> { Team.count }, +1 do
+    assert_difference -> { Team.count }, 1 do
       Team.find_or_create_by_handle('Shopify/new-team')
     end
   end
@@ -21,7 +21,7 @@ class TeamTest < ActiveSupport::TestCase
   test "#refresh_members! fetch all the team members from github" do
     response = stub(rels: {members: members_resource})
     Shipit.github_api.expects(:get).with(@team.api_url).returns(response)
-    assert_difference -> { User.count }, +1 do
+    assert_difference -> { User.count }, 1 do
       @team.refresh_members!
     end
   end

data/test/models/users_test.rb

@@ -8,7 +8,7 @@ class UsersTest < ActiveSupport::TestCase
   end
 
   test "find_or_create_from_github persist a new user if he is unknown" do
-    assert_difference 'User.count', +1 do
+    assert_difference 'User.count', 1 do
       fetch_user
     end
   end

data/test/test_helper.rb

@@ -6,7 +6,7 @@ SimpleCov.start 'rails'
 require 'fakeweb'
 FakeWeb.allow_net_connect = false
 
-require File.expand_path("../../test/dummy/config/environment.rb",  __FILE__)
+require File.expand_path("../../test/dummy/config/environment.rb", __FILE__)
 ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]
 ActiveRecord::Migrator.migrations_paths << File.expand_path('../../db/migrate', __FILE__)
 require "rails/test_help"

data/test/unit/github_url_helper_test.rb

@@ -18,7 +18,7 @@ class GithubUrlHelperTest < ActiveSupport::TestCase
 
   test "#github_diff_url returns a diff url" do
     from_sha = SecureRandom.hex
-    to_sha   = SecureRandom.hex
+    to_sha = SecureRandom.hex
     expected = "https://github.com/rails/rails/compare/#{from_sha}...#{to_sha}"
 
     assert_equal expected, github_diff_url("rails", "rails", from_sha, to_sha)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shipit-engine
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-22 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -600,6 +600,7 @@ files:
 - test/dummy/public/favicon.ico
 - test/dummy/tmp/cache/48B/590/task%3A80%3Apid
 - test/dummy/tmp/cache/48C/600/task%3A81%3Apid
+- test/dummy/tmp/cache/48D/660/task%3A73%3Apid
 - test/dummy/tmp/cache/48D/670/task%3A82%3Apid
 - test/dummy/tmp/cache/48E/6E0/task%3A83%3Apid
 - test/dummy/tmp/cache/48F/750/task%3A84%3Apid
@@ -2608,6 +2609,7 @@ test_files:
 - test/dummy/README.rdoc
 - test/dummy/tmp/cache/48B/590/task%3A80%3Apid
 - test/dummy/tmp/cache/48C/600/task%3A81%3Apid
+- test/dummy/tmp/cache/48D/660/task%3A73%3Apid
 - test/dummy/tmp/cache/48D/670/task%3A82%3Apid
 - test/dummy/tmp/cache/48E/6E0/task%3A83%3Apid
 - test/dummy/tmp/cache/48F/750/task%3A84%3Apid