ship_compliant 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f443106337d6607f7f5acbc873e53f0c0a0a4d93
-  data.tar.gz: 146bd1895326a8d9498e8eab4e2eda79972a37dd
+  metadata.gz: af2d76277ee247b655a0379f45fc8ef90c731c16
+  data.tar.gz: 722edef7e124c8f76100709a29323d276990b3e4
 SHA512:
-  metadata.gz: 6fe4a7762c4bd76c5ad638d5953f544a7b2762a11995ab8c3ccf591fb65f58ddd4d275a5767d8e38e4f7fd6b357cd912244e218045787d744bb0be45e38c3042
-  data.tar.gz: e0b51b47750b3d30968f5062a968bd3d19ecf574ea51cbadd68b7bb8320ac59a571abfe820b88f4e0705931debfe92c1ccf43e10f0237af41bb77f2ec86672f2
+  metadata.gz: 79f05b87eed5ce74083be059f623bb91356d289a20d3a7d7c9de70311879ddf7662d6d811db09db11c039f7a61a4f74c71c40eb13e85302b5696d9b3b5a53ecb
+  data.tar.gz: ae8536cb971526eb361ead6981c84aa208dd99b48ac6362dc61c63e291801345f5d7ce3b8020fa8191f5890d8953b8087f594a30e852dceb69c63c46c3058217

data/.travis.yml

@@ -1,8 +1,7 @@
 language: ruby
 cache: bundler
 rvm:
-  #- 1.9.2
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
+  - 2.2.2
+  - 2.2.6
+  - 2.3.3
 env: CUCUMBER_FORMAT=progress SHIP_COMPLIANT_KEY=foo SHIP_COMPLIANT_USER=bar SHIP_COMPLIANT_PASS=baz

data/CHANGELOG.md

@@ -0,0 +1,7 @@
+### 0.2.0 - 2014-03-28
+
+- 1 major enhancement
+  - Add support for [SearchMoreSalesOrders](http://shipcompliant.github.io/ship_compliant-ruby/documentation/search_more_sales_orders.html)
+
+- 1 minor adjustment
+  - Pry is included in the test environment.

data/README.md

@@ -52,11 +52,11 @@ TODO: Coming soon...
 [core_service_path]: https://shipcompliant.desk.com/customer/portal/articles/1451976-api-coreservice-v1-2?b_id=2759
 
 <!-- Status Badges -->
-[Coverage Status]: https://coveralls.io/repos/ShipCompliant/ship_compliant-ruby/badge.png?branch=master
+[Coverage Status]: https://coveralls.io/repos/ShipCompliant/ship_compliant-ruby/badge.svg?branch=master
 [coveralls_status]: https://coveralls.io/r/ShipCompliant/ship_compliant-ruby?branch=master
 
-[Build Status]: https://travis-ci.org/ShipCompliant/ship_compliant-ruby.png?branch=master
+[Build Status]: https://travis-ci.org/ShipCompliant/ship_compliant-ruby.svg?branch=master
 [travis_status]: https://travis-ci.org/ShipCompliant/ship_compliant-ruby
 
-[Code Climate]: https://codeclimate.com/github/ShipCompliant/ship_compliant-ruby.png
+[Code Climate]: https://codeclimate.com/github/ShipCompliant/ship_compliant-ruby.svg
 [code_gpa]: https://codeclimate.com/github/ShipCompliant/ship_compliant-ruby

data/features/step_definitions/brand_steps.rb

@@ -54,7 +54,7 @@ When(/^I ignore existing brand on update$/) do
 end
 
 Then(/^I should get an error for already defined brand$/) do
-  @brand_result.failure?.should be_true
+  @brand_result.failure?.should be_truthy
   @brand_result.errors.length.should == 1
   error = @brand_result.errors.first
   
@@ -65,9 +65,9 @@ Then(/^I should get an error for already defined brand$/) do
 end
 
 Then(/^the brand should have been updated$/) do
-  @brand_result.success?.should be_true
+  @brand_result.success?.should be_truthy
 end
 
 Then(/^the brand should have been created$/) do
-  @brand_result.success?.should be_true
+  @brand_result.success?.should be_truthy
 end

data/features/step_definitions/commit_sales_order/all_shipments.rb

@@ -10,6 +10,6 @@ When(/^I commit a sale with all shipments$/) do
 end
 
 Then(/^I get a successful commit message$/) do
-  @order_commit_result.success?.should be_true
+  @order_commit_result.success?.should be_truthy
   @order_commit_result.committed_shipments.should == ['1']
 end

data/features/step_definitions/compliance_check/available_product_steps.rb

@@ -90,8 +90,8 @@ When(/^I check compliance with an available product$/) do
 end
 
 Then(/^I should receive the sales tax rates$/) do
-  @compliance_status.success?.should be_true
-  @compliance_status.compliant?.should be_true
+  @compliance_status.success?.should be_truthy
+  @compliance_status.compliant?.should be_truthy
 
   # Tax Rates
   @compliance_status.recommended_tax_due.should == 44.1
@@ -112,7 +112,7 @@ end
 
 Then(/^I should receive the shipment compliance results$/) do
   shipment_compliance = @compliance_status.compliance_rules_for_shipment('1')
-  shipment_compliance.compliant?.should be_true
+  shipment_compliance.compliant?.should be_truthy
   shipment_compliance.shipment_key.should == '1'
 
   shipment_compliance.rules.length.should == 6

data/features/step_definitions/compliance_check/missing_product_steps.rb

@@ -90,7 +90,7 @@ When(/^I check compliance with a missing product$/) do
 end
 
 Then(/^I should receive a product key error$/) do
-  @compliance_status.failure?.should be_true
+  @compliance_status.failure?.should be_truthy
   @compliance_status.error_count.should == 1
   error = @compliance_status.errors.first
 

data/features/step_definitions/compliance_check/noncompliant_product.rb

@@ -86,7 +86,7 @@ When(/^I check compliance with a non\-compliant product$/) do
 end
 
 Then(/^I should receive error messages$/) do
-  @compliance_status.compliant?.should be_false
+  @compliance_status.compliant?.should be_falsey
   shipment = @compliance_status.compliance_rules_for_shipment('1')
   errors = shipment.rules.select { |r| !r.compliant? }
 

data/features/step_definitions/product_steps.rb

@@ -104,15 +104,15 @@ When(/^I ignore existing product on update$/) do
 end
 
 Then(/^the product should have been created$/) do
-  @product_response.success?.should be_true
+  @product_response.success?.should be_truthy
 end
 
 Then(/^I should get a message that the product was updated$/) do
-  @product_response.success?.should be_true
+  @product_response.success?.should be_truthy
 end
 
 Then(/^I should get an error message for the missing brand$/) do
-  product_response.failure?.should be_true
+  product_response.failure?.should be_truthy
   product_response.errors_count.should == 1
   
   error = product_response.errors[0]
@@ -124,7 +124,7 @@ Then(/^I should get an error message for the missing brand$/) do
 end
 
 Then(/^I should get an error for already defined product$/) do
-  product_response.failure?.should be_true
+  product_response.failure?.should be_truthy
   product_response.errors_count.should == 1
   
   error = product_response.errors[0]

data/features/step_definitions/sales_order_extended_steps.rb

@@ -12,7 +12,7 @@ end
 
 Then(/^I should receive shipment compliance statuses$/) do
   shipment_compliance = @order_result.compliance_rules_for_shipment('1')
-  shipment_compliance.compliant?.should be_true
+  shipment_compliance.compliant?.should be_truthy
   shipment_compliance.rules.should == []
 end
 
@@ -69,7 +69,7 @@ Then(/^I should receive order channel details$/) do
 end
 
 Then(/^I should receive an error that the order doesn't exist$/) do
-  @order_result.failure?.should be_true
+  @order_result.failure?.should be_truthy
   error = @order_result.errors.first
 
   error.code.should == 200

data/features/step_definitions/search_more_orders_steps.rb

@@ -11,12 +11,12 @@ When(/^I search with invalid paging cookie$/) do
 end
 
 Then(/^I should have orders$/) do
-  @orders_result.success?.should be_true
+  @orders_result.success?.should be_truthy
   @orders_result.length.should == 100
 end
 
 Then(/^I should receive an invalid cookie error$/) do
-  @orders_result.failure?.should be_true
+  @orders_result.failure?.should be_truthy
   error = @orders_result.errors.first
 
   error.message.should == 'PagingCookie was not found [00000000-0000-0000-0000-000000000000].'

data/features/step_definitions/search_order_steps.rb

@@ -14,7 +14,7 @@ When(/^I search with invalid criteria$/) do
 end
 
 Then(/^I should receive a success status for search$/) do
-  @search_results.success?.should be_true
+  @search_results.success?.should be_truthy
 end
 
 Then(/^I should have paging cookie information$/) do
@@ -23,7 +23,7 @@ Then(/^I should have paging cookie information$/) do
 end
 
 Then(/^I should get an error status for search$/) do
-  @search_results.failure?.should be_true
+  @search_results.failure?.should be_truthy
   @search_results.error_count.should == 1
   
   error = @search_results.errors.first

data/features/step_definitions/void_order_steps.rb

@@ -11,11 +11,11 @@ When(/^I void an already void order$/) do
 end
 
 Then(/^I should get a successful response$/) do
-  @voided_order.success?.should be_true
+  @voided_order.success?.should be_truthy
 end
 
 Then(/^I should get an error message$/) do
-  @voided_order.failure?.should be_true
+  @voided_order.failure?.should be_truthy
   @voided_order.errors_count.should == 1
 
   error = @voided_order.errors[0]

data/features/support/env.rb

@@ -1,6 +1,9 @@
 require 'bundler/setup'
 Bundler.setup
 
+require 'dotenv'
+Dotenv.load
+
 require 'ship_compliant'
 require 'vcr'
 require 'pry'

data/lib/ship_compliant/commit_sales_order.rb

@@ -16,7 +16,7 @@ module ShipCompliant
   # sales order without committing any of them.
   #
   #   result = ShipCompliant::CommitSalesOrder.call({
-  #     commit_options: 'AllShipments',
+  #     commit_option: 'AllShipments',
   #     payments: nil,
   #     sales_tax_collected: 0,
   #     sales_order_key: 'ORDER-KEY'

data/lib/ship_compliant/version.rb

@@ -1,3 +1,3 @@
 module ShipCompliant
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/ship_compliant.gemspec

@@ -13,14 +13,14 @@ Gem::Specification.new do |s|
   s.homepage      = "http://baylorrae.github.io/ship_compliant-ruby"
   s.license       = "MIT"
 
-  s.required_ruby_version = '>= 1.9.3'
+  s.required_ruby_version = '>= 2.2.2'
 
   s.files         = `git ls-files -z`.split("\x0")
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency "activesupport", "~> 4.0", ">= 4.0.3"
+  s.add_dependency "activesupport", ">= 4.0.3"
   s.add_dependency "savon", "~> 2.3"
 
   s.add_development_dependency "bundler", "~> 1.5"
@@ -29,8 +29,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency "pry", "~> 0.9"
 
   # TESTING
-  s.add_development_dependency "rspec", "~> 2.13"
+  s.add_development_dependency "rspec", "~> 3.3"
   s.add_development_dependency "cucumber", "~> 1.3"
   s.add_development_dependency "webmock", "~> 1.17"
   s.add_development_dependency "vcr", "~> 2.9"
+  s.add_development_dependency "dotenv", "~> 2.0"
 end

data/spec/lib/ship_compliant/add_update_brand_spec.rb

@@ -38,7 +38,7 @@ module ShipCompliant
           owner: { name: 'Sam' }
         }, update_mode: 'DoWackaDo')
 
-        result.should be_kind_of(AddUpdateBrandResult)
+        expect(result).to be_kind_of(AddUpdateBrandResult)
       end
 
       it "update mode defaults to ErrorOnExisting" do

data/spec/lib/ship_compliant/add_update_product_spec.rb

@@ -26,14 +26,14 @@ module ShipCompliant
 
     context "product" do
       it "queries the client with product an update mode" do
-        AddUpdateProduct.stub(:add_update_product) { {} }
+        allow(AddUpdateProduct).to receive(:add_update_product) { {} }
         
         result = AddUpdateProduct.product({
           bottle_size_ml: 123,
           default_wholesale_case_price: 150
         }, update_mode: 'DoWackaDo')
 
-        result.should be_kind_of(AddUpdateProductResult)
+        expect(result).to be_kind_of(AddUpdateProductResult)
       end
 
       it "update mode defaults to ErrorOnExisting" do

data/spec/lib/ship_compliant/address/suggested_address_spec.rb

@@ -3,17 +3,17 @@ require "spec_helper"
 module ShipCompliant
   describe SuggestedAddress do
 
-    it { should be_kind_of(Address) }
+    it { is_expected.to be_kind_of(Address) }
 
     context "details" do
       it "gets the details" do
-        subject.details.should == { address_details: true }
+        expect(subject.details).to eq({ address_details: true })
       end
     end
 
     context "parts" do
       it "gets the parts" do
-        subject.parts.should == { address_parts: true }
+        expect(subject.parts).to eq({ address_parts: true })
       end
     end
 

data/spec/lib/ship_compliant/address_spec.rb

@@ -5,96 +5,96 @@ module ShipCompliant
 
     context "city" do
       it "gets the city" do
-        subject.city.should == 'A City'
+        expect(subject.city).to eq('A City')
       end
     end
 
     context "county" do
       it "gets the county" do
-        subject.county.should == 'A County'
+        expect(subject.county).to eq('A County')
       end
     end
 
     context "state" do
       it "gets the state" do
-        subject.state.should == 'A State'
+        expect(subject.state).to eq('A State')
       end
     end
 
     context "country" do
       it "gets the country" do
-        subject.country.should == 'A Country'
+        expect(subject.country).to eq('A Country')
       end
     end
 
     context "street1" do
       it "gets street1" do
-        subject.street1.should == 'Street 1'
+        expect(subject.street1).to eq('Street 1')
       end
     end
 
     context "street2" do
       it "gets street2" do
-        subject.street2.should == 'Street 2'
+        expect(subject.street2).to eq('Street 2')
       end
     end
 
     context "zip1" do
       it "gets zip1" do
-        subject.zip1.should == 12345
+        expect(subject.zip1).to eq(12345)
       end
     end
 
     context "zip2" do
       it "gets zip2" do
-        subject.zip2.should == 1234
+        expect(subject.zip2).to eq(1234)
       end
 
       it "returns nil when empty" do
         subject.address[:zip2] = nil
-        subject.zip2.should be_nil
+        expect(subject.zip2).to be_nil
       end
     end
 
     context "company" do
       it "gets company" do
-        subject.company.should == 'Dippin Dots'
+        expect(subject.company).to eq('Dippin Dots')
       end
     end
 
     context "date_of_birth" do
       it "gets date_of_birth" do
-        subject.date_of_birth.should == Date.new(1967, 8, 12)
+        expect(subject.date_of_birth).to eq(Date.new(1967, 8, 12))
       end
     end
 
     context "email" do
       it "gets email" do
-        subject.email.should == 'sogood@getdots.com'
+        expect(subject.email).to eq('sogood@getdots.com')
       end
     end
 
     context "fax" do
       it "gets fax" do
-        subject.fax.should == '(555) 123-8901'
+        expect(subject.fax).to eq('(555) 123-8901')
       end
     end
     
     context "phone" do
       it "gets phone" do
-        subject.phone.should == '(555) 123-4567'
+        expect(subject.phone).to eq('(555) 123-4567')
       end
     end
 
     context "first_name" do
       it "gets first_name" do
-        subject.first_name.should == 'Lt.'
+        expect(subject.first_name).to eq('Lt.')
       end
     end
     
     context "last_name" do
       it "gets last_name" do
-        subject.last_name.should == 'Columbo'
+        expect(subject.last_name).to eq('Columbo')
       end
     end
 

data/spec/lib/ship_compliant/base_result_spec.rb

@@ -28,27 +28,27 @@ module ShipCompliant
     context "success?" do
       it "returns true for successful response status" do
         result = FauxResult.new(success_message)
-        result.success?.should be_true
+        expect(result.success?).to be_truthy
       end
 
       it "returns false for failed response status" do
         result = FauxResult.new(failure_message)
-        result.success?.should be_false
+        expect(result.success?).to be_falsey
       end
     end
 
     context "failure?" do
       it "returns opposite of success?" do
         result = FauxResult.new({})
-        result.stub(:success?) { false }
-        result.failure?.should be_true
+        allow(result).to receive(:success?) { false }
+        expect(result.failure?).to be_truthy
       end
     end
 
     context "errors" do
       it "returns an array of errors" do
         result = FauxResult.new(failure_message)
-        result.errors.should == [
+        expect(result.errors).to eq([
           ErrorResult.new({
               code: "404",
               key: "OrderId",
@@ -56,7 +56,7 @@ module ShipCompliant
               target: "SalesOrder",
               type: "Validation"
           })
-        ]
+        ])
       end
 
       it "doesn't break when errors is already an array" do
@@ -68,23 +68,23 @@ module ShipCompliant
           ]
         })
 
-        result.errors.should == [
+        expect(result.errors).to eq([
           ErrorResult.new(code: '404'),
           ErrorResult.new(code: '500')
-        ]
+        ])
       end
 
       it "returns an empty array for successful response" do
         result = FauxResult.new(success_message)
-        result.errors.should == []
+        expect(result.errors).to eq([])
       end
     end
 
     context "errors_count" do
       it "counts the number of errors" do
         result = FauxResult.new({})
-        result.stub(:errors) { [1, 2, 3 ] }
-        result.errors_count.should == 3
+        allow(result).to receive(:errors) { [1, 2, 3 ] }
+        expect(result.errors_count).to eq(3)
       end
     end
 

data/spec/lib/ship_compliant/channel_details_spec.rb

@@ -5,25 +5,25 @@ module ShipCompliant
 
     context "order_channel" do
       it "gets the order_channel" do
-        subject.order_channel.should == 'order-channel'
+        expect(subject.order_channel).to eq('order-channel')
       end
     end
 
     context "advertiser_key" do
       it "gets the advertiser_key" do
-        subject.advertiser_key.should == 'advertiser-key'
+        expect(subject.advertiser_key).to eq('advertiser-key')
       end
     end
     
     context "advertiser_name" do
       it "gets the advertiser_name" do
-        subject.advertiser_name.should == 'advertiser-name'
+        expect(subject.advertiser_name).to eq('advertiser-name')
       end
     end
 
     context "meta" do
       it "gets channel meta" do
-        subject.meta.should == 'channel-meta'
+        expect(subject.meta).to eq('channel-meta')
       end
     end
 

data/spec/lib/ship_compliant/check_compliance_result_spec.rb

@@ -6,7 +6,7 @@ module ShipCompliant
 
     context "compliant?" do
       it "successed if the salesorder was compliant" do
-        subject.compliant?.should be_true
+        expect(subject.compliant?).to be_truthy
       end
 
       it "fails if the salesorder was not compliant" do
@@ -14,19 +14,19 @@ module ShipCompliant
           sales_order: { is_compliant: false }
         })
 
-        result.compliant?.should be_false
+        expect(result.compliant?).to be_falsey
       end
     end
 
     context "recommended_tax_due" do
       it "gets the tax due as a float" do
-        subject.recommended_tax_due.should == 1372.34
+        expect(subject.recommended_tax_due).to eq(1372.34)
       end
     end
 
     context "shipment_sales_tax_rates" do
       it "returns an array of sales tax rates" do
-        subject.shipment_sales_tax_rates.should == [
+        expect(subject.shipment_sales_tax_rates).to eq([
           {
             :@shipment_key => 'ORDER-KEY',
             freight_sales_tax_rate: {
@@ -42,54 +42,54 @@ module ShipCompliant
               }
             }
           }
-        ]
+        ])
       end
     end
 
     context "taxes_for_shipment" do
       it "finds taxes from shipment_key" do
-        subject.taxes_for_shipment('ORDER-KEY').should == ShipmentSalesTaxRate.new(
+        expect(subject.taxes_for_shipment('ORDER-KEY')).to eq(ShipmentSalesTaxRate.new(
           shipment_key = 'ORDER-KEY',
           freight = FreightSalesTaxRate.new({ sales_tax_due: 100.5, sales_tax_rate: 10.34 }),
           products = [
             ProductSalesTaxRate.new({ brand_key: 'ABC', product_key: '123', sales_tax_due: 12.332, sales_tax_rate: 0.844 })
           ]
-        )
+        ))
       end
     end
 
     context "shipment_compliance_rules" do
       it "returns compliance rules as an array" do
-        subject.shipment_compliance_rules.should == [
+        expect(subject.shipment_compliance_rules).to eq([
           {
             is_compliant: true,
             key: 'ORDER-KEY'
           }
-        ]
+        ])
       end
     end
 
     context "compliance_rules_for_shipment" do
       it "finds compliance rules for shipment" do
-        subject.compliance_rules_for_shipment('ORDER-KEY').should == ShipmentCompliance.new({
+        expect(subject.compliance_rules_for_shipment('ORDER-KEY')).to eq(ShipmentCompliance.new({
           is_compliant: true,
           key: 'ORDER-KEY'
-        })
+        }))
       end
     end
 
     context "address_validation_result" do
       it "gets the address validation result" do
-        subject.address_validation_result.should == 'AddressValidated'
+        expect(subject.address_validation_result).to eq('AddressValidated')
       end
     end
 
     context "suggested_address" do
       it "returns the suggested address" do
-        subject.suggested_address.should == SuggestedAddress.new({
+        expect(subject.suggested_address).to eq(SuggestedAddress.new({
           city: 'Bluebell',
           state: 'Ice Cream'
-        })
+        }))
       end
     end
 

data/spec/lib/ship_compliant/check_compliance_spec.rb

@@ -35,7 +35,7 @@ module ShipCompliant
           foo_bar: { baz: false }
         })
 
-        result.should be_kind_of(CheckComplianceResult)
+        expect(result).to be_kind_of(CheckComplianceResult)
       end
     end