ship_compliant 0.2.0 → 0.2.1

data/spec/lib/ship_compliant/client_spec.rb

@@ -4,7 +4,7 @@ module ShipCompliant
   describe Client do
 
     it "inherits from Savon::Client" do
-      ShipCompliant.client.should be_kind_of(Savon::Client)
+      expect(ShipCompliant.client).to be_kind_of(Savon::Client)
     end
 
     it "uses wsdl from configuration" do
@@ -12,12 +12,12 @@ module ShipCompliant
         c.wsdl = 'http://example.com'
       end
 
-      ShipCompliant.client.globals[:wsdl].should == 'http://example.com'
+      expect(ShipCompliant.client.globals[:wsdl]).to eq('http://example.com')
     end
 
     it "uses log value from configuration" do
       # configuration is defined in spec_helper.rb
-      ShipCompliant.client.globals[:log].should == false
+      expect(ShipCompliant.client.globals[:log]).to be_falsey
     end
 
     context "call" do
@@ -43,8 +43,8 @@ module ShipCompliant
       end
 
       it "the response's result directly" do
-        ShipCompliant.client.stub(:savon_call) do
-          stub(to_hash: {
+        allow(ShipCompliant.client).to receive(:savon_call) do
+          double(to_hash: {
             a_method_response: {
               a_method_result: {
                 response_status: 'Success'
@@ -54,18 +54,18 @@ module ShipCompliant
         end
 
         result = ShipCompliant.client.call(:a_method, {})
-        result.should == {
+        expect(result).to eq({
           response_status: 'Success'
-        }
+        })
       end
     end
 
     context "wsdl=" do
       it "changes the default wsdl" do
         ShipCompliant.configuration = nil
-        ShipCompliant.client.globals[:wsdl].should == 'https://ws-dev.shipcompliant.com/services/1.2/coreservice.asmx?WSDL'
+        expect(ShipCompliant.client.globals[:wsdl]).to eq('https://ws-dev.shipcompliant.com/services/1.2/coreservice.asmx?WSDL')
         ShipCompliant.wsdl = 'http://ws.example.com?WSDL'
-        ShipCompliant.client.globals[:wsdl].should == 'http://ws.example.com?WSDL'
+        expect(ShipCompliant.client.globals[:wsdl]).to eq('http://ws.example.com?WSDL')
       end
     end
 

data/spec/lib/ship_compliant/commit_sales_order_result_spec.rb

@@ -6,15 +6,15 @@ module ShipCompliant
 
     context "shipments" do
       it "returns the shipments as an array" do
-        subject.shipments.should == [
+        expect(subject.shipments).to eq([
           { key: 'SHIPMENT-KEY', is_committed: true }
-        ]
+        ])
       end
     end
 
     context "committed_shipments" do
       it "returns the shipment keys for committed shipments" do
-        subject.committed_shipments.should == ['SHIPMENT-KEY']
+        expect(subject.committed_shipments).to eq(['SHIPMENT-KEY'])
       end
     end
 

data/spec/lib/ship_compliant/commit_sales_order_spec.rb

@@ -32,7 +32,7 @@ module ShipCompliant
         sales_order_key: 'ORDER-KEY'
       })
 
-      result.should be_kind_of(CommitSalesOrderResult)
+      expect(result).to be_kind_of(CommitSalesOrderResult)
     end
   end
 end

data/spec/lib/ship_compliant/compliance_rule_spec.rb

@@ -5,31 +5,31 @@ module ShipCompliant
 
     context "compliance_description" do
       it "gets the description" do
-        subject.compliance_description.should == 'Howdy Stranger'
+        expect(subject.compliance_description).to eq('Howdy Stranger')
       end
     end
 
     context "rule_description" do
       it "gets the rule" do
-        subject.rule_description.should == 'Must say hi to people you do not know.'
+        expect(subject.rule_description).to eq('Must say hi to people you do not know.')
       end
     end
 
     context "compliant?" do
       it "check this rule passed" do
-        subject.compliant?.should be_true
+        expect(subject.compliant?).to be_truthy
       end
     end
 
     context "license_relationship" do
       it "gets the relationship" do
-        subject.license_relationship.should == 'StrangerToFriend'
+        expect(subject.license_relationship).to eq('StrangerToFriend')
       end
     end
 
     context "rule_type" do
       it "gets the rule type" do
-        subject.rule_type.should == 'BeCourteous'
+        expect(subject.rule_type).to eq('BeCourteous')
       end
     end
 

data/spec/lib/ship_compliant/configuration_spec.rb

@@ -13,33 +13,33 @@ module ShipCompliant
     end
     
     it "stores user credentials" do
-      ShipCompliant.configuration.partner_key.should == 'abc-123'
-      ShipCompliant.configuration.username.should == 'bob@example.com'
-      ShipCompliant.configuration.password.should == 'secret'
+      expect(ShipCompliant.configuration.partner_key).to eq('abc-123')
+      expect(ShipCompliant.configuration.username).to eq('bob@example.com')
+      expect(ShipCompliant.configuration.password).to eq('secret')
     end
 
     it "creates authentication hash" do
-      ShipCompliant.configuration.credentials.should == {
+      expect(ShipCompliant.configuration.credentials).to eq({
         'PartnerKey' => 'abc-123',
         'Username' => 'bob@example.com',
         'Password' => 'secret'
-      }
+      })
     end
 
     it "defaults log to true" do
-      ShipCompliant.configuration.log.should == true
+      expect(ShipCompliant.configuration.log).to be_truthy
     end
 
     context "wsdl" do
       it "defaults to core services" do
-        ShipCompliant.configuration.wsdl.should == 'https://ws-dev.shipcompliant.com/services/1.2/coreservice.asmx?WSDL'
+        expect(ShipCompliant.configuration.wsdl).to eq('https://ws-dev.shipcompliant.com/services/1.2/coreservice.asmx?WSDL')
       end
 
       it "can be changed" do
         ShipCompliant.configure do |c|
           c.wsdl = 'http://example.com'
         end
-        ShipCompliant.configuration.wsdl.should == 'http://example.com'
+        expect(ShipCompliant.configuration.wsdl).to eq('http://example.com')
       end
     end
 

data/spec/lib/ship_compliant/error_result_spec.rb

@@ -16,31 +16,31 @@ module ShipCompliant
 
     context "code" do
       it "returns the code as an integer" do
-        subject.code.should == 404
+        expect(subject.code).to eq(404)
       end
     end
 
     context "key" do
       it "gets the key" do
-        subject.key.should == "OrderId"
+        expect(subject.key).to eq("OrderId")
       end
     end
 
     context "message" do
       it "gets the message" do
-        subject.message.should == "I'm smarter than the average bear, Boo Boo"
+        expect(subject.message).to eq("I'm smarter than the average bear, Boo Boo")
       end
     end
 
     context "target" do
       it "gets the target" do
-        subject.target.should == "SalesOrder"
+        expect(subject.target).to eq("SalesOrder")
       end
     end
 
     context "type" do
       it "gets the type" do
-        subject.type.should == "Validation"
+        expect(subject.type).to eq("Validation")
       end
     end
   end

data/spec/lib/ship_compliant/freight_sales_tax_rate_spec.rb

@@ -2,6 +2,6 @@ require "spec_helper"
 
 module ShipCompliant
   describe FreightSalesTaxRate do
-    it { should be_kind_of(SalesTaxRate) }
+    it { is_expected.to be_kind_of(SalesTaxRate) }
   end
 end

data/spec/lib/ship_compliant/get_inventory_details_result_spec.rb

@@ -7,9 +7,9 @@ module ShipCompliant
 
     context "locations" do
       it "returns an array of locations" do
-        subject.locations.should == [
+        expect(subject.locations).to eq([
           inventory_location[:inventory_location]
-        ]
+        ])
       end
 
       it "handles a single location" do
@@ -17,31 +17,31 @@ module ShipCompliant
           inventory_locations: inventory_location
         })
 
-        result.locations.should == [
+        expect(result.locations).to eq([
           inventory_location[:inventory_location]
-        ]
+        ])
       end
     end
 
     context "location" do
       it "finds a location" do
-        subject.location('WineShipping').should == inventory_location[:inventory_location]
+        expect(subject.location('WineShipping')).to eq(inventory_location[:inventory_location])
       end
 
       it "returns an empty hash when invalid" do
-        subject.location('toys-r-us').should == {}
+        expect(subject.location('toys-r-us')).to eq({})
       end
     end
 
     context "products_for_location" do
       it "returns an array of products" do
-        subject.products_for_location('WineShipping').should == [
+        expect(subject.products_for_location('WineShipping')).to eq([
           InventoryProduct.new(product_key: 'PRODUCT-KEY', inventory_levels: inventory_level)
-        ]
+        ])
       end
 
       it "returns empty array for invalid location" do
-        subject.products_for_location('toys-r-us').should == []
+        expect(subject.products_for_location('toys-r-us')).to eq([])
       end
     end
 

data/spec/lib/ship_compliant/get_inventory_details_spec.rb

@@ -29,7 +29,7 @@ module ShipCompliant
         fulfillment_location: 'FULFILLMENT-LOCATION'
       )
 
-      result.should be_kind_of(GetInventoryDetailsResult)
+      expect(result).to be_kind_of(GetInventoryDetailsResult)
     end
   end
 end

data/spec/lib/ship_compliant/get_sales_order_extended_result_spec.rb

@@ -6,54 +6,54 @@ module ShipCompliant
 
     context "shipment_compliance_rules" do
       it "returns compliance rules as an array" do
-        subject.shipment_compliance_rules.should == [
+        expect(subject.shipment_compliance_rules).to eq([
           {
             is_compliant: true,
             key: 'SHIPMENT-KEY',
           }
-        ]
+        ])
       end
     end
 
     context "compliance_rules_for_shipment" do
       it "finds compliance rules for shipment" do
-        subject.compliance_rules_for_shipment('SHIPMENT-KEY').should == ShipmentCompliance.new({
+        expect(subject.compliance_rules_for_shipment('SHIPMENT-KEY')).to eq(ShipmentCompliance.new({
           is_compliant: true,
           key: 'SHIPMENT-KEY'
-        })
+        }))
       end
     end
 
     context "bill_to" do
       it "returns an Address" do
-        subject.bill_to.should == Address.new({
+        expect(subject.bill_to).to eq(Address.new({
           city: 'Jellystone Park',
           state: 'WY'
-        })
+        }))
       end
     end
 
     context "shipments" do
       it "returns an array of shipments" do
-        subject.shipments.should == [{
+        expect(subject.shipments).to eq([{
           shipment_key: 'SHIPMENT-KEY',
           shipment_items: []
-        }]
+        }])
       end
     end
 
     context "find_shipment" do
       it "returns the shipment" do
-        subject.find_shipment('SHIPMENT-KEY').should == Shipment.new({
+        expect(subject.find_shipment('SHIPMENT-KEY')).to eq(Shipment.new({
           shipment_key: 'SHIPMENT-KEY',
           shipment_items: []
-        })
+        }))
       end
     end
 
     context "channel_details" do
       it "returns the details" do
-        subject.channel_details.should == ChannelDetails.new(some_details: 'online sales')
+        expect(subject.channel_details).to eq(ChannelDetails.new(some_details: 'online sales'))
       end
     end
 

data/spec/lib/ship_compliant/get_sales_order_extended_spec.rb

@@ -30,9 +30,9 @@ module ShipCompliant
       end
 
       it "returns GetSalesOrderExtendedResult" do
-        ShipCompliant.client.stub(:call) { {} }
+        allow(ShipCompliant.client).to receive(:call) { {} }
         result = GetSalesOrderExtended.by_order_key('order-id')
-        result.should be_kind_of(GetSalesOrderExtendedResult)
+        expect(result).to be_kind_of(GetSalesOrderExtendedResult)
       end
     end
   end

data/spec/lib/ship_compliant/inventory_product_spec.rb

@@ -5,77 +5,77 @@ module ShipCompliant
 
     context "default_case" do
       it "returns the default case" do
-        subject.default_case.should == 'DEFAULT-CASE'
+        expect(subject.default_case).to eq('DEFAULT-CASE')
       end
     end
 
     context "description" do
       it "returns the description" do
-        subject.description.should == 'PRODUCT-DESCRIPTION'
+        expect(subject.description).to eq('PRODUCT-DESCRIPTION')
       end
     end
 
     context "fulfillment_sku" do
       it "returns the fulfillment_sku" do
-        subject.fulfillment_sku.should == 'FULFILLMENT-SKU'
+        expect(subject.fulfillment_sku).to eq('FULFILLMENT-SKU')
       end
     end
 
     context "percent_alcohol" do
       it "returns the percent_alcohol" do
-        subject.percent_alcohol.should == 98.43
+        expect(subject.percent_alcohol).to eq(98.43)
       end
     end
 
     context "product_key" do
       it "returns the product_key" do
-        subject.product_key.should == 'PRODUCT-KEY'
+        expect(subject.product_key).to eq('PRODUCT-KEY')
       end
     end
 
     context "product_type" do
       it "returns the product_key" do
-        subject.product_type.should == 'PRODUCT-TYPE'
+        expect(subject.product_type).to eq('PRODUCT-TYPE')
       end
     end
 
     context "unit_price" do
       it "returns the unit_price" do
-        subject.unit_price.should == 873.21
+        expect(subject.unit_price).to eq(873.21)
       end
     end
 
     context "vintage" do
       it "returns the vintage" do
-        subject.vintage.should == 1922
+        expect(subject.vintage).to eq(1922)
       end
     end
 
     context "volume_amount" do
       it "returns the volume_amount" do
-        subject.volume_amount.should == 944.0
+        expect(subject.volume_amount).to eq(944.0)
       end
     end
 
     context "volume_ml" do
       it "returns the volume_ml" do
-        subject.volume_ml.should == 944.0
+        expect(subject.volume_ml).to eq(944.0)
       end
     end
 
     context "volume_unit" do
       it "returns the volume_unit" do
-        subject.volume_unit.should == 'Milliliter'
+        expect(subject.volume_unit).to eq('Milliliter')
       end
     end
 
     context "inventory_levels" do
       it "returns a hash of inventory levels" do
-        subject.inventory_levels.should == {
+        expect(subject.inventory_levels).to eq({
           available: 100,
           on_hand: 20,
           some_amazing_type: 1000
-        }
+        })
       end
     end
 

data/spec/lib/ship_compliant/order_search_spec.rb

@@ -6,14 +6,14 @@ module ShipCompliant
     context "to_h" do
       it "converts keys to pascal case" do
         order = OrderSearch.new(sales_order_key_min: 10)
-        order.to_h.should == {
+        expect(order.to_h).to eq({
           "SalesOrderKeyMin" => 10
-        }
+        })
       end
 
       it "ignores invalid keys" do
         order = OrderSearch.new(xyz: 5)
-        order.to_h.should == {}
+        expect(order.to_h).to eq({})
       end
     end
 

data/spec/lib/ship_compliant/package_spec.rb

@@ -5,13 +5,13 @@ module ShipCompliant
 
     context "tracking_number" do
       it "gets the tracking_number" do
-        subject.tracking_number.should == 'tracking-number'
+        expect(subject.tracking_number).to eq('tracking-number')
       end
     end
 
     context "tracking_status" do
       it "gets the tracking_status" do
-        subject.tracking_status.should == 'Lost in Transit'
+        expect(subject.tracking_status).to eq('Lost in Transit')
       end
     end
 

data/spec/lib/ship_compliant/product_attributes_spec.rb

@@ -6,9 +6,9 @@ module ShipCompliant
     context "to_h" do
       it "converts keys to pascal case" do
         product = ProductAttributes.new(unit_price: 10)
-        product.to_h.should == {
+        expect(product.to_h).to eq({
           "UnitPrice" => 10
-        }
+        })
       end
 
       it "handles special cases" do
@@ -21,14 +21,14 @@ module ShipCompliant
           upc: 'value'
         )
 
-        product.to_h.should == {
+        expect(product.to_h).to eq({
           'BottleSizeML' => 'value',
           'GTIN' => 'value',
           'NABCA' => 'value',
           'SCC' => 'value',
           'UNIMERC' => 'value',
           'UPC' => 'value'
-        }
+        })
       end
     end
 

data/spec/lib/ship_compliant/product_sales_tax_rate_spec.rb

@@ -3,18 +3,18 @@ require "spec_helper"
 module ShipCompliant
   describe ProductSalesTaxRate do
 
-    it { should be_kind_of(SalesTaxRate) }
+    it { is_expected.to be_kind_of(SalesTaxRate) }
     subject { ProductSalesTaxRate.new(brand_key: 'brand-key', product_key: 'the-product') }
 
     context "product_key" do
       it "returns the product key" do
-        subject.product_key.should == 'the-product'
+        expect(subject.product_key).to eq('the-product')
       end
     end
 
     context "brand_key" do
       it "returns the brand key" do
-        subject.brand_key.should == 'brand-key'
+        expect(subject.brand_key).to eq('brand-key')
       end
     end
 

data/spec/lib/ship_compliant/sales_tax_rate_spec.rb

@@ -6,14 +6,14 @@ module ShipCompliant
     context "sales_tax_due" do
       it "returns sales_tax_due" do
         tax_rate = SalesTaxRate.new(sales_tax_due: '34.43')
-        tax_rate.sales_tax_due.should == 34.43
+        expect(tax_rate.sales_tax_due).to eq(34.43)
       end
     end
 
     context "sales_tax_rate" do
       it "return sales_tax_rate" do
         tax_rate = SalesTaxRate.new(sales_tax_rate: '2.34')
-        tax_rate.sales_tax_rate.should == 2.34
+        expect(tax_rate.sales_tax_rate).to eq(2.34)
       end
     end
 

data/spec/lib/ship_compliant/search_sales_order_summary_spec.rb

@@ -26,20 +26,20 @@ module ShipCompliant
 
     context "purchase_date" do
       it "returns a DateTime from the purchase date" do
-        summary.purchase_date.should == DateTime.new(2014, 1, 1)
+        expect(summary.purchase_date).to eq(DateTime.new(2014, 1, 1))
       end
     end
 
     context "order_key" do
       it "returns the order_key" do
-        summary.order_key.should == 'ORD-1'
-        summary.sales_order_key.should == 'ORD-1'
+        expect(summary.order_key).to eq('ORD-1')
+        expect(summary.sales_order_key).to eq('ORD-1')
       end
     end
 
     context "shipment_summary" do
       it "the parsed hash" do
-        summary.shipment_summary.should == {
+        expect(summary.shipment_summary).to eq({
           compliance: 'Perfect Score',
           requested_ship_date: '2014-01-03T14:30:00',
           ship_date: '2014-01-03T12:23:00',
@@ -49,7 +49,7 @@ module ShipCompliant
             last_name: 'Smith',
             zip1: 80234
           }
-        }
+        })
       end
     end
   end