shinq 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b924bc9aa5b90d80b12a87648a79556806e05afb
-  data.tar.gz: f819bc9b7d685856fd493f962c13d0cdbd8ee841
+  metadata.gz: 9534f89c327ced4191505c4bd0e0034e2b8d2520
+  data.tar.gz: 5e44bcac5e977430c8fd147342ea062112248754
 SHA512:
-  metadata.gz: 02779081ac90c7e27bdf1838e16546beb3381e9756f885361239b0bf03c73d4371fd8bc12f59ba73848bead48ee5a4a3884aa70a608e67ed1174eee5124d08ea
-  data.tar.gz: 4b618dfc9164a2de53d1a6ef65de9566644d94ea9e36e8947c2735ca044e910c48a7301c32f66d69346dec285adb8e590fd96ad75642309943316da558bac5d5
+  metadata.gz: 41cc01e642978d5c345c4ea7b9956d41e5cbf6115e0ec70f54103baea484e088e873565d17010b230f6eb056c75434fbd2c03e70ce314398c1099e95ca78b9ef
+  data.tar.gz: 3cb2a4b1adf7216117e5e693e32bdeac0147a8a0c995abb5b58222d6f5bc9b2f748f4cd0de8e91f0feabe214ab7b1f8bd6873d0f215e278d118544c009d4b2cd

data/README.md

@@ -55,7 +55,7 @@ Generated migration file
 ```ruby
 class CreateWorkerNames < ActiveRecord::Migration
   def change
-    create_table :worker_names, {id: false, options: "ENGINE=QUEUE"} do |t|
+    create_table :worker_names, id: false, options: "ENGINE=QUEUE" do |t|
       t.string :job_id, null: false
       t.string :title
       t.datetime :enqueued_at, null: false
@@ -98,7 +98,7 @@ You can specify some options. see `bundle exec shinq --help`
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/shinq/fork )
+1. Fork it ( https://github.com/ryopeko/shinq/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/generators/shinq/worker/templates/create_table_migration.erb

@@ -1,6 +1,6 @@
 class <%= migration_class_name %> < ActiveRecord::Migration
   def change
-    create_table :<%= table_name %>, {id: false, options: "ENGINE=QUEUE"} do |t|
+    create_table :<%= table_name %>, id: false, options: "ENGINE=QUEUE" do |t|
       t.string :job_id, null: false
 <% attributes.each do |attribute| -%>
       t.<%= attribute.type %> :<%= attribute.name %><%= attribute.inject_options %>

data/lib/shinq/client.rb

@@ -17,7 +17,7 @@ module Shinq
         ))
         Shinq.connection.query(sql)
       else
-        raise ArgumentError, "Queue should be Hash"
+        raise ArgumentError, "`args` should be a Hash"
       end
     end
 
@@ -31,6 +31,7 @@ module Shinq
       unless has_queue[wait_query].to_i == 0
         sql = builder.select(table_name, ['*'])
         results = Shinq.connection.query(sql)
+        # select always returns 1 line in the owner (queue_wait) mode
         return results.first.symbolize_keys
       end
     end

data/lib/shinq/launcher.rb

@@ -17,7 +17,7 @@ module Shinq
           worker_class.new.perform(queue)
         rescue => e
           Shinq::Client.abort
-          raise
+          raise e
         end
 
         Shinq::Client.done

data/shinq.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "shinq"
-  spec.version       = '0.4.0'
+  spec.version       = '0.5.0'
   spec.authors       = ["Ryoichi SEKIGUCHI"]
   spec.email         = ["ryopeko@gmail.com"]
   spec.summary       = %q{Worker and enqueuer for Q4M using the interface of ActiveJob.}
@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "mysql2", "~> 0.3.16"
   spec.add_dependency "sql-maker", "~> 0.0.4"
-  spec.add_dependency "activesupport", "~> 4.2.0.beta2"
+  spec.add_dependency "activesupport", "~> 4.2"
   spec.add_dependency 'serverengine', '~> 1.5.9'
 end

data/spec/shinq_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 require 'shinq'
 require 'shinq/configuration'
+require 'logger'
 
 def shinq_class
   Shinq.dup
@@ -67,4 +68,22 @@ describe Shinq do
       it { expect(shinq.connection(db_name: :test)).to be_a_kind_of(Mysql2::Client) }
     end
   end
+
+  describe ".logger" do
+    context "when logger is present" do
+      let(:shinq) { shinq_class }
+      it { expect(shinq.logger).to be nil }
+    end
+
+    context "when logger is present" do
+      let(:logger) { Logger.new(STDOUT) }
+      let(:shinq) {
+        shinq_class.tap {|s|
+          s.logger = logger
+        }
+      }
+
+      it { expect(shinq.logger).to be logger }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shinq
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Ryoichi SEKIGUCHI
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-21 00:00:00.000000000 Z
+date: 2014-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0.beta2
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0.beta2
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: serverengine
   requirement: !ruby/object:Gem::Requirement