shimmer 0.0.27 → 0.0.29

data/config/rubocop_base.yml

@@ -1,15 +1,11 @@
+# Most of those cops are documented here:
+# https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style
+#
 AllCops:
   NewCops: disable
-  Exclude:
-    - '**/vendor/bundle/**/*'
-    - '**/bin/**/*'
-    - '**/db/schema.rb'
-    - '**/node_modules/**/*'
 
 require:
-  - standard
-  - rubocop-rails
-  - rubocop-rake
+  - standard # https://github.com/standardrb/standard
 
 inherit_gem:
   standard: config/base.yml
@@ -23,10 +19,32 @@ Style/MutableConstant:
   Enabled: true
   EnforcedStyle: strict
 
-# Allow `.update_all`.
-Rails/SkipsModelValidations:
-  Enabled: false
+# Pass &:method_name as an argument to index_by instead of a block.
+Style/SymbolProc:
+  Enabled: true
+
+# Prefer `[:foo, :bar]` to `%i[foo bar]`.
+Style/SymbolArray:
+  Enabled: true
+  EnforcedStyle: brackets
+
+# Prefer `["foo", "bar"]` to `%w[foo bar]`.
+Style/WordArray:
+  Enabled: true
+  EnforcedStyle: brackets
+
+# <% if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.1") %>
+Style/HashSyntax:
+  Enabled: true
+  EnforcedShorthandSyntax: always
+# <% end %>
 
-# Allow Rake tasks to not require the full Rails app to be loaded.
-Rails/RakeEnvironment:
-  Enabled: false
+# Keep at the end of the file (after the individual cops configuration),
+# otherwise, those cops are not configured properly.
+inherit_from:
+# <% Dir["#{File.expand_path(__dir__)}/rubocop_extensions/*.yml"].each do |filename| %>
+#   <% gem_name = filename.delete_suffix(".yml").delete_prefix("#{File.expand_path(__dir__)}/rubocop_extensions/") %>
+#   <% if Gem.loaded_specs.key?(gem_name) %>
+  - rubocop_extensions/<%= gem_name %>.yml
+#   <% end # if Gem.loaded_specs.key? %>
+# <% end # Dir.foreach %>

data/config/rubocop_extensions/graphql.yml

@@ -0,0 +1,68 @@
+# Documentation on the rules can be found here:
+# https://github.com/DmitryTsepelev/rubocop-graphql/tree/master/lib/rubocop/cop/graphql
+#
+require:
+  - rubocop-graphql
+
+GraphQL:
+  Enabled: false
+
+# Keep mutation file ordered.
+GraphQL/OrderedFields:
+  Enabled: true
+  Exclude:
+    - "*"
+  Include:
+    - '**/mutation_type.rb'
+
+# Ensures snake case of argument name.
+GraphQL/ArgumentName:
+  Enabled: true
+
+# Detects duplicate argument definitions.
+GraphQL/ArgumentUniqueness:
+  Enabled: true
+
+# Prevents defining unnecessary resolver methods in cases when `:hash_key` option can be used.
+GraphQL/FieldHashKey:
+  Enabled: true
+
+# Prevents defining unnecessary resolver methods in cases when `:method option` can be used.
+GraphQL/FieldMethod:
+  Enabled: true
+
+# Ensures snake case of field name.
+GraphQL/FieldName:
+  Enabled: true
+
+# Detects duplicate field definitions within the same type.
+GraphQL/FieldUniqueness:
+  Enabled: true
+
+# Ensures type definitions are class-based (no longer legacy).
+GraphQL/LegacyDsl:
+  Enabled: true
+
+# Ensures fields with multiple definitions are grouped together
+GraphQL/MultipleFieldDefinitions:
+  Enabled: true
+
+# Forces `Relay::Node` implementations to expose an `authorized?` method.
+GraphQL/NotAuthorizedNodeType:
+  Enabled: true
+
+# Checks for has an unnecessary argument camelize.
+GraphQL/UnnecessaryArgumentCamelize:
+  Enabled: true
+
+# Prevents defining an unnecessary `alias`, `method`, or `resolver_method` arguements to fields.
+GraphQL/UnnecessaryFieldAlias:
+  Enabled: true
+
+# Checks for has an unnecessary field camelize.
+GraphQL/UnnecessaryFieldCamelize:
+  Enabled: true
+
+# Arguments should either be listed explicitly or `**rest` should be in the resolve signature.
+GraphQL/UnusedArgument:
+  Enabled: true

data/config/rubocop_extensions/rails.yml

@@ -0,0 +1,34 @@
+AllCops:
+  Exclude:
+    - '**/vendor/bundle/**/*'
+    - '**/db/schema.rb'
+
+require:
+  - rubocop-rails
+
+Rails:
+  Enabled: false
+
+# Prefer :bad_request over 400 to define HTTP status code.
+Rails/HttpStatus:
+  Enabled: true
+
+# Prefer index_by over map { ... }.to_h.
+Rails/IndexBy:
+  Enabled: true
+
+# Prefer index_with over each_with_object.
+Rails/IndexWith:
+  Enabled: true
+
+# Specify a :dependent option. (https://rails.rubystyle.guide#has_many-has_one-dependent-option)
+Rails/HasManyOrHasOneDependent:
+  Enabled: true
+
+# Specify an :inverse_of option.
+Rails/InverseOf:
+  Enabled: true
+
+# Specifying the default value for foreign_key is redundant.
+Rails/RedundantForeignKey:
+  Enabled: true

data/config/rubocop_extensions/rspec.yml

@@ -0,0 +1,208 @@
+require:
+  - rubocop-rspec
+
+RSpec:
+  Enabled: false
+
+# Check that instances are not being stubbed globally.
+# Prefer instance doubles over stubbing any instance of a class.
+RSpec/AnyInstance:
+  Enabled: true
+
+# Checks that around blocks actually run the test.
+# Would be a shame if the test would be green simply because it is not called.
+RSpec/AroundBlock:
+  Enabled: true
+
+# Be what? Not nil? Present? Truthy?
+RSpec/Be:
+  Enabled: true
+
+# The be matcher compares by identity while the eq matcher compares using ==.
+# Booleans and nil can be compared by identity and therefore the be matcher is
+# preferable as it is a more strict test.
+RSpec/BeEq:
+  Enabled: true
+
+# The be matcher compares by identity while the eq matcher compares using ==.
+# Booleans and nil can be compared by identity and therefore the be matcher is
+# preferable as it is a more strict test.
+RSpec/BeEql:
+  Enabled: true
+
+# Prefer `.to be_nil` to `.to be(nil)`.
+RSpec/BeNil:
+  Enabled: true
+
+# Avoid `before(:all)`, prefer `before(:each)` within a group.
+RSpec/BeforeAfterAll:
+  Enabled: true
+
+# Avoid `.to change(...).by(0)`, prefer `not_to change` and `.to not_change` (for composite).
+RSpec/ChangeByZero:
+  Enabled: true
+
+# Expect expectations in all tests.
+# If it's just expecting it to not raise, wrap it in `expect do ... end.not_to raise`.
+RSpec/EmptyExampleGroup:
+  Enabled: true
+
+# Don't allow empty hooks.
+RSpec/EmptyHook:
+  Enabled: true
+
+# Separate groups.
+RSpec/EmptyLineAfterExampleGroup:
+  Enabled: true
+
+# Separate `let`s from tests.
+RSpec/EmptyLineAfterFinalLet:
+  Enabled: true
+
+# Separate hooks from tests.
+RSpec/EmptyLineAfterHook:
+  Enabled: true
+
+# Don't allow specs without description.
+RSpec/ExampleWithoutDescription:
+  Enabled: true
+
+# Checks for common mistakes in example descriptions.
+RSpec/ExampleWording:
+  Enabled: true
+
+# Trim descriptions.
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
+# Do stdout expectations right.
+RSpec/ExpectOutput:
+  Enabled: true
+
+# Enforces spec file naming convention.
+RSpec/FilePath:
+  Enabled: true
+
+# Don't forget focussed tests (expecially useful for the CI to fail).
+RSpec/Focus:
+  Enabled: true
+  AutoCorrect: false
+
+# Checks for before/around/after hooks that come after an example.
+RSpec/HooksBeforeExamples:
+  Enabled: true
+
+# Don't expect something to be itself.
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
+
+# Explicitly declare `it` blocks.
+RSpec/ImplicitBlockExpectation:
+  Enabled: true
+
+# Prevent instance variable usage in specs.
+RSpec/InstanceVariable:
+  Enabled: true
+
+# Check that all matcher is used instead of iterating over an array.
+RSpec/IteratedExpectation:
+  Enabled: true
+
+# Checks that no class, module, or constant is declared.
+# Constants, including classes and modules, when declared in a block scope,
+# are defined in global namespace, and leak between examples.
+# Prevents class re-opening, leading to unpredictable side effects.
+RSpec/LeakyConstantDeclaration:
+  Enabled: true
+
+# Force `let`s to be before tests.
+RSpec/LetBeforeExamples:
+  Enabled: true
+
+# Force groups to have descriptions or symbol.
+RSpec/MissingExampleGroupArgument:
+  Enabled: true
+
+# Files should have only one root `describe` block.
+RSpec/MultipleDescribes:
+  Enabled: true
+
+# Checks if an example group defines subject multiple times.
+RSpec/MultipleSubjects:
+  Enabled: true
+
+# Checks if an example contains any expectation.
+RSpec/NoExpectationExample:
+  Enabled: false # considered, but gives false positives when expectations are inside of a re-used function
+
+# Prefer `expect(...).not_to` to `expect(...).to_not`.
+RSpec/NotToNot:
+  Enabled: true
+
+# Prevent setting the same `let` block more than once.
+RSpec/OverwritingSetup:
+  Enabled: true
+
+# Prevent useless `around` hooks.
+RSpec/RedundantAround:
+  Enabled: true
+
+# Prevent duplicate description.
+RSpec/RepeatedDescription:
+  Enabled: true
+
+# Prevent duplicate example (test).
+RSpec/RepeatedExample:
+  Enabled: true
+
+# Detects duplicate in example group body.
+RSpec/RepeatedExampleGroupBody:
+  Enabled: true
+
+# Detects duplicate in example group description.
+RSpec/RepeatedExampleGroupDescription:
+  Enabled: true
+
+# Check for repeated include of shared examples.
+RSpec/RepeatedIncludeExample:
+  Enabled: true
+
+# Keep `let` blocks together.
+RSpec/ScatteredLet:
+  Enabled: true
+
+# Keep `setup` blocks (ex: group `before`) together.
+RSpec/ScatteredSetup:
+  Enabled: true
+
+# Checks for proper shared_context and shared_examples usage.
+RSpec/SharedContext:
+  Enabled: true
+
+# Enforces use of string to titleize shared examples.
+RSpec/SharedExamples:
+  Enabled: true
+
+# Checks that chains of messages contain more than one element.
+RSpec/SingleArgumentMessageChain:
+  Enabled: true
+
+# Skip either the whole example of not at all.
+RSpec/SkipBlockInsideExample:
+  Enabled: true
+
+# Be specific about what exception/error is expected.
+RSpec/UnspecifiedException:
+  Enabled: true
+
+# Use symbols for `let` and `subject` names.
+RSpec/VariableDefinition:
+  Enabled: true
+
+# Avoid empty expectation.
+RSpec/VoidExpect:
+  Enabled: true
+
+# Use proper `yield` stub syntax.
+RSpec/Yield:
+  Enabled: true

data/gemfiles/Gemfile-rails-7-0

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+# Specify your gem's dependencies in shimmer.gemspec
+gemspec path: ".."
+
+gem "rails", "~> 7.0.0"
+gem "propshaft"
+gem "sqlite3"
+gem "puma"
+gem "jsbundling-rails"
+gem "turbo-rails"
+gem "stimulus-rails"
+gem "cssbundling-rails"
+gem "jbuilder"
+gem "bootsnap", require: false
+gem "dotenv"
+gem "slim-rails"
+gem "awesome_print"
+gem "dotenv-rails"
+
+group :development, :test do
+  gem "debug", platforms: %i[mri mingw x64_mingw]
+  gem "rake"
+  gem "rspec-rails"
+  gem "rspec-retry"
+  gem "pry"
+  gem "pry-rails"
+  gem "pry-byebug"
+  gem "pry-doc"
+  gem "guard"
+  gem "guard-rspec"
+  gem "capybara"
+  gem "rack_session_access"
+  gem "cuprite"
+  gem "standard"
+  gem "rubocop"
+  gem "rubocop-rails"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+  gem "rubocop-rake"
+end
+
+group :development do
+  gem "web-console"
+  gem "annotate"
+end

data/lib/shimmer/auth/apple_provider.rb

@@ -10,7 +10,7 @@ module Shimmer
       def request_details(params)
         name = params[:user] ? JSON.parse(params[:user])["name"] : {}
         headers = {
-          'Content-Type': "application/x-www-form-urlencoded"
+          "Content-Type": "application/x-www-form-urlencoded"
         }
         form = {
           grant_type: "authorization_code",

data/lib/shimmer/form/builder.rb

@@ -72,7 +72,7 @@ module Shimmer
           classes << "input--error"
           errors = safe_join(object.errors[method].map { |e| content_tag :div, e, class: "input__error" })
         end
-        label = label == false ? nil : self.label(label_method || method, label, class: "input__label")
+        label = (label == false) ? nil : self.label(label_method || method, label, class: "input__label")
         description = description.presence ? content_tag(:div, description, class: "input__description") : nil
         content_tag(:div, safe_join([label, content, description, errors, extra].compact), class: ["input"] + classes, **options)
       end

data/lib/shimmer/utils/config.rb

@@ -3,16 +3,22 @@
 module Shimmer
   class Config
     include Singleton
+
     class MissingConfigError < StandardError; end
 
-    def method_missing(method_name)
+    def method_missing(method_name, **options)
+      default_provided = options.key?(:default)
+      default_value = options.delete(:default) if default_provided
+      raise ArgumentError, "unknown option#{"s" if options.length > 1}: #{options.keys.join(", ")}." if options.any?
+
       method_name = method_name.to_s
       type = :string
       key = method_name.delete_suffix("!").delete_suffix("?")
       required = method_name.end_with?("!")
       type = :bool if method_name.end_with?("?")
       value = ENV[key.upcase].presence
-      value ||= Rails.application.credentials.send(key)
+      value ||= Rails.application.credentials.public_send(key)
+      value = default_value if value.nil?
       raise MissingConfigError, "#{key.upcase} environment value is missing" if required && value.blank?
 
       coerce value, type
@@ -25,7 +31,7 @@ module Shimmer
     private
 
     def coerce(value, type)
-      return !value.in?(["n", "0", "no", "false"]) if type == :bool && value.is_a?(String)
+      return !value.downcase.in?(["n", "0", "no", "false"]) if type == :bool && value.is_a?(String)
 
       value
     end

data/lib/shimmer/utils/remote_navigation.rb

@@ -69,22 +69,34 @@ module Shimmer
       queued_updates.push turbo_stream.append "shimmer", "<div class='hidden' data-controller='remote-navigation'>#{script}</div>"
     end
 
-    def replace(id, with: id, **locals)
-      queued_updates.push turbo_stream.replace(id, partial: with, locals: locals)
+    def append(id, with:, **locals)
+      queued_updates.push turbo_stream.append(id, partial: with, locals: locals)
     end
 
     def prepend(id, with:, **locals)
       queued_updates.push turbo_stream.prepend(id, partial: with, locals: locals)
     end
 
-    def append(id, with:, **locals)
-      queued_updates.push turbo_stream.append(id, partial: with, locals: locals)
+    def replace(id, with: id, **locals)
+      queued_updates.push turbo_stream.replace(id, partial: with, locals: locals)
+    end
+
+    def update(id, with: id, **locals)
+      queued_updates.push turbo_stream.update(id, partial: with, locals: locals)
     end
 
     def remove(id)
       queued_updates.push turbo_stream.remove(id)
     end
 
+    def insert_before(id, with:, **locals)
+      queued_updates.push turbo_stream.before(id, partial: with, locals: locals)
+    end
+
+    def insert_after(id, with:, **locals)
+      queued_updates.push turbo_stream.after(id, partial: with, locals: locals)
+    end
+
     def open_modal(url, id: nil, size: nil, close: true)
       run_javascript "ui.modal.open(#{{url: url, id: id, size: size, close: close}.to_json})"
     end

data/lib/shimmer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Shimmer
-  VERSION = "0.0.27"
+  VERSION = "0.0.29"
 end

metadata

@@ -1,113 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: shimmer
 version: !ruby/object:Gem::Version
-  version: 0.0.27
+  version: 0.0.29
 platform: ruby
 authors:
 - Jens Ravens
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: standardrb
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2023-05-08 00:00:00.000000000 Z
+dependencies: []
 description: 
 email:
 - jens@nerdgeschoss.de
@@ -118,6 +20,7 @@ files:
 - ".editorconfig"
 - ".eslintrc.js"
 - ".prettierrc"
+- ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
 - ".solargraph.yml"
@@ -126,14 +29,24 @@ files:
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/_guard-core
 - bin/console
+- bin/dev
+- bin/guard
+- bin/rake
+- bin/rspec
 - bin/rubocop
 - bin/setup
 - bin/solargraph
 - config/rubocop_base.yml
+- config/rubocop_extensions/graphql.yml
+- config/rubocop_extensions/rails.yml
+- config/rubocop_extensions/rspec.yml
+- gemfiles/Gemfile-rails-7-0
 - lib/shimmer.rb
 - lib/shimmer/auth.rb
 - lib/shimmer/auth/apple_provider.rb
@@ -217,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Shimmer brings all the bells and whistles of a hotwired application, right