shiftable 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03d919c64ab0be03ba40c5474cfa7971dda6158ab01df20940bb644c32482b19
-  data.tar.gz: 3246e28e7578ea7b56ae905c23c675e121a8c71556d127b8ee4a0fbeedcce15b
+  metadata.gz: ae22d0c5730e6bde9ad658ee1b8deddb2ca83e8d09cccc560945faf51c796b6a
+  data.tar.gz: b8ef6d21e4273b247a4287a31059eb02bed5bafaf3941562ddfc78f798fd139a
 SHA512:
-  metadata.gz: b3721c0d437b1ab45deb99f71f7a199fe4c37aae31f86f8443eb2effd1bd07c9d930aa64c4a4b824c7371863c9cb219251e59dc673d9ef40a73551e75c7efc67
-  data.tar.gz: c0d40a890f89fda5137575d9052131605f33e6a861e6b9e55b6681d89cfeba4f9ac5547cb09c4ab68cb69bafa50a9c6ebc75412152cf8c3bf9e76f90ce80f823
+  metadata.gz: 19ab8c6178402cb18788424023d380672a8d4c7597b432703b79f73900950cf353d8fe85702a0fbd09387f3dd61c4276ba69fe0e9e99499bc77b52d8c9bc3b0b
+  data.tar.gz: 66d90707da9952a116619e7421127f2c6bad0f4b74558e24ea0da97d7e5670a17960dfabf92ece49ab9cf10bcc60deb9f556f25fc835df656ba9ad1f0f17aa82

data/CHANGELOG.md

@@ -12,6 +12,11 @@
 ### Removed
 
 
+## [0.6.1] - 2021-11-14
+### Added
+
+- Support for using save with bang (`save!`) to raise error when ActiveRecord save fails.
+
 ## [0.6.0] - 2021-11-12
 ### Added
 

data/lib/shiftable/collection.rb

@@ -73,8 +73,8 @@ module Shiftable
           define_method(:"#{prefix}shift_#{type}_column") do
             signature.send("shift_#{type}_column")
           end
-          define_method(:"#{prefix}shift_#{type}") do |shift_to:, shift_from:|
-            signature.shift_data!(shift_to: shift_to, shift_from: shift_from)
+          define_method(:"#{prefix}shift_#{type}") do |shift_to:, shift_from:, bang: false|
+            signature.shift_data!(shift_to: shift_to, shift_from: shift_from, bang: bang)
           end
         end
       end

data/lib/shiftable/mod_signature.rb

@@ -75,14 +75,15 @@ module Shiftable
         associations[:has_many]
       end
 
-      def shift_data!(shift_to:, shift_from:)
+      def shift_data!(shift_to:, shift_from:, bang: false)
         validate_relationships
         shifting_rel = ShiftingRelation.new(
           to: shift_to,
           from: shift_from,
           column: shift_column,
           base: base,
-          wrapper: wrapper
+          wrapper: wrapper,
+          bang: bang
         )
         shifting_rel.shift do
           before_shift&.call(shifting_rel)
@@ -96,7 +97,7 @@ module Shiftable
       #   associations[:has_many]
       # end
 
-      def shift_data!(shift_to:, shift_from:)
+      def shift_data!(shift_to:, shift_from:, bang: false)
         validate_relationships
         shifting_rel = ShiftingPolymorphicRelation.new(
           to: shift_to,
@@ -107,7 +108,8 @@ module Shiftable
             id_column: shift_pcx_column
           },
           base: base,
-          wrapper: wrapper
+          wrapper: wrapper,
+          bang: bang
         )
         shifting_rel.shift do
           before_shift&.call(shifting_rel)
@@ -125,14 +127,15 @@ module Shiftable
         options[:precheck]
       end
 
-      def shift_data!(shift_to:, shift_from:)
+      def shift_data!(shift_to:, shift_from:, bang: false)
         validate_relationships
         shifting = ShiftingRecord.new(
           to: shift_to,
           from: shift_from,
           column: shift_column,
           base: base,
-          wrapper: wrapper
+          wrapper: wrapper,
+          bang: bang
         ) do
           !precheck || !shift_to.send(has_rel)
         end

data/lib/shiftable/shifting.rb

@@ -3,9 +3,13 @@
 module Shiftable
   # Gets data to be shifted
   class Shifting
-    attr_reader :to, :from, :column, :base, :result, :run_save, :shift_all_wrapper, :shift_each_wrapper
+    # Public API
+    attr_accessor :result, :bang, :shift_all_wrapper, :shift_each_wrapper
+    attr_reader :to, :from
+    # Internal API
+    attr_reader :column, :base, :run_save
 
-    def initialize(to:, from:, column:, base:, wrapper:)
+    def initialize(to:, from:, column:, base:, wrapper:, bang:)
       @to = to
       @from = from
       @column = column
@@ -16,6 +20,7 @@ module Shiftable
       @run_save = true
       @shift_all_wrapper = wrapper[:all]
       @shift_each_wrapper = wrapper[:each]
+      @bang = bang
     end
 
     # def found?
@@ -47,11 +52,11 @@ module Shiftable
       if shift_each_wrapper
         each do |rec|
           shift_each_wrapper.call(rec) do
-            rec.save
+            bang ? rec.save! : rec.save
           end
         end
       else
-        each(&:save)
+        bang ? each(&:save!) : each(&:save)
       end
     end
 

data/lib/shiftable/shifting_record.rb

@@ -33,10 +33,10 @@ module Shiftable
     def do_save
       if shift_each_wrapper
         shift_each_wrapper.call(result) do
-          result.save
+          bang ? result.save! : result.save
         end
       else
-        result.save
+        bang ? result.save! : result.save
       end
     end
 

data/lib/shiftable/single.rb

@@ -73,8 +73,8 @@ module Shiftable
           define_method(:"#{prefix}shift_column") do
             signature.send("shift_#{signature.type}_column")
           end
-          define_method(:"#{prefix}shift_single") do |shift_to:, shift_from:|
-            signature.shift_data!(shift_to: shift_to, shift_from: shift_from)
+          define_method(:"#{prefix}shift_single") do |shift_to:, shift_from:, bang: false|
+            signature.shift_data!(shift_to: shift_to, shift_from: shift_from, bang: bang)
           end
         end
       end

data/lib/shiftable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Shiftable
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shiftable
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Peter Boling
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-12 00:00:00.000000000 Z
+date: 2021-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord