shields_up 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 391eded2ca4d95f1777b8a227f13905e7f01b975
-  data.tar.gz: 05c2a17280fb9c761b3743e688abcc3c9cbe97ce
+  metadata.gz: 437e1ba9fb4476f8dc720427401607320e7d4625
+  data.tar.gz: 09c5b2be9c7e5d2d84a6f3cd466be68639cb59bd
 SHA512:
-  metadata.gz: a13deb71b95918e3c1b7d297ec5f72a9d8b29a71d9a58c8f3259d09d9d8373aa2c6f7881b9f7c0c2c0b0df01adcd0f6f052383454ec527c2ac061faf045830a1
-  data.tar.gz: 4d99e218185e1db2828543e5c9ce39f469c593a9cc0a16c98516e1625ffe7d903acb7bf895c2b81ac830c85b49137aaf19d5562bf0bb785de84549da3a8732fd
+  metadata.gz: 11cc043d76fcf28e2cb50150b95a639ea8f138c5a5986f5720fbeaedc760e64bb2d73c737e06aa2fb25750f1d5ddc90035d08f4436a2f4154546490548f2d3cc
+  data.tar.gz: ee27061c271e103a51bd9c12287d19ed6108483eb16a93b2cffa6ae36bf5ffa6dfeb386c699a3a229716893e2f014e8d053ae890a4e6acb4608af5048d5046c8

data/Appraisals

@@ -0,0 +1,7 @@
+appraise "activesupport-3.2" do
+  gem 'activesupport', '~> 3.2.0'
+end
+
+appraise "activesupport-4.0" do
+  gem 'activesupport', '~> 4.0.0'
+end

data/Gemfile

@@ -2,6 +2,7 @@ source 'https://rubygems.org'
 
 gemspec
 
+gem 'appraisal'
 gem 'mocha'
 gem 'activemodel'
 gem 'rails'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shields_up (0.16.0)
+    shields_up (0.17.0)
       activesupport (~> 3.2)
 
 GEM

data/README.md

@@ -1,6 +1,7 @@
 [![Build Status](https://travis-ci.org/appfolio/shields_up.png)](https://travis-ci.org/appfolio/shields_up)
 [![Code Climate](https://codeclimate.com/github/appfolio/shields_up/badges/gpa.svg)](https://codeclimate.com/github/appfolio/shields_up)
 [![Test Coverage](https://codeclimate.com/github/appfolio/shields_up/badges/coverage.svg)](https://codeclimate.com/github/appfolio/shields_up)
+[![Gem Version](https://badge.fury.io/rb/shields_up.svg)](http://badge.fury.io/rb/shields_up)
 
 #Shields Up
 This gem provides an alternative implementation of strong_parameters.
@@ -11,6 +12,8 @@ This gem provides an alternative implementation of strong_parameters.
 ##Differences to strong parameter
 params.symbolize_keys (or similar functions) will disable strong_parameters
 protection silently. With ShieldsUp this can not happen.
+(For a more in depth explanation see this discussion on the rails core mailing
+list: https://groups.google.com/forum/#!topic/rubyonrails-core/TdQVJCw1HfI)
 
 ## Enable ShieldsUp<br>
 
@@ -23,28 +26,18 @@ in controllers<br>
   include ShieldsUp
 ```
 
-- ShieldsUp::Parameter type only allows three operations: [], permit and require.
+- ShieldsUp::Parameters type only allows three operations: [], permit and require.
 - You can use symbols or strings to access variables.<br>
 
 ##Example:<br>
 ```
-params[:company]
+params[:company] Or params["company"]
 ```
-not:
-```
-params["company"]
-```
-or
-```
-params.fetch(:company)
-params.fetch("company")
-```
-
 ##A more complicated example:<br>
 ```
 params.permit(:company => [:address, :enabled])
 ```
-not:
+Or:
 ```
 params.permit("company" => [:address, "enabled"])
 ```

data/Rakefile

@@ -10,6 +10,7 @@ rescue Bundler::BundlerError => e
 end
 
 require 'rake'
+require 'appraisal'
 require 'rake/testtask'
 
 namespace :test do

data/gemfiles/activesupport_3.2.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "mocha"
+gem "activemodel"
+gem "rails"
+gem "minitest", "~> 4.0"
+gem "codeclimate-test-reporter", :require => nil
+gem "activesupport", "~> 3.2.0"
+
+gemspec :path => "../"

data/gemfiles/activesupport_4.0.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "mocha"
+gem "activemodel"
+gem "rails"
+gem "minitest", "~> 4.0"
+gem "codeclimate-test-reporter", :require => nil
+gem "activesupport", "~> 4.0.0"
+
+gemspec :path => "../"

data/lib/shields_up/parameters.rb

@@ -1,10 +1,12 @@
 require 'active_support/core_ext/hash/indifferent_access'
 module ShieldsUp
   class Parameters
-    if defined?(ActionController) && defined?(ActionController::Parameters)
-      PARAM_TYPE = ActionController::Parameters
-    else
-      PARAM_TYPE = ActiveSupport::HashWithIndifferentAccess
+    def self.param_type
+      @param_type ||= if defined?(ActionController) && defined?(ActionController::Parameters)
+        ActionController::Parameters
+      else
+        ActiveSupport::HashWithIndifferentAccess
+      end
     end
 
     PERMITTED_SCALAR_TYPES = [
@@ -143,7 +145,7 @@ module ShieldsUp
     end
 
     def deep_dup_to_hash(params)
-      return dup_if_possible(params) unless params.is_a?(PARAM_TYPE)
+      return dup_if_possible(params) unless params.is_a?(self.class.param_type)
       {}.tap do |dup|
         params.each do |key, value|
           dup[key] = deep_dup_to_hash(value)

data/lib/shields_up/version.rb

@@ -1,3 +1,3 @@
 module ShieldsUp
-  VERSION = '0.17.0'.freeze
+  VERSION = '0.18.0'.freeze
 end

data/shields_up.gemspec

@@ -17,5 +17,5 @@ Gem::Specification.new do |s|
   s.files         = Dir['**/*'].reject{ |f| f[%r{^pkg/}] || f[%r{^test/}] }
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
   s.require_paths = ['lib']
-  s.add_dependency('activesupport', '~> 3.2')
+  s.add_dependency('activesupport', ['>= 3.2', '< 4.1'])
 end

metadata

@@ -1,40 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: shields_up
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - AppFolio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2014-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4.1'
 description: Mass assignment Protection made by AppFolio Inc., inspired by strong_parameters.
 email: dev@appfolio.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- Appraisals
 - Gemfile
 - Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
+- gemfiles/activesupport_3.2.gemfile
+- gemfiles/activesupport_4.0.gemfile
 - lib/shields_up.rb
 - lib/shields_up/exceptions.rb
 - lib/shields_up/parameters.rb
@@ -61,8 +70,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Mass assignment Protection made by AppFolio Inc., inspired by strong_parameters.
 test_files: []
+has_rdoc: