shellopts 2.4.1 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53f85a46df1cf2280e591fbf996781c73e3ddb3dfe88ede023f6ef29f26995a4
-  data.tar.gz: 0ffb37c5f3843e92676004994600687dec0db89afccd20dea984998692e160a8
+  metadata.gz: 93dc09edd7bd318c85134a93f7c45352f4b2e550663c1a80a029d4fcb1d8ab16
+  data.tar.gz: c9e0b523c15f372d5dd988d2fd804c01539e90f0ee02ef68d284b4a1340e7c9c
 SHA512:
-  metadata.gz: e67de152c69ae86557ec6898e7b0402d4188b8ca57a53128cfd7b3521655e80aadbc6114bcf943101f1a4012216604703dba54ae2a6921019d228b0b343b1837
-  data.tar.gz: bfe12de981b2504514cd42c81f64511d01fe7948d1d8a563b2f34473d30fa8cd7e5cc22f550e9e81bd3a31ff3da863adbc60dd33ffd9fed53ea69d0bc8907a62
+  metadata.gz: 520132f149801fb6d2bb8e325e38cdb6bf81a01c9d881f88165b02550dfae4a0f95706bcbd558e34b2232015b327c87f779cbf2cdef6d0355640db6e87acaaea
+  data.tar.gz: 7a26fe6f1a8501f9a52103224ea4cdfa2d95441e6253af6ecfcb71f09f8f57c84bae7734079fa5ab1c47756f859ac0eaddbac3c350ce1d8a6b845be011ecedc3

data/README.md

@@ -193,7 +193,6 @@ indicate that the option can be repeated
   --gamma=ARG?  @ --gamma, takes an optional argument
 ```
 
-
 An option argument has a name and a type. The type can be specified as '#'
 (integer), '$' (float), or as a comma-separated list of allowed values. It can
 also be defined by a keyword that expects a file or directory argument:
@@ -202,15 +201,17 @@ also be defined by a keyword that expects a file or directory argument:
   | --------- | ---- |
   | FILE      | A file if present or in an existing directory if not |
   | DIR       | A directory if present or in an existing directory if not |
-  | PATH      | Either a FILE or DIR |
+  | PATH      | FILE or DIR |
   | EFILE     | An existing file |
   | EDIR      | An existing directory |
-  | EPATH     | Either an EFILE or EDIR |
+  | EPATH     | EFILE or EDIR |
   | NFILE     | A new file |
   | NDIR      | A new directory |
-  | NPATH     | A new file or  directory |
+  | NPATH     | NFILE or NDIR |
+
 
-By default the option name is inferred from the type but it can be specified explicitly by separating it from the type with a ':'. Examples:
+By default the option name is inferred from the type but it can be specified
+explicitly by separating it from the type with a ':'. Examples:
 
 ```
   -a=#                  @ -a takes an integer argument
@@ -244,7 +245,7 @@ In single-line format, subcommands are specified by prefixing the supercommand's
 
 ## Example
 
-The rm(1) command could be specified like this:
+The standard rm(1) command could be specified like this:
 
 ```ruby
 

data/TODO

@@ -1,4 +1,14 @@
 
+o Remove IFILE and OFILE. Alternatively document them
+o Document special-case file argument '-'
+o Accept both strings and symbols for commands (maybe... ruins the global namespace in #[])
+o ShellOpts#command -> Full path. Eg. ':command.subcommand!'
+  ShellOpts#commands -> Array of commands. Eg. [:command!, :subcommand!]
+o Exclude -h, -v, and -q from short description and only include them in the
+  detailed option description
+o Output handling: mesg, verb, ... should record eols. error and failure should
+  use that to end the current line with a newline if necessary
+o Strings from ShellOpts are frozen. Is that what we want?
 o Assigner methods for options
 o Make opts[] point at the main object
     opts[].subcommand is the direct subcommand of main

data/lib/shellopts/argument_type.rb

@@ -26,7 +26,7 @@ module ShellOpts
       def to_s() name end
 
     protected
-      # it is important that #set_message return false
+      # Note that it is important that #set_message return false
       def set_message(msg)
         @message = msg
         false
@@ -63,7 +63,8 @@ module ShellOpts
       def subject # Used in error messages
         @subject ||= 
             case kind
-              when :file, :efile, :nfile, :ifile, :ofile; "file"
+              when :file, :efile; "regular file"
+              when :nfile, :ifile, :ofile; "file"
               when :dir, :edir, :ndir; "directory"
               when :path, :epath, :npath; "path"
             else
@@ -81,19 +82,18 @@ module ShellOpts
         if literal == '-' && [:ifile, :ofile].include?(kind)
           true
 
-        # Special-case standard I/O files
+        # Special-case standard I/O files. These files have read-write (rw)
+        # filesystem permissions so they need to be handled individually
         elsif %w(/dev/stdin /dev/stdout /dev/stderr /dev/null).include?(literal)
           case kind
             when :file, :path, :efile, :epath, :nfile, :npath
               true
             when :ifile
-              %w(/dev/stdin /dev/null).include? literal or 
-                  set_message "Can't read #{literal}"
+              %w(/dev/stdin /dev/null).include? literal or set_message "Can't read #{literal}"
             when :ofile
-              %w(/dev/stdout /dev/stderr /dev/null).include?(literal) or 
-                  set_message "Can't write to #{literal}"
+              %w(/dev/stdout /dev/stderr /dev/null).include?(literal) or set_message "Can't write to #{literal}"
             when :dir, :edir, :ndir
-              set_message "Expected file, got directory #{literal}"
+              set_message "#{literal} is not a directory"
           else
             raise ArgumentError, "Unhandled kind: #{kind.inspect}"
           end
@@ -139,44 +139,47 @@ module ShellOpts
 
     protected
       def match_path(name, literal, kind, method, mode)
-        # file exists and is the rigth type?
+        # file exists and the method returned true
         if File.send(method, literal)
           if mode == :new
-            set_message "#{subject.capitalize} already exists in #{name}: #{literal}"
+            set_message "Won't overwrite #{literal}"
           elsif kind == :path || kind == :epath
             if File.file?(literal) || File.directory?(literal)
               true
             else
-              set_message "Expected file or directory as #{name} argument: #{literal}"
+              set_message "#{literal} is not a file or a directory"
             end
           elsif (kind == :ifile || kind == :ofile) && File.directory?(literal)
-            set_message "File expected, got directory: #{literal}"
+            set_message "#{literal} is not a device file"
           else
             true
           end
 
-        # file exists but not the right type?
+        # file exists but the method returned false
         elsif File.exist?(literal)
           if kind == :ifile
             set_message "Can't read #{literal}"
           elsif kind == :ofile
             set_message "Can't write to #{literal}"
           elsif mode == :new
-            set_message "#{subject.capitalize} already exists - #{literal}"
+            set_message "Won't overwrite #{literal}"
           else
-            set_message "Expected #{subject} as #{name} argument: #{literal}"
+            set_message "#{literal} is not a #{subject}"
           end
 
         # file does not exist
         else 
           if [:default, :new].include? mode
-            if File.exist?(File.dirname(literal)) || kind == :ofile
-              true
+            dir = File.dirname(literal)
+            if !File.directory?(dir)
+              set_message "Illegal path - #{literal}"
+            elsif !File.writable?(dir)
+              set_message "Can't create #{subject} #{literal}"
             else
-              set_message "Illegal path in #{name}: #{literal}"
+              true
             end
           else
-            set_message "Can't find #{subject} #{literal}"
+            set_message "Can't find #{literal}"
           end
         end
       end
@@ -185,7 +188,7 @@ module ShellOpts
     class EnumArgument < ArgumentType
       attr_reader :values
       def initialize(values) @values = values.dup end
-      def match?(name, literal) value?(literal) or set_message "Illegal value in #{name}: '#{literal}'" end
+      def match?(name, literal) value?(literal) or set_message "Illegal value - #{literal}" end
       def value?(value) @values.include?(value) end
     end
   end

data/lib/shellopts/version.rb

@@ -1,3 +1,3 @@
 module ShellOpts
-  VERSION = "2.4.1"
+  VERSION = "2.4.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shellopts
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.4.2
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-02-10 00:00:00.000000000 Z
+date: 2024-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: forward_to