sheets 1.0.0 → 1.1.0

data/.gitignore

@@ -1,6 +1,9 @@
 .DS_Store
 *.gem
 .bundle
+.vagrant
 Gemfile.lock
 pkg/*
-doc/*
+doc/*
+log/*
+*.rbc

data/.travis.yml

@@ -0,0 +1,6 @@
+rvm:
+ - 1.8.7
+ - 1.9.2
+ - 1.9.3
+ - ree
+ - rbx

data/README.md

@@ -14,7 +14,7 @@ Your application only needs to care about the layout of the spreadsheet, and the
 Usage
 ----------
 
-Install via Rubygems: (This will also install Roo its dependencies, including Spreadsheet).
+Install via Rubygems:
 
     gem install sheets
 
@@ -80,6 +80,13 @@ Renderers subclass Sheets::Renderers::Base, live in the Sheets::Renderers namesp
 
 Renderers are given access to the results of Sheets::Base#to_array as @data. See lib/sheets/renderers/* for examples.
 
+Test Suite Results
+-----
+
+Sheets uses Travis-CI for Continuous Integration.
+
+[![Build Status](http://travis-ci.org/bspaulding/Sheets.png)](http://travis-ci.org/bspaulding/Sheets)
+
 License
 ----------
 
@@ -90,7 +97,8 @@ Please note that Sheets is dependent upon the Spreadsheet gem, which is licensed
 Credits
 ----------
 
-Sheets takes full advantage of the great work done in these gems:
+Sheets takes advantage of the work done in these gems:
 
-* [Spreadsheet](http://spreadsheet.rubyforge.org/) - mhatakeyama@ywesee.com, zdavatz@ywesee.com
-* [Roo](http://roo.rubyforge.org/) - [Thomas Preymesser](mailto:thopre@gmail.com)
+* [spreadsheet](http://rubygems.org/gems/spreadsheet)
+* [rubyzip](http://rubygems.org/gems/rubyzip)
+* [nokogiri](http://rubygems.org/gems/nokogiri)

data/Rakefile

@@ -1,7 +1,55 @@
+# require 'rubygems'
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
-task :test do
-  require File.join(File.expand_path(File.dirname(__FILE__)), 'test', 'test_helper.rb')
-  Dir[ File.join(File.expand_path(File.dirname(__FILE__)), 'test', '**', '*_test.rb') ].each {|file| require file }
+testing_rubies = %w[1.8.7 1.9.2 ree ree-1.8.7-2010.01 jruby rbx]
+
+task :default => :test
+
+namespace :test do
+  task :current do
+    require File.join(File.expand_path(File.dirname(__FILE__)), 'test', 'test_helper.rb')
+    Dir[ File.join(File.expand_path(File.dirname(__FILE__)), 'test', '**', '*_test.rb') ].each {|file| require file }
+  end
+
+  task :all do
+    File.delete('test/results.json') if File.exists?('test/results.json')
+    system "rvm --json #{testing_rubies.join(',')} rake test > test/results.json"
+  end
+end
+
+task :test => ['test:current']
+
+namespace :install do
+  def ruby_installed?(ruby)
+    !%x[rvm use #{ruby}].include?('not installed')
+  end
+
+  task :rubies do
+    testing_rubies.each do |ruby|
+      puts ruby
+      puts "----------"
+
+      ruby_installed?(ruby) ? puts('- Installed.') : system("rvm install #{ruby}")
+    end
+  end
+
+  task :bundles => :rubies do
+    testing_rubies.each do |ruby|
+      puts ruby
+      puts "----------"
+
+      puts '- Installing bundler...'
+      system "rvm #{ruby} gem install --no-rdoc --no-ri bundler"
+      
+      puts '- Installing bundle...'
+      system "rvm #{ruby} exec bundle install"
+    end
+  end
+end
+
+namespace :clean do
+  task :rbx do
+    Dir[ File.join(File.expand_path(File.dirname(__FILE__)), '**', '*.rbc') ].each {|file| File.delete(file) }
+  end
 end

data/lib/sheets/parsers/excel_parser.rb

@@ -0,0 +1,16 @@
+require 'spreadsheet'
+
+class Sheets::Parsers::ExcelParser < Sheets::Parsers::Base
+  parses :xls
+
+  def to_array
+    workbook = Spreadsheet.open(@file_path)
+    worksheet = workbook.worksheet(0)
+    # worksheet.collect {|row| row.collect {|cell| cell } }
+    worksheet.collect do |row|
+      cells = []
+      row.count.times {|cell_index| cells << row[cell_index].to_s }
+      cells
+    end
+  end
+end

data/lib/sheets/parsers/nokogiri_ods_parser.rb

@@ -0,0 +1,47 @@
+require 'nokogiri'
+require 'zip/zip'
+
+class Sheets::Parsers::NokogiriOdsParser < Sheets::Parsers::Base
+  parses :ods
+
+  def to_array
+    rows.collect do |row| 
+      table_cells = []
+      row.xpath('table:table-cell').each do |cell|
+        repeat = cell.attributes["number-columns-repeated"].text.to_i if cell.attributes["number-columns-repeated"]
+        repeat ||= 1
+        repeat.times { table_cells << cell }
+      end
+
+      table_cells.collect {|cell| value_for_cell(cell) }
+    end
+  end
+
+  private
+
+  # returns the zipfile object for the document
+  def zipfile
+    @zipfile ||= Zip::ZipFile.open( @file_path )
+  end
+
+  def content_doc
+    @content_doc ||= Nokogiri::XML( zipfile.read('content.xml') )
+  end
+
+  def rows
+    @rows ||= content_doc.xpath('//table:table/table:table-row')
+  end
+
+  def value_for_cell(cell_element)
+    value_type = cell_element.attributes["value-type"]
+    send("#{value_type}_value_for_cell", cell_element)
+  end
+
+  def string_value_for_cell(cell_element)
+    cell_element.xpath('text:p').text
+  end
+
+  def float_value_for_cell(cell_element)
+    cell_element.xpath('text:p').text.to_f.to_s
+  end
+end

data/lib/sheets/parsers/nokogiri_xlsx_parser.rb

@@ -0,0 +1,79 @@
+require 'nokogiri'
+require 'zip/zip'
+
+class Sheets::Parsers::NokogiriXlsxParser < Sheets::Parsers::Base
+  parses :xlsx
+
+  def to_array
+    # Create Matrices
+    matrices = worksheets.collect do |worksheet|
+      worksheet.css('sheetData>row').collect do |row|
+        row.css('c').collect do |cell|
+          cell_value = cell.css('v').text
+
+          if cell.attribute('t')
+            celltype = cell.attribute('t').value
+            if celltype == 's'
+              # Load Shared String Value
+              cell_value = shared_strings[cell_value.to_i]
+            elsif celltype == 'b'
+              cell_value = (cell_value == "1") ? "TRUE" : "FALSE"
+            end
+          end
+          
+          if cell.attribute('s') && cell.attribute('s').value == "1"
+            cell_value = (base_date + cell_value.to_f).strftime('%Y-%m-%d') # Date conversion
+          end
+
+          if cell_value.match(/\A[0-9]+\.?[0-9]*\Z/)
+            cell_value = cell_value.to_f.to_s
+          end
+
+          cell_value
+        end
+      end
+    end
+
+    matrices.first
+  end
+
+  private
+
+  # returns the zipfile object for the document
+  def zipfile
+    @zipfile ||= Zip::ZipFile.open( @file_path )
+  end
+
+  # returns a nokogiri document for the workbook
+  def workbook
+    @workbook ||= Nokogiri::XML( zipfile.read("xl/workbook.xml") )
+  end
+
+  # returns an array of strings for the sharedStrings.
+  def shared_strings
+    @shared_strings ||= Nokogiri::XML( zipfile.read("xl/sharedStrings.xml") ).css('si>t').collect(&:text)
+  end
+
+  # returns an array of strings containing the worksheet ids from the workbook
+  def worksheet_ids
+    @sheet_ids ||= workbook.css('sheets>sheet').collect {|sheet| sheet.attribute('sheetId').value }
+  end
+
+  # returns an array of nokogiri documents for each worksheet
+  def worksheets
+    @worksheets ||= worksheet_ids.collect {|sheet_id| Nokogiri::XML( zipfile.read("xl/worksheets/sheet#{sheet_id}.xml") ) }
+  end
+
+  # returns a date object representing the start of the serial date system for this sheet
+  # Either 1900-01-01 or 1904-01-01
+  def base_date
+    @base_date ||= lambda do
+      date_base_element = workbook.search('workbookPr').attribute('date1904')
+      if date_base_element && date_base_element.value.to_i == 1
+        Date.parse('1904-01-01')
+      else
+        Date.parse('1900-01-01')
+      end
+    end.call
+  end
+end

data/lib/sheets/version.rb

@@ -1,3 +1,3 @@
 module Sheets
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/sheets.gemspec

@@ -15,12 +15,10 @@ Gem::Specification.new do |s|
   s.rubyforge_project = "sheets"
 
   s.add_dependency('spreadsheet', '>= 0.6.5.2')
-  s.add_dependency('roo', '= 1.9.3')
-  # These are the dependencies roo forgot:
-  s.add_dependency('builder', '>= 3.0.0')
   s.add_dependency('rubyzip', '>= 0.9.4')
   s.add_dependency('nokogiri', '>= 1.4.3.1')
-  s.add_dependency('google-spreadsheet-ruby', '>= 0.1.1')
+
+  s.add_development_dependency('rake', '0.9.2')
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/test/data/simple.csv

@@ -1,11 +1,11 @@
 Date,Impressions,Clicks,Actions
-2011-01-01,10,10,10
-2011-01-02,10,10,10
-2011-01-03,10,10,10
-2011-01-04,10,10,10
-2011-01-05,10,10,10
-2011-01-06,10,10,10
-2011-01-07,10,10,10
-2011-01-08,10,10,10
-2011-01-09,10,10,10
-2011-01-10,10,10,10
+2011-01-01,10.0,10.0,10.0
+2011-01-02,10.0,10.0,10.0
+2011-01-03,10.0,10.0,10.0
+2011-01-04,10.0,10.0,10.0
+2011-01-05,10.0,10.0,10.0
+2011-01-06,10.0,10.0,10.0
+2011-01-07,10.0,10.0,10.0
+2011-01-08,10.0,10.0,10.0
+2011-01-09,10.0,10.0,10.0
+2011-01-10,10.0,10.0,10.0

data/test/parsers/basic_parsers_test.rb

@@ -1,4 +1,4 @@
-parser_classes = (Sheets::Parsers.constants - ["Base"]).map {|constant_name| Sheets::Parsers.const_get(constant_name) }
+parser_classes = (Sheets::Parsers.constants.map(&:to_s) - ["Base"]).map {|constant_name| Sheets::Parsers.const_get(constant_name) }
 
 test_classes_for_collection parser_classes do |parser_class|
   define_method :test_provides_formats do
@@ -10,9 +10,34 @@ test_classes_for_collection parser_classes do |parser_class|
   end
 
   parser_class.formats.each do |format|
-    define_method "test_#{format}_to_array" do
+    define_method "test_#{format}_responds_to_to_array" do
       parser = parser_class.new([], format, nil)
       assert parser.respond_to?("to_array"), "#{parser.inspect} doesn't respond to to_array"
     end
+
+    define_method "test_#{format}_to_array_matches_sample_data" do
+      example_data = [
+        [ "Date",       "Impressions", "Clicks", "Actions" ],
+        [ "2011-01-01", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-02", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-03", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-04", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-05", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-06", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-07", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-08", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-09", "10.0",        "10.0",   "10.0"    ],
+        [ "2011-01-10", "10.0",        "10.0",   "10.0"    ]
+      ]
+
+      file_path = File.expand_path( File.join('test', 'data', "simple.#{format}") )
+      parser = parser_class.new( File.read(file_path), format, file_path )
+      result = parser.to_array
+
+      # Normalize to parsed dates to avoid Date type conflict 'failures'
+      result[1..-1].collect {|row| row[0] = Date.parse(row[0]).strftime('%Y-%m-%d') }
+
+      assert_equal example_data, result, "#{parser_class}#to_array for format #{format} doesn't match example data."
+    end
   end
 end

data/test/renderers/basic_renderers_test.rb

@@ -1,4 +1,4 @@
-renderer_classes = (Sheets::Renderers.constants - ["Base"]).map {|constant_name| Sheets::Renderers.const_get(constant_name) }
+renderer_classes = (Sheets::Renderers.constants.map(&:to_s) - ["Base"]).map {|constant_name| Sheets::Renderers.const_get(constant_name) }
 
 test_classes_for_collection renderer_classes do |renderer_class|
   define_method :test_provides_formats do

data/test/results.json

@@ -0,0 +1,13 @@
+{
+"totals": { "rubies": 6, "successes": 6, "errors": 0 },
+"successful": ["ruby-1.8.7-p334", "ruby-1.9.2-p180", "ree-1.8.7-2011.03", "ree-1.8.7-2010.01", "jruby-1.6.1", "rbx-head"],
+"errors": [],
+"rubies": { 
+    {"ruby-1.8.7-p334": 0},  
+    {"ruby-1.9.2-p180": 0},  
+    {"ree-1.8.7-2011.03": 0},  
+    {"ree-1.8.7-2010.01": 0},  
+    {"jruby-1.6.1": 0},  
+    {"rbx-head": 0}
+  }
+}

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: sheets
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: 
+  prerelease: false
   segments: 
   - 1
+  - 1
   - 0
-  - 0
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Bradley J. Spaulding
@@ -15,107 +14,67 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-11 00:00:00 -04:00
+date: 2011-11-29 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: spreadsheet
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 111
         segments: 
         - 0
         - 6
         - 5
         - 2
         version: 0.6.5.2
-  type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: roo
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        hash: 53
-        segments: 
-        - 1
-        - 9
-        - 3
-        version: 1.9.3
-  type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: builder
+  requirement: *id001
+  name: spreadsheet
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
-        version: 3.0.0
   type: :runtime
-  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rubyzip
-  prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 51
         segments: 
         - 0
         - 9
         - 4
         version: 0.9.4
+  requirement: *id002
+  name: rubyzip
+  prerelease: false
   type: :runtime
-  version_requirements: *id004
 - !ruby/object:Gem::Dependency 
-  name: nokogiri
-  prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 113
         segments: 
         - 1
         - 4
         - 3
         - 1
         version: 1.4.3.1
+  requirement: *id003
+  name: nokogiri
+  prerelease: false
   type: :runtime
-  version_requirements: *id005
 - !ruby/object:Gem::Dependency 
-  name: google-spreadsheet-ruby
-  prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 25
         segments: 
         - 0
-        - 1
-        - 1
-        version: 0.1.1
-  type: :runtime
-  version_requirements: *id006
+        - 9
+        - 2
+        version: 0.9.2
+  requirement: *id004
+  name: rake
+  prerelease: false
+  type: :development
 description: Work with spreadsheets easily in a native ruby format.
 email: 
 - brad.spaulding@gmail.com
@@ -127,6 +86,7 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -136,10 +96,9 @@ files:
 - lib/sheets/parseable.rb
 - lib/sheets/parsers/base.rb
 - lib/sheets/parsers/csv_parser.rb
-- lib/sheets/parsers/roo_parser.rb
-- lib/sheets/parsers/roo_patches.rb
-- lib/sheets/parsers/roo_patches/roo_patch_28885.rb
-- lib/sheets/parsers/roo_patches/roo_patch_29045.rb
+- lib/sheets/parsers/excel_parser.rb
+- lib/sheets/parsers/nokogiri_ods_parser.rb
+- lib/sheets/parsers/nokogiri_xlsx_parser.rb
 - lib/sheets/renderable.rb
 - lib/sheets/renderers/base.rb
 - lib/sheets/renderers/csv_renderer.rb
@@ -156,11 +115,11 @@ files:
 - test/parseable_test.rb
 - test/parsers/basic_parsers_test.rb
 - test/parsers/csv_parser_test.rb
-- test/parsers/roo_parser_test.rb
 - test/renderable_test.rb
 - test/renderers/basic_renderers_test.rb
 - test/renderers/csv_renderer_test.rb
 - test/renderers/excel_renderer_test.rb
+- test/results.json
 - test/test_helper.rb
 has_rdoc: true
 homepage: https://github.com/bspaulding/Sheets
@@ -172,27 +131,23 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: sheets
-rubygems_version: 1.5.0
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Sheets provides a Facade for importing spreadsheets that gives the application control. Any Spreadsheet can be represented as either (1) a two dimensional array, or (2) an array of hashes. Sheets' goal is to convert any spreadsheet format to one of these native Ruby data structures.
@@ -207,9 +162,9 @@ test_files:
 - test/parseable_test.rb
 - test/parsers/basic_parsers_test.rb
 - test/parsers/csv_parser_test.rb
-- test/parsers/roo_parser_test.rb
 - test/renderable_test.rb
 - test/renderers/basic_renderers_test.rb
 - test/renderers/csv_renderer_test.rb
 - test/renderers/excel_renderer_test.rb
+- test/results.json
 - test/test_helper.rb

data/lib/sheets/parsers/roo_parser.rb

@@ -1,29 +0,0 @@
-require 'roo'
-require File.join( File.expand_path(File.dirname(__FILE__)), 'roo_patches.rb' )
-
-class Sheets::Parsers::RooParser < Sheets::Parsers::Base
-  parses :xls, :xlsx, :ods
-
-  ROO_CLASS = {
-    :xls  => Excel,
-    :xlsx => Excelx,
-    :ods  => Openoffice
-  }
-
-  def to_array
-    array = []
-    (spreadsheet.first_row..spreadsheet.last_row).each do |row_num|
-      row = []
-      (spreadsheet.first_column..spreadsheet.last_column).each do |column_num|
-        row << spreadsheet.cell(row_num, column_num).to_s
-      end
-      array << row
-    end
-    array
-  end
-
-  private
-  def spreadsheet
-    ROO_CLASS[@format.to_sym].new(@file_path)
-  end
-end

data/lib/sheets/parsers/roo_patches.rb

@@ -1,5 +0,0 @@
-puts "Loading Roo Patches"
-Dir[ File.join( File.expand_path(File.dirname(__FILE__)), 'roo_patches', '*.rb' ) ].each do |file|
-  puts "- #{File.basename(file)}"
-  require file
-end

data/lib/sheets/parsers/roo_patches/roo_patch_28885.rb

@@ -1,116 +0,0 @@
-# RubyForge Patch: 28885 - Fixes to Honor XLSX Base Date Format
-# NOTE: This fix is *highly* brittle. If roo updates, this may break roo.
-
-class Excelx
-
-  def initialize(filename, packed=nil, file_warning = :error) #, create = false)
-    super()
-    @file_warning = file_warning
-    @tmpdir = "oo_"+$$.to_s
-    @tmpdir = File.join(ENV['ROO_TMP'], @tmpdir) if ENV['ROO_TMP'] 
-    unless File.exists?(@tmpdir)
-      FileUtils::mkdir(@tmpdir)
-    end
-    filename = open_from_uri(filename) if filename[0,7] == "http://"
-    filename = unzip(filename) if packed and packed == :zip
-    begin
-      file_type_check(filename,'.xlsx','an Excel-xlsx')
-      @cells_read = Hash.new
-      @filename = filename
-      unless File.file?(@filename)
-        raise IOError, "file #{@filename} does not exist"
-      end
-      @@nr += 1
-      @file_nr = @@nr
-      extract_content(@filename)
-      file = File.new(File.join(@tmpdir, @file_nr.to_s+"_roo_workbook.xml"))
-      # TODO: @workbook_doc = XML::Parser.io(file).parse
-      @workbook_doc = Nokogiri::XML(file)
-      
-      # Set the base date, could be 1900 or 1904 depending on the system of origin.
-      date_base_element = @workbook_doc.search('workbookPr').attribute('date1904')
-      if date_base_element && date_base_element.value.to_i == 1
-        @base_date = Date.parse('1904-01-01')
-      else
-        @base_date = Date.parse('1900-01-01')
-      end
-      @base_datetime = DateTime.parse( @base_date.strftime("%Y-%m-%d") )
-      
-      file.close
-      @shared_table = []
-      if File.exist?(File.join(@tmpdir, @file_nr.to_s+'_roo_sharedStrings.xml'))
-        file = File.new(File.join(@tmpdir, @file_nr.to_s+'_roo_sharedStrings.xml'))
-        #TODO: @sharedstring_doc = XML::Parser.io(file).parse
-        @sharedstring_doc = Nokogiri::XML(file)
-        file.close
-        read_shared_strings(@sharedstring_doc)
-      end
-      @styles_table = []
-      @style_definitions = Array.new # TODO: ??? { |h,k| h[k] = {} }
-      if File.exist?(File.join(@tmpdir, @file_nr.to_s+'_roo_styles.xml'))
-        file = File.new(File.join(@tmpdir, @file_nr.to_s+'_roo_styles.xml'))
-        #TODO: @styles_doc = XML::Parser.io(file).parse
-        @styles_doc = Nokogiri::XML(file)
-        file.close
-        read_styles(@styles_doc)
-      end
-      @sheet_doc = []
-      @sheet_files.each_with_index do |item, i|
-        file = File.new(item)
-        #TODO: @sheet_doc[i] = XML::Parser.io(file).parse
-        @sheet_doc[i] = Nokogiri::XML(file)
-        file.close
-      end
-    ensure
-      #if ENV["roo_local"] != "thomas-p"
-      FileUtils::rm_r(@tmpdir)
-      #end
-    end
-    @default_sheet = self.sheets.first
-    @cell = Hash.new
-    @cell_type = Hash.new
-    @formula = Hash.new
-    @first_row = Hash.new
-    @last_row = Hash.new
-    @first_column = Hash.new
-    @last_column = Hash.new
-    @header_line = 1
-    @excelx_type = Hash.new
-    @excelx_value = Hash.new
-    @s_attribute = Hash.new # TODO: ggf. wieder entfernen nur lokal benoetigt
-  end
-
-  def set_cell_values(sheet,x,y,i,v,vt,formula,tr,str_v,
-      excelx_type=nil,
-      excelx_value=nil,
-      s_attribute=nil)
-    key = [y,x+i]
-    @cell_type[sheet] = {} unless @cell_type[sheet]
-    @cell_type[sheet][key] = vt
-    @formula[sheet] = {} unless @formula[sheet]
-    @formula[sheet][key] = formula  if formula
-    @cell[sheet]    = {} unless @cell[sheet]
-    case @cell_type[sheet][key]
-    when :float
-      @cell[sheet][key] = v.to_f
-    when :string
-      @cell[sheet][key] = str_v
-    when :date
-      @cell[sheet][key] = (@base_date+v.to_i).strftime("%Y-%m-%d")
-    when :datetime
-      @cell[sheet][key] = (@base_datetime+v.to_f).strftime("%Y-%m-%d %H:%M:%S")
-    when :percentage
-      @cell[sheet][key] = v.to_f
-    when :time
-      @cell[sheet][key] = v.to_f*(24*60*60)
-    else
-      @cell[sheet][key] = v
-    end
-    @excelx_type[sheet] = {} unless @excelx_type[sheet]
-    @excelx_type[sheet][key] = excelx_type
-    @excelx_value[sheet] = {} unless @excelx_value[sheet]
-    @excelx_value[sheet][key] = excelx_value
-    @s_attribute[sheet] = {} unless @s_attribute[sheet]
-    @s_attribute[sheet][key] = s_attribute
-  end
-end

data/lib/sheets/parsers/roo_patches/roo_patch_29045.rb

@@ -1,2 +0,0 @@
-# RubyForge Patch: 29045 - Fixes missing date format "January 10, 2011"
-Excelx::FORMATS["mmm\\ d\\,\\ yyyy"] = :date

data/test/parsers/roo_parser_test.rb

@@ -1,8 +0,0 @@
-class TestRooParser < Test::Unit::TestCase
-  
-  def test_roo_date_format_issue
-    sheet = Sheets::Base.new( 'test/data/roo_issue_28885_test.xlsx' )
-
-    assert_equal "2011-01-10", sheet.to_array[1][0]
-  end
-end