sharepoint_api 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c05bcfa82a6db67d9f534913826d123879b36617cf08414f324397882847848
-  data.tar.gz: 5002313d37f643cb89780d5fdb22dee5804e7366ba46f50f5b938fb1976a5db9
+  metadata.gz: a04ca042235cb062f83374dc540fd27d12b2068bb356bf52b54716e48b15c905
+  data.tar.gz: 6923a225c514c6a53c8f08d7b95e072fc75272db591f232c4148ed7eece95c95
 SHA512:
-  metadata.gz: 9b7867fdb75d7afee66c3d23660dc600ffa2227a33a7da16f15a45ae9d3019b7ff7ec7ab3ec5604f5a30b17f3878df2fc7cb30f6ff2da95c5b14fb520042b5b9
-  data.tar.gz: a0a4201b08b3eb6c1c3713a92ecdfefe0413ffcd0372eca2f3e8a4bd4e5f039cbf12f7e5b5aedc555dd83bc599d67543f9fc5acb26b4e8bc2fbb278a74984349
+  metadata.gz: 96c52d86e21e98b0e2e2430b151fe91a253412b98dac1d2952b983e8fa37e605839cd58ea3c6e640901a4fcb14caa58637ff1391e1a068f44894d69d0102df1e
+  data.tar.gz: 37a24f9c97d3e279be6a438dadd276030d319b62964347570f9ab2d3a81320b31cd82da3b04a95f0b9b2495364ef56f87d4e8ee36a8f150d2d7d3576eabffdb4

data/.pryrc

@@ -0,0 +1,46 @@
+#!/usr/env/bin ruby
+
+# user = `echo "$USER"`.strip
+class ProgrammerError < StandardError; end
+
+if defined?(Pry)
+  Pry.config.editor = 'vim'
+
+  # Hit enter to repeat the last command.
+  Pry::Commands.command(/^$/, 'Repeat last command.') do
+    pry_instance.run_command Pry.history.to_a.last
+  end
+
+  Pry::Commands.command('args', 'Display local variables.') do
+    pry_instance.run_command 'ls -l'
+  end
+
+  Pry.commands.alias_command 'ss', 'show-source'
+  Pry.commands.alias_command 'q', 'quit'
+  Pry.commands.alias_command 'w', 'whereami'
+  Pry.commands.alias_command 'r', 'reload-code'
+  Pry.commands.alias_command 'ed', 'edit'
+  Pry.commands.alias_command 'ec', 'edit -c' # open current file in editor
+end
+
+if defined?(PryByebug)
+  Pry.commands.alias_command 'b', 'backtrace'
+  Pry.commands.alias_command 'c', 'continue'
+  Pry.commands.alias_command 'n', 'next'
+  Pry.commands.alias_command 's', 'step'
+end
+
+class String
+  def gitize
+    gsub(/\W+$/, ''). # kill trailing whitespace
+      gsub(/\W+/, '-'). # replace whitespace with -
+      gsub(/([A-Z])/, '-\1'). # prepend dash to capitals
+      gsub(/^-/, ''). # strip leading dash
+      gsub(/-+/, '-'). # compress multiple dashes to a single dash
+      downcase
+  end
+
+  def prize
+    gsub(/\W+$/, '').gsub(/\W+/, ' ').gsub(/\b(?<!['’`])[a-z]/, &:capitalize)
+  end
+end

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## [1.0.3] - 2021-01-12
+  * Handle edge case where FileInfo file#modified_by refers to a user that no longer exists.
+
 ## [1.0.2] - 2021-01-04
   * Handle edge case where FileInfo file/file version refers to a user that no longer exists.
 

data/Gemfile

@@ -5,9 +5,14 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in sharepoint_api.gemspec
 gemspec
 
-gem 'faker'
+gem 'faker', '~> 2.15'
+gem 'guard', '~> 2.16'
+gem 'guard-rspec', '~> 4.7'
+gem 'pry', '~> 0.13.1'
+gem 'pry-byebug', '~> 3.9'
+gem 'pry-rescue', '~> 1.5'
 gem 'rake', '~> 13.0'
 gem 'rspec', '~> 3.6'
-gem 'rspec-collection_matchers'
+gem 'rspec-collection_matchers', '~> 1.2'
 gem 'rubocop', '~> 1.5'
 gem 'rubocop-rspec', '~> 2.0'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sharepoint_api (1.0.2)
+    sharepoint_api (1.0.3)
       addressable (~> 2.7)
       proof-sharepoint-ruby (~> 1.0)
 
@@ -11,21 +11,61 @@ GEM
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.1)
+    byebug (11.1.3)
+    coderay (1.1.3)
     concurrent-ruby (1.1.7)
     curb (0.9.10)
     diff-lcs (1.4.4)
     faker (2.15.1)
       i18n (>= 1.6, < 2)
+    ffi (1.14.2)
+    formatador (0.2.5)
+    guard (2.16.2)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
     i18n (1.8.5)
       concurrent-ruby (~> 1.0)
+    interception (0.5)
+    listen (3.4.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    nenv (0.3.0)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
     parallel (1.20.1)
     parser (2.7.2.0)
       ast (~> 2.4.1)
     proof-sharepoint-ruby (1.0.0)
       curb (~> 0.8, <= 0.9.10)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    pry-rescue (1.5.2)
+      interception (>= 0.5)
+      pry (>= 0.12.0)
     public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.1)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
     regexp_parser (2.0.0)
     rexml (3.2.4)
     rspec (3.10.0)
@@ -58,19 +98,26 @@ GEM
       rubocop (~> 1.0)
       rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.10.1)
+    shellany (0.0.1)
+    thor (1.0.1)
     unicode-display_width (1.7.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  faker
+  faker (~> 2.15)
+  guard (~> 2.16)
+  guard-rspec (~> 4.7)
+  pry (~> 0.13.1)
+  pry-byebug (~> 3.9)
+  pry-rescue (~> 1.5)
   rake (~> 13.0)
   rspec (~> 3.6)
-  rspec-collection_matchers
+  rspec-collection_matchers (~> 1.2)
   rubocop (~> 1.5)
   rubocop-rspec (~> 2.0)
   sharepoint_api!
 
 BUNDLED WITH
-   1.17.2
+   2.2.4

data/Guardfile

@@ -0,0 +1,42 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: 'echo -e "\033c"; bundle exec rspec' do
+  require 'guard/rspec/dsl'
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/README.md

@@ -39,25 +39,27 @@ api = SharepointApi.new(
 
 api.fetch_content_types # or whatever method you want to test.
 ```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+> NOTE: run `bundle install` and commit the changes to the Gemfile.lock before deploying a new version.
+
 ## Testing
 
-Run the test suite:
-`rspec`
+Start the test suite watcher:
+`bundle exec guard`
 
-Run the tests for just one file:
-`rspec spec/sharepoint_api/items_spec.rb`
+Run the tests for just one file just enter the filename in the Guard console.
+`spec/sharepoint_api/items_spec.rb`
 
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/anlek/sharepoint_api. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/anlek/sharepoint_api/blob/master/CODE_OF_CONDUCT.md).
 
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/bin/console

@@ -7,8 +7,8 @@ require "sharepoint_api"
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
+require "pry"
+Pry.start
 
-require "irb"
-IRB.start(__FILE__)
+# require "irb"
+# IRB.start(__FILE__)

data/docs/pull_request_template.md

@@ -0,0 +1,38 @@
+[XXXXX](https://proof-tech.atlassian.net/browse/XXXXX)
+
+### Overview
+
+Please include a summary of the changes in this pull request.
+List any dependencies that are required before this change is applied.
+
+### Solution
+
+How did you solve the problem?
+Call out any particular implementation choices or design decisions you made
+
+### Screenshots
+
+[insert screenshots here]
+
+### Testing Instructions
+
+Describe, for your colleagues, how they can test your code locally on their system
+
+### Pre-Merge Checklist
+
+- [ ] I have updated the version and changelog in a different PR than bug fixes and features.
+- [ ] The work here reflects the user stories in the JIRA ticket(s) listed at the top of this pull request
+- [ ] This pull request has been referenced via URL in the JIRA ticket(s) listed
+- [ ] I have performed a self-review of the code I have written here
+- [ ] I have done end-to-end QA testing of sections of the code I have altered
+- [ ] My changes generate no new warnings / errors in the console
+- [ ] I have written/updated Ruby tests for the areas of the code base that I have modified
+- [ ] I am prepared for this code to go to production today (or there is a WIP label on the pull request)
+- [ ] I am prepared to write hotfixes or rollback my code if something goes wrong
+
+### Gem Deployment Instructions
+
+1. `bundle exec rake install`
+2. `bundle exec rake release`
+
+Reminder that deploy instructions are in the [here](https://github.com/proofgov/sharepoint_api#development).

data/lib/sharepoint_api/file_info.rb

@@ -1,5 +1,9 @@
+require_relative 'sharepoint_error'
+
 class SharepointApi
   class FileInfo
+    class FileInfoError < SharepointError; end
+
     extend Forwardable
     attr_reader :version, :version_id, :file, :updated_at
 
@@ -31,7 +35,7 @@ class SharepointApi
         version_id,
         created_at: updated_at,
         current: true,
-        creator_login: file.modified_by&.login_name
+        creator_login: safe_modified_by(file)&.login_name
       )
 
       return @all_versions unless version > 1
@@ -63,5 +67,13 @@ class SharepointApi
         **attrs
       )
     end
+
+    def safe_modified_by(file)
+      file.modified_by
+    rescue Sharepoint::SPException => e
+      return nil if e.message =~ /User cannot be found/
+
+      raise(FileInfoError, e.message)
+    end
   end
 end

data/lib/sharepoint_api/version.rb

@@ -1,3 +1,3 @@
 class SharepointApi
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

data/sharepoint_api.gemspec

@@ -16,16 +16,16 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = 'https://github.com/proofgov/sharepoint_api'
   spec.metadata['changelog_uri'] = 'https://github.com/proofgov/sharepoint_api/blob/master/CHANGELOG.md'
 
-  spec.add_runtime_dependency('proof-sharepoint-ruby', '~> 1.0')
   spec.add_runtime_dependency('addressable', '~> 2.7')
+  spec.add_runtime_dependency('proof-sharepoint-ruby', '~> 1.0')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir = 'exe'
-  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = 'bin'
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
 
   spec.require_paths = ['lib']
 end

metadata

@@ -1,67 +1,72 @@
 --- !ruby/object:Gem::Specification
 name: sharepoint_api
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Andrew Kalek
 - Marlen Brunner
 - Danella Olsen
-autorequire: 
-bindir: exe
+autorequire:
+bindir: bin
 cert_chain: []
-date: 2021-01-04 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: proof-sharepoint-ruby
+  name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.7'
 - !ruby/object:Gem::Dependency
-  name: addressable
+  name: proof-sharepoint-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '1.0'
 description: A tool to make it easier to talk to sharepoint (via the proof-sharepoint-ruby
   gem)
 email:
 - akalek@proofgov.com
 - mbrunner@proofgov.com
 - dolsen@proofgov.com
-executables: []
+executables:
+- console
+- setup
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".pryrc"
 - ".rspec"
 - ".rubocop.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - bin/console
 - bin/setup
+- docs/pull_request_template.md
 - lib/sharepoint_api.rb
 - lib/sharepoint_api/file_info.rb
 - lib/sharepoint_api/file_system.rb
@@ -80,7 +85,7 @@ metadata:
   homepage_uri: https://github.com/proofgov/sharepoint_api
   source_code_uri: https://github.com/proofgov/sharepoint_api
   changelog_uri: https://github.com/proofgov/sharepoint_api/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -95,8 +100,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.4
+signing_key:
 specification_version: 4
 summary: SharepointApi allows you to interact with sharepoint in a simpler DSL.
 test_files: []