shapeup-cli 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecb0aff2791935bf727f5afbb283ec92bb181325bb57b8ba0d6778d05b18db26
-  data.tar.gz: 8f938f4be9b1dafc98c44916bcf539b936ba89fa0ca9c245cf78b1531c6a64c6
+  metadata.gz: f7f49a40c881c3e40aa1749a419a41139d02a5c3066113e851efecf544cddc84
+  data.tar.gz: baa1415c2d57ea6aeeb74c4562e67773041ddd72ad9d27667bf34756faca8e56
 SHA512:
-  metadata.gz: f337c2f8aade0196c9cdaff8f48d7e10a4216736844e7b2381aa348dcc0855a12d8a0d3ee557fee7778599f1ab8bb15399676afcf87c8150b446e54e5328d323
-  data.tar.gz: 517305b0931a662d4b3b8a4cfb2910a3a879b64bfce4d303edaf7da7cf390a6f0c2c8f1155ab9f2f0261ec64c6ef69574fed070f564c0ad0b9f8b9ebe820149f
+  metadata.gz: 83fb9f6f9978710170a847e270469de2b7b0d57381adb4751a0748db279477e6780d2ca87176f1f787a06cd89c5594e7cd65533c773d6b7fb12b7d0f3ee3747d
+  data.tar.gz: '098b476ae487d54975b7726227407462452da622fb5a7b188de2bd72d42a902dfc10f2fe474874eda44069b2014b5ea7d725a021e8cd988e90c7f8fa009faf11'

data/lib/shapeup_cli/commands/comments.rb

@@ -66,12 +66,9 @@ module ShapeupCli
           attach_paths = extract_options("--attach")
           text = positional_arg(1) || abort('Usage: shapeup comments add --issue <id> [--parent <comment_id>] [--attach <image>] "Comment text"')
 
-          text, images = local_images_in(text)
-          images += attach_paths.map { |path| [ path, nil ] }
-
-          arguments = { commentable_type: type, commentable_id: id.to_s, content: text }
+          arguments = { commentable_type: type, commentable_id: id.to_s, content: place_local_images(text) }
           arguments[:parent_id] = parent.to_s if parent
-          arguments[:attachments] = images.map { |path, alt| upload_image(path, alt) } if images.any?
+          arguments[:attachments] = attach_paths.map { |path| upload_image(path, nil) } if attach_paths.any?
           result = call_tool("create_comment", **arguments)
 
           render result,
@@ -85,7 +82,7 @@ module ShapeupCli
           comment_id = positional_arg(1) || abort('Usage: shapeup comments edit <comment_id> "New text"')
           text = positional_arg(2) || abort('Usage: shapeup comments edit <comment_id> "New text"')
 
-          result = call_tool("update_comment", comment_id: comment_id.to_s, content: text)
+          result = call_tool("update_comment", comment_id: comment_id.to_s, content: place_local_images(text))
 
           render result, summary: "Comment ##{comment_id} updated"
         end
@@ -111,20 +108,16 @@ module ShapeupCli
 
         IMAGE_TYPES = { ".png" => "image/png", ".jpg" => "image/jpeg", ".jpeg" => "image/jpeg", ".gif" => "image/gif", ".webp" => "image/webp" }.freeze
         IMAGE_MAX_SIZE = 10 * 1024 * 1024
-        MARKDOWN_IMAGE = /!\[([^\]]*)\]\(([^)\s]+)\)\n?/
-
-        def local_images_in(text)
-          images = []
-          text = text.gsub(MARKDOWN_IMAGE) do |markdown|
-            alt, path = $1, $2
-            if path.match?(%r{\A[a-z][a-z0-9+.-]*://}i) || !File.file?(path)
-              markdown
-            else
-              images << [ path, alt ]
-              ""
-            end
+        MARKDOWN_IMAGE = /!\[([^\]]*)\]\(([^)\s]+)(?:\s+"([^"]*)")?\)/
+
+        def place_local_images(text)
+          text.gsub(MARKDOWN_IMAGE) do |markdown|
+            alt, path, caption = $1, $2, $3
+            next markdown if path.match?(%r{\A[a-z][a-z0-9+.-]*:}i) || !File.file?(path)
+
+            uploaded = upload_image(path, alt)
+            %(![#{uploaded[:alt]}](attachment:#{uploaded[:attachment]}#{%( "#{caption}") if caption}))
           end
-          [ text.strip, images ]
         end
 
         def upload_image(path, alt)

data/lib/shapeup_cli/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ShapeupCli
-  VERSION = "0.9.0"
+  VERSION = "0.10.0"
 end

data/skills/shapeup/SKILL.md

@@ -222,7 +222,7 @@ Branch on `retryable` to decide retry-vs-abandon; `false` means "no known reason
 | Watch the inbox as JSON lines | `SHAPEUP_PROFILE=<agent> shapeup connect` |
 | Reply under a comment | `shapeup comments add --issue <id> --parent <comment_id> "Reply"` |
 | React to a comment | `shapeup comments react <comment_id> 👀` |
-| Attach screenshots to a comment | `shapeup comments add --issue <id> "Text ![What it shows](./shot.png)"` or `--attach shot.png` |
+| Attach screenshots to a comment | `shapeup comments add --issue <id> "Text ![What it shows](./shot.png \"Caption\")"` (stays where you put it; images on consecutive lines sit side by side) or `--attach shot.png` (added at the end) |
 
 ## Common Workflows
 

data/skills/shapeup-connect/SKILL.md

@@ -142,18 +142,36 @@ Give the subagent this, filled in:
 >    commit there. Never push, deploy, merge or delete branches unless the owner said so in this
 >    session.
 > 4. If the ask is unclear or you are blocked, ask on the issue rather than guess.
-> 5. If the work changes anything people see, show it. Use whatever browser tool you have to take
->    screenshots of each place it touches, before (from the main branch) and after (from yours),
->    at the size people use it and on a phone when it matters. Save them as PNG files outside the
->    repository, with names that say what they show.
+> 5. If the work changes anything people see, compare it the way a careful reviewer would:
+>    - From your diff, list the screens and states it touches, including the ones it could break.
+>    - Run the main branch beside yours: check main out into a git worktree outside this
+>      repository and start it on a second port, so both are up at once. How to start and sign in
+>      to the app should be in the project's CLAUDE.md or README; if it isn't, ask on the issue.
+>    - With whatever browser tool you have, capture each screen in both, at the same size and with
+>      the same content, plus a phone width and dark mode where they matter. Save PNGs outside the
+>      repository, named for what they show.
+>    - Stop the second server and remove the worktree when you're done.
 > 6. Reply once, under the comment that asked:
 >    `shapeup --profile <profile> comments add --issue <issue.id> --parent <reply_to.comment_id> "<reply>"`
->    (leave out `--parent` when `reply_to.comment_id` is null). Start with `@<requester.name>`.
->    Say what changed, the branch and commit, how you checked it, and anything still open.
->    Keep it short and plain. Put each screenshot in the reply as a local Markdown image,
->    `![Toolbar after the fix, on a phone](/tmp/toolbar-after-phone.png)`: the CLI uploads it and
->    the words in brackets become its description for people who can't see it, so write them
->    properly. Mention anyone the requester asked you to hand over to.
+>    (leave out `--parent` when `reply_to.comment_id` is null). Start with `@<requester.name>`,
+>    then say what changed, the branch and commit, and how you checked it. Keep it plain.
+>
+>    When you have screenshots, write the rest like a review: a `## heading` per area, a line on
+>    what changed there, then its before and after as local Markdown images on consecutive lines,
+>    so they sit side by side:
+>
+>    ```markdown
+>    ## Toolbar
+>    Looks the same. Dropdowns now open with focus on the first item.
+>
+>    ![Toolbar on main, dropdown open](/tmp/shots/toolbar-before.png "Before")
+>    ![Toolbar on this branch, dropdown open with the first item focused](/tmp/shots/toolbar-after.png "After")
+>    ```
+>
+>    The CLI uploads each image where it stands. The words in brackets are its description for
+>    people who can't see it, so say what it shows; the quoted word is its caption. End with a
+>    `## Worth a look` section for anything that seems off, and mention whoever the requester asked
+>    you to hand over to.
 > 7. Then take it out of the inbox: `shapeup --profile <profile> inbox done <id>`.
 > 8. Report back in one line.
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shapeup-cli
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - ShapeUp