shamu 0.0.9 → 0.0.11

data/spec/lib/shamu/services/result_spec.rb

@@ -34,4 +34,40 @@ describe Shamu::Services::Result do
     result  = Shamu::Services::Result.new
     expect( result.entity ).to be_nil
   end
-end
+
+  describe "#value!" do
+    it "raises an error if not valid" do
+      result = Shamu::Services::Result.new
+      result.errors.add :base, :whatever
+
+      expect do
+        result.value!
+      end.to raise_error Shamu::Services::ServiceRequestFailedError
+    end
+
+    it "returns #value if valid" do
+      result = Shamu::Services::Result.new :one
+
+      expect( result.value! ).to eq :one
+    end
+  end
+
+  describe "#entity!" do
+    it "raises an error if not valid" do
+      entity = Shamu::Entities::Entity.new
+      result = Shamu::Services::Result.new entity
+      result.errors.add :base, :whatever
+
+      expect do
+        result.entity!
+      end.to raise_error Shamu::Services::ServiceRequestFailedError
+    end
+
+    it "returns #entity if valid" do
+      entity = Shamu::Entities::Entity.new
+      result = Shamu::Services::Result.new entity
+
+      expect( result.entity! ).to be entity
+    end
+  end
+end

data/spec/lib/shamu/services/service_spec.rb

@@ -25,8 +25,10 @@ module ServiceSpec
     public :lookup_association
     public :lazy_association
 
-    def build_entity( record, records = nil )
-      scorpion.fetch ServiceSpec::Entity, { record: record }, {}
+    def build_entities( records )
+      records.map do |record|
+        scorpion.fetch ServiceSpec::Entity, { record: record }, {}
+      end
     end
   end
 
@@ -51,10 +53,19 @@ describe Shamu::Services::Service do
 
   let( :service ) { scorpion.new ServiceSpec::Service }
 
+  def transformer( &block )
+    ->( records ) {
+      records.map do |r|
+        yield || r
+      end
+    }
+  end
+
+
   describe "#entity_list" do
     it "maps each record" do
       expect do |b|
-        list = service.entity_list [ double ], &b
+        list = service.entity_list [ double ], &transformer( &b )
         list.to_a
       end.to yield_control
     end
@@ -64,7 +75,7 @@ describe Shamu::Services::Service do
     end
 
     it "invokes build_entity if no transformer provided" do
-      expect( service ).to receive( :build_entity ).and_call_original
+      expect( service ).to receive( :build_entities ).and_call_original
       list = service.entity_list( [{}] )
       list.first
     end
@@ -100,7 +111,7 @@ describe Shamu::Services::Service do
 
     it "yields for a matching id" do
       expect do |b|
-        service.entity_lookup_list( records, [record.id], ServiceSpec::NullEntity, &b )
+        service.entity_lookup_list( records, [record.id], ServiceSpec::NullEntity, &transformer( &b ) )
       end.to yield_control
     end
 
@@ -109,24 +120,24 @@ describe Shamu::Services::Service do
     end
 
     it "matches on id by default" do
-      list = service.entity_lookup_list( records, [record.id], ServiceSpec::NullEntity ) do |r|
-        scorpion.fetch ServiceSpec::Entity, { record: r }, {}
+      list = service.entity_lookup_list( records, [record.id], ServiceSpec::NullEntity ) do |records|
+        records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 
       expect( list.first ).to be_present
     end
 
     it "matches on id with string numbers" do
-      list = service.entity_lookup_list( records, [record.id.to_s], ServiceSpec::NullEntity ) do |r|
-        scorpion.fetch ServiceSpec::Entity, { record: r }, {}
+      list = service.entity_lookup_list( records, [record.id.to_s], ServiceSpec::NullEntity ) do |records|
+        records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 
       expect( list.first ).to be_present
     end
 
     it "matches on a custom field" do
-      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: :amount ) do |r|
-        scorpion.fetch ServiceSpec::Entity, { record: r }, {}
+      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: :amount ) do |records|
+        records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 
       expect( list.first ).to be_present
@@ -134,8 +145,8 @@ describe Shamu::Services::Service do
 
     it "matches with a custom proc" do
       matcher = ->( record ) { record.amount }
-      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: matcher ) do |r|
-        scorpion.fetch ServiceSpec::Entity, { record: r }, {}
+      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: matcher ) do |records|
+        records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 
       expect( list.first ).to be_present
@@ -304,4 +315,4 @@ describe Shamu::Services::Service do
 
 
   end
-end
+end

data/spec/spec_helper.rb

@@ -24,7 +24,7 @@ RSpec.configure do |config|
 
   config.order = "random"
 
-  config.filter_gems_from_backtrace "activesupport", "actionpack", "actionview", "scorpion-ioc", "rspec-wait"
+  config.filter_gems_from_backtrace "activesupport", "actionpack", "actionview", "scorpion-ioc", "rspec-wait", "rspec-core", "rspec", "rspec-support", "rspec-expectations"
 
   config.filter_run focus: true
   config.filter_run_excluding :broken => true

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: shamu
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.11
 platform: ruby
 authors:
 - Paul Alexander
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-15 00:00:00.000000000 Z
+date: 2017-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: scorpion-ioc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.16
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.16
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -70,14 +70,14 @@ dependencies:
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1'
 - !ruby/object:Gem::Dependency
@@ -195,7 +195,9 @@ dependencies:
 description: 
 email:
 - me@phallguy.com
-executables: []
+executables:
+- rake
+- rspec
 extensions: []
 extra_rdoc_files: []
 files:
@@ -212,6 +214,8 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- bin/rake
+- bin/rspec
 - circle.yml
 - config.ru
 - lib/generators/shamu.rb
@@ -349,6 +353,7 @@ files:
 - lib/shamu/services/request_support.rb
 - lib/shamu/services/result.rb
 - lib/shamu/services/service.rb
+- lib/shamu/services/service_call_failed_error.rb
 - lib/shamu/sessions.rb
 - lib/shamu/sessions/README.md
 - lib/shamu/sessions/cookie_store.rb
@@ -407,6 +412,7 @@ files:
 - spec/lib/shamu/features/toggle_codec_spec.rb
 - spec/lib/shamu/features/toggle_spec.rb
 - spec/lib/shamu/json_api/base_builder_spec.rb
+- spec/lib/shamu/json_api/builder_methods/identifier_spec.rb
 - spec/lib/shamu/json_api/common_builder_spec.rb
 - spec/lib/shamu/json_api/context_spec.rb
 - spec/lib/shamu/json_api/error_builder_spec.rb
@@ -466,7 +472,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Have a whale of a good time adding Service Oriented Architecture to your
@@ -522,6 +528,7 @@ test_files:
 - spec/lib/shamu/features/toggle_codec_spec.rb
 - spec/lib/shamu/features/toggle_spec.rb
 - spec/lib/shamu/json_api/base_builder_spec.rb
+- spec/lib/shamu/json_api/builder_methods/identifier_spec.rb
 - spec/lib/shamu/json_api/common_builder_spec.rb
 - spec/lib/shamu/json_api/context_spec.rb
 - spec/lib/shamu/json_api/error_builder_spec.rb
@@ -561,4 +568,3 @@ test_files:
 - spec/support/active_record.rb
 - spec/support/database.rb
 - spec/support/logger.rb
-has_rdoc: