shamu 0.0.13 → 0.0.14

data/spec/lib/shamu/entities/entity_path_spec.rb

@@ -7,7 +7,6 @@ module EntityPathSpec
 end
 
 describe Shamu::Entities::EntityPath do
-  include Shamu::Entities::EntityPath
 
   {
     "User[45]/Calendar[567]/Event[1]" => [
@@ -19,7 +18,7 @@ describe Shamu::Entities::EntityPath do
     "EntityPathSpec::Example[91]"     => [ [ "EntityPathSpec::Example", "91" ] ]
   }.each do |path, entities|
     it "decompose #{ path } to #{ entities }" do
-      expect( decompose_entity_path( path ) ).to eq entities
+      expect( Shamu::Entities::EntityPath.decompose_entity_path( path ) ).to eq entities
     end
   end
 
@@ -34,7 +33,7 @@ describe Shamu::Entities::EntityPath do
     "EntityPathSpec::Example[91]"     => [ EntityPathSpec::ExampleEntity.new( id: 91 ) ]
   }.each do |path, entities|
     it "composes #{ entities } to #{ path }" do
-      expect( compose_entity_path( entities ) ).to eq path
+      expect( Shamu::Entities::EntityPath.compose_entity_path( entities ) ).to eq path
     end
   end
-end
+end

data/spec/lib/shamu/entities/list_scope/paging_spec.rb

@@ -21,11 +21,15 @@ describe Shamu::Entities::ListScope::Paging do
   end
 
   it "uses default_per_page if not per_page set" do
-    expect( klass.new.per_page ).to eq 25
+    scope = klass.new
+    scope.default_per_page = 25
+    expect( scope.per_page ).to eq 25
   end
 
   it "includes paging values in to_param" do
-    expect( klass.new.params ).to eq page: nil, per_page: 25
+    scope = klass.new
+    scope.default_per_page = 25
+    expect( scope.params ).to eq page: nil, per_page: 25
   end
 
   it "should not be paged if using defaults" do
@@ -38,4 +42,4 @@ describe Shamu::Entities::ListScope::Paging do
     expect( scope.paged? ).to be_truthy
   end
 
-end
+end

data/spec/lib/shamu/entities/list_scope/sorting_spec.rb

@@ -18,12 +18,6 @@ describe Shamu::Entities::ListScope::Paging do
     expect( scope.sort_by ).to eq first_name: :asc, last_name: :asc
   end
 
-  it "parses array of args to fluid_assignment" do
-    scope = klass.new
-    scope.sort_by :first_name, :last_name
-    expect( scope.sort_by ).to eq first_name: :asc, last_name: :asc
-  end
-
   it "parses array via assignment" do
     scope = klass.new
     scope.sort_by = [ :first_name, :last_name ]
@@ -56,4 +50,4 @@ describe Shamu::Entities::ListScope::Paging do
   it "is sorted when asked" do
     expect( klass.new( sort_by: :name ).sorted? ).to be_truthy
   end
-end
+end

data/spec/lib/shamu/entities/opaque_entity_lookup_service_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+require_relative "entity_lookup_models"
+
+describe Shamu::Entities::OpaqueEntityLookupService do
+  let( :service ) { scorpion.new Shamu::Entities::OpaqueEntityLookupService }
+
+  describe "#ids" do
+    it "obfuscates the ids" do
+      entity = EntityLookupServiceSpecs::ExampleEntity.new( id: 5 )
+      expect( service.ids( entity ) ).not_to include( match( /EntityLookupServiceSpecs/ ) )
+    end
+  end
+
+  describe "#record_ids" do
+    it "gets the original record id" do
+      entity = EntityLookupServiceSpecs::ExampleEntity.new( id: 5 )
+      id     = service.ids( entity ).first
+
+      expect( service.record_ids( id ).first ).to eq( 5 )
+    end
+  end
+
+  describe "#lookup" do
+    let( :examples_service ) { double( EntityLookupServiceSpecs::ExamplesService ) }
+
+    before( :each ) do
+      allow( service.scorpion ).to receive( :fetch )
+        .with( EntityLookupServiceSpecs::ExamplesService )
+        .and_return( examples_service )
+    end
+
+    it "finds an entity" do
+      expect( examples_service ).to receive( :lookup ).with( "4" ).and_return [ "Found" ]
+      id = service.ids( "EntityLookupServiceSpecs::Example[4]" ).first
+
+      expect( service.lookup( id ).to_a ).to eq [ "Found" ]
+    end
+  end
+end

data/spec/lib/shamu/entities/opaque_id_spec.rb

@@ -0,0 +1,30 @@
+require "spec_helper"
+
+describe Shamu::Entities::OpaqueId do
+
+  describe ".to_model_id" do
+    it "gets the encoded id for a valid opaque id" do
+      # Patients::Patient[1]
+      expect( Shamu::Entities::OpaqueId.to_model_id( "::UGF0aWVudHM6OlBhdGllbnRbMV0=" ) ).to eq 1
+    end
+
+    it "is int for raw ids" do
+      expect( Shamu::Entities::OpaqueId.to_model_id( "23" ) ).to eq 23
+    end
+  end
+
+  describe ".opaque_id?" do
+    it "recognizes encoded ids" do
+      expect( Shamu::Entities::OpaqueId.opaque_id?( "::UGF0aWVudHM6OlBhdGllbnRbMV0=" ) ).to be_truthy
+    end
+
+    it "does not recognize raw numbers" do
+      expect( Shamu::Entities::OpaqueId.opaque_id?( "123" ) ).to be_falsy
+    end
+
+    it "does not recognize base64 encoded" do
+      expect( Shamu::Entities::OpaqueId.opaque_id?( "UGF0aWVudHM6OlBhdGllbnRbMV0=" ) ).to be_falsy
+    end
+  end
+
+end

data/spec/lib/shamu/entities/paged_list_spec.rb

@@ -0,0 +1,170 @@
+require "spec_helper"
+require "active_record"
+require "lib/shamu/active_record_support"
+
+module PagedListSpec
+  class Scope < ::ActiveRecordSpec::FavoriteScope
+    include Shamu::Entities::ListScope::Paging
+  end
+end
+
+describe Shamu::Entities::PagedList do
+  use_active_record
+
+  let( :relation ) do
+    scope = PagedListSpec::Scope.new( per_page: 10 )
+    ActiveRecordSpec::Favorite.by_list_scope( scope )
+  end
+
+  let( :transform ) do
+    Shamu::Services::LazyTransform.new( relation ) do |records|
+      records.map do |record|
+        ActiveRecordSpec::FavoriteEntity.new( record: record )
+      end
+    end
+  end
+
+  describe "#total_count" do
+    it "delegates to underlying relation" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :total_count )
+      list.total_count
+    end
+
+    it "uses absolute value" do
+      list = Shamu::Entities::PagedList.new( transform, total_count: 23 )
+
+      expect( list.total_count ).to eq 23
+    end
+
+    it "invokes block" do
+      expect do |b|
+        list = Shamu::Entities::PagedList.new( transform, total_count: b.to_proc )
+        list.total_count
+      end.to yield_control
+    end
+  end
+
+  describe "#limit" do
+
+    it "delegates to underlying relation" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :limit_value )
+      list.limit
+    end
+
+    it "uses absolute value" do
+      list = Shamu::Entities::PagedList.new( transform, limit: 23 )
+
+      expect( list.limit ).to eq 23
+    end
+
+    it "invokes block" do
+      expect do |b|
+        list = Shamu::Entities::PagedList.new( transform, limit: b.to_proc )
+        list.limit
+      end.to yield_control
+    end
+
+  end
+
+  describe "#offset" do
+
+    it "delegates to underlying relation" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :offset_value )
+      list.offset
+    end
+
+    it "uses absolute value" do
+      list = Shamu::Entities::PagedList.new( transform, offset: 23 )
+
+      expect( list.offset ).to eq 23
+    end
+
+    it "invokes block" do
+      expect do |b|
+        list = Shamu::Entities::PagedList.new( transform, offset: b.to_proc )
+        list.offset
+      end.to yield_control
+    end
+
+  end
+
+  describe "#next?" do
+
+    it "delegates to underlying relation has_next?" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :has_next? )
+      list.next?
+    end
+
+    it "delegates to underlying relation last_page?" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :last_page? )
+      list.next?
+    end
+
+    it "uses absolute value" do
+      list = Shamu::Entities::PagedList.new( transform, has_next: true )
+
+      expect( list.next? ).to be_truthy
+    end
+
+    it "invokes block" do
+      expect do |b|
+        list = Shamu::Entities::PagedList.new( transform, has_next: b.to_proc )
+        list.next?
+      end.to yield_control
+    end
+
+  end
+
+  describe "#previous?" do
+
+    it "delegates to underlying relation has_previous?" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :has_previous? )
+      list.previous?
+    end
+
+    it "delegates to underlying relation last_page?" do
+      list = Shamu::Entities::PagedList.new( transform )
+
+      expect( relation ).to receive( :first_page? )
+      list.previous?
+    end
+
+    it "uses absolute value" do
+      list = Shamu::Entities::PagedList.new( transform, has_previous: true )
+
+      expect( list.previous? ).to be_truthy
+    end
+
+    it "invokes block" do
+      expect do |b|
+        list = Shamu::Entities::PagedList.new( transform, has_previous: b.to_proc )
+        list.previous?
+      end.to yield_control
+    end
+
+  end
+
+  describe "current_page" do
+    it "calculates page" do
+      list = Shamu::Entities::PagedList.new( transform, limit: 5, offset: 15 )
+      expect( list.current_page ).to eq 4
+    end
+
+    it "calculates page with padding" do
+      list = Shamu::Entities::PagedList.new( transform, limit: 5, offset: 16 )
+      expect( list.current_page ).to eq 4
+    end
+  end
+end

data/spec/lib/shamu/services/active_record_crud_spec.rb

@@ -23,6 +23,10 @@ module ActiveRecordCrudSpec
       attribute :id
     end
 
+    class Destroy < Change
+      attribute :id
+    end
+
   end
 
   class Service < Shamu::Services::Service
@@ -189,6 +193,11 @@ describe Shamu::Services::ActiveRecordCrud do
       service.update entity, request
     end
 
+    it "backfills missing attributes" do
+      expect( request ).to receive( :assign_attributes ).with( hash_including( label: "Books" ) )
+      service.update entity, request
+    end
+
     it "calls apply_changes if present" do
       expect( service ).to receive( :apply_changes )
         .with(
@@ -425,7 +434,7 @@ describe Shamu::Services::ActiveRecordCrud do
 
     it "destroys the record" do
       expect do
-        service.destroy entity
+        service.destroy( entity ).valid!
       end.to change( ActiveRecordSpec::Favorite, :count ).by( -1 )
     end
 

data/spec/lib/shamu/services/lazy_transform_spec.rb

@@ -47,6 +47,20 @@ describe Shamu::Services::LazyTransform do
     end.to yield_control.exactly(3)
   end
 
+  it "short-circuits last" do
+    expect do |block|
+      transformed = Shamu::Services::LazyTransform.new( source, &transformer( &block ) )
+      transformed.last
+    end.to yield_control.once
+  end
+
+  it "doesn't short-circuit last(n)" do
+    expect do |block|
+      transformed = Shamu::Services::LazyTransform.new( source, &transformer( &block ) )
+      transformed.last( 2 )
+    end.to yield_control.exactly(3)
+  end
+
   it "short-circuits empty?" do
     expect do |block|
       transformed = Shamu::Services::LazyTransform.new( source, &transformer( &block ) )

data/spec/lib/shamu/to_model_id_extension_spec.rb

@@ -23,6 +23,10 @@ describe Shamu::ToModelIdExtension do
     it "returns self for an integer" do
       expect( 789.to_model_id ).to eq 789
     end
+
+    it "returns nil for nil" do
+      expect( nil.to_model_id ).to eq nil
+    end
   end
 
   describe Shamu::ToModelIdExtension::Enumerables do
@@ -51,4 +55,4 @@ describe Shamu::ToModelIdExtension do
     end
   end
 
-end
+end

data/spec/support/active_record.rb

@@ -14,4 +14,4 @@ module Support
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shamu
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Paul Alexander
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-18 00:00:00.000000000 Z
+date: 2017-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: '1.11'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -230,10 +230,13 @@ files:
 - lib/shamu/attributes.rb
 - lib/shamu/attributes/README.md
 - lib/shamu/attributes/assignment.rb
+- lib/shamu/attributes/camel_case.rb
 - lib/shamu/attributes/equality.rb
 - lib/shamu/attributes/fluid_assignment.rb
 - lib/shamu/attributes/html_sanitation.rb
 - lib/shamu/attributes/validation.rb
+- lib/shamu/attributes/validators.rb
+- lib/shamu/attributes/validators/valid_validator.rb
 - lib/shamu/auditing.rb
 - lib/shamu/auditing/README.md
 - lib/shamu/auditing/audit_record.rb
@@ -247,6 +250,7 @@ files:
 - lib/shamu/entities/active_record.rb
 - lib/shamu/entities/active_record_soft_destroy.rb
 - lib/shamu/entities/entity.rb
+- lib/shamu/entities/entity_lookup_service.rb
 - lib/shamu/entities/entity_path.rb
 - lib/shamu/entities/html_sanitation.rb
 - lib/shamu/entities/identity_cache.rb
@@ -256,7 +260,11 @@ files:
 - lib/shamu/entities/list_scope/paging.rb
 - lib/shamu/entities/list_scope/scoped_paging.rb
 - lib/shamu/entities/list_scope/sorting.rb
+- lib/shamu/entities/list_scope/window_paging.rb
 - lib/shamu/entities/null_entity.rb
+- lib/shamu/entities/opaque_entity_lookup_service.rb
+- lib/shamu/entities/opaque_id.rb
+- lib/shamu/entities/paged_list.rb
 - lib/shamu/error.rb
 - lib/shamu/events.rb
 - lib/shamu/events/README.md
@@ -370,6 +378,7 @@ files:
 - spec/internal/public/favicon.ico
 - spec/lib/shamu/active_record_support.rb
 - spec/lib/shamu/attributes/assignment_spec.rb
+- spec/lib/shamu/attributes/camel_case_spec.rb
 - spec/lib/shamu/attributes/equality_spec.rb
 - spec/lib/shamu/attributes/fluid_assignment_spec.rb
 - spec/lib/shamu/attributes/html_sanitation_spec.rb
@@ -379,6 +388,8 @@ files:
 - spec/lib/shamu/auditing/support_spec.rb
 - spec/lib/shamu/entities/active_record_soft_destroy_spec.rb
 - spec/lib/shamu/entities/active_record_spec.rb
+- spec/lib/shamu/entities/entity_lookup_models.rb
+- spec/lib/shamu/entities/entity_lookup_service_spec.rb
 - spec/lib/shamu/entities/entity_path_spec.rb
 - spec/lib/shamu/entities/entity_spec.rb
 - spec/lib/shamu/entities/html_sanitation_spec.rb
@@ -390,6 +401,9 @@ files:
 - spec/lib/shamu/entities/list_scope_spec.rb
 - spec/lib/shamu/entities/list_spec.rb
 - spec/lib/shamu/entities/null_entity_spec.rb
+- spec/lib/shamu/entities/opaque_entity_lookup_service_spec.rb
+- spec/lib/shamu/entities/opaque_id_spec.rb
+- spec/lib/shamu/entities/paged_list_spec.rb
 - spec/lib/shamu/events/active_record/migration_spec.rb
 - spec/lib/shamu/events/active_record/service_spec.rb
 - spec/lib/shamu/events/events_service_spec.rb
@@ -486,6 +500,7 @@ test_files:
 - spec/internal/public/favicon.ico
 - spec/lib/shamu/active_record_support.rb
 - spec/lib/shamu/attributes/assignment_spec.rb
+- spec/lib/shamu/attributes/camel_case_spec.rb
 - spec/lib/shamu/attributes/equality_spec.rb
 - spec/lib/shamu/attributes/fluid_assignment_spec.rb
 - spec/lib/shamu/attributes/html_sanitation_spec.rb
@@ -495,6 +510,8 @@ test_files:
 - spec/lib/shamu/auditing/support_spec.rb
 - spec/lib/shamu/entities/active_record_soft_destroy_spec.rb
 - spec/lib/shamu/entities/active_record_spec.rb
+- spec/lib/shamu/entities/entity_lookup_models.rb
+- spec/lib/shamu/entities/entity_lookup_service_spec.rb
 - spec/lib/shamu/entities/entity_path_spec.rb
 - spec/lib/shamu/entities/entity_spec.rb
 - spec/lib/shamu/entities/html_sanitation_spec.rb
@@ -506,6 +523,9 @@ test_files:
 - spec/lib/shamu/entities/list_scope_spec.rb
 - spec/lib/shamu/entities/list_spec.rb
 - spec/lib/shamu/entities/null_entity_spec.rb
+- spec/lib/shamu/entities/opaque_entity_lookup_service_spec.rb
+- spec/lib/shamu/entities/opaque_id_spec.rb
+- spec/lib/shamu/entities/paged_list_spec.rb
 - spec/lib/shamu/events/active_record/migration_spec.rb
 - spec/lib/shamu/events/active_record/service_spec.rb
 - spec/lib/shamu/events/events_service_spec.rb