shakapacker 9.3.0 → 9.3.2

data/eslint.config.fast.js

@@ -17,11 +17,12 @@ module.exports = [
   // Global ignores (replaces .eslintignore)
   {
     ignores: [
-      "lib/**",
-      "**/node_modules/**",
-      "vendor/**",
-      "spec/**",
-      "package/**" // TODO: Remove after issue #644 is resolved (lints package/ TS source files)
+      "lib/**", // Ruby files, not JavaScript
+      "**/node_modules/**", // Third-party dependencies
+      "vendor/**", // Vendored dependencies
+      "spec/**", // Ruby specs, not JavaScript
+      "package/**/*.js", // Generated/compiled JavaScript from TypeScript
+      "package/**/*.d.ts" // Generated TypeScript declaration files
     ]
   },
 
@@ -63,7 +64,11 @@ module.exports = [
       "import/no-extraneous-dependencies": "off",
       // TypeScript handles extensions, not needed for JS imports
       "import/extensions": "off",
-      indent: ["error", 2]
+      indent: ["error", 2],
+      // Allow for...of loops - modern JS syntax
+      "no-restricted-syntax": "off",
+      // Allow console statements - used for debugging/logging throughout
+      "no-console": "off"
     },
     settings: {
       react: {
@@ -130,13 +135,120 @@ module.exports = [
       "@typescript-eslint/no-use-before-define": ["error"],
       "@typescript-eslint/no-unused-vars": [
         "error",
-        { argsIgnorePattern: "^_" }
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }
       ],
       "@typescript-eslint/no-explicit-any": "error",
-      "@typescript-eslint/explicit-module-boundary-types": "off"
+      "@typescript-eslint/explicit-module-boundary-types": "off",
+      "no-undef": "off"
     }
   },
 
+  // Global rule for all TypeScript files in package/
+  // Suppress require() imports - these are intentional for CommonJS compatibility
+  // Will be addressed in Phase 3 (breaking changes) - see #708
+  {
+    files: ["package/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-require-imports": "off",
+      "global-require": "off",
+      "import/no-import-module-exports": "off"
+    }
+  },
+
+  // Consolidated override for package/config.ts and package/babel/preset.ts
+  {
+    files: ["package/babel/preset.ts", "package/config.ts"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "off",
+      "import/order": "off",
+      "import/newline-after-import": "off",
+      "import/first": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+      "no-useless-escape": "off"
+    }
+  },
+
+  // configExporter module overrides
+  {
+    files: ["package/configExporter/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-use-before-define": "off",
+      "import/no-dynamic-require": "off",
+      "class-methods-use-this": "off",
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off",
+      "no-restricted-globals": "off",
+      "@typescript-eslint/no-unused-vars": "off",
+      "@typescript-eslint/no-explicit-any": "off"
+    }
+  },
+
+  // Utils module overrides
+  {
+    files: [
+      "package/utils/inliningCss.ts",
+      "package/utils/errorCodes.ts",
+      "package/utils/errorHelpers.ts",
+      "package/utils/pathValidation.ts",
+      "package/utils/getStyleRule.ts",
+      "package/utils/helpers.ts",
+      "package/utils/validateDependencies.ts",
+      "package/webpackDevServerConfig.ts"
+    ],
+    rules: {
+      "@typescript-eslint/no-explicit-any": "off",
+      "no-useless-escape": "off"
+    }
+  },
+
+  // Plugins and optimization overrides
+  {
+    files: ["package/plugins/**/*.ts", "package/optimization/**/*.ts"],
+    rules: {
+      "import/prefer-default-export": "off"
+    }
+  },
+
+  // Rules, rspack, swc, esbuild, and other modules
+  {
+    files: [
+      "package/index.ts",
+      "package/rspack/index.ts",
+      "package/rules/**/*.ts",
+      "package/swc/index.ts",
+      "package/esbuild/index.ts",
+      "package/dev_server.ts",
+      "package/env.ts"
+    ],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "off",
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off"
+    }
+  },
+
+  // Environments module overrides
+  {
+    files: ["package/environments/**/*.ts"],
+    rules: {
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off"
+    }
+  },
+
+  // Type tests are intentionally unused - they test type compatibility
+  {
+    files: ["package/**/__type-tests__/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "off"
+    }
+  },
+
+  // Note: Type-aware rule overrides from main config (e.g., @typescript-eslint/no-unsafe-*,
+  // @typescript-eslint/restrict-template-expressions) are intentionally omitted here since
+  // fast mode doesn't enable type-aware linting (no parserOptions.project specified).
+  // This keeps fast mode performant while maintaining consistency for non-type-aware rules.
+
   // Prettier config must be last to override other configs
   prettierConfig
 ]

data/eslint.config.js

@@ -19,13 +19,7 @@ module.exports = [
       "vendor/**", // Vendored dependencies
       "spec/**", // Ruby specs, not JavaScript
       "package/**/*.js", // Generated/compiled JavaScript from TypeScript
-      "package/**/*.d.ts", // Generated TypeScript declaration files
-      // Temporarily ignore TypeScript files until technical debt is resolved
-      // See ESLINT_TECHNICAL_DEBT.md for tracking
-      // TODO: Remove this once ESLint issues are fixed (tracked in #723)
-      // Exception: configExporter is being fixed in #707
-      "package/**/*.ts",
-      "!package/configExporter/**/*.ts" // Enable linting for configExporter (issue #707)
+      "package/**/*.d.ts" // Generated TypeScript declaration files
     ]
   },
 
@@ -142,10 +136,10 @@ module.exports = [
       // Disable base rule in favor of TypeScript version
       "no-use-before-define": "off",
       "@typescript-eslint/no-use-before-define": ["error"],
-      // Allow unused vars if they start with underscore (convention for ignored params)
+      // Allow unused vars if they start with underscore (convention for ignored params and type tests)
       "@typescript-eslint/no-unused-vars": [
         "error",
-        { argsIgnorePattern: "^_" }
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }
       ],
       // Strict: no 'any' types allowed - use 'unknown' or specific types instead
       "@typescript-eslint/no-explicit-any": "error",
@@ -157,37 +151,42 @@ module.exports = [
     }
   },
 
+  // Global rule for all TypeScript files in package/
+  // Suppress require() imports - these are intentional for CommonJS compatibility
+  // Will be addressed in Phase 3 (breaking changes) - see #708
+  {
+    files: ["package/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-require-imports": "off",
+      "global-require": "off",
+      "import/no-import-module-exports": "off"
+    }
+  },
+
   // Temporary overrides for files with remaining errors
   // See ESLINT_TECHNICAL_DEBT.md for detailed documentation
   //
-  // These overrides suppress ~172 errors that require either:
+  // These overrides suppress ~94 type safety errors that require:
   // 1. Major type refactoring (any/unsafe-* rules)
-  // 2. Potential breaking changes (module system)
-  // 3. Significant code restructuring
+  // 2. Proper type definitions for config objects
   //
-  // GitHub Issues tracking this technical debt:
-  // - #707: TypeScript: Refactor configExporter module for type safety
-  // - #708: Module System: Modernize to ES6 modules with codemod
-  // - #709: Code Style: Fix remaining ESLint style issues
+  // GitHub Issue tracking this technical debt:
+  // - #790: TypeScript ESLint Phase 2b: Type Safety Improvements (~94 errors)
   {
     // Consolidated override for package/config.ts and package/babel/preset.ts
     // Combines rules from both previous override blocks to avoid duplication
     files: ["package/babel/preset.ts", "package/config.ts"],
     rules: {
-      // From first override block
-      "@typescript-eslint/no-require-imports": "off",
       "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/no-unsafe-call": "off",
       "import/order": "off",
       "import/newline-after-import": "off",
       "import/first": "off",
-      // Additional rules that were in the second override for config.ts
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-unsafe-argument": "off",
       "@typescript-eslint/no-explicit-any": "off",
-      "no-useless-escape": "off",
-      "no-continue": "off"
+      "no-useless-escape": "off"
     }
   },
   {
@@ -205,19 +204,14 @@ module.exports = [
       // Code organization (functions before use due to large file)
       "@typescript-eslint/no-use-before-define": "off",
       // Import style (CommonJS require for dynamic imports)
-      "@typescript-eslint/no-require-imports": "off",
       "import/no-dynamic-require": "off",
-      "global-require": "off",
       // Class methods that are part of public API
       "class-methods-use-this": "off",
       // Template expressions (valid use cases with union types)
       "@typescript-eslint/restrict-template-expressions": "off",
       // Style preferences
-      "no-continue": "off",
       "import/prefer-default-export": "off",
-      "no-await-in-loop": "off",
       "no-underscore-dangle": "off",
-      "no-shadow": "off",
       "no-restricted-globals": "off",
       "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/require-await": "off"
@@ -236,20 +230,26 @@ module.exports = [
     }
   },
   {
-    // Remaining utils files (removed package/config.ts from this block)
+    // Remaining utils files that need type safety improvements
+    // These use dynamic requires and helper functions that return `any`
     files: [
       "package/utils/inliningCss.ts",
       "package/utils/errorCodes.ts",
       "package/utils/errorHelpers.ts",
-      "package/utils/pathValidation.ts"
+      "package/utils/pathValidation.ts",
+      "package/utils/getStyleRule.ts",
+      "package/utils/helpers.ts",
+      "package/utils/validateDependencies.ts",
+      "package/webpackDevServerConfig.ts"
     ],
     rules: {
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
       "@typescript-eslint/no-explicit-any": "off",
-      "no-useless-escape": "off",
-      "no-continue": "off"
+      "no-useless-escape": "off"
     }
   },
   {
@@ -257,13 +257,13 @@ module.exports = [
     rules: {
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-redundant-type-constituents": "off",
       "import/prefer-default-export": "off"
     }
   },
   {
     files: [
-      "package/environments/**/*.ts",
       "package/index.ts",
       "package/rspack/index.ts",
       "package/rules/**/*.ts",
@@ -276,6 +276,8 @@ module.exports = [
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-call": "off",
       "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
       "@typescript-eslint/no-redundant-type-constituents": "off",
       "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/no-unsafe-function-type": "off",
@@ -283,6 +285,23 @@ module.exports = [
       "no-underscore-dangle": "off"
     }
   },
+  {
+    // package/environments/**/*.ts now passes no-unused-vars rule
+    // Type test functions use underscore prefix (argsIgnorePattern: "^_")
+    // All other variables are used in the code
+    files: ["package/environments/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-redundant-type-constituents": "off",
+      "@typescript-eslint/no-unsafe-function-type": "off",
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off"
+    }
+  },
 
   // Prettier config must be last to override other configs
   prettierConfig

data/lib/install/config/shakapacker.yml

@@ -19,6 +19,18 @@ default: &default
   #  css_extract_ignore_order_warnings to true
   css_extract_ignore_order_warnings: false
 
+  # CSS Modules export mode
+  # Controls how CSS Module class names are exported in JavaScript
+  # Defaults to 'named' if not specified. Uncomment and change to 'default' for v8 behavior.
+  # Options:
+  #   - named (default): Use named exports with camelCase conversion (v9 default)
+  #     Example: import { button } from './styles.module.css'
+  #   - default: Use default export with both original and camelCase names (v8 behavior)
+  #     Example: import styles from './styles.module.css'
+  # For gradual migration, you can set this to default to maintain v8 behavior
+  # See https://github.com/shakacode/shakapacker/blob/main/docs/css-modules-export-mode.md
+  # css_modules_export_mode: named
+
   public_root_path: public
   public_output_path: packs
   cache_path: tmp/shakapacker
@@ -41,7 +53,8 @@ default: &default
   cache_manifest: false
 
   # Select JavaScript transpiler to use
-  # Available options: 'swc' (default, 20x faster), 'babel', or 'esbuild'
+  # Available options: 'swc' (default, 20x faster), 'babel', 'esbuild', or 'none'
+  # Use 'none' when providing a completely custom webpack configuration
   # Note: When using rspack, swc is used automatically regardless of this setting
   javascript_transpiler: "swc"
 

data/lib/shakapacker/bundler_switcher.rb

@@ -9,6 +9,9 @@ module Shakapacker
     SHAKAPACKER_CONFIG = "config/shakapacker.yml"
     CUSTOM_DEPS_CONFIG = ".shakapacker-switch-bundler-dependencies.yml"
 
+    # Regex pattern to detect assets_bundler key in config (only matches uncommented lines)
+    ASSETS_BUNDLER_PATTERN = /^[ \t]*assets_bundler:/
+
     # Default dependencies for each bundler (package names only, no versions)
     DEFAULT_RSPACK_DEPS = {
       dev: %w[@rspack/cli @rspack/plugin-react-refresh],
@@ -37,18 +40,33 @@ module Shakapacker
       end
 
       current = current_bundler
-      if current == bundler && !install_deps
+      config_content = File.read(config_path)
+      has_assets_bundler = config_content =~ ASSETS_BUNDLER_PATTERN
+
+      # Early exit if already using the target bundler
+      # For webpack: if current is webpack, we're done (key optional due to default)
+      # For rspack: requires explicit key to be present
+      already_configured = if bundler == "webpack"
+        current == bundler
+      else
+        current == bundler && has_assets_bundler
+      end
+
+      if already_configured && !install_deps
         puts "✅ Already using #{bundler}"
         return
       end
 
-      if current == bundler && install_deps
+      if already_configured && install_deps
         puts "✅ Already using #{bundler} - reinstalling dependencies as requested"
         manage_dependencies(bundler, install_deps, switching: false, no_uninstall: no_uninstall)
         return
       end
 
-      update_config(bundler)
+      successfully_updated = update_config(bundler, config_content, has_assets_bundler)
+
+      # Verify the update was successful (only if update reported success)
+      verify_config_update(bundler) if successfully_updated
 
       puts "✅ Switched from #{current} to #{bundler}"
       puts ""
@@ -95,22 +113,15 @@ module Shakapacker
       puts "Current bundler: #{current}"
       puts ""
       puts "Usage:"
-      puts "  rails shakapacker:switch_bundler [webpack|rspack] [OPTIONS]"
       puts "  rake shakapacker:switch_bundler [webpack|rspack] -- [OPTIONS]"
       puts ""
       puts "Options:"
       puts "  --install-deps    Automatically install/uninstall dependencies"
-      puts "  --no-uninstall    Skip uninstalling old bundler packages (faster, keeps both bundlers)"
+      puts "  --no-uninstall    Skip uninstalling old bundler packages"
       puts "  --init-config     Create #{CUSTOM_DEPS_CONFIG} with default dependencies"
       puts "  --help, -h        Show this help message"
       puts ""
       puts "Examples:"
-      puts "  # Using rails command"
-      puts "  rails shakapacker:switch_bundler rspack --install-deps"
-      puts "  rails shakapacker:switch_bundler webpack --install-deps --no-uninstall"
-      puts "  rails shakapacker:switch_bundler --init-config"
-      puts ""
-      puts "  # Using rake command (note the -- separator)"
       puts "  rake shakapacker:switch_bundler rspack -- --install-deps"
       puts "  rake shakapacker:switch_bundler webpack -- --install-deps --no-uninstall"
       puts "  rake shakapacker:switch_bundler -- --init-config"
@@ -150,20 +161,74 @@ module Shakapacker
         end
       end
 
-      def update_config(bundler)
-        content = File.read(config_path)
+      def update_config(bundler, content, has_assets_bundler)
+        # Check if assets_bundler key exists (only uncommented lines)
+        unless has_assets_bundler
+          # Track whether we successfully added the key
+          added = false
+
+          # Add assets_bundler after javascript_transpiler if it exists (excluding commented lines)
+          if (match = content.match(/^[ \t]*(?![ \t]*#)javascript_transpiler:.*$/))
+            indent = match[0][/^[ \t]*/]
+            content.sub!(/^([ \t]*(?![ \t]*#)javascript_transpiler:.*$)/, "\\1\n#{assets_bundler_entry(bundler, indent)}")
+            added = true
+          # Otherwise, add it after source_path if it exists (excluding commented lines)
+          elsif (match = content.match(/^[ \t]*(?![ \t]*#)source_path:.*$/))
+            indent = match[0][/^[ \t]*/]
+            content.sub!(/^([ \t]*(?![ \t]*#)source_path:.*$)/, "\\1\n#{assets_bundler_entry(bundler, indent)}")
+            added = true
+          # Add it after default: &default if it exists
+          elsif content.match?(/^default:[ \t]*&default[ \t]*$/)
+            # Use default 2-space indentation for this case
+            content.sub!(/^(default:[ \t]*&default[ \t]*)$/, "\\1\n#{assets_bundler_entry(bundler, '  ')}")
+            added = true
+          # Fallback: add after "default:" with proper indentation detection (handles blank lines)
+          elsif (match = content.match(/^default:\s*\n\s*([ \t]+)/m))
+            # Extract indentation from first indented line after "default:"
+            indent = match[1]
+            content.sub!(/^(default:\s*)$/, "\\1\n#{assets_bundler_entry(bundler, indent)}")
+            added = true
+          end
 
-        # Replace assets_bundler value (handles spaces, tabs, and various quote styles)
-        # Only matches uncommented lines
-        content.gsub!(/^([ \t]*assets_bundler:[ \t]*['"]?)(webpack|rspack)(['"]?)/, "\\1#{bundler}\\3")
+          unless added
+            puts "⚠️  Warning: Could not find appropriate location for assets_bundler in config"
+            puts "   Please add 'assets_bundler: #{bundler}' to the default section manually"
+          end
+        else
+          # Replace existing assets_bundler value (handles spaces, tabs, and various quote styles)
+          # Only matches uncommented lines
+          content.gsub!(/^([ \t]*)(?![ \t]*#)(assets_bundler:[ \t]*['"]?)(webpack|rspack)(['"]?)/, "\\1\\2#{bundler}\\4")
+          added = true
+        end
 
         # Update javascript_transpiler recommendation for rspack
         # Only update if not already set to swc and only on uncommented lines
-        if bundler == "rspack" && content !~ /^[ \t]*javascript_transpiler:[ \t]*['"]?swc['"]?/
-          content.gsub!(/^([ \t]*javascript_transpiler:[ \t]*['"]?)\w+(['"]?)/, "\\1swc\\2")
+        if bundler == "rspack" && content !~ /^[ \t]*(?![ \t]*#)javascript_transpiler:[ \t]*['"]?swc['"]?/
+          content.gsub!(/^([ \t]*(?![ \t]*#)javascript_transpiler:[ \t]*['"]?)(\w+)(['"]?)/, '\1swc\3')
         end
 
         File.write(config_path, content)
+        added
+      end
+
+      # Verify that the config was updated successfully
+      def verify_config_update(bundler)
+        config = load_yaml_config(config_path)
+        actual_bundler = config.dig("default", "assets_bundler")
+
+        if actual_bundler != bundler
+          raise "Config update verification failed: expected assets_bundler to be '#{bundler}', but got '#{actual_bundler}'"
+        end
+      rescue Psych::SyntaxError => e
+        raise "Config update generated invalid YAML: #{e.message}"
+      end
+
+      # Generate the assets_bundler YAML entry with proper indentation
+      # @param bundler [String] The bundler name ('webpack' or 'rspack')
+      # @param indent [String] The indentation string to use (e.g., '  ' or '\t')
+      # @return [String] The formatted YAML entry
+      def assets_bundler_entry(bundler, indent)
+        "\n#{indent}# Select assets bundler to use\n#{indent}# Available options: 'webpack' (default) or 'rspack'\n#{indent}assets_bundler: \"#{bundler}\""
       end
 
       def manage_dependencies(bundler, install_deps, switching: true, no_uninstall: false)

data/lib/shakapacker/configuration.rb

@@ -339,6 +339,31 @@ class Shakapacker::Configuration
     javascript_transpiler
   end
 
+  # Returns the CSS Modules export mode configuration
+  #
+  # Controls how CSS Module class names are exported in JavaScript:
+  # - "named" (default): Use named exports with camelCase conversion (v9 behavior)
+  # - "default": Use default export with both original and camelCase names (v8 behavior)
+  #
+  # @return [String] "named" or "default"
+  # @raise [ArgumentError] if an invalid value is configured
+  def css_modules_export_mode
+    @css_modules_export_mode ||= begin
+      mode = fetch(:css_modules_export_mode) || "named"
+
+      # Validate the configuration value
+      valid_modes = ["named", "default"]
+      unless valid_modes.include?(mode)
+        raise ArgumentError,
+          "Invalid css_modules_export_mode: '#{mode}'. " \
+          "Valid values are: #{valid_modes.map { |m| "'#{m}'" }.join(', ')}. " \
+          "See https://github.com/shakacode/shakapacker/blob/main/docs/css-modules-export-mode.md"
+      end
+
+      mode
+    end
+  end
+
   # Returns the path to the bundler configuration directory
   #
   # This is where webpack.config.js or rspack.config.js should be located.
@@ -353,6 +378,25 @@ class Shakapacker::Configuration
     rspack? ? "config/rspack" : "config/webpack"
   end
 
+  # Returns the raw configuration data hash
+  #
+  # Returns the merged configuration from the shakapacker.yml file for the current environment.
+  # The hash has symbolized keys loaded from the config file. Individual config values can be
+  # accessed through specific accessor methods like {#source_path}, which apply defaults via {#fetch}.
+  #
+  # The returned hash is frozen to prevent accidental mutations. To access config values,
+  # use the provided accessor methods instead of modifying this hash directly.
+  #
+  # @return [Hash<Symbol, Object>] the raw configuration data with symbolized keys (frozen)
+  # @example
+  #   config.data[:source_path]  #=> "app/javascript"
+  #   config.data[:compile]      #=> true
+  # @note The hash is frozen to prevent mutations. Use accessor methods for safe config access.
+  # @api public
+  def data
+    @data ||= load.freeze
+  end
+
   private
 
     def default_javascript_transpiler
@@ -363,6 +407,9 @@ class Shakapacker::Configuration
     def validate_transpiler_configuration(transpiler)
       return unless ENV["NODE_ENV"] != "test" # Skip validation in test environment
 
+      # Skip validation if transpiler is set to 'none' (custom webpack config)
+      return if transpiler == "none"
+
       # Check if package.json exists
       package_json_path = root_path.join("package.json")
       return unless package_json_path.exist?
@@ -495,10 +542,6 @@ class Shakapacker::Configuration
       [private_full_path.cleanpath.to_s, public_full_path.cleanpath.to_s]
     end
 
-    def data
-      @data ||= load
-    end
-
     def load
       config = begin
         YAML.load_file(config_path.to_s, aliases: true)

data/lib/shakapacker/dev_server_runner.rb

@@ -18,6 +18,8 @@ module Shakapacker
         exit(0)
       end
 
+      Shakapacker.ensure_node_env!
+
       # Check for --build flag
       build_index = argv.index("--build")
       if build_index
@@ -65,6 +67,8 @@ module Shakapacker
     end
 
     def self.run_with_build_config(argv, build_config)
+      Shakapacker.ensure_node_env!
+
       # Apply build config environment variables
       build_config[:environment].each do |key, value|
         ENV[key] = value.to_s

data/lib/shakapacker/doctor.rb

@@ -54,7 +54,7 @@ module Shakapacker
           Shakapacker Doctor - Diagnostic tool for Shakapacker configuration
 
           Usage:
-            bin/rails shakapacker:doctor [options]
+            bundle exec rake shakapacker:doctor [options]
 
           Options:
             --help       Show this help message
@@ -163,7 +163,7 @@ module Shakapacker
           begin
             manifest_content = JSON.parse(File.read(manifest_path))
             if manifest_content.empty?
-              add_warning("Manifest file is empty - you may need to run 'bin/rails assets:precompile'")
+              add_warning("Manifest file is empty - you may need to run 'bundle exec rake assets:precompile'")
             end
           rescue JSON::ParserError
             @issues << "Manifest file #{manifest_path} contains invalid JSON"
@@ -325,16 +325,16 @@ module Shakapacker
           if source_files.any?
             newest_source = source_files.map { |f| File.mtime(f) }.max
             if newest_source > File.mtime(manifest_path)
-              add_warning("Source files have been modified after last asset compilation. Run 'bin/rails assets:precompile'")
+              add_warning("Source files have been modified after last asset compilation. Run 'bundle exec rake assets:precompile'")
             end
           end
         else
           rails_env = defined?(Rails) ? Rails.env : ENV["RAILS_ENV"]
           if rails_env == "production"
-            @issues << "No compiled assets found (manifest.json missing). Run 'bin/rails assets:precompile'"
+            @issues << "No compiled assets found (manifest.json missing). Run 'bundle exec rake assets:precompile'"
           elsif options[:verbose]
             # Only show in verbose mode for non-production environments
-            @info << "Assets not yet compiled. Run 'bin/rails assets:precompile' or start the dev server"
+            @info << "Assets not yet compiled. Run 'bundle exec rake assets:precompile' or start the dev server"
           end
         end
       end
@@ -402,7 +402,7 @@ module Shakapacker
 
         unless missing_binstubs.empty?
           add_action_required("Missing binstubs: #{missing_binstubs.join(', ')}.")
-          add_action_required("  Fix: Run 'bin/rails shakapacker:binstubs' to create them.")
+          add_action_required("  Fix: Run 'bundle exec rake shakapacker:binstubs' to create them.")
         end
       end
 
@@ -914,7 +914,7 @@ module Shakapacker
             return unless doctor.config.config_path.exist?
 
             puts "\nConfiguration values for '#{doctor.config.env}' environment:"
-            config_data = doctor.config.send(:data)
+            config_data = doctor.config.data
 
             if config_data.any?
               print_config_data(config_data)