shakapacker 9.3.0 → 9.3.1

data/package/utils/debug.ts

@@ -18,24 +18,20 @@ const isDebugMode = (): boolean => {
 
 const debug = (message: string, ...args: unknown[]): void => {
   if (isDebugMode()) {
-    // eslint-disable-next-line no-console
     console.log(`[Shakapacker] ${message}`, ...args)
   }
 }
 
 const warn = (message: string, ...args: unknown[]): void => {
-  // eslint-disable-next-line no-console
   console.warn(`[Shakapacker] WARNING: ${message}`, ...args)
 }
 
 const error = (message: string, ...args: unknown[]): void => {
-  // eslint-disable-next-line no-console
   console.error(`[Shakapacker] ERROR: ${message}`, ...args)
 }
 
 const info = (message: string, ...args: unknown[]): void => {
   if (isDebugMode()) {
-    // eslint-disable-next-line no-console
     console.info(`[Shakapacker] INFO: ${message}`, ...args)
   }
 }

data/package/utils/getStyleRule.ts

@@ -1,18 +1,19 @@
-/* eslint global-require: 0 */
+import type { Config } from "../types"
+
 const { canProcess, moduleExists } = require("./helpers")
 const { requireOrError } = require("./requireOrError")
-const config = require("../config")
+const config = require("../config") as Config
 const inliningCss = require("./inliningCss")
 
 interface StyleRule {
   test: RegExp
-  use: any[]
+  use: unknown[]
   type?: string
 }
 
 const getStyleRule = (
   test: RegExp,
-  preprocessors: any[] = []
+  preprocessors: unknown[] = []
 ): StyleRule | null => {
   if (moduleExists("css-loader")) {
     const tryPostcss = () =>
@@ -28,6 +29,11 @@ const getStyleRule = (
         ? requireOrError("@rspack/core").CssExtractRspackPlugin.loader
         : requireOrError("mini-css-extract-plugin").loader
 
+    // Determine CSS Modules export mode based on configuration
+    // 'named' (default): Use named exports with camelCaseOnly (v9 behavior)
+    // 'default': Use default exports with camelCase (v8 behavior)
+    const useNamedExports = config.css_modules_export_mode !== "default"
+
     const use = [
       inliningCss ? "style-loader" : extractionPlugin,
       {
@@ -37,11 +43,13 @@ const getStyleRule = (
           importLoaders: 2,
           modules: {
             auto: true,
-            // v9 defaults: Use named exports with camelCase conversion
-            // Note: css-loader requires 'camelCaseOnly' or 'dashesOnly' when namedExport is true
-            // Using 'camelCase' with namedExport: true causes a build error
-            namedExport: true,
-            exportLocalsConvention: "camelCaseOnly"
+            // Use named exports for v9 (default), or default exports for v8 compatibility
+            namedExport: useNamedExports,
+            // 'camelCaseOnly' with namedExport: true (v9 default)
+            // 'camelCase' with namedExport: false (v8 behavior - exports both original and camelCase)
+            exportLocalsConvention: useNamedExports
+              ? "camelCaseOnly"
+              : "camelCase"
           }
         }
       },

data/package/utils/helpers.ts

@@ -38,6 +38,11 @@ const loaderMatches = <T = unknown>(
   loaderToCheck: string,
   fn: () => T
 ): T | null => {
+  // If transpiler is set to 'none', skip all transpiler rules (for custom webpack configs)
+  if (configLoader === "none") {
+    return null
+  }
+
   if (configLoader !== loaderToCheck) {
     return null
   }
@@ -60,13 +65,13 @@ const loaderMatches = <T = unknown>(
 const packageFullVersion = (packageName: string): string => {
   try {
     const packageJsonPath = require.resolve(`${packageName}/package.json`)
-    // eslint-disable-next-line import/no-dynamic-require, global-require
+    // eslint-disable-next-line import/no-dynamic-require
     const packageJson = require(packageJsonPath) as { version: string }
     return packageJson.version
-  } catch (error: any) {
+  } catch (error: unknown) {
     // Re-throw the error with proper code to maintain compatibility with babel preset
     // The preset expects MODULE_NOT_FOUND errors to handle missing core-js gracefully
-    if (error.code === "MODULE_NOT_FOUND") {
+    if ((error as NodeJS.ErrnoException).code === "MODULE_NOT_FOUND") {
       throw error
     }
     // For other errors, warn and re-throw

data/package/utils/pathValidation.ts

@@ -138,17 +138,16 @@ export function validatePaths(paths: string[], basePath: string): string[] {
       console.warn(
         `[SHAKAPACKER WARNING] Skipping potentially unsafe path: ${userPath}`
       )
-      continue
-    }
-
-    try {
-      const safePath = safeResolvePath(basePath, userPath)
-      validatedPaths.push(safePath)
-    } catch (error) {
-      console.warn(
-        `[SHAKAPACKER WARNING] Invalid path configuration: ${userPath}\n` +
-          `Error: ${error instanceof Error ? error.message : String(error)}`
-      )
+    } else {
+      try {
+        const safePath = safeResolvePath(basePath, userPath)
+        validatedPaths.push(safePath)
+      } catch (error) {
+        console.warn(
+          `[SHAKAPACKER WARNING] Invalid path configuration: ${userPath}\n` +
+            `Error: ${error instanceof Error ? error.message : String(error)}`
+        )
+      }
     }
   }
 

data/package/utils/requireOrError.ts

@@ -1,12 +1,13 @@
-/* eslint global-require: 0 */
 /* eslint import/no-dynamic-require: 0 */
-const config = require("../config")
+import type { Config } from "../types"
+
+const config = require("../config") as Config
 
 interface ErrorWithCause extends Error {
   cause?: unknown
 }
 
-const requireOrError = (moduleName: string): any => {
+const requireOrError = (moduleName: string): unknown => {
   try {
     return require(moduleName)
   } catch (originalError: unknown) {

data/package/webpackDevServerConfig.ts

@@ -25,11 +25,11 @@ interface WebpackDevServerConfig {
     [key: string]: unknown
   }
   client?: Record<string, unknown>
-  allowedHosts?: "all" | "auto" | string | string[]
+  allowedHosts?: string | string[]
   bonjour?: boolean | Record<string, unknown>
   compress?: boolean
   headers?: Record<string, unknown> | (() => Record<string, unknown>)
-  host?: "local-ip" | "local-ipv4" | "local-ipv6" | string
+  host?: string
   http2?: boolean
   https?: boolean | Record<string, unknown>
   ipc?: boolean | string
@@ -42,12 +42,12 @@ interface WebpackDevServerConfig {
     | string[]
     | Record<string, unknown>
     | Record<string, unknown>[]
-  port?: "auto" | string | number
+  port?: string | number
   proxy?: unknown
   server?: string | boolean | Record<string, unknown>
   setupExitSignals?: boolean
   setupMiddlewares?: (middlewares: unknown[], devServer: unknown) => unknown[]
-  watchFiles?: string | string[] | unknown
+  watchFiles?: unknown
   webSocketServer?: string | boolean | Record<string, unknown>
   [key: string]: unknown
 }

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "9.3.0",
+  "version": "9.3.1",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {

data/test/package/transpiler-defaults.test.js

@@ -124,4 +124,46 @@ describe("JavaScript Transpiler Defaults", () => {
       expect(config.javascript_transpiler).toBe("swc")
     })
   })
+
+  describe("none transpiler option", () => {
+    it("accepts 'none' as a valid transpiler value", () => {
+      process.env.SHAKAPACKER_JAVASCRIPT_TRANSPILER = "none"
+
+      jest.resetModules()
+      const config = require("../../package/config")
+
+      expect(config.javascript_transpiler).toBe("none")
+    })
+
+    it("'none' option doesn't throw errors for missing transpiler packages", () => {
+      process.env.SHAKAPACKER_JAVASCRIPT_TRANSPILER = "none"
+
+      jest.resetModules()
+
+      // Should not throw even though there's no 'none-loader' package
+      expect(() => {
+        require("../../package/config")
+      }).not.toThrow()
+    })
+
+    it("'none' option results in no transpiler rules being applied", () => {
+      process.env.SHAKAPACKER_JAVASCRIPT_TRANSPILER = "none"
+      delete process.env.SHAKAPACKER_ASSETS_BUNDLER
+
+      jest.resetModules()
+
+      // Load the webpack rules - should not include babel, swc, or esbuild rules
+      const rules = require("../../package/rules/webpack")
+
+      // Verify no transpiler rules are present by checking rules array
+      // When transpiler is 'none', loaderMatches returns null for all transpilers
+      // which means babel.ts, swc.ts, and esbuild.ts all export null
+      // These get filtered out, so rules array should not contain them
+      const rulesJson = JSON.stringify(rules)
+
+      expect(rulesJson).not.toContain("babel-loader")
+      expect(rulesJson).not.toContain("swc-loader")
+      expect(rulesJson).not.toContain("esbuild-loader")
+    })
+  })
 })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 9.3.0
+  version: 9.3.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -131,11 +131,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".claude/commands/update-changelog.md"
 - ".github/FUNDING.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/STATUS.md"
+- ".github/actionlint-matcher.json"
 - ".github/workflows/claude-code-review.yml"
 - ".github/workflows/claude.yml"
 - ".github/workflows/dummy.yml"
@@ -171,6 +173,7 @@ files:
 - conductor.json
 - config/README.md
 - config/shakapacker.yml
+- docs/api-reference.md
 - docs/cdn_setup.md
 - docs/common-upgrades.md
 - docs/configuration.md
@@ -386,7 +389,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.3.0
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.3.1
 rdoc_options: []
 require_paths:
 - lib