shakapacker 9.3.0.beta.7 → 9.3.1

data/eslint.config.js

@@ -19,14 +19,18 @@ module.exports = [
       "vendor/**", // Vendored dependencies
       "spec/**", // Ruby specs, not JavaScript
       "package/**/*.js", // Generated/compiled JavaScript from TypeScript
-      "package/**/*.d.ts", // Generated TypeScript declaration files
-      // Temporarily ignore TypeScript files until technical debt is resolved
-      // See ESLINT_TECHNICAL_DEBT.md for tracking
-      // TODO: Remove this once ESLint issues are fixed (tracked in #723)
-      "package/**/*.ts"
+      "package/**/*.d.ts" // Generated TypeScript declaration files
     ]
   },
 
+  // Global linter options
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: "error",
+      reportUnusedInlineConfigs: "error"
+    }
+  },
+
   // Base config for all JS files
   ...compat.extends("airbnb"),
   {
@@ -132,10 +136,10 @@ module.exports = [
       // Disable base rule in favor of TypeScript version
       "no-use-before-define": "off",
       "@typescript-eslint/no-use-before-define": ["error"],
-      // Allow unused vars if they start with underscore (convention for ignored params)
+      // Allow unused vars if they start with underscore (convention for ignored params and type tests)
       "@typescript-eslint/no-unused-vars": [
         "error",
-        { argsIgnorePattern: "^_" }
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }
       ],
       // Strict: no 'any' types allowed - use 'unknown' or specific types instead
       "@typescript-eslint/no-explicit-any": "error",
@@ -147,72 +151,105 @@ module.exports = [
     }
   },
 
+  // Global rule for all TypeScript files in package/
+  // Suppress require() imports - these are intentional for CommonJS compatibility
+  // Will be addressed in Phase 3 (breaking changes) - see #708
+  {
+    files: ["package/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-require-imports": "off",
+      "global-require": "off",
+      "import/no-import-module-exports": "off"
+    }
+  },
+
   // Temporary overrides for files with remaining errors
   // See ESLINT_TECHNICAL_DEBT.md for detailed documentation
   //
-  // These overrides suppress ~172 errors that require either:
+  // These overrides suppress ~94 type safety errors that require:
   // 1. Major type refactoring (any/unsafe-* rules)
-  // 2. Potential breaking changes (module system)
-  // 3. Significant code restructuring
+  // 2. Proper type definitions for config objects
   //
-  // GitHub Issues tracking this technical debt:
-  // - #707: TypeScript: Refactor configExporter module for type safety
-  // - #708: Module System: Modernize to ES6 modules with codemod
-  // - #709: Code Style: Fix remaining ESLint style issues
+  // GitHub Issue tracking this technical debt:
+  // - #790: TypeScript ESLint Phase 2b: Type Safety Improvements (~94 errors)
   {
     // Consolidated override for package/config.ts and package/babel/preset.ts
     // Combines rules from both previous override blocks to avoid duplication
     files: ["package/babel/preset.ts", "package/config.ts"],
     rules: {
-      // From first override block
-      "@typescript-eslint/no-require-imports": "off",
       "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/no-unsafe-call": "off",
       "import/order": "off",
       "import/newline-after-import": "off",
       "import/first": "off",
-      // Additional rules that were in the second override for config.ts
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-unsafe-argument": "off",
       "@typescript-eslint/no-explicit-any": "off",
-      "no-useless-escape": "off",
-      "no-continue": "off"
+      "no-useless-escape": "off"
     }
   },
   {
+    // #707: Significant type safety improvements in configExporter module!
+    // - configFile.ts: ✅ Fully type-safe (0 type errors)
+    // - buildValidator.ts: ✅ Fully type-safe (0 type errors)
+    // - yamlSerializer.ts: ✅ Fully type-safe (0 type errors)
+    // - cli.ts: ⚠️ Partial (dynamic webpack config loading requires some `any`)
+    //
+    // Remaining overrides are for:
+    // 1. Code style/organization (not type safety)
+    // 2. Dynamic require() in cli.ts for webpack config loading
     files: ["package/configExporter/**/*.ts"],
+    rules: {
+      // Code organization (functions before use due to large file)
+      "@typescript-eslint/no-use-before-define": "off",
+      // Import style (CommonJS require for dynamic imports)
+      "import/no-dynamic-require": "off",
+      // Class methods that are part of public API
+      "class-methods-use-this": "off",
+      // Template expressions (valid use cases with union types)
+      "@typescript-eslint/restrict-template-expressions": "off",
+      // Style preferences
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off",
+      "no-restricted-globals": "off",
+      "@typescript-eslint/no-unused-vars": "off",
+      "@typescript-eslint/require-await": "off"
+    }
+  },
+  {
+    // cli.ts: Dynamic webpack config loading requires `any` types
+    // This is acceptable as webpack configs can have any shape
+    files: ["package/configExporter/cli.ts"],
     rules: {
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "@typescript-eslint/no-unsafe-function-type": "off",
-      "@typescript-eslint/no-unused-vars": "off",
-      "@typescript-eslint/require-await": "off",
-      "no-await-in-loop": "off",
-      "import/prefer-default-export": "off",
-      "global-require": "off",
-      "no-underscore-dangle": "off"
+      "@typescript-eslint/no-unsafe-return": "off"
     }
   },
   {
-    // Remaining utils files (removed package/config.ts from this block)
+    // Remaining utils files that need type safety improvements
+    // These use dynamic requires and helper functions that return `any`
     files: [
       "package/utils/inliningCss.ts",
       "package/utils/errorCodes.ts",
       "package/utils/errorHelpers.ts",
-      "package/utils/pathValidation.ts"
+      "package/utils/pathValidation.ts",
+      "package/utils/getStyleRule.ts",
+      "package/utils/helpers.ts",
+      "package/utils/validateDependencies.ts",
+      "package/webpackDevServerConfig.ts"
     ],
     rules: {
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
       "@typescript-eslint/no-explicit-any": "off",
-      "no-useless-escape": "off",
-      "no-continue": "off"
+      "no-useless-escape": "off"
     }
   },
   {
@@ -220,13 +257,13 @@ module.exports = [
     rules: {
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
       "@typescript-eslint/no-redundant-type-constituents": "off",
       "import/prefer-default-export": "off"
     }
   },
   {
     files: [
-      "package/environments/**/*.ts",
       "package/index.ts",
       "package/rspack/index.ts",
       "package/rules/**/*.ts",
@@ -239,6 +276,8 @@ module.exports = [
       "@typescript-eslint/no-unsafe-assignment": "off",
       "@typescript-eslint/no-unsafe-call": "off",
       "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
       "@typescript-eslint/no-redundant-type-constituents": "off",
       "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/no-unsafe-function-type": "off",
@@ -246,6 +285,23 @@ module.exports = [
       "no-underscore-dangle": "off"
     }
   },
+  {
+    // package/environments/**/*.ts now passes no-unused-vars rule
+    // Type test functions use underscore prefix (argsIgnorePattern: "^_")
+    // All other variables are used in the code
+    files: ["package/environments/**/*.ts"],
+    rules: {
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-redundant-type-constituents": "off",
+      "@typescript-eslint/no-unsafe-function-type": "off",
+      "import/prefer-default-export": "off",
+      "no-underscore-dangle": "off"
+    }
+  },
 
   // Prettier config must be last to override other configs
   prettierConfig

data/knip.ts

@@ -47,7 +47,14 @@ const config: KnipConfig = {
     "css-loader",
     "esbuild-loader",
     "swc-loader",
-    "webpack"
+    "webpack",
+    // eslint-config-airbnb isn't detected because it's used by compat.extends("airbnb"),
+    // the rest are its peerDependencies
+    "eslint-config-airbnb",
+    "eslint-plugin-import",
+    "eslint-plugin-jsx-a11y",
+    "eslint-plugin-react",
+    "eslint-plugin-react-hooks"
   ]
 }
 

data/lib/install/config/shakapacker.yml

@@ -19,6 +19,18 @@ default: &default
   #  css_extract_ignore_order_warnings to true
   css_extract_ignore_order_warnings: false
 
+  # CSS Modules export mode
+  # Controls how CSS Module class names are exported in JavaScript
+  # Defaults to 'named' if not specified. Uncomment and change to 'default' for v8 behavior.
+  # Options:
+  #   - named (default): Use named exports with camelCase conversion (v9 default)
+  #     Example: import { button } from './styles.module.css'
+  #   - default: Use default export with both original and camelCase names (v8 behavior)
+  #     Example: import styles from './styles.module.css'
+  # For gradual migration, you can set this to default to maintain v8 behavior
+  # See https://github.com/shakacode/shakapacker/blob/main/docs/css-modules-export-mode.md
+  # css_modules_export_mode: named
+
   public_root_path: public
   public_output_path: packs
   cache_path: tmp/shakapacker
@@ -41,7 +53,8 @@ default: &default
   cache_manifest: false
 
   # Select JavaScript transpiler to use
-  # Available options: 'swc' (default, 20x faster), 'babel', or 'esbuild'
+  # Available options: 'swc' (default, 20x faster), 'babel', 'esbuild', or 'none'
+  # Use 'none' when providing a completely custom webpack configuration
   # Note: When using rspack, swc is used automatically regardless of this setting
   javascript_transpiler: "swc"
 
@@ -67,9 +80,8 @@ default: &default
   compiler_strategy: digest
 
   # Select whether the compiler will always use a content hash and not just in production
-  # Don't use contentHash except for production for performance
-  # https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling
-  useContentHash: false
+  # Content hashes are recommended for production cache busting
+  useContentHash: true
 
   # Setting the asset host here will override Rails.application.config.asset_host.
   # Here, you can set different asset_host per environment. Note that
@@ -101,6 +113,10 @@ development:
   compile: true
   compiler_strategy: mtime
 
+  # Disable content hashes in development for faster builds
+  # https://webpack.js.org/guides/caching/
+  useContentHash: false
+
   # Early hints disabled by default in development
   # To enable: Set enabled: true AND start Puma with: bundle exec puma --early-hints
   # See docs/early_hints_new_api.md for setup instructions
@@ -164,9 +180,6 @@ production:
   # Production depends on precompilation of packs prior to booting for performance.
   compile: false
 
-  # Use content hash for naming assets. Cannot be overridden in production.
-  useContentHash: true
-
   # Cache manifest.json for performance
   cache_manifest: true