shakapacker 9.3.0.beta.7 → 9.3.0

data/test/package/configExporter.test.js

@@ -105,6 +105,223 @@ describe("configExporter", () => {
     })
   })
 
+  describe("yamlSerializer", () => {
+    test("serializes object keys in alphabetical order", () => {
+      const {
+        YamlSerializer
+      } = require("../../package/configExporter/yamlSerializer")
+      const serializer = new YamlSerializer({
+        annotate: false,
+        appRoot: "/test/app"
+      })
+
+      // Create an object with keys intentionally out of alphabetical order
+      const config = {
+        mode: "production",
+        entry: "./src/index.js",
+        optimization: {
+          minimize: true
+        },
+        output: {
+          path: "/dist",
+          filename: "bundle.js"
+        },
+        devtool: "source-map"
+      }
+
+      const metadata = {
+        exportedAt: "2025-10-28",
+        environment: "production",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      // Extract just the config part (skip the header)
+      const lines = result.split("\n")
+      const keyMatches = lines
+        .map((line) => line.match(/^(\w+):/))
+        .filter(Boolean)
+        .map((match) => match[1])
+
+      // Expected order: devtool, entry, mode, optimization, output
+      expect(keyMatches).toStrictEqual([
+        "devtool",
+        "entry",
+        "mode",
+        "optimization",
+        "output"
+      ])
+    })
+
+    test("serializes nested object keys in alphabetical order", () => {
+      const {
+        YamlSerializer
+      } = require("../../package/configExporter/yamlSerializer")
+      const serializer = new YamlSerializer({
+        annotate: false,
+        appRoot: "/test/app"
+      })
+
+      const config = {
+        output: {
+          path: "/dist",
+          filename: "bundle.js",
+          clean: true
+        }
+      }
+
+      const metadata = {
+        exportedAt: "2025-10-28",
+        environment: "production",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      // Extract nested keys from the output section
+      const lines = result.split("\n")
+      const outputKeys = lines
+        .map((line) => line.match(/^ {2}(\w+):/))
+        .filter(Boolean)
+        .map((match) => match[1])
+
+      // Expected order: clean, filename, path
+      expect(outputKeys).toStrictEqual(["clean", "filename", "path"])
+    })
+
+    test("quotes strings containing square brackets", () => {
+      const {
+        YamlSerializer
+      } = require("../../package/configExporter/yamlSerializer")
+      const yaml = require("js-yaml")
+
+      const serializer = new YamlSerializer({
+        annotate: false,
+        appRoot: process.cwd()
+      })
+
+      const testConfig = {
+        options: {
+          modules: {
+            localIdentName: "[name]-[local]__[contenthash]"
+          }
+        }
+      }
+
+      const metadata = {
+        exportedAt: new Date().toISOString(),
+        environment: "test",
+        bundler: "webpack",
+        configType: "test",
+        configCount: 1
+      }
+
+      const yamlOutput = serializer.serialize(testConfig, metadata)
+
+      // Verify YAML can be parsed without errors
+      expect(() => yaml.load(yamlOutput)).not.toThrow()
+
+      // Verify the parsed value matches the original
+      const parsed = yaml.load(yamlOutput)
+      expect(parsed.options.modules.localIdentName).toBe(
+        "[name]-[local]__[contenthash]"
+      )
+    })
+
+    test("quotes RegExp strings containing special characters", () => {
+      const {
+        YamlSerializer
+      } = require("../../package/configExporter/yamlSerializer")
+      const yaml = require("js-yaml")
+
+      const serializer = new YamlSerializer({
+        annotate: false,
+        appRoot: process.cwd()
+      })
+
+      const testConfig = {
+        options: {
+          modules: {
+            localIdentRegExp: /([^/-]+|[^/]+)(?:-styles)?.module.scss$/,
+            localIdentName: "[name]-[local]__[contenthash]"
+          }
+        }
+      }
+
+      const metadata = {
+        exportedAt: new Date().toISOString(),
+        environment: "test",
+        bundler: "webpack",
+        configType: "test",
+        configCount: 1
+      }
+
+      const yamlOutput = serializer.serialize(testConfig, metadata)
+
+      // Verify YAML can be parsed without errors
+      expect(() => yaml.load(yamlOutput)).not.toThrow()
+
+      // Verify the parsed values match the originals
+      const parsed = yaml.load(yamlOutput)
+      expect(parsed.options.modules.localIdentName).toBe(
+        "[name]-[local]__[contenthash]"
+      )
+      // RegExp becomes a string in YAML
+      expect(parsed.options.modules.localIdentRegExp).toBe(
+        "([^/-]+|[^/]+)(?:-styles)?.module.scss$"
+      )
+    })
+
+    test("quotes strings with YAML special characters", () => {
+      const {
+        YamlSerializer
+      } = require("../../package/configExporter/yamlSerializer")
+      const yaml = require("js-yaml")
+
+      const serializer = new YamlSerializer({
+        annotate: false,
+        appRoot: process.cwd()
+      })
+
+      // Test various YAML special characters
+      const testConfig = {
+        curlyBraces: "{value}",
+        asterisk: "*value*",
+        ampersand: "&value",
+        exclamation: "!important",
+        atSign: "@import",
+        backtick: "`value`"
+      }
+
+      const metadata = {
+        exportedAt: new Date().toISOString(),
+        environment: "test",
+        bundler: "webpack",
+        configType: "test",
+        configCount: 1
+      }
+
+      const yamlOutput = serializer.serialize(testConfig, metadata)
+
+      // Verify YAML can be parsed without errors
+      expect(() => yaml.load(yamlOutput)).not.toThrow()
+
+      // Verify all special characters are preserved
+      const parsed = yaml.load(yamlOutput)
+      expect(parsed.curlyBraces).toBe("{value}")
+      expect(parsed.asterisk).toBe("*value*")
+      expect(parsed.ampersand).toBe("&value")
+      expect(parsed.exclamation).toBe("!important")
+      expect(parsed.atSign).toBe("@import")
+      expect(parsed.backtick).toBe("`value`")
+    })
+  })
+
   describe("environment variable preservation in runDoctorMode", () => {
     let originalEnv
 
@@ -192,4 +409,51 @@ describe("configExporter", () => {
       expect(process.env.SERVER_BUNDLE_ONLY).toBeUndefined()
     })
   })
+
+  describe("argument validation", () => {
+    let mockExit
+
+    beforeEach(() => {
+      // Mock process.exit to prevent yargs from killing the test process
+      mockExit = jest.spyOn(process, "exit").mockImplementation(() => {
+        throw new Error("process.exit called")
+      })
+    })
+
+    afterEach(() => {
+      mockExit.mockRestore()
+    })
+
+    test("rejects --all-builds with --output", () => {
+      const { parseArguments } = require("../../package/configExporter/cli")
+
+      expect(() => {
+        parseArguments(["--all-builds", "--output=config.yml"])
+      }).toThrow("process.exit called")
+    })
+
+    test("rejects --all-builds with --stdout", () => {
+      const { parseArguments } = require("../../package/configExporter/cli")
+
+      expect(() => {
+        parseArguments(["--all-builds", "--stdout"])
+      }).toThrow("process.exit called")
+    })
+
+    test("rejects --stdout with --output", () => {
+      const { parseArguments } = require("../../package/configExporter/cli")
+
+      expect(() => {
+        parseArguments(["--stdout", "--output=config.yml"])
+      }).toThrow("process.exit called")
+    })
+
+    test("allows --all-builds with --save-dir", () => {
+      const { parseArguments } = require("../../package/configExporter/cli")
+
+      expect(() => {
+        parseArguments(["--all-builds", "--save-dir=./configs"])
+      }).not.toThrow()
+    })
+  })
 })

data/test/package/yamlSerializer.test.js

@@ -0,0 +1,204 @@
+const {
+  YamlSerializer
+} = require("../../package/configExporter/yamlSerializer")
+
+describe("YamlSerializer", () => {
+  let serializer
+
+  beforeEach(() => {
+    serializer = new YamlSerializer({
+      annotate: false,
+      appRoot: "/test/app"
+    })
+  })
+
+  describe("serialize", () => {
+    test("includes metadata header in serialized output", () => {
+      const config = { mode: "development" }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("# Webpack/Rspack Configuration Export")
+      expect(result).toContain("# Generated: 2025-01-15T12:00:00Z")
+      expect(result).toContain("# Environment: development")
+      expect(result).toContain("# Bundler: webpack")
+      expect(result).toContain("# Config Type: client")
+      expect(result).toContain("mode: development")
+    })
+
+    test("includes config count when multiple configs present", () => {
+      const config = { mode: "production" }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "production",
+        bundler: "rspack",
+        configType: "server",
+        configCount: 3
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("# Total Configs: 3")
+    })
+
+    test("omits config count when only one config present", () => {
+      const config = { mode: "production" }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "production",
+        bundler: "rspack",
+        configType: "server",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).not.toContain("# Total Configs:")
+    })
+
+    test("serializes simple objects correctly", () => {
+      const config = {
+        mode: "development",
+        devtool: "source-map"
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("mode: development")
+      expect(result).toContain("devtool: source-map")
+    })
+
+    test("serializes nested objects", () => {
+      const config = {
+        output: {
+          path: "/dist",
+          filename: "bundle.js"
+        }
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("output:")
+      expect(result).toContain("path: /dist")
+      expect(result).toContain("filename: bundle.js")
+    })
+
+    test("handles empty objects with constructor names", () => {
+      class CustomPlugin {}
+      const config = {
+        plugins: [new CustomPlugin()]
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("plugins:")
+      expect(result).toContain("CustomPlugin")
+    })
+
+    test("serializes arrays", () => {
+      const config = {
+        entry: ["./src/index.js", "./src/app.js"]
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("entry:")
+      expect(result).toContain("- ./src/index.js")
+      expect(result).toContain("- ./src/app.js")
+    })
+
+    test("handles functions in config", () => {
+      const config = {
+        output: {
+          filename() {
+            return "bundle.js"
+          }
+        }
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      expect(result).toContain("output:")
+      expect(result).toContain("filename: |")
+      expect(result).toContain("filename()")
+    })
+
+    test("handles RegExp in config without flags", () => {
+      const config = {
+        test: /\.js$/
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      // RegExp objects serialize as their pattern without slashes
+      expect(result).toContain("test: \\.js$")
+    })
+
+    test("handles RegExp with flags in config", () => {
+      const config = {
+        test: /\.js$/i
+      }
+      const metadata = {
+        exportedAt: "2025-01-15T12:00:00Z",
+        environment: "development",
+        bundler: "webpack",
+        configType: "client",
+        configCount: 1
+      }
+
+      const result = serializer.serialize(config, metadata)
+
+      // RegExp with flags includes flags as inline comment
+      expect(result).toContain("test: \\.js$ # flags: i")
+    })
+  })
+})

data/test/typescript/pathValidation.test.js

@@ -63,6 +63,50 @@ describe("Path Validation Security", () => {
         safeResolvePath(basePath, maliciousPath)
       }).toThrow("Path traversal attempt detected")
     })
+
+    it("rethrows non-ENOENT errors for better security", () => {
+      const fs = require("fs")
+
+      // Mock fs.realpathSync to throw EACCES (permission denied)
+      const realpathSyncSpy = jest
+        .spyOn(fs, "realpathSync")
+        .mockImplementation(() => {
+          const error = new Error("Permission denied")
+          error.code = "EACCES"
+          throw error
+        })
+
+      const basePath = path.join(path.sep, "app")
+      const userPath = path.join("src", "index.js")
+
+      expect(() => {
+        safeResolvePath(basePath, userPath)
+      }).toThrow("Permission denied")
+
+      // Restore original function
+      realpathSyncSpy.mockRestore()
+    })
+
+    it("handles errors without code property gracefully", () => {
+      const fs = require("fs")
+
+      // Mock fs.realpathSync to throw error without code property
+      const realpathSyncSpy = jest
+        .spyOn(fs, "realpathSync")
+        .mockImplementation(() => {
+          throw new Error("Unknown error")
+        })
+
+      const basePath = path.join(path.sep, "app")
+      const userPath = path.join("src", "index.js")
+
+      expect(() => {
+        safeResolvePath(basePath, userPath)
+      }).toThrow("Unknown error")
+
+      // Restore original function
+      realpathSyncSpy.mockRestore()
+    })
   })
 
   describe("validatePaths", () => {

data/test/typescript/requireOrError.test.js

@@ -0,0 +1,49 @@
+// Tests for requireOrError utility
+const { requireOrError } = require("../../package/utils/requireOrError")
+
+describe("requireOrError", () => {
+  describe("successful require", () => {
+    it("returns the required module", () => {
+      const result = requireOrError("path")
+      expect(result).toBeDefined()
+      expect(typeof result.join).toBe("function")
+    })
+  })
+
+  describe("failed require", () => {
+    it("throws error with helpful message when module not found", () => {
+      expect(() => {
+        requireOrError("nonexistent-module-that-does-not-exist")
+      }).toThrow("[SHAKAPACKER]")
+      expect(() => {
+        requireOrError("nonexistent-module-that-does-not-exist")
+      }).toThrow("is required for")
+    })
+
+    it("includes original error as cause for debugging", () => {
+      let caughtError
+      try {
+        requireOrError("nonexistent-module-that-does-not-exist")
+      } catch (error) {
+        caughtError = error
+      }
+
+      expect(caughtError).toBeDefined()
+      expect(caughtError.cause).toBeDefined()
+      expect(caughtError.cause.code).toBe("MODULE_NOT_FOUND")
+    })
+
+    it("preserves original error stack in cause", () => {
+      let caughtError
+      try {
+        requireOrError("another-nonexistent-module")
+      } catch (error) {
+        caughtError = error
+      }
+
+      expect(caughtError.cause).toBeDefined()
+      expect(caughtError.cause.stack).toBeDefined()
+      expect(typeof caughtError.cause.stack).toBe("string")
+    })
+  })
+})

data/yarn.lock

@@ -972,11 +972,6 @@
   resolved "https://registry.npmjs.org/@oxc-resolver/binding-win32-x64-msvc/-/binding-win32-x64-msvc-11.9.0.tgz#3e8127b5c225cb2d99b991f251768188efbda25f"
   integrity sha512-gE3QJvhh0Yj9cSAkkHjRLKPmC7BTJeiaB5YyhVKVUwbnWQgTszV92lZ9pvZtNPEghP7jPbhEs4c6983A0ojQwA==
 
-"@pkgr/core@^0.2.9":
-  version "0.2.9"
-  resolved "https://registry.npmjs.org/@pkgr/core/-/core-0.2.9.tgz#d229a7b7f9dac167a156992ef23c7f023653f53b"
-  integrity sha512-QNqXyfVS2wm9hweSYD2O7F0G06uurj9kZ96TRQE5Y9hU7+tgdZwIkbAKc5Ocy1HxEY2kuDQa6cQ1WRs/O5LFKA==
-
 "@polka/url@^1.0.0-next.24":
   version "1.0.0-next.29"
   resolved "https://registry.npmjs.org/@polka/url/-/url-1.0.0-next.29.tgz#5a40109a1ab5f84d6fd8fc928b19f367cbe7e7b1"
@@ -3027,14 +3022,6 @@ eslint-plugin-jsx-a11y@^6.10.2:
     safe-regex-test "^1.0.3"
     string.prototype.includes "^2.0.1"
 
-eslint-plugin-prettier@^5.5.4:
-  version "5.5.4"
-  resolved "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-5.5.4.tgz#9d61c4ea11de5af704d4edf108c82ccfa7f2e61c"
-  integrity sha512-swNtI95SToIz05YINMA6Ox5R057IMAmWZ26GqPxusAp1TZzj+IdY9tXNWWD3vkF/wEqydCONcwjTFpxybBqZsg==
-  dependencies:
-    prettier-linter-helpers "^1.0.0"
-    synckit "^0.11.7"
-
 eslint-plugin-react-hooks@^7.0.0:
   version "7.0.0"
   resolved "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-7.0.0.tgz#a255a1db826ea42b0e37f160430e4bd0b4b659f9"
@@ -3293,11 +3280,6 @@ fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
   resolved "https://registry.npmjs.org/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
   integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==
 
-fast-diff@^1.1.2:
-  version "1.3.0"
-  resolved "https://registry.npmjs.org/fast-diff/-/fast-diff-1.3.0.tgz#ece407fa550a64d638536cd727e129c61616e0f0"
-  integrity sha512-VxPP4NqbUjj6MaAOafWeUn2cXWLcCtljklUtZf0Ind4XQ+QPtmA0b18zZy0jIQx+ExRVCR/ZQpBmik5lXshNsw==
-
 fast-glob@^3.3.2, fast-glob@^3.3.3:
   version "3.3.3"
   resolved "https://registry.npmjs.org/fast-glob/-/fast-glob-3.3.3.tgz#d06d585ce8dba90a16b0505c543c3ccfb3aeb818"
@@ -5458,13 +5440,6 @@ prelude-ls@^1.2.1:
   resolved "https://registry.npmjs.org/prelude-ls/-/prelude-ls-1.2.1.tgz#debc6489d7a6e6b0e7611888cec880337d316396"
   integrity sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g==
 
-prettier-linter-helpers@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.npmjs.org/prettier-linter-helpers/-/prettier-linter-helpers-1.0.0.tgz#d23d41fe1375646de2d0104d3454a3008802cf7b"
-  integrity sha512-GbK2cP9nraSSUF9N2XwUwqfzlAFlMNYYl+ShE/V+H8a9uNl/oUqB1w2EL54Jh0OlyRSd8RfWYJ3coVS4TROP2w==
-  dependencies:
-    fast-diff "^1.1.2"
-
 prettier@^3.2.5:
   version "3.6.2"
   resolved "https://registry.npmjs.org/prettier/-/prettier-3.6.2.tgz#ccda02a1003ebbb2bfda6f83a074978f608b9393"
@@ -6306,13 +6281,6 @@ swc-loader@^0.1.15:
   resolved "https://registry.npmjs.org/swc-loader/-/swc-loader-0.1.16.tgz#4c718d698e518f3e6ceb9f7872c1855cdb187066"
   integrity sha512-NKIm8aJjK/z/yfzk+v7YGwJMjBKaLaUs9ZKI2zoaIGKAjtkwjO92ZLI0fiTZuwzRqVLQl/29fBdSgFCBzquR0w==
 
-synckit@^0.11.7:
-  version "0.11.11"
-  resolved "https://registry.npmjs.org/synckit/-/synckit-0.11.11.tgz#c0b619cf258a97faa209155d9cd1699b5c998cb0"
-  integrity sha512-MeQTA1r0litLUf0Rp/iisCaL8761lKAZHaimlbGK4j0HysC4PLfqygQj9srcs0m2RdtDYnF8UuYyKpbjHYp7Jw==
-  dependencies:
-    "@pkgr/core" "^0.2.9"
-
 tapable@^2.1.1, tapable@^2.2.0, tapable@^2.2.1, tapable@^2.3.0:
   version "2.3.0"
   resolved "https://registry.npmjs.org/tapable/-/tapable-2.3.0.tgz#7e3ea6d5ca31ba8e078b560f0d83ce9a14aa8be6"