shakapacker 9.0.0.beta.9 → 9.0.0.beta.11

data/test/package/env.test.js

@@ -24,6 +24,18 @@ describe("Env", () => {
     delete process.env.NODE_ENV
     expect(require("../../package/env")).toStrictEqual({
       railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
+      runningWebpackDevServer: false
+    })
+  })
+
+  test("with undefined NODE_ENV and RAILS_ENV set to production", () => {
+    process.env.RAILS_ENV = "production"
+    delete process.env.NODE_ENV
+    expect(require("../../package/env")).toStrictEqual({
+      railsEnv: "production",
       nodeEnv: "production",
       isProduction: true,
       isDevelopment: false,
@@ -35,10 +47,10 @@ describe("Env", () => {
     delete process.env.NODE_ENV
     delete process.env.RAILS_ENV
     expect(require("../../package/env")).toStrictEqual({
-      railsEnv: "production",
-      nodeEnv: "production",
-      isProduction: true,
-      isDevelopment: false,
+      railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
       runningWebpackDevServer: false
     })
   })
@@ -48,10 +60,33 @@ describe("Env", () => {
     process.env.NODE_ENV = "staging"
     expect(require("../../package/env")).toStrictEqual({
       railsEnv: "staging",
-      nodeEnv: "production",
-      isProduction: true,
-      isDevelopment: false,
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
+      runningWebpackDevServer: false
+    })
+  })
+
+  test("rejects malicious NODE_ENV values and uses default", () => {
+    process.env.RAILS_ENV = "development"
+    process.env.NODE_ENV = "../../../etc/passwd"
+    expect(require("../../package/env")).toStrictEqual({
+      railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
       runningWebpackDevServer: false
     })
   })
+
+  test("warns when NODE_ENV is invalid", () => {
+    const consoleSpy = jest.spyOn(console, "warn").mockImplementation()
+    process.env.NODE_ENV = "invalid"
+    delete process.env.RAILS_ENV
+    require("../../package/env")
+    expect(consoleSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Invalid NODE_ENV value: invalid")
+    )
+    consoleSpy.mockRestore()
+  })
 })

data/test/package/environments/base.test.js

@@ -7,6 +7,10 @@ const { chdirTestApp, resetEnv } = require("../../helpers")
 const rootPath = process.cwd()
 chdirTestApp()
 
+// Set NODE_ENV before requiring modules to ensure contenthash is enabled
+// Base config tests expect production-like behavior with contenthash
+process.env.NODE_ENV = "production"
+
 const baseConfig = require("../../../package/environments/base")
 const config = require("../../../package/config")
 

data/test/package/staging.test.js

@@ -19,7 +19,7 @@ describe("Custom environment", () => {
   describe("generateWebpackConfig", () => {
     beforeEach(() => jest.resetModules())
 
-    test("should use staging config and default production environment", () => {
+    test("should use staging config and default development environment", () => {
       process.env.RAILS_ENV = "staging"
       delete process.env.NODE_ENV
 
@@ -31,9 +31,10 @@ describe("Custom environment", () => {
         resolve("public", "packs-staging")
       )
       expect(webpackConfig.output.publicPath).toBe("/packs-staging/")
+      // With the NODE_ENV fix, staging now defaults to development environment
+      // instead of production, providing better DX for staging environments
       expect(webpackConfig).toMatchObject({
-        devtool: "source-map",
-        stats: "normal"
+        devtool: "cheap-module-source-map"
       })
     })
   })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 9.0.0.beta.9
+  version: 9.0.0.beta.11
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -347,7 +347,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.0.0.beta.9
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.0.0.beta.11
 rdoc_options: []
 require_paths:
 - lib