shakapacker 9.0.0.beta.8 → 9.0.0.beta.10

data/lib/shakapacker/swc_migrator.rb

@@ -30,6 +30,15 @@ module Shakapacker
       "swc-loader" => "^0.2.6"
     }.freeze
 
+    ESLINT_CONFIG_FILES = %w[
+      .eslintrc
+      .eslintrc.js
+      .eslintrc.cjs
+      .eslintrc.yaml
+      .eslintrc.yml
+      .eslintrc.json
+    ].freeze
+
     DEFAULT_SWCRC_CONFIG = {
       "jsc" => {
         "parser" => {
@@ -41,8 +50,7 @@ module Shakapacker
           "react" => {
             "runtime" => "automatic"
           }
-        },
-        "target" => "es2015"
+        }
       },
       "module" => {
         "type" => "es6"
@@ -67,6 +75,10 @@ module Shakapacker
       logger.info "🎉 Migration to SWC complete!"
       logger.info "   Note: SWC is approximately 20x faster than Babel for transpilation."
       logger.info "   Please test your application thoroughly after migration."
+      logger.info "\n📝 Configuration Info:"
+      logger.info "   - .swcrc provides base configuration for all environments"
+      logger.info "   - The SWC loader adds automatic environment targeting (via 'env' setting)"
+      logger.info "   - You can customize .swcrc, but avoid setting 'jsc.target' as it conflicts with 'env'"
 
       # Show cleanup recommendations if babel packages found
       if results[:babel_packages_found].any?
@@ -99,6 +111,16 @@ module Shakapacker
         return { removed_packages: [], config_files_deleted: [] }
       end
 
+      # Check if ESLint uses Babel parser
+      if eslint_uses_babel?
+        logger.info "\n⚠️  WARNING: ESLint configuration detected that may use Babel"
+        logger.info "   If you use @babel/eslint-parser or babel-eslint, you may need to:"
+        logger.info "   1. Keep @babel/core and related Babel packages for ESLint"
+        logger.info "   2. Or switch to @typescript-eslint/parser for TypeScript files"
+        logger.info "   3. Or use espree (ESLint's default parser) for JavaScript files"
+        logger.info "\n   Proceeding with Babel package removal. Check your ESLint config after."
+      end
+
       removed_packages = remove_babel_from_package_json(package_json_path)
       deleted_files = delete_babel_config_files
 
@@ -132,6 +154,42 @@ module Shakapacker
 
     private
 
+      def eslint_uses_babel?
+        # Check for ESLint config files
+        # Note: This is a heuristic check that may have false positives (e.g., in comments),
+        # but false positives only result in an extra warning, which is safer than silently
+        # breaking ESLint configurations.
+        ESLINT_CONFIG_FILES.each do |config_file|
+          config_path = root_path.join(config_file)
+          next unless config_path.exist?
+
+          content = File.read(config_path)
+          # Check for Babel parser references
+          return true if content.match?(/@babel\/eslint-parser|babel-eslint/)
+        end
+
+        # Check package.json for eslintConfig
+        package_json_path = root_path.join("package.json")
+        if package_json_path.exist?
+          begin
+            package_json = JSON.parse(File.read(package_json_path))
+            if package_json["eslintConfig"]
+              return true if package_json["eslintConfig"].to_json.match?(/@babel\/eslint-parser|babel-eslint/)
+            end
+
+            # Check if Babel ESLint packages are installed
+            dependencies = package_json["dependencies"] || {}
+            dev_dependencies = package_json["devDependencies"] || {}
+            all_deps = dependencies.merge(dev_dependencies)
+            return true if all_deps.key?("@babel/eslint-parser") || all_deps.key?("babel-eslint")
+          rescue JSON::ParserError => e
+            logger.debug "Could not parse package.json for ESLint detection: #{e.message}"
+          end
+        end
+
+        false
+      end
+
       def update_shakapacker_config
         config_path = root_path.join("config/shakapacker.yml")
         return false unless config_path.exist?

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "9.0.0.beta.8".freeze
+  VERSION = "9.0.0.beta.10".freeze
 end

data/lib/shakapacker.rb

@@ -6,7 +6,7 @@ require "active_support/tagged_logging"
 module Shakapacker
   extend self
 
-  DEFAULT_ENV = "production".freeze
+  DEFAULT_ENV = "development".freeze
 
   def instance=(instance)
     @instance = instance

data/package/env.ts

@@ -6,21 +6,32 @@ const { isFileNotFoundError } = require("./utils/errorHelpers")
 const { sanitizeEnvValue } = require("./utils/pathValidation")
 
 const NODE_ENVIRONMENTS = ["development", "production", "test"] as const
-const DEFAULT = "production"
 
 // Sanitize environment variables to prevent injection
 const initialRailsEnv = sanitizeEnvValue(process.env.RAILS_ENV)
 const rawNodeEnv = sanitizeEnvValue(process.env.NODE_ENV)
 
+// Default NODE_ENV based on RAILS_ENV to match bin/shakapacker behavior (see lib/shakapacker/runner.rb:27)
+// - RAILS_ENV=production → DEFAULT="production" (safe for production builds)
+// - RAILS_ENV=development, test, staging, or unset → DEFAULT="development" (good DX for dev server)
+// This ensures the dev server works out of the box without requiring NODE_ENV to be set explicitly
+const DEFAULT = initialRailsEnv === "production" ? "production" : "development"
+
 // Validate NODE_ENV strictly
 const nodeEnv =
-  rawNodeEnv && NODE_ENVIRONMENTS.includes(rawNodeEnv as typeof NODE_ENVIRONMENTS[number]) ? rawNodeEnv : DEFAULT
+  rawNodeEnv &&
+  NODE_ENVIRONMENTS.includes(rawNodeEnv as (typeof NODE_ENVIRONMENTS)[number])
+    ? rawNodeEnv
+    : DEFAULT
 
 // Log warning if NODE_ENV was invalid
-if (rawNodeEnv && !NODE_ENVIRONMENTS.includes(rawNodeEnv as typeof NODE_ENVIRONMENTS[number])) {
+if (
+  rawNodeEnv &&
+  !NODE_ENVIRONMENTS.includes(rawNodeEnv as (typeof NODE_ENVIRONMENTS)[number])
+) {
   console.warn(
     `[SHAKAPACKER WARNING] Invalid NODE_ENV value: ${rawNodeEnv}. ` +
-    `Valid values are: ${NODE_ENVIRONMENTS.join(', ')}. Using default: ${DEFAULT}`
+      `Valid values are: ${NODE_ENVIRONMENTS.join(", ")}. Using default: ${DEFAULT}`
   )
 }
 
@@ -42,13 +53,13 @@ try {
     } catch (defaultError) {
       throw new Error(
         `Failed to load Shakapacker configuration.\n` +
-        `Neither user config (${configPath}) nor default config (${defaultConfigPath}) could be loaded.\n\n` +
-        `To fix this issue:\n` +
-        `1. Create a config/shakapacker.yml file in your project\n` +
-        `2. Or set the SHAKAPACKER_CONFIG environment variable to point to your config file\n` +
-        `3. Or reinstall Shakapacker to restore the default configuration:\n` +
-        `   npm install shakapacker --force\n` +
-        `   yarn add shakapacker --force`
+          `Neither user config (${configPath}) nor default config (${defaultConfigPath}) could be loaded.\n\n` +
+          `To fix this issue:\n` +
+          `1. Create a config/shakapacker.yml file in your project\n` +
+          `2. Or set the SHAKAPACKER_CONFIG environment variable to point to your config file\n` +
+          `3. Or reinstall Shakapacker to restore the default configuration:\n` +
+          `   npm install shakapacker --force\n` +
+          `   yarn add shakapacker --force`
       )
     }
   } else {
@@ -61,13 +72,14 @@ const regex = new RegExp(`^(${availableEnvironments})$`, "g")
 
 const runningWebpackDevServer = process.env.WEBPACK_SERVE === "true"
 
-const validatedRailsEnv = initialRailsEnv && initialRailsEnv.match(regex) ? initialRailsEnv : DEFAULT
+const validatedRailsEnv =
+  initialRailsEnv && initialRailsEnv.match(regex) ? initialRailsEnv : DEFAULT
 
 if (initialRailsEnv && validatedRailsEnv !== initialRailsEnv) {
   /* eslint no-console:0 */
   console.warn(
     `[SHAKAPACKER WARNING] Environment '${initialRailsEnv}' not found in the configuration.\n` +
-    `Using '${DEFAULT}' configuration as a fallback.`
+      `Using '${DEFAULT}' configuration as a fallback.`
   )
 }
 

data/package/utils/getStyleRule.ts

@@ -33,7 +33,12 @@ const getStyleRule = (test: RegExp, preprocessors: any[] = []): StyleRule | null
           sourceMap: true,
           importLoaders: 2,
           modules: {
-            auto: true
+            auto: true,
+            // v9 defaults: Use named exports with camelCase conversion
+            // Note: css-loader requires 'camelCaseOnly' or 'dashesOnly' when namedExport is true
+            // Using 'camelCase' with namedExport: true causes a build error
+            namedExport: true,
+            exportLocalsConvention: 'camelCaseOnly'
           }
         }
       },
@@ -56,4 +61,4 @@ const getStyleRule = (test: RegExp, preprocessors: any[] = []): StyleRule | null
   return null
 }
 
-export = { getStyleRule }
+export = { getStyleRule }

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "9.0.0-beta.8",
+  "version": "9.0.0-beta.10",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {

data/test/package/config.test.js

@@ -71,6 +71,7 @@ describe("Config", () => {
   })
 
   test("should allow enabling integrity", () => {
+    process.env.RAILS_ENV = "production"
     process.env.SHAKAPACKER_CONFIG = "config/shakapacker_integrity.yml"
     const config = require("../../package/config")
 
@@ -78,6 +79,7 @@ describe("Config", () => {
   })
 
   test("should allow configuring hash functions", () => {
+    process.env.RAILS_ENV = "production"
     process.env.SHAKAPACKER_CONFIG = "config/shakapacker_integrity.yml"
     const config = require("../../package/config")
 
@@ -89,6 +91,7 @@ describe("Config", () => {
   })
 
   test("should allow configuring crossorigin", () => {
+    process.env.RAILS_ENV = "production"
     process.env.SHAKAPACKER_CONFIG = "config/shakapacker_integrity.yml"
     const config = require("../../package/config")
 

data/test/package/env.test.js

@@ -24,6 +24,18 @@ describe("Env", () => {
     delete process.env.NODE_ENV
     expect(require("../../package/env")).toStrictEqual({
       railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
+      runningWebpackDevServer: false
+    })
+  })
+
+  test("with undefined NODE_ENV and RAILS_ENV set to production", () => {
+    process.env.RAILS_ENV = "production"
+    delete process.env.NODE_ENV
+    expect(require("../../package/env")).toStrictEqual({
+      railsEnv: "production",
       nodeEnv: "production",
       isProduction: true,
       isDevelopment: false,
@@ -35,10 +47,10 @@ describe("Env", () => {
     delete process.env.NODE_ENV
     delete process.env.RAILS_ENV
     expect(require("../../package/env")).toStrictEqual({
-      railsEnv: "production",
-      nodeEnv: "production",
-      isProduction: true,
-      isDevelopment: false,
+      railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
       runningWebpackDevServer: false
     })
   })
@@ -48,10 +60,33 @@ describe("Env", () => {
     process.env.NODE_ENV = "staging"
     expect(require("../../package/env")).toStrictEqual({
       railsEnv: "staging",
-      nodeEnv: "production",
-      isProduction: true,
-      isDevelopment: false,
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
+      runningWebpackDevServer: false
+    })
+  })
+
+  test("rejects malicious NODE_ENV values and uses default", () => {
+    process.env.RAILS_ENV = "development"
+    process.env.NODE_ENV = "../../../etc/passwd"
+    expect(require("../../package/env")).toStrictEqual({
+      railsEnv: "development",
+      nodeEnv: "development",
+      isProduction: false,
+      isDevelopment: true,
       runningWebpackDevServer: false
     })
   })
+
+  test("warns when NODE_ENV is invalid", () => {
+    const consoleSpy = jest.spyOn(console, "warn").mockImplementation()
+    process.env.NODE_ENV = "invalid"
+    delete process.env.RAILS_ENV
+    require("../../package/env")
+    expect(consoleSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Invalid NODE_ENV value: invalid")
+    )
+    consoleSpy.mockRestore()
+  })
 })

data/test/package/environments/base.test.js

@@ -7,6 +7,10 @@ const { chdirTestApp, resetEnv } = require("../../helpers")
 const rootPath = process.cwd()
 chdirTestApp()
 
+// Set NODE_ENV before requiring modules to ensure contenthash is enabled
+// Base config tests expect production-like behavior with contenthash
+process.env.NODE_ENV = "production"
+
 const baseConfig = require("../../../package/environments/base")
 const config = require("../../../package/config")
 

data/test/package/staging.test.js

@@ -19,7 +19,7 @@ describe("Custom environment", () => {
   describe("generateWebpackConfig", () => {
     beforeEach(() => jest.resetModules())
 
-    test("should use staging config and default production environment", () => {
+    test("should use staging config and default development environment", () => {
       process.env.RAILS_ENV = "staging"
       delete process.env.NODE_ENV
 
@@ -31,9 +31,10 @@ describe("Custom environment", () => {
         resolve("public", "packs-staging")
       )
       expect(webpackConfig.output.publicPath).toBe("/packs-staging/")
+      // With the NODE_ENV fix, staging now defaults to development environment
+      // instead of production, providing better DX for staging environments
       expect(webpackConfig).toMatchObject({
-        devtool: "source-map",
-        stats: "normal"
+        devtool: "cheap-module-source-map"
       })
     })
   })

data/tools/README.md

@@ -104,7 +104,7 @@ const Button: React.FC = () => {
 
 ### Notes
 
-1. **Kebab-case conversion**: CSS classes with kebab-case (e.g., `my-button`) are automatically converted to camelCase (`myButton`) for JavaScript files, matching css-loader's `exportLocalsConvention: 'camelCase'` setting.
+1. **Kebab-case conversion**: CSS classes with kebab-case (e.g., `my-button`) are automatically converted to camelCase (`myButton`) for JavaScript files, matching css-loader's `exportLocalsConvention: 'camelCaseOnly'` setting.
 
 2. **Unused imports**: The codemod only imports CSS classes that are actually used in JavaScript files. If you pass the entire styles object to a component, it will convert to namespace import for safety.
 
@@ -121,4 +121,4 @@ const Button: React.FC = () => {
 **Solution**: Ensure your TypeScript definitions are updated as shown in the [v9 Upgrade Guide](../docs/v9_upgrade.md).
 
 **Issue**: Runtime errors about missing CSS classes
-**Solution**: Check if you have kebab-case class names that need camelCase conversion.
+**Solution**: Check if you have kebab-case class names that need camelCase conversion.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 9.0.0.beta.8
+  version: 9.0.0.beta.10
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -147,6 +147,7 @@ files:
 - ".github/workflows/ruby.yml"
 - ".github/workflows/test-bundlers.yml"
 - ".gitignore"
+- ".husky/pre-commit"
 - ".node-version"
 - ".npmignore"
 - ".rspec"
@@ -346,7 +347,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.0.0.beta.8
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.0.0.beta.10
 rdoc_options: []
 require_paths:
 - lib