shakapacker 8.4.0 → 9.7.0

data/.github/workflows/claude-code-review.yml

@@ -0,0 +1,45 @@
+name: Claude Code Review
+
+on:
+  pull_request:
+    types: [opened, synchronize, ready_for_review, reopened]
+
+jobs:
+  claude-review:
+    if: github.event.pull_request.head.repo.full_name == github.repository
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+      issues: write
+      id-token: write
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code Review
+        id: claude-review
+        uses: anthropics/claude-code-action@v1
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          prompt: |
+            REPO: ${{ github.repository }}
+            PR NUMBER: ${{ github.event.pull_request.number }}
+
+            Please review this pull request with a focus on:
+            - Code quality and best practices
+            - Potential bugs or issues
+            - Security implications
+            - Performance considerations
+
+            Note: The PR branch is already checked out in the current working directory.
+
+            Use `gh pr comment` for top-level feedback.
+            Use `mcp__github_inline_comment__create_inline_comment` to highlight specific code issues.
+            Only post GitHub comments - don't submit review text as messages.
+
+          claude_args: |
+            --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"

data/.github/workflows/claude.yml

@@ -0,0 +1,55 @@
+name: Claude Code
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_review_comment:
+    types: [created]
+  issues:
+    types: [opened, assigned]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  claude:
+    if: |
+      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
+      (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+      actions: read # Required for Claude to read CI results on PRs
+      checks: read
+      statuses: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code
+        id: claude
+        uses: anthropics/claude-code-action@v1
+        with:
+          github_token: ${{ github.token }}
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+
+          # This is an optional setting that allows Claude to read CI results on PRs
+          additional_permissions: |
+            actions: read
+            checks: read
+            statuses: read
+
+          # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
+          # prompt: 'Update the pull request description to include a summary of changes.'
+
+          # Optional: Add claude_args to customize behavior and configuration
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://code.claude.com/docs/en/cli-reference for available options
+          # claude_args: '--allowed-tools Bash(gh pr:*)'
+

data/.github/workflows/dummy.yml

@@ -3,8 +3,17 @@ name: Dummy specs
 on:
   push:
     branches:
-      - 'main'
+      - "main"
   pull_request:
+    paths:
+      - "spec/dummy/**"
+      - "lib/**"
+      - "**.rb"
+      - "**.js"
+      - "**.ts"
+      - "package.json"
+      - ".github/workflows/dummy.yml"
+  workflow_dispatch:
 
 concurrency:
   # Pushing new changes to a branch will cancel any in-progress CI runs
@@ -21,16 +30,20 @@ jobs:
           persist-credentials: false
       - uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: "20"
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.1.2'
+          ruby-version: "3.2"
           rubygems: latest
       - name: Install dependencies
         run: |
           bundle install
-          yarn install
-          sudo yarn global add yalc
+          yarn install --frozen-lockfile --production=false
+          npm install -g yalc
+          cd spec/dummy && npm install
+
+      - name: Build TypeScript
+        run: yarn build
 
       - name: Run tests
         run: bundle exec rake run_spec:dummy

data/.github/workflows/eslint-validation.yml

@@ -0,0 +1,46 @@
+name: ESLint Validation
+
+on:
+  pull_request:
+    paths:
+      - "eslint.config.js"
+      - "package.json"
+      - "package/**/*.js"
+      - "test/**/*.js"
+      - ".github/workflows/eslint-validation.yml"
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "yarn"
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Validate ESLint config
+        run: |
+          echo "Validating ESLint configuration..."
+          node -e "const config = require('./eslint.config.js'); console.log('✓ Config is valid with', config.length, 'rule sets')"
+
+      - name: Run ESLint
+        run: |
+          echo "Running ESLint on allowed files..."
+          yarn eslint . --max-warnings 5
+
+      - name: Check warning count
+        run: |
+          echo "Checking warning count..."
+          WARNING_COUNT=$(yarn eslint . 2>&1 | grep -E "^✖.*warning" | grep -oE "[0-9]+ warning" | cut -d' ' -f1)
+          echo "Current warning count: $WARNING_COUNT"
+          if [ "$WARNING_COUNT" -gt "5" ]; then
+            echo "❌ Too many warnings: $WARNING_COUNT (max allowed: 5)"
+            exit 1
+          fi
+          echo "✓ Warning count is acceptable"

data/.github/workflows/generator.yml

@@ -3,8 +3,21 @@ name: Generator specs
 on:
   push:
     branches:
-      - 'main'
+      - "main"
   pull_request:
+    paths:
+      - "lib/install/**"
+      - "lib/generators/**"
+      - "spec/generator_specs/**"
+      - "**.rb"
+      - "**.gemspec"
+      - "Gemfile"
+      - "gemfiles/**"
+      - "package.json"
+      - "**.js"
+      - "**.ts"
+      - ".github/workflows/generator.yml"
+  workflow_dispatch:
 
 concurrency:
   # Pushing new changes to a branch will cancel any in-progress CI runs
@@ -18,10 +31,8 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
         gemfile:
-          - gemfiles/Gemfile-rails.6.0.x
-          - gemfiles/Gemfile-rails.6.1.x
           - gemfiles/Gemfile-rails.7.0.x
           - gemfiles/Gemfile-rails.7.1.x
           - gemfiles/Gemfile-rails.7.2.x
@@ -30,29 +41,17 @@ jobs:
           # upcomming Rails versions, maybe before a release.
           #- gemfiles/Gemfile-rails-edge
         exclude:
-          - ruby: '2.7'
+          - ruby: "2.7"
             gemfile: gemfiles/Gemfile-rails.7.2.x
-          - ruby: '2.7'
+          - ruby: "2.7"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.0'
+          - ruby: "3.0"
             gemfile: gemfiles/Gemfile-rails.7.2.x
-          - ruby: '3.0'
+          - ruby: "3.0"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.1'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.1'
+          - ruby: "3.1"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.2'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
-            gemfile: gemfiles/Gemfile-rails.6.1.x
-          - ruby: '3.4'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.4'
-            gemfile: gemfiles/Gemfile-rails.6.1.x
-          - ruby: '3.4'
+          - ruby: "3.4"
             gemfile: gemfiles/Gemfile-rails.7.0.x
 
     env:
@@ -67,4 +66,21 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           rubygems: latest
           bundler-cache: true
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+
+      - name: Install Node dependencies
+        run: yarn install --frozen-lockfile --production=false
+
+      - name: Build TypeScript
+        run: yarn build
+
+      - name: Pack npm package for testing
+        run: |
+          TARBALL=$(npm pack)
+          echo "SHAKAPACKER_NPM_PACKAGE=$(pwd)/$TARBALL" >> $GITHUB_ENV
+          echo "Created package: $TARBALL"
+
       - run: bundle exec rake run_spec:generator

data/.github/workflows/node.yml

@@ -3,8 +3,21 @@ name: Node based checks
 on:
   push:
     branches:
-      - 'main'
+      - "main"
   pull_request:
+    paths:
+      - "**.js"
+      - "**.ts"
+      - "package.json"
+      - "yarn.lock"
+      - "eslint.config.js"
+      - ".prettierrc"
+      - ".prettierignore"
+      - "knip.json"
+      - "tsconfig.json"
+      - "jest.config.js"
+      - ".github/workflows/node.yml"
+  workflow_dispatch:
 
 concurrency:
   # Pushing new changes to a branch will cancel any in-progress CI runs
@@ -30,12 +43,110 @@ jobs:
 
       - name: Node eslint
         run: yarn lint
+
+      - name: Prettier format check
+        run: yarn prettier --check .
+
+      - name: Detect dead code
+        run: yarn knip
+
+      - name: Detect dead code in production
+        run: yarn knip:production
+
+  type-check:
+    name: TypeScript Type Checking
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+
+      - name: Install dependencies
+        run: yarn --frozen-lockfile --non-interactive --prefer-offline
+
+      - name: TypeScript type check
+        run: yarn type-check
+
+      # We only download and run Actionlint if there is any difference in GitHub Action workflows
+      # https://github.com/rhysd/actionlint/blob/main/docs/usage.md#on-github-actions
+      # Note: Only runs on pull_request events, not push events (where github.event.pull_request is null)
+      - name: Check GitHub Action changes
+        if: github.event_name == 'pull_request'
+        id: check-workflows
+        run: |
+          git fetch origin ${{ github.event.pull_request.base.sha }}
+          if git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -q '^.github/workflows'; then
+            echo "changed=true" >> "$GITHUB_OUTPUT"
+            response=$(curl -sf https://api.github.com/repos/rhysd/actionlint/releases/latest)
+            if [ $? -eq 0 ]; then
+              actionlint_version=$(echo "$response" | jq -r .tag_name)
+              if [ -z "$actionlint_version" ]; then
+                echo "Failed to parse Actionlint version"
+                exit 1
+              fi
+              echo "actionlint_version=\"$actionlint_version\"" >> "$GITHUB_OUTPUT"
+            fi
+          fi
+      - name: Setup Actionlint
+        if: github.event_name == 'pull_request' && steps.check-workflows.outputs.changed == 'true'
+        uses: actions/cache@v4
+        id: cache-actionlint
+        with:
+          path: ./actionlint
+          key: ${{ runner.os }}-actionlint-${{ steps.check-workflows.outputs.actionlint_version }}
+      - name: Download Actionlint
+        if: github.event_name == 'pull_request' && steps.check-workflows.outputs.changed == 'true' && steps.cache-actionlint.outputs.cache-hit != 'true'
+        run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
+      - name: Lint GitHub Actions
+        if: github.event_name == 'pull_request' && steps.check-workflows.outputs.changed == 'true'
+        run: |
+          echo "::add-matcher::.github/actionlint-matcher.json"
+          SHELLCHECK_OPTS="-S warning" ./actionlint -color
+        shell: bash
+
+  type-check-dts-without-webpack:
+    name: Verify .d.ts files work without webpack
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+
+      - name: Create test directory and copy .d.ts files
+        run: |
+          mkdir -p /tmp/test-types
+          cp package/*.d.ts /tmp/test-types/
+          # types.ts is imported by index.d.ts; copy if it exists
+          cp package/types.ts /tmp/test-types/ 2>/dev/null || true
+
+      - name: Install TypeScript in test directory
+        run: |
+          cd /tmp/test-types
+          npm init -y
+          npm install typescript @types/node
+
+      - name: Verify hand-written .d.ts files type-check without webpack
+        run: |
+          cd /tmp/test-types
+          npx tsc --noEmit \
+            --skipLibCheck \
+            --moduleResolution node \
+            *.d.ts
   test:
     name: Testing
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [14.x, 16.x, 18.x, 20.x]
+        node: [20.x, 22.x]
 
     runs-on: ${{ matrix.os }}
 
@@ -52,5 +163,8 @@ jobs:
       - name: Install dependencies
         run: yarn --frozen-lockfile --non-interactive --prefer-offline
 
+      - name: Build TypeScript
+        run: yarn build
+
       - name: Jest Specs
         run: yarn test

data/.github/workflows/ruby.yml

@@ -3,8 +3,20 @@ name: Ruby based checks
 on:
   push:
     branches:
-      - 'main'
+      - "main"
   pull_request:
+    paths:
+      - "**.rb"
+      - "**.rbs"
+      - "**.gemspec"
+      - "Gemfile"
+      - "Rakefile"
+      - "gemfiles/**"
+      - ".rubocop.yml"
+      - "package.json"
+      - "**.ts"
+      - ".github/workflows/ruby.yml"
+  workflow_dispatch:
 
 concurrency:
   # Pushing new changes to a branch will cancel any in-progress CI runs
@@ -23,20 +35,39 @@ jobs:
         run: rm -f Gemfile.lock
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.4'
+          ruby-version: "3.4"
           rubygems: latest
           bundler-cache: true
 
       - name: Ruby rubocop
         run: bundle exec rubocop
 
+  rbs-validate:
+    name: RBS Type Validation
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Remove Gemfile.lock
+        # Remove lock to test compatibility with latest gem versions
+        run: rm -f Gemfile.lock
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4"
+          rubygems: latest
+          bundler-cache: true
+
+      - name: Validate RBS signatures
+        run: bundle exec rbs validate
+
   test:
     name: Testing
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
         gemfile:
           - gemfiles/Gemfile-rails.6.0.x
           - gemfiles/Gemfile-rails.6.1.x
@@ -48,29 +79,29 @@ jobs:
           # upcomming Rails versions, maybe before a release.
           #- gemfiles/Gemfile-rails-edge
         exclude:
-          - ruby: '2.7'
+          - ruby: "2.7"
             gemfile: gemfiles/Gemfile-rails.7.2.x
-          - ruby: '2.7'
+          - ruby: "2.7"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.0'
+          - ruby: "3.0"
             gemfile: gemfiles/Gemfile-rails.7.2.x
-          - ruby: '3.0'
+          - ruby: "3.0"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.1'
+          - ruby: "3.1"
             gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.1'
+          - ruby: "3.1"
             gemfile: gemfiles/Gemfile-rails.8.0.x
-          - ruby: '3.2'
+          - ruby: "3.2"
             gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
+          - ruby: "3.3"
             gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
+          - ruby: "3.3"
             gemfile: gemfiles/Gemfile-rails.6.1.x
-          - ruby: '3.4'
+          - ruby: "3.4"
             gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.4'
+          - ruby: "3.4"
             gemfile: gemfiles/Gemfile-rails.6.1.x
-          - ruby: '3.4'
+          - ruby: "3.4"
             gemfile: gemfiles/Gemfile-rails.7.0.x
 
     env:
@@ -86,5 +117,16 @@ jobs:
           rubygems: latest
           bundler-cache: true
 
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+
+      - name: Install Node dependencies
+        run: yarn install --frozen-lockfile --production=false
+
+      - name: Build TypeScript
+        run: yarn build
+
       - name: Ruby specs
         run: bundle exec rake run_spec:gem