shakapacker 8.0.2 → 9.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db9b65b6bcad3c69564cc6e9a1c81ef86586b551cceac4426ff4648388943063
-  data.tar.gz: 764219a7ff3a435f16bf8554f538f56b5d32f29e1849cdf06241504098b5f9c9
+  metadata.gz: 5ac40ff5ddf8db373b1de0efaf805a033d7ba87641d84bde529669761b8e64d2
+  data.tar.gz: 5d0abb49ede8ad2aa37c94e9148e4def579c3eabb8c6e8d94a127796941ed559
 SHA512:
-  metadata.gz: 1b45a4a37953a95d40eeaa8382350991058e074157594a8eeb977eace38db31d0c2507db9aec61eb8eea20485e135d68e9e9d688fc8fe094f4672532715ecc01
-  data.tar.gz: b053d207e3e1d56ab2e92987d216212f75e4b6d41d49d6b5bed1ccfdb29d917b94ac4d17220f607253ffc9d335de733089deb1e5aca44dc389a6177168e244da
+  metadata.gz: 5309f5d9beef93aaa0434e0e8ab93118545ecad507ade518ab56a332980d804536e36762670d21245d67d6c60e126367b1ea4edd8e4766daf20c294871ea1263
+  data.tar.gz: 4fb22afab6e203194018a1be9096aac472bffdbc08d58fc7a5b04a23c5e5d8c52084a17830d8ffb5156a6e4798de061f6f671474638616b7ffecd6c6348916f5

data/.eslintignore

@@ -2,3 +2,4 @@ lib/*
 node_modules/*
 vendor/*
 spec/*
+package/*

data/.eslintrc.fast.js

@@ -0,0 +1,40 @@
+// Fast ESLint config for quick development feedback
+// Skips type-aware rules that require TypeScript compilation
+
+const baseConfig = require("./.eslintrc.js")
+
+module.exports = {
+  ...baseConfig,
+  overrides: [
+    ...baseConfig.overrides.filter((o) => !o.files.includes("**/*.{ts,tsx}")),
+    {
+      files: ["**/*.{ts,tsx}"],
+      parser: "@typescript-eslint/parser",
+      parserOptions: {
+        // No project specified - disables type-aware linting
+        ecmaVersion: 2020,
+        sourceType: "module"
+      },
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        // Skip the "recommended-requiring-type-checking" preset
+        "plugin:prettier/recommended"
+      ],
+      plugins: ["@typescript-eslint"],
+      rules: {
+        // Same rules as main config minus type-aware ones
+        "import/no-unresolved": "off",
+        "import/no-extraneous-dependencies": "off",
+        "import/extensions": "off",
+        "no-use-before-define": "off",
+        "@typescript-eslint/no-use-before-define": ["error"],
+        "@typescript-eslint/no-unused-vars": [
+          "error",
+          { argsIgnorePattern: "^_" }
+        ],
+        "@typescript-eslint/no-explicit-any": "error",
+        "@typescript-eslint/explicit-module-boundary-types": "off"
+      }
+    }
+  ]
+}

data/.eslintrc.js

@@ -1,11 +1,22 @@
 module.exports = {
+  root: true, // Prevent ESLint from looking in parent directories
   extends: ["airbnb", "plugin:prettier/recommended"],
   rules: {
+    // Webpack handles module resolution, not ESLint
     "import/no-unresolved": "off",
+    // Allow importing devDependencies in config/test files
     "import/no-extraneous-dependencies": "off",
+    // TypeScript handles extensions, not needed for JS imports
     "import/extensions": "off",
     indent: ["error", 2]
   },
+  settings: {
+    react: {
+      // Suppress "react package not installed" warning
+      // This project doesn't use React but airbnb config requires react-plugin
+      version: "999.999.999"
+    }
+  },
   env: {
     browser: true,
     node: true
@@ -31,6 +42,43 @@ module.exports = {
         "jest/prefer-strict-equal": "error",
         "jest/prefer-todo": "error"
       }
+    },
+    {
+      files: ["**/*.{ts,tsx}"],
+      parser: "@typescript-eslint/parser",
+      parserOptions: {
+        // Enables type-aware linting for better type safety
+        // Note: This can slow down linting on large codebases
+        // Consider using --cache flag with ESLint if performance degrades
+        project: "./tsconfig.eslint.json",
+        tsconfigRootDir: __dirname
+      },
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "plugin:prettier/recommended"
+      ],
+      plugins: ["@typescript-eslint"],
+      rules: {
+        // TypeScript compiler handles module resolution
+        "import/no-unresolved": "off",
+        // Allow importing devDependencies in TypeScript files
+        "import/no-extraneous-dependencies": "off",
+        // TypeScript handles file extensions via moduleResolution
+        "import/extensions": "off",
+        // Disable base rule in favor of TypeScript version
+        "no-use-before-define": "off",
+        "@typescript-eslint/no-use-before-define": ["error"],
+        // Allow unused vars if they start with underscore (convention for ignored params)
+        "@typescript-eslint/no-unused-vars": [
+          "error",
+          { argsIgnorePattern: "^_" }
+        ],
+        // Strict: no 'any' types allowed - use 'unknown' or specific types instead
+        "@typescript-eslint/no-explicit-any": "error",
+        // Allow implicit return types - TypeScript can infer them
+        "@typescript-eslint/explicit-module-boundary-types": "off"
+      }
     }
   ]
 }

data/.github/STATUS.md

@@ -0,0 +1 @@
+# CI Status Update

data/.github/workflows/claude-code-review.yml

@@ -0,0 +1,54 @@
+name: Claude Code Review
+
+on:
+  pull_request:
+    types: [opened, synchronize]
+    # Optional: Only run on specific file changes
+    # paths:
+    #   - "src/**/*.ts"
+    #   - "src/**/*.tsx"
+    #   - "src/**/*.js"
+    #   - "src/**/*.jsx"
+
+jobs:
+  claude-review:
+    # Optional: Filter by PR author
+    # if: |
+    #   github.event.pull_request.user.login == 'external-contributor' ||
+    #   github.event.pull_request.user.login == 'new-developer' ||
+    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
+    
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+    
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code Review
+        id: claude-review
+        uses: anthropics/claude-code-action@v1
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          prompt: |
+            Please review this pull request and provide feedback on:
+            - Code quality and best practices
+            - Potential bugs or issues
+            - Performance considerations
+            - Security concerns
+            - Test coverage
+            
+            Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback.
+
+            Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
+          
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
+          claude_args: '--model claude-sonnet-4-5-20250929 --allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
+

data/.github/workflows/claude.yml

@@ -0,0 +1,50 @@
+name: Claude Code
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_review_comment:
+    types: [created]
+  issues:
+    types: [opened, assigned]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  claude:
+    if: |
+      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
+      (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
+      issues: read
+      id-token: write
+      actions: read # Required for Claude to read CI results on PRs
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code
+        id: claude
+        uses: anthropics/claude-code-action@v1
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          
+          # This is an optional setting that allows Claude to read CI results on PRs
+          additional_permissions: |
+            actions: read
+
+          # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
+          # prompt: 'Update the pull request description to include a summary of changes.'
+
+          # Optional: Add claude_args to customize behavior and configuration
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
+          # claude_args: '--model claude-opus-4-1-20250805 --allowed-tools Bash(gh pr:*)'
+

data/.github/workflows/dummy.yml

@@ -21,15 +21,20 @@ jobs:
           persist-credentials: false
       - uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '20'
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.1.2'
+          ruby-version: '3.2'
+          rubygems: latest
       - name: Install dependencies
         run: |
           bundle install
-          yarn install
-          sudo yarn global add yalc
+          yarn install --frozen-lockfile --production=false
+          npm install -g yalc
+          cd spec/dummy && npm install
+      
+      - name: Build TypeScript
+        run: yarn build
 
       - name: Run tests
         run: bundle exec rake run_spec:dummy

data/.github/workflows/generator.yml

@@ -18,24 +18,28 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
+        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
         gemfile:
-          - gemfiles/Gemfile-rails.6.0.x
-          - gemfiles/Gemfile-rails.6.1.x
           - gemfiles/Gemfile-rails.7.0.x
           - gemfiles/Gemfile-rails.7.1.x
+          - gemfiles/Gemfile-rails.7.2.x
+          - gemfiles/Gemfile-rails.8.0.x
           # Uncomment the following line only to ensure compatibility with the
           # upcomming Rails versions, maybe before a release.
           #- gemfiles/Gemfile-rails-edge
         exclude:
+          - ruby: '2.7'
+            gemfile: gemfiles/Gemfile-rails.7.2.x
+          - ruby: '2.7'
+            gemfile: gemfiles/Gemfile-rails.8.0.x
+          - ruby: '3.0'
+            gemfile: gemfiles/Gemfile-rails.7.2.x
+          - ruby: '3.0'
+            gemfile: gemfiles/Gemfile-rails.8.0.x
           - ruby: '3.1'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.2'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
-            gemfile: gemfiles/Gemfile-rails.6.0.x
-          - ruby: '3.3'
-            gemfile: gemfiles/Gemfile-rails.6.1.x
+            gemfile: gemfiles/Gemfile-rails.8.0.x
+          - ruby: '3.4'
+            gemfile: gemfiles/Gemfile-rails.7.0.x
 
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
@@ -47,5 +51,23 @@ jobs:
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
+          rubygems: latest
           bundler-cache: true
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+      
+      - name: Install Node dependencies
+        run: yarn install --frozen-lockfile --production=false
+
+      - name: Build TypeScript
+        run: yarn build
+
+      - name: Pack npm package for testing
+        run: |
+          TARBALL=$(npm pack)
+          echo "SHAKAPACKER_NPM_PACKAGE=$(pwd)/$TARBALL" >> $GITHUB_ENV
+          echo "Created package: $TARBALL"
+
       - run: bundle exec rake run_spec:generator

data/.github/workflows/node.yml

@@ -30,12 +30,31 @@ jobs:
 
       - name: Node eslint
         run: yarn lint
+
+  type-check:
+    name: TypeScript Type Checking
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+
+      - name: Install dependencies
+        run: yarn --frozen-lockfile --non-interactive --prefer-offline
+
+      - name: TypeScript type check
+        run: yarn type-check
   test:
     name: Testing
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [14.x, 16.x, 18.x, 20.x]
+        node: [18.x, 20.x, 22.x]
 
     runs-on: ${{ matrix.os }}
 
@@ -52,5 +71,8 @@ jobs:
       - name: Install dependencies
         run: yarn --frozen-lockfile --non-interactive --prefer-offline
 
+      - name: Build TypeScript
+        run: yarn build
+
       - name: Jest Specs
         run: yarn test

data/.github/workflows/ruby.yml

@@ -23,7 +23,8 @@ jobs:
         run: rm -f Gemfile.lock
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
+          rubygems: latest
           bundler-cache: true
 
       - name: Ruby rubocop
@@ -35,24 +36,42 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
+        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
         gemfile:
           - gemfiles/Gemfile-rails.6.0.x
           - gemfiles/Gemfile-rails.6.1.x
           - gemfiles/Gemfile-rails.7.0.x
           - gemfiles/Gemfile-rails.7.1.x
+          - gemfiles/Gemfile-rails.7.2.x
+          - gemfiles/Gemfile-rails.8.0.x
           # Uncomment the following line only to ensure compatibility with the
           # upcomming Rails versions, maybe before a release.
           #- gemfiles/Gemfile-rails-edge
         exclude:
+          - ruby: '2.7'
+            gemfile: gemfiles/Gemfile-rails.7.2.x
+          - ruby: '2.7'
+            gemfile: gemfiles/Gemfile-rails.8.0.x
+          - ruby: '3.0'
+            gemfile: gemfiles/Gemfile-rails.7.2.x
+          - ruby: '3.0'
+            gemfile: gemfiles/Gemfile-rails.8.0.x
           - ruby: '3.1'
             gemfile: gemfiles/Gemfile-rails.6.0.x
+          - ruby: '3.1'
+            gemfile: gemfiles/Gemfile-rails.8.0.x
           - ruby: '3.2'
             gemfile: gemfiles/Gemfile-rails.6.0.x
           - ruby: '3.3'
             gemfile: gemfiles/Gemfile-rails.6.0.x
           - ruby: '3.3'
             gemfile: gemfiles/Gemfile-rails.6.1.x
+          - ruby: '3.4'
+            gemfile: gemfiles/Gemfile-rails.6.0.x
+          - ruby: '3.4'
+            gemfile: gemfiles/Gemfile-rails.6.1.x
+          - ruby: '3.4'
+            gemfile: gemfiles/Gemfile-rails.7.0.x
 
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
@@ -64,7 +83,19 @@ jobs:
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
+          rubygems: latest
           bundler-cache: true
+      
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+          cache: yarn
+
+      - name: Install Node dependencies
+        run: yarn install --frozen-lockfile --production=false
+
+      - name: Build TypeScript
+        run: yarn build
 
       - name: Ruby specs
         run: bundle exec rake run_spec:gem

data/.github/workflows/test-bundlers.yml

@@ -0,0 +1,170 @@
+name: Test Both Bundlers
+
+on:
+  pull_request:
+  push:
+    branches: [master, main]
+
+jobs:
+  test-webpack:
+    name: Test with Webpack
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: spec/dummy
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.2'
+          bundler-cache: true
+          working-directory: spec/dummy
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'yarn'
+          cache-dependency-path: spec/dummy/yarn.lock
+
+      - name: Install yalc
+        run: npm install -g yalc
+
+      - name: Build TypeScript
+        run: |
+          cd ../..
+          yarn install --frozen-lockfile --production=false
+          yarn build
+
+      - name: Publish shakapacker to yalc
+        run: |
+          cd ../..
+          yalc publish
+
+      - name: Install dependencies
+        run: |
+          yalc link shakapacker
+          yarn install
+
+      - name: Switch to Webpack
+        run: bin/test-bundler webpack
+
+      - name: Build with Webpack
+        run: bin/shakapacker
+
+      - name: Run tests with Webpack
+        run: |
+          bundle exec rspec
+
+  test-rspack:
+    name: Test with RSpack
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: spec/dummy
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.2'
+          bundler-cache: true
+          working-directory: spec/dummy
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'yarn'
+          cache-dependency-path: spec/dummy/yarn.lock
+
+      - name: Install yalc
+        run: npm install -g yalc
+
+      - name: Build TypeScript
+        run: |
+          cd ../..
+          yarn install --frozen-lockfile --production=false
+          yarn build
+
+      - name: Publish shakapacker to yalc
+        run: |
+          cd ../..
+          yalc publish
+
+      - name: Install dependencies
+        run: |
+          yalc link shakapacker
+          yarn install
+
+      - name: Switch to RSpack
+        run: bin/test-bundler rspack
+
+      - name: Build with RSpack
+        run: bin/shakapacker
+
+      - name: Run tests with RSpack
+        run: |
+          bundle exec rspec
+
+  test-switching:
+    name: Test Bundler Switching
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: spec/dummy
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.2'
+          bundler-cache: true
+          working-directory: spec/dummy
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'yarn'
+          cache-dependency-path: spec/dummy/yarn.lock
+
+      - name: Install yalc
+        run: npm install -g yalc
+
+      - name: Build TypeScript
+        run: |
+          cd ../..
+          yarn install --frozen-lockfile --production=false
+          yarn build
+
+      - name: Publish shakapacker to yalc
+        run: |
+          cd ../..
+          yalc publish
+
+      - name: Install dependencies
+        run: |
+          yalc link shakapacker
+          yarn install
+
+      - name: Test switching between bundlers
+        run: |
+          # Start with webpack
+          bin/test-bundler webpack
+          bin/shakapacker
+
+          # Switch to rspack
+          bin/test-bundler rspack
+          bin/shakapacker
+
+          # Switch back to webpack
+          bin/test-bundler webpack
+          bin/shakapacker

data/.gitignore

@@ -11,6 +11,26 @@ yarn-error.log*
 /log
 gemfiles/*.lock
 .DS_Store
+.eslintcache
 
 .yalc
 yalc.lock
+
+# Config exporter output directory
+shakapacker-config-exports/
+
+# TypeScript generated files
+package/**/*.d.ts
+package/**/*.d.ts.map
+package/**/*.js.map
+# Ignore compiled JS files from TypeScript sources
+package/**/*.js
+# Keep specific files that are not TypeScript-generated
+!package/index.d.ts
+!package/loaders.d.ts
+!package/webpack-types.d.ts
+!package/babel/preset-react.js
+!package/loaders/*.js
+!package/__mocks__/*.js
+!package/utils/get_style_rule.js
+!package/utils/node_modules.js

data/.husky/pre-commit

@@ -0,0 +1,2 @@
+#!/usr/bin/env sh
+npx lint-staged