shakapacker 7.3.0.beta.1 → 8.0.0.rc.2

data/spec/backward_compatibility_specs/manifest_spec.rb

@@ -1,100 +0,0 @@
-require_relative "spec_helper_initializer"
-
-describe "Webpacker::Manifest" do
-  let(:manifest_path) { File.expand_path File.join(File.dirname(__FILE__), "webpacker_test_app/public/packs", "manifest.json").to_s }
-
-  it "#lookup! raises an exception for a non-existing asset file" do
-    asset_file = "calendar.js"
-    expected_error_message = "Shakapacker can't find #{asset_file} in #{manifest_path}"
-
-    allow(Webpacker.config).to receive(:compile?).and_return(false)
-
-    expect {
-      Webpacker.manifest.lookup!(asset_file)
-    }.to raise_error(Webpacker::Manifest::MissingEntryError, /#{expected_error_message}/)
-  end
-
-  it "#lookup! raises an exception for a non-existing asset file with type and without an extension" do
-    asset_file = "calendar"
-    expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
-
-    allow(Webpacker.config).to receive(:compile?).and_return(false)
-
-    expect {
-      Webpacker.manifest.lookup!(asset_file, type: :javascript)
-    }.to raise_error(Webpacker::Manifest::MissingEntryError, /#{expected_error_message}/)
-  end
-
-  it "#lookup! returns the path to the bundled bootstrap.js" do
-    actual = Webpacker.manifest.lookup!("bootstrap.js")
-    expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup_pack_with_chunks! returns an array of paths to the bundled bootstrap of type javascript" do
-    actual = Webpacker.manifest.lookup_pack_with_chunks!("bootstrap", type: :javascript)
-    expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup_with_chunks! returns an array of paths to the bundled bootstrap.js of type javascript" do
-    actual = Webpacker.manifest.lookup_pack_with_chunks!("bootstrap.js", type: :javascript)
-    expected = ["/packs/bootstrap-300631c4f0e0f9c865bc.js"]
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application' without an extension and in a sub-directory" do
-    actual = Webpacker.manifest.lookup_pack_with_chunks!("print/application", type: :css)
-    expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup_with_chunks! returns an array of paths to the bundled 'print/application.css' in a sub-directory" do
-    actual = Webpacker.manifest.lookup_pack_with_chunks!("print/application.css", type: :css)
-    expected = ["/packs/print/application-983b6c164a47f7ed49cd.css"]
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup returns nil for non-existing asset files" do
-    expect(Webpacker.manifest.lookup("foo.js")).to be nil
-  end
-
-  it "#lookup_pack_with_chunks returns nil for non-existing asset files" do
-    expect(Webpacker.manifest.lookup_pack_with_chunks("foo.js")).to be nil
-  end
-
-  it "#lookup returns the path for bootstrap.js" do
-    actual = Webpacker.manifest.lookup("bootstrap.js")
-    expected = "/packs/bootstrap-300631c4f0e0f9c865bc.js"
-
-    expect(actual).to eq expected
-  end
-
-  it "#lookup_pack_with_chunks! raises an exception for non-existing asset files" do
-    asset_file = "calendar"
-
-    expected_error_message = "Shakapacker can't find #{asset_file}.js in #{manifest_path}"
-
-    allow(Webpacker.config).to receive(:compile?).and_return(false)
-
-    expect {
-      Webpacker.manifest.lookup_pack_with_chunks!(asset_file, type: :javascript)
-    }.to raise_error(Shakapacker::Manifest::MissingEntryError, /#{expected_error_message}/)
-  end
-
-  it "#lookup_pack_with_chunks! returns an array of paths to bundled js files with 'application' in their name" do
-    actual_application_entrypoints = Webpacker.manifest.lookup_pack_with_chunks!("application", type: :javascript)
-    expected_application_entrypoints = [
-      "/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js",
-      "/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js",
-      "/packs/application-k344a6d59eef8632c9d1.js"
-    ]
-
-    expect(actual_application_entrypoints).to eq expected_application_entrypoints
-  end
-end

data/spec/backward_compatibility_specs/mtime_strategy_spec.rb

@@ -1,55 +0,0 @@
-require_relative "spec_helper_initializer"
-
-describe "Webpacker::MtimeStrategy" do
-  let(:mtime_strategy) { Webpacker::MtimeStrategy.new }
-  let(:manifest_timestamp) { Time.parse("2021-01-01 12:34:56 UTC") }
-
-  describe "#fresh?" do
-    it "returns false when the manifest is missing" do
-      latest_timestamp = manifest_timestamp + 3600
-
-      with_stubs(latest_timestamp: latest_timestamp.to_i, manifest_exists: false) do
-        expect(mtime_strategy.fresh?).to be false
-      end
-    end
-
-    it "returns false when the manifest is older" do
-      latest_timestamp = manifest_timestamp + 3600
-
-      with_stubs(latest_timestamp: latest_timestamp.to_i) do
-        expect(mtime_strategy.fresh?).to be false
-      end
-    end
-
-    it "returns true when the manifest is new" do
-      latest_timestamp = manifest_timestamp - 3600
-
-      with_stubs(latest_timestamp: latest_timestamp.to_i) do
-        expect(mtime_strategy.fresh?).to be true
-      end
-    end
-  end
-
-  describe "#stale?" do
-    it "returns false when #fresh? is true" do
-      expect(mtime_strategy).to receive(:fresh?).and_return(true)
-
-      expect(mtime_strategy.stale?).to be false
-    end
-
-    it "returns true when #fresh? is false" do
-      expect(mtime_strategy).to receive(:fresh?).and_return(false)
-
-      expect(mtime_strategy.stale?).to be true
-    end
-  end
-
-  private
-
-    def with_stubs(latest_timestamp:, manifest_exists: true)
-      allow(mtime_strategy).to receive(:latest_modified_timestamp).and_return(latest_timestamp)
-      allow(FileTest).to receive(:exist?).and_return(manifest_exists)
-      allow(File).to receive(:mtime).and_return(manifest_timestamp)
-      yield
-    end
-end

data/spec/backward_compatibility_specs/rake_tasks_spec.rb

@@ -1,41 +0,0 @@
-require_relative "spec_helper_initializer"
-
-describe "RakeTasks" do
-  TEST_APP_PATH = File.expand_path("webpacker_test_app", __dir__)
-
-  it "`rake -T` lists Webpacker tasks" do
-    output = Dir.chdir(TEST_APP_PATH) { `rake -T` }
-
-    expect(output).to match /webpacker .+DEPRECATED/
-    expect(output).to match /webpacker:check_binstubs.+DEPRECATED/
-    expect(output).to match /webpacker:check_node.+DEPRECATED/
-    expect(output).to match /webpacker:check_yarn.+DEPRECATED/
-    expect(output).to match /webpacker:clean.+DEPRECATED/
-    expect(output).to match /webpacker:clobber.+DEPRECATED/
-    expect(output).to match /webpacker:compile.+DEPRECATED/
-    expect(output).to match /webpacker:install.+DEPRECATED/
-    expect(output).to match /webpacker:verify_install.+DEPRECATED/
-  end
-
-  it "`webpacker:check_binstubs` doesn't get 'webpack binstub not found' error" do
-    output = Dir.chdir(TEST_APP_PATH) { `rake webpacker:check_binstubs 2>&1` }
-
-    expect(output).to_not include "webpack binstub not found."
-    expect(output).to include "DEPRECATION"
-  end
-
-  it "`webpacker:check_node` doesn't get 'webpacker requires Node.js' error" do
-    output = Dir.chdir(TEST_APP_PATH) { `rake webpacker:check_node 2>&1` }
-
-    expect(output).to_not include "Shakapacker requires Node.js"
-    expect(output).to include "DEPRECATION"
-  end
-
-  it "`webpacker:check_yarn` doesn't get error related to yarn" do
-    output = Dir.chdir(TEST_APP_PATH) { `rake webpacker:check_yarn 2>&1` }
-
-    expect(output).to_not include "Yarn not installed"
-    expect(output).to_not include "Shakapacker requires Yarn"
-    expect(output).to include "DEPRECATION"
-  end
-end

data/spec/backward_compatibility_specs/spec_helper_initializer.rb

@@ -1,24 +0,0 @@
-require_relative "webpacker_test_app/config/environment"
-
-Rails.env = "production"
-
-Webpacker.instance = ::Webpacker::Instance.new
-
-def reloaded_config
-  Webpacker.instance.instance_variable_set(:@env, nil)
-  Webpacker.instance.instance_variable_set(:@config, nil)
-  Webpacker.instance.instance_variable_set(:@dev_server, nil)
-  Webpacker.env
-  Webpacker.config
-  Webpacker.dev_server
-end
-
-def with_rails_env(env)
-  original = Rails.env
-  Rails.env = ActiveSupport::StringInquirer.new(env)
-  reloaded_config
-  yield
-ensure
-  Rails.env = ActiveSupport::StringInquirer.new(original)
-  reloaded_config
-end

data/spec/backward_compatibility_specs/webpack_runner_spec.rb

@@ -1,86 +0,0 @@
-require_relative "spec_helper_initializer"
-# Requiring from webpacker directory to ensure old ./bin/webpacker-dev-server works fine
-require "webpacker/webpack_runner"
-
-describe "WebpackRunner" do
-  before :all do
-    @original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
-    @original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
-  end
-
-  after :all do
-    ENV["NODE_ENV"] = @original_node_env
-    ENV["RAILS_ENV"] = @original_rails_env
-  end
-
-  let(:test_app_path) { File.expand_path("./webpacker_test_app", __dir__) }
-
-  NODE_PACKAGE_MANAGERS.each do |fallback_manager|
-    context "when using package_json with #{fallback_manager} as the manager" do
-      with_use_package_json_gem(enabled: true, fallback_manager: fallback_manager)
-
-      let(:package_json) { PackageJson.read(test_app_path) }
-
-      require "package_json"
-
-      it "uses the expected package manager", unless: fallback_manager == "yarn_classic" do
-        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js"])
-
-        manager_name = fallback_manager.split("_")[0]
-
-        expect(cmd).to start_with(manager_name)
-      end
-
-      it "runs the command using the manager" do
-        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js"])
-
-        verify_command(cmd)
-      end
-
-      it "passes on arguments" do
-        cmd = package_json.manager.native_exec_command("webpack", ["--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"])
-
-        verify_command(cmd, argv: (["--watch"]))
-      end
-    end
-  end
-
-  context "when not using package_json" do
-    with_use_package_json_gem(enabled: false)
-
-    it "supports running via node_modules" do
-      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-
-      verify_command(cmd, use_node_modules: true)
-    end
-
-    it "supports running via yarn" do
-      cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js"]
-
-      verify_command(cmd, use_node_modules: false)
-    end
-
-    it "passes on arguments" do
-      cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/webpack.config.js", "--watch"]
-
-      verify_command(cmd, argv: ["--watch"])
-    end
-  end
-
-  private
-
-    def verify_command(cmd, use_node_modules: true, argv: [])
-      Dir.chdir(test_app_path) do
-        klass = Webpacker::WebpackRunner
-        instance = klass.new(argv)
-
-        allow(klass).to receive(:new).and_return(instance)
-        allow(instance).to receive(:node_modules_bin_exist?).and_return(use_node_modules)
-        allow(Kernel).to receive(:exec)
-
-        klass.run(argv)
-
-        expect(Kernel).to have_received(:exec).with(Webpacker::Compiler.env, *cmd)
-      end
-    end
-end

data/spec/backward_compatibility_specs/webpacker_spec.rb

@@ -1,41 +0,0 @@
-require_relative "spec_helper_initializer"
-
-describe "webpacker" do
-  describe "#inline_css?" do
-    let(:dev_server) { instance_double("Webpacker::DevServer") }
-
-    before :each do
-      allow(dev_server).to receive(:host).and_return("localhost")
-      allow(dev_server).to receive(:port).and_return("3035")
-      allow(dev_server).to receive(:pretty?).and_return(false)
-      allow(dev_server).to receive(:https?).and_return(true)
-      allow(dev_server).to receive(:running?).and_return(true)
-    end
-
-    it "returns nil with disabled dev_server" do
-      expect(Webpacker.inlining_css?).to be nil
-    end
-
-    it "returns true with enabled hmr" do
-      allow(dev_server).to receive(:hmr?).and_return(true)
-      allow(dev_server).to receive(:inline_css?).and_return(true)
-
-      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
-
-      expect(Webpacker.inlining_css?).to be true
-    end
-
-    it "returns false with enabled hmr and explicitly setting inline_css to false" do
-      allow(dev_server).to receive(:hmr?).and_return(true)
-      allow(dev_server).to receive(:inline_css?).and_return(false)
-
-      allow(Webpacker.instance).to receive(:dev_server).and_return(dev_server)
-
-      expect(Webpacker.inlining_css?).to be false
-    end
-  end
-
-  it "has app_autoload_paths cleanup" do
-    expect($test_app_autoload_paths_in_initializer).to eq []
-  end
-end

data/spec/backward_compatibility_specs/webpacker_test_app/.gitignore

@@ -1,2 +0,0 @@
-log/
-tmp/

data/spec/backward_compatibility_specs/webpacker_test_app/Rakefile

@@ -1,3 +0,0 @@
-require_relative "config/application"
-
-Rails.application.load_tasks

data/spec/backward_compatibility_specs/webpacker_test_app/app/packs/entrypoints/application.js

@@ -1,10 +0,0 @@
-/* eslint no-console:0 */
-// This file is automatically compiled by Webpack, along with any other files
-// present in this directory. You're encouraged to place your actual application logic in
-// a relevant structure within app/packs and only use these pack files to reference
-// that code so it'll be compiled.
-//
-// To reference this file, add <%= javascript_pack_tag 'application' %> to the appropriate
-// layout file, like app/views/layouts/application.html.erb
-
-console.log('Hello World from shakapacker')

data/spec/backward_compatibility_specs/webpacker_test_app/app/packs/entrypoints/generated/something.js

@@ -1,2 +0,0 @@
-/* eslint no-console:0 */
-console.log('entrypoints/nested/something')

data/spec/backward_compatibility_specs/webpacker_test_app/app/packs/entrypoints/multi_entry.css

@@ -1,4 +0,0 @@
-/*
- * Dummy file #1 for Multi File Entry points: https://webpack.js.org/guides/entry-advanced/
- * This file must be named the same
- */

data/spec/backward_compatibility_specs/webpacker_test_app/app/packs/entrypoints/multi_entry.js

@@ -1,4 +0,0 @@
-/*
- * Dummy file #2 for Multi File Entry points: https://webpack.js.org/guides/entry-advanced/
- * This file must be named the same
- */

data/spec/backward_compatibility_specs/webpacker_test_app/bin/webpacker

@@ -1,13 +0,0 @@
-#!/usr/bin/env ruby
-
-ENV["RAILS_ENV"] ||= "development"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
-
-require "bundler/setup"
-require "webpacker"
-require "webpacker/webpack_runner"
-
-APP_ROOT = File.expand_path("..", __dir__)
-Dir.chdir(APP_ROOT) do
-  Webpacker::WebpackRunner.run(ARGV)
-end

data/spec/backward_compatibility_specs/webpacker_test_app/bin/webpacker-dev-server

@@ -1,13 +0,0 @@
-#!/usr/bin/env ruby
-
-ENV["RAILS_ENV"] ||= "development"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
-
-require "bundler/setup"
-require "webpacker"
-require "webpacker/dev_server_runner"
-
-APP_ROOT = File.expand_path("..", __dir__)
-Dir.chdir(APP_ROOT) do
-  Webpacker::DevServerRunner.run(ARGV)
-end

data/spec/backward_compatibility_specs/webpacker_test_app/config/application.rb

@@ -1,11 +0,0 @@
-require "action_controller/railtie"
-require "action_view/railtie"
-require "shakapacker"
-
-module WebpackerTestApp
-  class Application < ::Rails::Application
-    config.secret_key_base = "abcdef"
-    config.eager_load = true
-    config.active_support.test_order = :sorted
-  end
-end

data/spec/backward_compatibility_specs/webpacker_test_app/config/environment.rb

@@ -1,4 +0,0 @@
-require_relative "application"
-
-Rails.backtrace_cleaner.remove_silencers!
-Rails.application.initialize!

data/spec/backward_compatibility_specs/webpacker_test_app/config/initializers/inspect_autoload_paths.rb

@@ -1 +0,0 @@
-$test_app_autoload_paths_in_initializer = ActiveSupport::Dependencies.autoload_paths

data/spec/backward_compatibility_specs/webpacker_test_app/config/webpacker.yml

@@ -1,83 +0,0 @@
-# Note: You must restart bin/shakapacker-dev-server for changes to take effect
-
-default: &default
-  source_path: app/packs
-  source_entry_path: entrypoints
-  nested_entries: false
-  public_root_path: public
-  public_output_path: packs
-  cache_path: tmp/webpacker
-  webpack_compile_output: false
-  webpack_loader: babel
-
-  # Location for manifest.json, defaults to {public_output_path}/manifest.json if unset
-  # manifest_path: public/packs/manifest.json
-
-  # Additional paths webpack should look up modules
-  # ['app/assets', 'engine/foo/app/assets']
-  additional_paths:
-    - app/assets
-    - /etc/yarn
-    - some.config.js
-    - app/elm
-
-  # Reload manifest.json on all requests so we reload latest compiled packs
-  cache_manifest: false
-
-  static_assets_extensions:
-    - .jpg
-    - .jpeg
-    - .png
-    - .gif
-    - .tiff
-    - .ico
-    - .svg
-
-  extensions:
-    - .mjs
-    - .js
-
-development:
-  <<: *default
-  compile: true
-  ensure_consistent_versioning: true
-
-  # Reference: https://webpack.js.org/configuration/dev-server/
-  dev_server:
-    https: false
-    host: localhost
-    port: 3035
-    public: localhost:3035
-    hmr: true
-    overlay: true
-    disable_host_check: true
-    use_local_ip: false
-    pretty: false
-
-test:
-  <<: *default
-  compile: true
-
-  # Compile test packs to a separate directory
-  public_output_path: packs-test
-
-production:
-  <<: *default
-
-  # Production depends on precompilation of packs prior to booting for performance.
-  compile: false
-
-  # Cache manifest.json for performance
-  cache_manifest: true
-
-staging:
-  <<: *default
-
-  # Production depends on precompilation of packs prior to booting for performance.
-  compile: false
-
-  # Cache manifest.json for performance
-  cache_manifest: true
-
-  # Compile staging packs to a separate directory
-  public_output_path: packs-staging

data/spec/backward_compatibility_specs/webpacker_test_app/config/webpacker_css_extract_ignore_order_warnings.yml

@@ -1,84 +0,0 @@
-# Note: You must restart bin/shakapacker-dev-server for changes to take effect
-
-default: &default
-  source_path: app/packs
-  source_entry_path: entrypoints
-  nested_entries: true
-  public_root_path: public
-  public_output_path: packs
-  cache_path: tmp/webpacker
-  webpack_compile_output: false
-  webpack_loader: babel
-  css_extract_ignore_order_warnings: true
-
-  # Location for manifest.json, defaults to {public_output_path}/manifest.json if unset
-  # manifest_path: public/packs/manifest.json
-
-  # Additional paths webpack should look up modules
-  # ['app/assets', 'engine/foo/app/assets']
-  additional_paths:
-    - app/assets
-    - /etc/yarn
-    - some.config.js
-    - app/elm
-
-  # Reload manifest.json on all requests so we reload latest compiled packs
-  cache_manifest: false
-
-  static_assets_extensions:
-    - .jpg
-    - .jpeg
-    - .png
-    - .gif
-    - .tiff
-    - .ico
-    - .svg
-
-  extensions:
-    - .mjs
-    - .js
-
-development:
-  <<: *default
-  compile: true
-  ensure_consistent_versioning: true
-
-  # Reference: https://webpack.js.org/configuration/dev-server/
-  dev_server:
-    https: false
-    host: localhost
-    port: 3035
-    public: localhost:3035
-    hmr: false
-    overlay: true
-    disable_host_check: true
-    use_local_ip: false
-    pretty: false
-
-test:
-  <<: *default
-  compile: true
-
-  # Compile test packs to a separate directory
-  public_output_path: packs-test
-
-production:
-  <<: *default
-
-  # Production depends on precompilation of packs prior to booting for performance.
-  compile: false
-
-  # Cache manifest.json for performance
-  cache_manifest: true
-
-staging:
-  <<: *default
-
-  # Production depends on precompilation of packs prior to booting for performance.
-  compile: false
-
-  # Cache manifest.json for performance
-  cache_manifest: true
-
-  # Compile staging packs to a separate directory
-  public_output_path: packs-staging

data/spec/backward_compatibility_specs/webpacker_test_app/config/webpacker_defaults_fallback.yml

@@ -1,11 +0,0 @@
-# Note: You must restart bin/shakapacker-dev-server for changes to take effect
-
-default: &default
-  # cache_manifest will be fetched from bundled defaults
-  webpacker_precompile: false
-
-staging:
-  <<: *default
-
-production:
-  <<: *default