shakapacker 7.2.3 → 8.0.0.pre.rc.1

data/lib/shakapacker/deprecation_helper.rb

@@ -1,87 +1,9 @@
 require "thor"
 
 module Shakapacker
-  DEPRECATION_GUIDE_URL = "https://github.com/shakacode/shakapacker/blob/main/docs/v7_upgrade.md"
-  DEPRECATION_MESSAGE = <<~MSG
-    DEPRECATION NOTICE:
-
-    Using webpacker spelling is deprecated in Shakapacker.
-    Update your project with the new spelling.
-
-    For more information about this process, check:
-    #{DEPRECATION_GUIDE_URL}
-  MSG
   SHELL = Thor::Shell::Color.new
 
-  def get_config_file_path_with_backward_compatibility(config_path)
-    if config_path.to_s.end_with?("shakapacker.yml") && !File.exist?(config_path)
-      webpacker_config_path = if config_path.class == Pathname
-        Pathname.new(config_path.to_s.gsub("shakapacker.yml", "webpacker.yml"))
-      else
-        config_path.gsub("shakapacker.yml", "webpacker.yml")
-      end
-
-      if File.exist?(webpacker_config_path)
-        puts_deprecation_message(
-          short_deprecation_message(
-            "config/webpacker.yml",
-            "config/shakapacker.yml"
-          )
-        )
-        return webpacker_config_path
-      end
-    end
-
-    config_path
-  end
-
-  def set_shakapacker_env_variables_for_backward_compatibility
-    webpacker_env_variables = ENV.select { |key| key.start_with?("WEBPACKER_") }
-
-    deprecation_message_body = ""
-
-    webpacker_env_variables.each do |webpacker_key, _|
-      shakapacker_key = webpacker_key.gsub("WEBPACKER_", "SHAKAPACKER_")
-      next if ENV.key?(shakapacker_key)
-
-      deprecation_message_body += <<~MSG
-        Use `#{shakapacker_key}` instead of the deprecated `#{webpacker_key}`.
-      MSG
-
-      ENV[shakapacker_key] = ENV[webpacker_key]
-    end
-
-    if deprecation_message_body.present?
-      Shakapacker.puts_deprecation_message(
-        <<~MSG
-          DEPRECATION NOTICE:
-
-          #{deprecation_message_body}
-          Read more: #{Shakapacker::DEPRECATION_GUIDE_URL}
-        MSG
-      )
-    end
-  end
-
-  def short_deprecation_message(old_usage, new_usage)
-    <<~MSG
-      DEPRECATION NOTICE:
-
-      Consider using `#{new_usage}` instead of the deprecated `#{old_usage}`.
-      Read more: #{DEPRECATION_GUIDE_URL}
-    MSG
-  end
-
   def puts_deprecation_message(message)
     SHELL.say "\n#{message}\n", :yellow
   end
-
-  def puts_rake_deprecation_message(webpacker_task_name)
-    Shakapacker.puts_deprecation_message(
-      Shakapacker.short_deprecation_message(
-        "rake #{webpacker_task_name}",
-        "rake #{webpacker_task_name.gsub("webpacker", "shakapacker")}"
-      )
-    )
-  end
 end

data/lib/shakapacker/dev_server.rb

@@ -30,21 +30,6 @@ class Shakapacker::DevServer
     fetch(:port)
   end
 
-  def https?
-    value = fetch(:https)
-
-    unless value.nil?
-      puts "WARNING: `https: true` has been deprecated in favor of `server: 'https'`"
-    end
-
-    case value
-    when true, "true", Hash
-      true
-    else
-      false
-    end
-  end
-
   def server
     server_value = fetch(:server)
     server_type = server_value.is_a?(Hash) ? server_value[:type] : server_value
@@ -65,7 +50,7 @@ class Shakapacker::DevServer
   end
 
   def protocol
-    return "https" if server == "https" || https? == true
+    return "https" if server == "https"
 
     "http"
   end

data/lib/shakapacker/dev_server_runner.rb

@@ -70,16 +70,7 @@ module Shakapacker
 
         cmd = build_cmd
 
-        if @argv.include?("--debug-webpacker")
-          Shakapacker.puts_deprecation_message(
-            Shakapacker.short_deprecation_message(
-              "--debug-webpacker",
-              "--debug-shakapacker"
-            )
-          )
-        end
-
-        if @argv.delete("--debug-shakapacker") || @argv.delete("--debug-webpacker")
+        if @argv.delete("--debug-shakapacker")
           env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --inspect-brk --trace-warnings"
         end
 
@@ -98,17 +89,7 @@ module Shakapacker
       end
 
       def build_cmd
-        if Shakapacker::Utils::Misc.use_package_json_gem
-          return package_json.manager.native_exec_command("webpack", ["serve"])
-        end
-
-        return ["#{@node_modules_bin_path}/webpack", "serve"] if node_modules_bin_exist?
-
-        ["yarn", "webpack", "serve"]
-      end
-
-      def node_modules_bin_exist?
-        File.exist?("#{@node_modules_bin_path}/webpack-dev-server")
+        package_json.manager.native_exec_command("webpack", ["serve"])
       end
   end
 end

data/lib/shakapacker/env.rb

@@ -20,7 +20,7 @@ class Shakapacker::Env
     end
 
     def fallback_env_warning
-      logger.info "RAILS_ENV=#{Rails.env} environment is not defined in config/shakapacker.yml, falling back to #{Shakapacker::DEFAULT_ENV} environment"
+      logger.info "RAILS_ENV=#{Rails.env} environment is not defined in #{config_path}, falling back to #{Shakapacker::DEFAULT_ENV} environment"
     end
 
     def available_environments

data/lib/shakapacker/instance.rb

@@ -7,9 +7,7 @@ class Shakapacker::Instance
 
   def initialize(root_path: Rails.root, config_path: Rails.root.join("config/shakapacker.yml"))
     @root_path = root_path
-
-    # For backward compatibility
-    @config_path = Shakapacker.get_config_file_path_with_backward_compatibility(config_path)
+    @config_path = Pathname.new(ENV["SHAKAPACKER_CONFIG"] || config_path)
   end
 
   def env

data/lib/shakapacker/manifest.rb

@@ -105,7 +105,7 @@ class Shakapacker::Manifest
     def missing_file_from_manifest_error(bundle_name)
       <<-MSG
 Shakapacker can't find #{bundle_name} in #{config.manifest_path}. Possible causes:
-1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node
+1. You forgot to install javascript packages or are running an incompatible javascript runtime version
 2. Your app has code with a non-standard extension (like a `.jsx` file) but the extension is not in the `extensions` config in `config/shakapacker.yml`
 3. You have set compile: false (see `config/shakapacker.yml`) for this environment
    (unless you are using the `bin/shakapacker -w` or the `bin/shakapacker-dev-server`, in which case maybe you aren't running the dev server in the background?)

data/lib/shakapacker/railtie.rb

@@ -3,6 +3,7 @@ require "rails/railtie"
 require "shakapacker/helper"
 require "shakapacker/dev_server_proxy"
 require "shakapacker/version_checker"
+require "shakapacker/utils/manager"
 
 class Shakapacker::Engine < ::Rails::Engine
   # Allows Shakapacker config values to be set via Rails env config files
@@ -14,6 +15,12 @@ class Shakapacker::Engine < ::Rails::Engine
     end
   end
 
+  initializer "shakapacker.manager_checker" do
+    if File.exist?(Shakapacker::VersionChecker::NodePackageVersion.package_json_path)
+      Shakapacker::Utils::Manager.error_unless_package_manager_is_obvious!
+    end
+  end
+
   initializer "shakapacker.proxy" do |app|
     if (Shakapacker.config.dev_server.present? rescue nil)
       app.middleware.insert_before 0,

data/lib/shakapacker/runner.rb

@@ -1,4 +1,6 @@
 require "shakapacker/utils/misc"
+require "shakapacker/utils/manager"
+require "package_json"
 
 module Shakapacker
   class Runner
@@ -13,34 +15,18 @@ module Shakapacker
 
       @app_path              = File.expand_path(".", Dir.pwd)
       @webpack_config        = File.join(@app_path, "config/webpack/webpack.config.js")
-
-      Shakapacker.set_shakapacker_env_variables_for_backward_compatibility
-
-      @node_modules_bin_path = fetch_node_modules_bin_path
       @shakapacker_config    = ENV["SHAKAPACKER_CONFIG"] || File.join(@app_path, "config/shakapacker.yml")
 
-      @shakapacker_config = Shakapacker.get_config_file_path_with_backward_compatibility(@shakapacker_config)
-
       unless File.exist?(@webpack_config)
         $stderr.puts "webpack config #{@webpack_config} not found, please run 'bundle exec rails shakapacker:install' to install Shakapacker with default configs or add the missing config file for your custom environment."
         exit!
       end
-    end
 
-    def fetch_node_modules_bin_path
-      return nil if Shakapacker::Utils::Misc.use_package_json_gem
-
-      ENV["SHAKAPACKER_NODE_MODULES_BIN_PATH"] || `yarn bin`.chomp
+      Shakapacker::Utils::Manager.error_unless_package_manager_is_obvious!
     end
 
     def package_json
-      if @package_json.nil?
-        Shakapacker::Utils::Misc.require_package_json_gem
-
-        @package_json = PackageJson.read(@app_path)
-      end
-
-      @package_json
+      @package_json ||= PackageJson.read(@app_path)
     end
   end
 end

data/lib/shakapacker/utils/manager.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require "package_json"
+
+module Shakapacker
+  module Utils
+    class Manager
+      class Error < StandardError; end
+
+      MANAGER_LOCKS = {
+        "bun" => "bun.lockb",
+        "npm" => "package-lock.json",
+        "pnpm" => "pnpm-lock.yaml",
+        "yarn" => "yarn.lock"
+      }
+
+      # Emits a warning if it's not obvious what package manager to use
+      def self.error_unless_package_manager_is_obvious!
+        return unless PackageJson.read.fetch("packageManager", nil).nil?
+
+        guessed_binary = guess_binary
+
+        return if guessed_binary == "npm"
+
+        raise Error, <<~MSG
+          You don't have "packageManager" set in your package.json
+          meaning that Shakapacker will use npm but you've got a #{MANAGER_LOCKS[guessed_binary]}
+          file meaning you probably want to be using #{guessed_binary} instead.
+
+          To make this happen, set "packageManager" in your package.json to #{guessed_binary}@#{guess_version}
+        MSG
+      end
+
+      # Guesses the binary of the package manager to use based on what lockfiles exist
+      #
+      # @return [String]
+      def self.guess_binary
+        MANAGER_LOCKS.find { |_, lock| File.exist?(lock) }&.first || "npm"
+      end
+
+      # Guesses the version of the package manager to use by calling `<manager> --version`
+      #
+      # @return [String]
+      def self.guess_version
+        require "open3"
+
+        command = "#{guess_binary} --version"
+        stdout, stderr, status = Open3.capture3(command)
+
+        unless status.success?
+          raise Error, "#{command} failed with exit code #{status.exitstatus}: #{stderr}"
+        end
+
+        stdout.chomp
+      end
+    end
+  end
+end

data/lib/shakapacker/utils/misc.rb

@@ -8,18 +8,6 @@ module Shakapacker
     class Misc
       extend FileUtils
 
-      def self.use_package_json_gem
-        ENV.fetch("SHAKAPACKER_USE_PACKAGE_JSON_GEM", "false").casecmp("true").zero?
-      end
-
-      def self.require_package_json_gem
-        unless use_package_json_gem
-          raise "PackageJson should not be used unless SHAKAPACKER_USE_PACKAGE_JSON_GEM is true"
-        end
-
-        require "package_json"
-      end
-
       def self.uncommitted_changes?(message_handler)
         return false if ENV["COVERAGE"] == "true"
 

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "7.2.3".freeze
+  VERSION = "8.0.0-rc.1".freeze
 end

data/lib/shakapacker/version_checker.rb

@@ -17,41 +17,19 @@ module Shakapacker
 
     def raise_if_gem_and_node_package_versions_differ
       # Skip check if package is not in package.json or listed from relative path, git repo or github URL
-      return if node_package_version.skip_processing?
+      # or if consistent version checking is not enabled
+      return if node_package_version.skip_processing? || !Shakapacker.config.ensure_consistent_versioning?
 
       node_major_minor_patch = node_package_version.major_minor_patch
       gem_major_minor_patch = gem_major_minor_patch_version
-      versions_match = node_major_minor_patch[0] == gem_major_minor_patch[0] &&
-                       node_major_minor_patch[1] == gem_major_minor_patch[1] &&
-                       node_major_minor_patch[2] == gem_major_minor_patch[2]
 
-      uses_wildcard = node_package_version.semver_wildcard?
+      raise_differing_versions_warning unless (
+        node_major_minor_patch[0] == gem_major_minor_patch[0] &&
+        node_major_minor_patch[1] == gem_major_minor_patch[1] &&
+        node_major_minor_patch[2] == gem_major_minor_patch[2]
+      )
 
-      if !Shakapacker.config.ensure_consistent_versioning? && (uses_wildcard || !versions_match)
-        check_failed = if uses_wildcard
-          "Semver wildcard without a lockfile detected"
-        else
-          "Version mismatch detected"
-        end
-
-        warn <<-MSG.strip_heredoc
-          Shakapacker::VersionChecker - #{check_failed}
-
-          You are currently not checking for consistent versions of shakapacker gem and npm package. A version mismatch or usage of semantic versioning wildcard (~ or ^) without a lockfile has been detected.
-
-          Version mismatch can lead to incorrect behavior and bugs. You should ensure that both the gem and npm package dependencies are locked to the same version.
-
-          You can enable the version check by setting `ensure_consistent_versioning: true` in your `shakapacker.yml` file.
-
-          Checking for gem and npm package versions mismatch or wildcard will be enabled by default in the next major version of shakapacker.
-        MSG
-
-        return
-      end
-
-      raise_differing_versions_warning unless versions_match
-
-      raise_node_semver_version_warning if uses_wildcard
+      raise_node_semver_version_warning if node_package_version.semver_wildcard?
     end
 
     private
@@ -87,6 +65,7 @@ module Shakapacker
         [match[1], match[2], match[3]]
       end
 
+      # TODO: this might as well use package_json
       class NodePackageVersion
         attr_reader :package_json
 

data/lib/shakapacker/webpack_runner.rb

@@ -23,16 +23,7 @@ module Shakapacker
 
       cmd = build_cmd
 
-      if @argv.include?("--debug-webpacker")
-        Shakapacker.puts_deprecation_message(
-          Shakapacker.short_deprecation_message(
-            "--debug-webpacker",
-            "--debug-shakapacker"
-          )
-        )
-      end
-
-      if @argv.delete("--debug-shakapacker") || @argv.delete("--debug-webpacker")
+      if @argv.delete("--debug-shakapacker")
         env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --inspect-brk"
       end
 
@@ -59,17 +50,7 @@ module Shakapacker
     private
 
       def build_cmd
-        if Shakapacker::Utils::Misc.use_package_json_gem
-          return package_json.manager.native_exec_command("webpack")
-        end
-
-        return ["#{@node_modules_bin_path}/webpack"] if node_modules_bin_exist?
-
-        ["yarn", "webpack"]
-      end
-
-      def node_modules_bin_exist?
-        File.exist?("#{@node_modules_bin_path}/webpack")
+        package_json.manager.native_exec_command("webpack")
       end
   end
 end

data/lib/shakapacker.rb

@@ -47,5 +47,3 @@ require "shakapacker/dev_server"
 require "shakapacker/deprecation_helper"
 
 require "shakapacker/railtie" if defined?(Rails)
-
-Webpacker = Shakapacker

data/lib/tasks/shakapacker/check_binstubs.rake

@@ -1,34 +1,20 @@
 namespace :shakapacker do
   desc "Verifies that bin/shakapacker is present"
   task :check_binstubs do
-    verify_file_existence("bin/shakapacker", "bin/webpacker")
-    verify_file_existence("bin/shakapacker-dev-server", "bin/webpacker-dev-server")
+    verify_file_existence("bin/shakapacker")
+    verify_file_existence("bin/shakapacker-dev-server")
   end
 end
 
-def verify_file_existance(main_file, alternative_file)
-  puts "verify_file_existance is deprecated - use verify_file_existence instead"
-  verify_file_existence(main_file, alternative_file)
-end
-
-def verify_file_existence(main_file, alternative_file)
-  unless File.exist?(Rails.root.join(main_file))
-    if File.exist?(Rails.root.join(alternative_file))
-      Shakapacker.puts_deprecation_message(
-        Shakapacker.short_deprecation_message(
-          alternative_file,
-          main_file
-        )
-      )
-    else
-      puts <<~MSG
-        Couldn't find shakapacker binstubs!
-        Possible solutions:
-        - Ensure you have run `rails shakapacker:install`.
-        - Run `rails shakapacker:binstubs` if you have already installed shakapacker.
-        - Ensure the `bin` directory, `bin/shakapacker`, and `bin/shakapacker-dev-server` are not included in .gitignore.
-      MSG
-      exit!
-    end
+def verify_file_existence(binstub_file)
+  unless File.exist?(Rails.root.join(binstub_file))
+    puts <<~MSG
+      Couldn't find shakapacker binstubs!
+      Possible solutions:
+      - Ensure you have run `rails shakapacker:install`.
+      - Run `rails shakapacker:binstubs` if you have already installed shakapacker.
+      - Ensure the `bin` directory, `bin/shakapacker`, and `bin/shakapacker-dev-server` are not included in .gitignore.
+    MSG
+    exit!
   end
 end

data/lib/tasks/shakapacker/check_manager.rake

@@ -1,15 +1,10 @@
 require "shakapacker/utils/misc"
+require "shakapacker/utils/manager"
 
 namespace :shakapacker do
   desc "Verifies if the expected JS package manager is installed"
-  task :check_manager do |task|
-    unless Shakapacker::Utils::Misc.use_package_json_gem
-      prefix = task.name.split(/#|shakapacker:/).first
-      Rake::Task["#{prefix}shakapacker:check_manager"].invoke
-      next
-    end
-
-    require "package_json"
+  task :check_manager do
+    Shakapacker::Utils::Manager.error_unless_package_manager_is_obvious!
 
     package_json = PackageJson.read
     pm = package_json.manager.binary

data/lib/tasks/shakapacker/info.rake

@@ -1,5 +1,6 @@
 require "shakapacker/version"
 require "shakapacker/utils/misc"
+require "shakapacker/utils/manager"
 
 namespace :shakapacker do
   desc "Provide information on Shakapacker's environment"
@@ -9,30 +10,20 @@ namespace :shakapacker do
       $stdout.puts "Rails: #{Rails.version}"
       $stdout.puts "Shakapacker: #{Shakapacker::VERSION}"
       $stdout.puts "Node: #{`node --version`}"
-      if Shakapacker::Utils::Misc.use_package_json_gem
-        require "package_json"
 
-        pj_manager = PackageJson.read.manager
+      Shakapacker::Utils::Manager.error_unless_package_manager_is_obvious!
 
-        $stdout.puts "#{pj_manager.binary}: #{pj_manager.version}"
-      else
-        $stdout.puts "Yarn: #{`yarn --version`}"
-      end
+      pj_manager = PackageJson.read.manager
 
-      if Shakapacker::Utils::Misc.use_package_json_gem
-        node_package_version = Shakapacker::VersionChecker.build.node_package_version.raw
-      else
-        node_package_version = `npm list shakapacker version`
-      end
+      $stdout.puts "#{pj_manager.binary}: #{pj_manager.version}"
+
+      node_package_version = Shakapacker::VersionChecker.build.node_package_version.raw
 
       $stdout.puts "\n"
       $stdout.puts "shakapacker: #{node_package_version}"
 
       $stdout.puts "Is bin/shakapacker present?: #{File.exist? 'bin/shakapacker'}"
       $stdout.puts "Is bin/shakapacker-dev-server present?: #{File.exist? 'bin/shakapacker-dev-server'}"
-      unless Shakapacker::Utils::Misc.use_package_json_gem
-        $stdout.puts "Is bin/yarn present?: #{File.exist? 'bin/yarn'}"
-      end
     end
   end
 end

data/package/babel/preset.js

@@ -1,11 +1,11 @@
-const { moduleExists } = require('shakapacker')
+const { moduleExists } = require("shakapacker")
 
 module.exports = function config(api) {
-  const validEnv = ['development', 'test', 'production']
+  const validEnv = ["development", "test", "production"]
   const currentEnv = api.env()
-  const isDevelopmentEnv = api.env('development')
-  const isProductionEnv = api.env('production')
-  const isTestEnv = api.env('test')
+  const isDevelopmentEnv = api.env("development")
+  const isProductionEnv = api.env("production")
+  const isTestEnv = api.env("test")
 
   if (!validEnv.includes(currentEnv)) {
     throw new Error(
@@ -17,21 +17,21 @@ module.exports = function config(api) {
 
   return {
     presets: [
-      isTestEnv && ['@babel/preset-env', { targets: { node: 'current' } }],
+      isTestEnv && ["@babel/preset-env", { targets: { node: "current" } }],
       (isProductionEnv || isDevelopmentEnv) && [
-        '@babel/preset-env',
+        "@babel/preset-env",
         {
-          useBuiltIns: 'entry',
-          corejs: '3.8',
-          modules: 'auto',
+          useBuiltIns: "entry",
+          corejs: "3.8",
+          modules: "auto",
           bugfixes: true,
-          exclude: ['transform-typeof-symbol']
+          exclude: ["transform-typeof-symbol"]
         }
       ],
-      moduleExists('@babel/preset-typescript') && '@babel/preset-typescript'
+      moduleExists("@babel/preset-typescript") && "@babel/preset-typescript"
     ].filter(Boolean),
-    plugins: [
-      ['@babel/plugin-transform-runtime', { helpers: false }]
-    ].filter(Boolean)
+    plugins: [["@babel/plugin-transform-runtime", { helpers: false }]].filter(
+      Boolean
+    )
   }
 }

data/package/config.js

@@ -1,19 +1,16 @@
-const { resolve } = require('path')
-const { load } = require('js-yaml')
-const { existsSync, readFileSync } = require('fs')
+const { resolve } = require("path")
+const { load } = require("js-yaml")
+const { existsSync, readFileSync } = require("fs")
 
-const { merge } = require('webpack-merge')
-const {
-  ensureTrailingSlash,
-  setShakapackerEnvVariablesForBackwardCompatibility
-} = require('./utils/helpers')
-const { railsEnv } = require('./env')
-const configPath = require('./utils/configPath')
+const { merge } = require("webpack-merge")
+const { ensureTrailingSlash } = require("./utils/helpers")
+const { railsEnv } = require("./env")
+const configPath = require("./utils/configPath")
 
-const defaultConfigPath = require('./utils/defaultConfigPath')
+const defaultConfigPath = require("./utils/defaultConfigPath")
 
 const getDefaultConfig = () => {
-  const defaultConfig = load(readFileSync(defaultConfigPath), 'utf8')
+  const defaultConfig = load(readFileSync(defaultConfigPath), "utf8")
   return defaultConfig[railsEnv] || defaultConfig.production
 }
 
@@ -21,12 +18,14 @@ const defaults = getDefaultConfig()
 let config
 
 if (existsSync(configPath)) {
-  const appYmlObject = load(readFileSync(configPath), 'utf8')
+  const appYmlObject = load(readFileSync(configPath), "utf8")
   const envAppConfig = appYmlObject[railsEnv]
 
   if (!envAppConfig) {
     /* eslint no-console:0 */
-    console.warn(`Warning: ${railsEnv} key not found in the configuration file. Using production configuration as a fallback.`)
+    console.warn(
+      `Warning: ${railsEnv} key not found in the configuration file. Using production configuration as a fallback.`
+    )
   }
 
   config = merge(defaults, envAppConfig || {})
@@ -39,8 +38,7 @@ config.outputPath = resolve(config.public_root_path, config.public_output_path)
 // Ensure that the publicPath includes our asset host so dynamic imports
 // (code-splitting chunks and static assets) load from the CDN instead of a relative path.
 const getPublicPath = () => {
-  setShakapackerEnvVariablesForBackwardCompatibility()
-  const rootUrl = ensureTrailingSlash(process.env.SHAKAPACKER_ASSET_HOST || '/')
+  const rootUrl = ensureTrailingSlash(process.env.SHAKAPACKER_ASSET_HOST || "/")
   return `${rootUrl}${config.public_output_path}/`
 }
 
@@ -50,7 +48,7 @@ config.publicPathWithoutCDN = `/${config.public_output_path}/`
 if (config.manifest_path) {
   config.manifestPath = resolve(config.manifest_path)
 } else {
-  config.manifestPath = resolve(config.outputPath, 'manifest.json')
+  config.manifestPath = resolve(config.outputPath, "manifest.json")
 }
 
 module.exports = config