shakapacker 7.2.2 → 7.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6613d4b52d4526e1ead4d4711e9daab007e98076f3af92e2cd9a61a65386cf74
-  data.tar.gz: 7d31d8f1cfbfe305a6a6e2cc0159150ab6d7c7a3c36ef0608c13389b85a7424b
+  metadata.gz: 5968b3bebbc2447a2aa26ecdef02b4bd96e593d9f04b30fdcf33415b2e674e64
+  data.tar.gz: fe48b75ef65f90b2df1a78c76530ffe265228d048da91f5cbbdd038aac10ca11
 SHA512:
-  metadata.gz: 5d60bca460bbbba6f9944368cab33d63e1958b607d12aac91aba71eb9a00066cbce92893fcc01034c33e347e4f938321bbba2c27650436577ed3078cad13c753
-  data.tar.gz: 80d705dd8d7b5fae172909a5f334cd774dcd57c5864d3c051cc7a33d6b2ef82412f5d104e4a0284d65c3c8a630992798812925e9f5f4e4389b0ec05f8b357889
+  metadata.gz: eb4c1b9f91d5c60d03bb71deeff4d42a6746261f0ea8d5013f60f0b8a343a9d3758db097a863abce1027496634e0677355f56ac1726a270e5b3a9ac88ec5dc9c
+  data.tar.gz: 96d1279afa3d03a145ab537e1e1f4357e14567fd3c9855dba36d37fff88efc6e20b261063e7c075455cf038ad504981da51b5446e5004485ebf66c134735aeeb

data/.github/workflows/dummy.yml

@@ -3,7 +3,8 @@ name: Dummy specs
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/generator.yml

@@ -3,7 +3,8 @@ name: Generator specs
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/jest.yml

@@ -3,7 +3,8 @@ name: Jest specs
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/js-lint.yml

@@ -3,7 +3,8 @@ name: JS lint
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/rubocop.yml

@@ -3,7 +3,8 @@ name: Rubocop
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/ruby-backward-compatibility.yml

@@ -3,7 +3,8 @@ name: Ruby specs - Backward compatibility
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.github/workflows/ruby.yml

@@ -3,7 +3,8 @@ name: Ruby specs
 on:
   push:
     branches:
-      - 'master'
+      - 'main'
+      - 'next'
   pull_request:
 
 jobs:

data/.node-version

@@ -1 +1 @@
-16.14.0
+21.0.0

data/CHANGELOG.md

@@ -7,8 +7,12 @@
 ## [Unreleased]
 Changes since the last non-beta release.
 
-### Added
+- Emit warnings instead of errors when compilation is success but stderr is not empty. [PR 416](https://github.com/shakacode/shakapacker/pull/416) by [n-rodriguez](https://github.com/n-rodriguez).
+- Allow `webpack-dev-server` v5. [PR 418](https://github.com/shakacode/shakapacker/pull/418) by [G-Rath](https://github.com/g-rath)
+
+## [v7.2.2] - January 19, 2024
 
+### Added
 - Allow `compression-webpack-plugin` v11. [PR 406](https://github.com/shakacode/shakapacker/pull/406) by [tagliala](https://github.com/tagliala).
 
 ## [v7.2.1] - December 30, 2023
@@ -61,7 +65,7 @@ Changes since the last non-beta release.
 
 - Export immutable webpackConfig function. [PR 293](https://github.com/shakacode/shakapacker/pull/293) by [tomdracz](https://github.com/tomdracz).
 
-  The `webpackConfig` property in the `shakapacker` module has been updated to be a function instead of a global mutable webpack configuration. This function now returns an immutable webpack configuration object, which ensures that any modifications made to it will not affect any other usage of the webpack configuration. If a project still requires the old mutable object, it can be accessed by replacing `webpackConfig` with `globalMutableWebpackConfig`. Check [v7-upgrade](https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md) documentation for more detail.
+  The `webpackConfig` property in the `shakapacker` module has been updated to be a function instead of a global mutable webpack configuration. This function now returns an immutable webpack configuration object, which ensures that any modifications made to it will not affect any other usage of the webpack configuration. If a project still requires the old mutable object, it can be accessed by replacing `webpackConfig` with `globalMutableWebpackConfig`. Check [v7-upgrade](https://github.com/shakacode/shakapacker/blob/main/docs/v7_upgrade.md) documentation for more detail.
 
 ### Added
 - Set CSS modules mode depending on file type. [PR 261](https://github.com/shakacode/shakapacker/pull/261) by [talyuk](https://github.com/talyuk).
@@ -299,7 +303,8 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions
 ## v5.4.3 and prior changes from rails/webpacker
 See [CHANGELOG.md in rails/webpacker (up to v5.4.3)](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
 
-[Unreleased]: https://github.com/shakacode/shakapacker/compare/v7.2.1...master
+[Unreleased]: https://github.com/shakacode/shakapacker/compare/v7.2.2...main
+[v7.2.2]: https://github.com/shakacode/shakapacker/compare/v7.2.1...v7.2.2
 [v7.2.1]: https://github.com/shakacode/shakapacker/compare/v7.2.0...v7.2.1
 [v7.2.0]: https://github.com/shakacode/shakapacker/compare/v7.1.0...v7.2.0
 [v7.1.0]: https://github.com/shakacode/shakapacker/compare/v7.0.3...v7.1.0

data/README.md

@@ -703,7 +703,26 @@ yarn add postcss-preset-env postcss-flexbugs-fixes
 #### Sass
 
 ```bash
-yarn add sass sass-loader
+yarn add sass-loader
+```
+
+You will also need to install [Dart Sass](https://github.com/sass/dart-sass), [Node Sass](https://github.com/sass/node-sass) or [Sass Embedded](https://github.com/sass/embedded-host-node) to pick the implementation to use. sass-loader will automatically pick an implementation based on installed packages.
+
+Please refer to [sass-loader documentation](https://www.npmjs.com/package/sass-loader) and individual packages repos for more information on all the options.
+
+##### Dart Sass
+```bash
+yarn add sass
+```
+
+##### Node Sass
+```bash
+yarn add node-sass
+```
+
+##### Sass Embedded
+```bash
+yarn add sass-embedded
 ```
 
 #### Less

data/docs/react.md

@@ -226,7 +226,7 @@ module.exports = webpackConfig;
 - },
 ```
 
-11. Create a `babel.config.js` file in the project root and add the following [sample code](https://github.com/shakacode/shakapacker/blob/master/docs/customizing_babel_config.md#react-configuration):
+11. Create a `babel.config.js` file in the project root and add the following [sample code](https://github.com/shakacode/shakapacker/blob/main/docs/customizing_babel_config.md#react-configuration):
 ```js
 module.exports = function (api) {
   const defaultConfigFunc = require('shakapacker/package/babel/preset.js')

data/docs/v6_upgrade.md

@@ -140,7 +140,7 @@ _If you're on webpacker v5, follow [how to upgrade to webpacker v6.0.0.rc.6 from
    ```
    See customization example the [Customizing Babel Config](./customizing_babel_config.md) for React configuration.
 
-1. `extensions` was removed from the `webpacker.yml` file. Move custom extensions to your configuration by merging an object like this. For more details, see docs for [Webpack Configuration](https://github.com/shakacode/shakapacker/blob/master/README.md#webpack-configuration)
+1. `extensions` was removed from the `webpacker.yml` file. Move custom extensions to your configuration by merging an object like this. For more details, see docs for [Webpack Configuration](https://github.com/shakacode/shakapacker/blob/main/README.md#webpack-configuration)
 
    ```js
    {

data/lib/shakapacker/compiler.rb

@@ -88,7 +88,7 @@ class Shakapacker::Compiler
 
       if status.success?
         logger.info "Compiled all packs in #{config.public_output_path}"
-        logger.error "#{stderr}" unless stderr.empty?
+        logger.warn "#{stderr}" unless stderr.empty?
 
         if config.webpack_compile_output?
           logger.info stdout

data/lib/shakapacker/deprecation_helper.rb

@@ -1,7 +1,7 @@
 require "thor"
 
 module Shakapacker
-  DEPRECATION_GUIDE_URL = "https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md"
+  DEPRECATION_GUIDE_URL = "https://github.com/shakacode/shakapacker/blob/main/docs/v7_upgrade.md"
   DEPRECATION_MESSAGE = <<~MSG
     DEPRECATION NOTICE:
 

data/lib/shakapacker/helper.rb

@@ -98,7 +98,7 @@ module Shakapacker::Helper
   def javascript_pack_tag(*names, defer: true, **options)
     if @javascript_pack_tag_loaded
       raise "To prevent duplicated chunks on the page, you should call javascript_pack_tag only once on the page. " \
-      "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
+      "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
     end
 
     append_javascript_pack_tag(*names, defer: defer)
@@ -169,7 +169,7 @@ module Shakapacker::Helper
   def append_stylesheet_pack_tag(*names)
     if @stylesheet_pack_tag_loaded
       raise "You can only call append_stylesheet_pack_tag before stylesheet_pack_tag helper. " \
-      "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+      "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
     end
 
     @stylesheet_pack_tag_queue ||= []
@@ -196,7 +196,7 @@ module Shakapacker::Helper
     def update_javascript_pack_tag_queue(defer:)
       if @javascript_pack_tag_loaded
         raise "You can only call #{caller_locations(1..1).first.label} before javascript_pack_tag helper. " \
-        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+        "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
       end
 
       yield(defer ? :deferred : :non_deferred)

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "7.2.2".freeze
+  VERSION = "7.2.3".freeze
 end

data/package/index.js

@@ -57,7 +57,7 @@ Please use 'globalMutableWebpackConfig' instead, or use
 'generateWebpackConfig()' to avoid unwanted config mutation across the app.
 
 For more information, see version 7 upgrade documentation at:
-https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md
+https://github.com/shakacode/shakapacker/blob/main/docs/v7_upgrade.md
 `)
       return globalMutableWebpackConfig()
     }

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "7.2.2",
+  "version": "7.2.3",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {
@@ -68,7 +68,7 @@
     "webpack": "^5.72.0",
     "webpack-assets-manifest": "^5.0.6",
     "webpack-cli": "^4.9.2 || ^5.0.0",
-    "webpack-dev-server": "^4.9.0",
+    "webpack-dev-server": "^4.9.0 || ^5.0.0",
     "webpack-merge": "^5.8.0"
   },
   "peerDependenciesMeta": {

data/spec/backward_compatibility_specs/helper_spec.rb

@@ -126,7 +126,7 @@ module ActionView::TestCase::Behavior
     it "#append_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call append_javascript_pack_tag before javascript_pack_tag helper. " +
-        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+        "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag("application")
@@ -137,7 +137,7 @@ module ActionView::TestCase::Behavior
     it "#prepend_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call prepend_javascript_pack_tag before javascript_pack_tag helper. " +
-        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+        "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag("application")
@@ -167,7 +167,7 @@ module ActionView::TestCase::Behavior
 
     it "#javascript_pack_tag rases error on multiple invocations" do
       expected_error_message = "To prevent duplicated chunks on the page, you should call javascript_pack_tag only once on the page. " +
-      "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
+      "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag(:application)

data/spec/fixtures/github_url_package-lock.v1.json

@@ -102,7 +102,7 @@
     },
     "shakapacker": {
       "version": "github:shakacode/shakapacker#31854a58be49f736f3486a946b72d7e4f334e2b2",
-      "from": "github:shakacode/shakapacker#master",
+      "from": "github:shakacode/shakapacker#main",
       "requires": {
         "glob": "^7.2.0",
         "js-yaml": "^4.1.0",

data/spec/fixtures/github_url_package-lock.v2.json

@@ -9,7 +9,7 @@
       "version": "1.0.0",
       "license": "MIT",
       "dependencies": {
-        "shakapacker": "shakacode/shakapacker#master"
+        "shakapacker": "shakacode/shakapacker#main"
       },
       "devDependencies": {
         "right-pad": "^1.0.1"
@@ -9594,7 +9594,7 @@
     },
     "shakapacker": {
       "version": "git+ssh://git@github.com/shakacode/shakapacker.git#31854a58be49f736f3486a946b72d7e4f334e2b2",
-      "from": "shakapacker@shakacode/shakapacker#master",
+      "from": "shakapacker@shakacode/shakapacker#main",
       "requires": {
         "glob": "^7.2.0",
         "js-yaml": "^4.1.0",

data/spec/fixtures/github_url_package.json

@@ -5,7 +5,7 @@
   "license": "MIT",
   "private": true,
   "dependencies": {
-    "shakapacker": "shakacode/shakapacker#master"
+    "shakapacker": "shakacode/shakapacker#main"
   },
   "devDependencies": {
     "right-pad": "^1.0.1"

data/spec/fixtures/github_url_pnpm-lock.v7.yaml

@@ -2,7 +2,7 @@ lockfileVersion: 5.4
 
 specifiers:
   right-pad: ^1.0.1
-  shakapacker: shakacode/shakapacker#master
+  shakapacker: shakacode/shakapacker#main
 
 dependencies:
   shakapacker: github.com/shakacode/shakapacker/cdf32835d3e0949952b8b4b53063807f714f9b24

data/spec/fixtures/github_url_pnpm-lock.v8.yaml

@@ -6,7 +6,7 @@ settings:
 
 dependencies:
   shakapacker:
-    specifier: shakacode/shakapacker#master
+    specifier: shakacode/shakapacker#main
     version: github.com/shakacode/shakapacker/cdf32835d3e0949952b8b4b53063807f714f9b24(@babel/core@7.22.10)(@babel/plugin-transform-runtime@7.22.10)(@babel/preset-env@7.22.10)(@babel/runtime@7.22.10)(babel-loader@9.1.3)(compression-webpack-plugin@10.0.0)(terser-webpack-plugin@5.3.9)(webpack-assets-manifest@5.1.0)(webpack-cli@5.1.4)(webpack-dev-server@4.15.1)(webpack-merge@5.9.0)(webpack@5.88.2)
 
 devDependencies:

data/spec/fixtures/github_url_yarn.v1.lock

@@ -91,7 +91,7 @@ right-pad@^1.0.1:
   resolved "https://registry.yarnpkg.com/right-pad/-/right-pad-1.0.1.tgz#8ca08c2cbb5b55e74dafa96bf7fd1a27d568c8d0"
   integrity sha512-bYBjgxmkvTAfgIYy328fmkwhp39v8lwVgWhhrzxPV3yHtcSqyYKe9/XOhvW48UFjATg3VuJbpsp5822ACNvkmw==
 
-shakapacker@shakacode/shakapacker#master:
+shakapacker@shakacode/shakapacker#main:
   version "6.5.0"
   resolved "https://codeload.github.com/shakacode/shakapacker/tar.gz/31854a58be49f736f3486a946b72d7e4f334e2b2"
   dependencies:

data/spec/fixtures/github_url_yarn.v2.lock

@@ -124,7 +124,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"shakapacker@shakacode/shakapacker#master":
+"shakapacker@shakacode/shakapacker#main":
   version: 6.5.0
   resolution: "shakapacker@https://github.com/shakacode/shakapacker.git#commit=31854a58be49f736f3486a946b72d7e4f334e2b2"
   dependencies:
@@ -153,7 +153,7 @@ __metadata:
   resolution: "test_app@workspace:."
   dependencies:
     right-pad: ^1.0.1
-    shakapacker: "shakacode/shakapacker#master"
+    shakapacker: "shakacode/shakapacker#main"
   languageName: unknown
   linkType: soft
 

data/spec/shakapacker/helper_spec.rb

@@ -126,7 +126,7 @@ module ActionView::TestCase::Behavior
     it "#append_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call append_javascript_pack_tag before javascript_pack_tag helper. " +
-        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+        "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag("application")
@@ -137,7 +137,7 @@ module ActionView::TestCase::Behavior
     it "#prepend_javascript_pack_tag raises an error if called after calling #javascript_pack_tag" do
       expected_error_message = \
         "You can only call prepend_javascript_pack_tag before javascript_pack_tag helper. " +
-        "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
+        "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helper-append_javascript_pack_tag-prepend_javascript_pack_tag-and-append_stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag("application")
@@ -167,7 +167,7 @@ module ActionView::TestCase::Behavior
 
     it "#javascript_pack_tag rases error on multiple invocations" do
       expected_error_message = "To prevent duplicated chunks on the page, you should call javascript_pack_tag only once on the page. " +
-      "Please refer to https://github.com/shakacode/shakapacker/blob/master/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
+      "Please refer to https://github.com/shakacode/shakapacker/blob/main/README.md#view-helpers-javascript_pack_tag-and-stylesheet_pack_tag for the usage guide"
 
       expect {
         javascript_pack_tag(:application)

data/spec/shakapacker/version_checker_spec.rb

@@ -233,7 +233,7 @@ describe "VersionChecker::NodePackageVersion" do
       let(:node_package_version_from_github_url) { node_package_version(fixture_version: "github_url") }
 
       it "#raw returns the GitHub repo address" do
-        expect(node_package_version_from_github_url.raw).to eq "shakacode/shakapacker#master"
+        expect(node_package_version_from_github_url.raw).to eq "shakacode/shakapacker#main"
       end
 
       it "#major_minor_patch returns nil" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 7.2.2
+  version: 7.2.3
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-20 00:00:00.000000000 Z
+date: 2024-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -566,7 +566,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.2.2
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v7.2.3
 post_install_message:
 rdoc_options: []
 require_paths: